[ 
https://issues.apache.org/jira/browse/LANG-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb resolved LANG-568.
-----------------------

    Resolution: Fixed

Warnings have now been tidied up

> @SuppressWarnings("unchecked") is used too generally
> ----------------------------------------------------
>
>                 Key: LANG-568
>                 URL: https://issues.apache.org/jira/browse/LANG-568
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: General
>            Reporter: Sebb
>            Assignee: Sebb
>             Fix For: 3.0
>
>
> @SuppressWarnings("unchecked") is used in several places on entire methods.
> Mostly there is no documentation as to why it is safe to ignore the warnings.
> Seems to me the annotation should be used as close as possible to the site of 
> the warning, and the reason should be documented, so it can be revisited if 
> there is a code change later.
> In fact, at least one of the warnings is NOT safe to ignore:
> String[] s = ArrayUtils.add((String[])null, null);
> generates a ClassCastException, which should not happen if the warning is OK 
> to ignore.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to