aherbert commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1404661158
##
src/test/java/org/apache/commons/collections4/bloomfilter/CountingPredicateTest.java:
##
@@ -16,31 +16,103 @@
*/
package
garydgregory merged PR #182:
URL: https://github.com/apache/commons-email/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #475:
URL: https://github.com/apache/commons-text/pull/475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #167:
URL: https://github.com/apache/commons-validator/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #223:
URL: https://github.com/apache/commons-codec/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1826188320
> Hi @garydgregory,
>
> In my understanding, the constructor of PecentCodec calls the
`insertAlwaysEncodeChars(byte[])` method in [Line
palacsint closed pull request #1136: Updates javadoc of
ExceptionUtils.getRootCause()
URL: https://github.com/apache/commons-lang/pull/1136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
palacsint commented on PR #1136:
URL: https://github.com/apache/commons-lang/pull/1136#issuecomment-1825381080
@garydgregory : Thanks, it's much better with your changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sebbASF merged PR #280:
URL: https://github.com/apache/commons-crypto/pull/280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #181:
URL: https://github.com/apache/commons-logging/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #516:
URL: https://github.com/apache/commons-io/pull/516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-codec/pull/220#discussion_r1404348287
##
src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java:
##
@@ -126,10 +126,20 @@ public final String encode(String name) {
garydgregory commented on code in PR #221:
URL: https://github.com/apache/commons-codec/pull/221#discussion_r1404346632
##
src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java:
##
@@ -208,6 +208,11 @@ public static final byte[] encodeQuotedPrintable(BitSet
[
https://issues.apache.org/jira/browse/COMPRESS-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789454#comment-17789454
]
Gary D. Gregory commented on COMPRESS-653:
--
Hello [~kvr]
Thank you for taking the time to
agoss94 commented on PR #225:
URL: https://github.com/apache/commons-geometry/pull/225#issuecomment-1825699425
I think I took a look at every comment so far and made alterations. Are
there more remarks on your side?
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/LOGGING-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789465#comment-17789465
]
Piotr Karwasz commented on LOGGING-187:
---
I agree that Commons Logging is almost ready for a new
garydgregory merged PR #107:
URL: https://github.com/apache/commons-digester/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #197:
URL: https://github.com/apache/commons-build-plugin/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #223:
URL: https://github.com/apache/commons-dbutils/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #372:
URL: https://github.com/apache/commons-csv/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #211:
URL: https://github.com/apache/commons-jexl/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #209:
URL: https://github.com/apache/commons-cli/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #187:
URL: https://github.com/apache/commons-jcs/pull/187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #446:
URL: https://github.com/apache/commons-vfs/pull/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #260:
URL: https://github.com/apache/commons-pool/pull/260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #373:
URL: https://github.com/apache/commons-csv/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #168:
URL: https://github.com/apache/commons-scxml/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on code in PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#discussion_r1404328661
##
src/main/java/org/apache/commons/dbutils/wrappers/StringTrimmedResultSet.java:
##
@@ -92,12 +92,25 @@ public Object invoke(final Object proxy, final
garydgregory commented on PR #223:
URL: https://github.com/apache/commons-codec/pull/223#issuecomment-1825661894
@arthurscchan
Please use a better description in PRs and JIRA: Specify the class and
method where the exception occurs.
--
This is an automated message from the Apache Git
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1825686434
> @arthurscchan Please use a better description in PRs and JIRA: Specify the
class and method where the exception occurs.
> > > Hi, I have added unit test. I am
carlovend opened a new pull request, #430:
URL: https://github.com/apache/commons-collections/pull/430
Add constant instead of literals, refactor method that have too much
cognitive complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
sebbASF merged PR #281:
URL: https://github.com/apache/commons-crypto/pull/281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #216:
URL: https://github.com/apache/commons-release-plugin/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #219:
URL: https://github.com/apache/commons-codec/pull/219#issuecomment-1825662631
@arthurscchan
Please use a better description in PRs and JIRA: Specify the class and
method where the exception occurs.
--
This is an automated message from the Apache Git
garydgregory commented on PR #220:
URL: https://github.com/apache/commons-codec/pull/220#issuecomment-1825662476
@arthurscchan
Please use a better description in PRs and JIRA: Specify the class and
method where the exception occurs.
--
This is an automated message from the Apache Git
garydgregory commented on PR #221:
URL: https://github.com/apache/commons-codec/pull/221#issuecomment-1825662290
@arthurscchan
Please use a better description in PRs and JIRA: Specify the class and
method where the exception occurs.
--
This is an automated message from the Apache Git
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1825662110
@arthurscchan
Please use a better description in PRs and JIRA: Specify the class and
method where the exception occurs.
--
This is an automated message from the Apache Git
ppkarwasz commented on PR #178:
URL: https://github.com/apache/commons-logging/pull/178#issuecomment-1825661071
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-codec/pull/220#discussion_r1404351532
##
src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java:
##
@@ -519,4 +520,22 @@ public final void
carlovend closed pull request #430: Fix major code smells
URL: https://github.com/apache/commons-collections/pull/430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
garydgregory merged PR #325:
URL: https://github.com/apache/commons-dbcp/pull/325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #70:
URL: https://github.com/apache/commons-jci/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #445:
URL: https://github.com/apache/commons-compress/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #93:
URL: https://github.com/apache/commons-skin/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #333:
URL: https://github.com/apache/commons-parent/pull/333#issuecomment-1825621739
Close: We use profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
garydgregory commented on code in PR #223:
URL: https://github.com/apache/commons-codec/pull/223#discussion_r1404340973
##
src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java:
##
@@ -431,7 +431,7 @@ public String encode(String input, final
garydgregory commented on code in PR #223:
URL: https://github.com/apache/commons-codec/pull/223#discussion_r1404339328
##
src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineTest.java:
##
@@ -70,4 +80,13 @@ public void testEncode(final String name, final String
garydgregory merged PR #445:
URL: https://github.com/apache/commons-vfs/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
agoss94 commented on code in PR #225:
URL: https://github.com/apache/commons-geometry/pull/225#discussion_r1404368676
##
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/hull/ConvexHull3D.java:
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/LOGGING-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789465#comment-17789465
]
Piotr Karwasz edited comment on LOGGING-187 at 11/24/23 3:47 PM:
-
I
[
https://issues.apache.org/jira/browse/LOGGING-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789504#comment-17789504
]
Piotr Karwasz commented on LOGGING-187:
---
[~ggregory],
I am referring to the upgrade from 1.2 to
[
https://issues.apache.org/jira/browse/CRYPTO-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated CRYPTO-168:
Fix Version/s: 1.2.0
> Centralise access to the crypto dynamic library
>
[
https://issues.apache.org/jira/browse/CRYPTO-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved CRYPTO-168.
-
Resolution: Fixed
> Centralise access to the crypto dynamic library
>
[
https://issues.apache.org/jira/browse/CRYPTO-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789506#comment-17789506
]
Sebb commented on CRYPTO-168:
-
This was done in:
Piotr Karwasz created LOGGING-188:
-
Summary: Deprecate and disable Lumberjack and Log4j 1.x logger
Key: LOGGING-188
URL: https://issues.apache.org/jira/browse/LOGGING-188
Project: Commons Logging
garydgregory merged PR #122:
URL: https://github.com/apache/commons-daemon/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #136:
URL: https://github.com/apache/commons-exec/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LOGGING-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789468#comment-17789468
]
Gary D. Gregory commented on LOGGING-187:
-
I agree with [~pkarwasz]
Piotr: What "upgrade
Sebb created CRYPTO-179:
---
Summary: Crash on macOS with default crypto library
Key: CRYPTO-179
URL: https://issues.apache.org/jira/browse/CRYPTO-179
Project: Commons Crypto
Issue Type: Bug
Claudenw commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1825804075
@aherbert just a friendly ping. I'd like to get this closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
garydgregory merged PR #224:
URL: https://github.com/apache/commons-codec/pull/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/JEXL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789513#comment-17789513
]
Henri Biestro commented on JEXL-411:
The logic for parsing is described in the
[
https://issues.apache.org/jira/browse/LOGGING-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789517#comment-17789517
]
Piotr Karwasz commented on LOGGING-173:
---
For completeness' sake, users can still enable these
garydgregory merged PR #1138:
URL: https://github.com/apache/commons-lang/pull/1138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Sebb created CRYPTO-180:
---
Summary: Need instructions for building distributions
Key: CRYPTO-180
URL: https://issues.apache.org/jira/browse/CRYPTO-180
Project: Commons Crypto
Issue Type: Bug
garydgregory merged PR #338:
URL: https://github.com/apache/commons-imaging/pull/338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #256:
URL: https://github.com/apache/commons-fileupload/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #95:
URL: https://github.com/apache/commons-jxpath/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arthurscchan commented on code in PR #223:
URL: https://github.com/apache/commons-codec/pull/223#discussion_r1404619881
##
src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineTest.java:
##
@@ -70,4 +80,13 @@ public void testEncode(final String name, final String
ppkarwasz opened a new pull request, #182:
URL: https://github.com/apache/commons-logging/pull/182
This PR removes Lumberjack and Log4j 1.x for the automatic logging backend
discovery procedure.
The updated procedure is documented in the guide.
This closes LOGGING-173 and
[
https://issues.apache.org/jira/browse/LOGGING-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789528#comment-17789528
]
Piotr Karwasz commented on LOGGING-173:
---
As far as I can see, this issue is already solved in
garydgregory merged PR #247:
URL: https://github.com/apache/commons-bcel/pull/247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arthurscchan commented on code in PR #220:
URL: https://github.com/apache/commons-codec/pull/220#discussion_r1404623725
##
src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java:
##
@@ -519,4 +520,34 @@ public final void
arthurscchan commented on code in PR #220:
URL: https://github.com/apache/commons-codec/pull/220#discussion_r1404623804
##
src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java:
##
@@ -519,4 +520,34 @@ public final void
[
https://issues.apache.org/jira/browse/CRYPTO-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789525#comment-17789525
]
Sebb commented on CRYPTO-166:
-
Library reloading was fixed by CRYPTO-168.
However, the symbols are also
[
https://issues.apache.org/jira/browse/CRYPTO-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved CRYPTO-166.
-
Resolution: Fixed
> Library is reloaded multiple times
> --
>
>
[
https://issues.apache.org/jira/browse/CRYPTO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved CRYPTO-120.
-
Resolution: Fixed
Subsumed into CRYPTO-180
> Add instructions for native build at wiki
>
[
https://issues.apache.org/jira/browse/CRYPTO-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved CRYPTO-132.
-
Resolution: Fixed
Subsumed into CRYPTO-180
> Instructions in BUILDING.txt don't work on MacOS
>
garydgregory merged PR #174:
URL: https://github.com/apache/commons-rdf/pull/174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-codec/pull/220#discussion_r1404620116
##
src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java:
##
@@ -519,4 +520,34 @@ public final void
garydgregory merged PR #221:
URL: https://github.com/apache/commons-codec/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #221:
URL: https://github.com/apache/commons-codec/pull/221#issuecomment-1826190545
@arthurscchan
TY, merged. It looks like encoder exceptions are not in play here.
--
This is an automated message from the Apache Git Service.
To respond to the message,
garydgregory merged PR #220:
URL: https://github.com/apache/commons-codec/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #219:
URL: https://github.com/apache/commons-codec/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
84 matches
Mail list logo
