[jira] [Commented] (CRYPTO-176) Drop dependency on Commons IO?

2023-11-09 Thread Sebb (Jira)
[ https://issues.apache.org/jira/browse/CRYPTO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784623#comment-17784623 ] Sebb commented on CRYPTO-176: - There is bound to be some code duplication across components, so I don't see

[jira] [Commented] (COMPRESS-651) Uncompress BZIP2 File Max Output is 900000 chars

2023-11-09 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784620#comment-17784620 ] Gary D. Gregory commented on COMPRESS-651: -- Hello [~ahmadin] Thank you for your report. Please

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
yakovsh commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388676379 ## src/test/java/org/apache/commons/compress/compressors/z/ZCompressorInputStreamTest.java: ## @@ -68,4 +70,28 @@ public void

[jira] [Updated] (COMPRESS-651) Uncompress BZIP2 File Max Output is 900000 chars

2023-11-09 Thread Ahmadin Badruddin (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmadin Badruddin updated COMPRESS-651: --- Description: I tried to uncompress a big file (a few MBs) of bz2 file using 

[jira] [Created] (COMPRESS-651) Uncompress BZIP2 File Max Output is 900000 chars

2023-11-09 Thread Ahmadin Badruddin (Jira)
Ahmadin Badruddin created COMPRESS-651: -- Summary: Uncompress BZIP2 File Max Output is 90 chars Key: COMPRESS-651 URL: https://issues.apache.org/jira/browse/COMPRESS-651 Project: Commons

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
yakovsh commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388596361 ## src/test/java/org/apache/commons/compress/compressors/z/ZCompressorInputStreamTest.java: ## @@ -68,4 +70,28 @@ public void

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
yakovsh commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388589483 ## src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java: ## @@ -72,6 +72,12 @@ public ZCompressorInputStream(final InputStream

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
yakovsh commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388574923 ## src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java: ## @@ -72,6 +72,12 @@ public ZCompressorInputStream(final InputStream

Re: [PR] COMPRESS-648 - Adding ability to restrict autodetection in CompressorStreamFactory [commons-compress]

2023-11-09 Thread via GitHub
yakovsh commented on code in PR #433: URL: https://github.com/apache/commons-compress/pull/433#discussion_r1388568582 ## src/main/java/org/apache/commons/compress/compressors/CompressorStreamFactory.java: ## @@ -522,6 +524,39 @@ public CompressorInputStream

Re: [PR] Add test for FileChannels.contentEquals. [commons-io]

2023-11-09 Thread via GitHub
garydgregory commented on PR #509: URL: https://github.com/apache/commons-io/pull/509#issuecomment-1804647264  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] COMPRESS-648 - Adding ability to restrict autodetection in CompressorStreamFactory [commons-compress]

2023-11-09 Thread via GitHub
yakovsh commented on code in PR #433: URL: https://github.com/apache/commons-compress/pull/433#discussion_r1388555944 ## src/main/java/org/apache/commons/compress/compressors/CompressorStreamFactory.java: ## @@ -522,6 +524,39 @@ public CompressorInputStream

[jira] [Commented] (COMPRESS-650) LZ4 compressor throws IndexOutOfBoundsException

2023-11-09 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784600#comment-17784600 ] Gary D. Gregory commented on COMPRESS-650: -- TY [~cpreisler]! PR merged. Please test git

[jira] [Updated] (COMPRESS-650) LZ4 compressor throws IndexOutOfBoundsException

2023-11-09 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COMPRESS-650: - External issue ID: https://github.com/apache/commons-compress/pull/436 > LZ4

[jira] [Resolved] (COMPRESS-650) LZ4 compressor throws IndexOutOfBoundsException

2023-11-09 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved COMPRESS-650. -- Fix Version/s: 1.25.0 Resolution: Fixed > LZ4 compressor throws

[jira] [Updated] (COMPRESS-650) LZ4 compress throws IndexOutOfBoundsException

2023-11-09 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COMPRESS-650: - Summary: LZ4 compress throws IndexOutOfBoundsException (was: lz4 compress throws

[jira] [Updated] (COMPRESS-650) LZ4 compressor throws IndexOutOfBoundsException

2023-11-09 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COMPRESS-650: - Summary: LZ4 compressor throws IndexOutOfBoundsException (was: LZ4's {noformat}t

[jira] [Updated] (COMPRESS-650) lz4 compress throws IndexOutOfBoundsException

2023-11-09 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COMPRESS-650: - Description: When passing data that is larger than the block size to the write method,

[jira] [Updated] (COMPRESS-650) LZ4's {noformat}t hrows IndexOutOfBoundsException

2023-11-09 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COMPRESS-650: - Summary: LZ4's {noformat}t hrows IndexOutOfBoundsException (was: LZ4 compress throws

Re: [PR] Fixed lz4 write so it no longer throws an IndexOutOfBoundsException [commons-compress]

2023-11-09 Thread via GitHub
garydgregory merged PR #436: URL: https://github.com/apache/commons-compress/pull/436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add test for FileChannels.contentEquals. [commons-io]

2023-11-09 Thread via GitHub
smarkwal commented on PR #509: URL: https://github.com/apache/commons-io/pull/509#issuecomment-1804580569 Hi @garydgregory, Thank you very much for the quick fix and improving the test. I have been able to use 2.15.1-SNAPSHOT without problems in my project. I also did some more

Re: [PR] Add test for FileChannels.contentEquals. [commons-io]

2023-11-09 Thread via GitHub
smarkwal closed pull request #509: Add test for FileChannels.contentEquals. URL: https://github.com/apache/commons-io/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
garydgregory commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388488921 ## src/test/java/org/apache/commons/compress/compressors/z/ZCompressorInputStreamTest.java: ## @@ -68,4 +70,28 @@ public void

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
garydgregory commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388412007 ## src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java: ## @@ -72,6 +72,12 @@ public ZCompressorInputStream(final

[PR] Fixed lz4 write so it no longer throws an IndexOutOfBoundsException [commons-compress]

2023-11-09 Thread via GitHub
cpreisler opened a new pull request, #436: URL: https://github.com/apache/commons-compress/pull/436 Fixed lz4 write so it no longer throws an IndexOutOfBoundsException when data is larger than Block size. Test was added. [COMPRESS-650](https://issues.apache.org/jira/browse/COMPRESS-650)

[jira] [Created] (COMPRESS-650) lz4 compress throws IndexOutOfBoundsException

2023-11-09 Thread Chad Preisler (Jira)
Chad Preisler created COMPRESS-650: -- Summary: lz4 compress throws IndexOutOfBoundsException Key: COMPRESS-650 URL: https://issues.apache.org/jira/browse/COMPRESS-650 Project: Commons Compress

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
garydgregory commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388413780 ## src/test/java/org/apache/commons/compress/compressors/z/ZCompressorInputStreamTest.java: ## @@ -68,4 +70,28 @@ public void

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
garydgregory commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388413780 ## src/test/java/org/apache/commons/compress/compressors/z/ZCompressorInputStreamTest.java: ## @@ -68,4 +70,28 @@ public void

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
garydgregory commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388413780 ## src/test/java/org/apache/commons/compress/compressors/z/ZCompressorInputStreamTest.java: ## @@ -68,4 +70,28 @@ public void

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
garydgregory commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388412007 ## src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java: ## @@ -72,6 +72,12 @@ public ZCompressorInputStream(final

[jira] [Commented] (CRYPTO-176) Drop dependency on Commons IO?

2023-11-09 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/CRYPTO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784566#comment-17784566 ] Gilles Sadowski commented on CRYPTO-176: IMO, the issue is rather the code duplication. Those

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
yakovsh commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388282217 ## src/test/java/org/apache/commons/compress/compressors/z/ZCompressorInputStreamTest.java: ## @@ -68,4 +70,24 @@ public void

Re: [PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
garydgregory commented on code in PR #435: URL: https://github.com/apache/commons-compress/pull/435#discussion_r1388194711 ## src/test/java/org/apache/commons/compress/compressors/z/ZCompressorInputStreamTest.java: ## @@ -68,4 +70,24 @@ public void

[PR] COMPRESS-632: Adding a check for invalid maxCodeSize values in ZCompressorInputStream [commons-compress]

2023-11-09 Thread via GitHub
yakovsh opened a new pull request, #435: URL: https://github.com/apache/commons-compress/pull/435 Adds a validation check and unit text for possible invalid values of maxCodeSize when parsing Z files. This was discovered as part of the fuzzing expansion covered in COMPRESS-632. This

[jira] [Commented] (CRYPTO-176) Drop dependency on Commons IO?

2023-11-09 Thread Sebb (Jira)
[ https://issues.apache.org/jira/browse/CRYPTO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784514#comment-17784514 ] Sebb commented on CRYPTO-176: - Note that there are already versions of readFully and closeQuietly in

[jira] [Comment Edited] (CRYPTO-176) Drop dependency on Commons IO?

2023-11-09 Thread Sebb (Jira)
[ https://issues.apache.org/jira/browse/CRYPTO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784514#comment-17784514 ] Sebb edited comment on CRYPTO-176 at 11/9/23 3:29 PM: -- Note that there are already

[jira] [Created] (CRYPTO-176) Drop dependency on Commons IO?

2023-11-09 Thread Sebb (Jira)
Sebb created CRYPTO-176: --- Summary: Drop dependency on Commons IO? Key: CRYPTO-176 URL: https://issues.apache.org/jira/browse/CRYPTO-176 Project: Commons Crypto Issue Type: Improvement

Re: [PR] COMPRESS-648 - Adding ability to restrict autodetection in CompressorStreamFactory [commons-compress]

2023-11-09 Thread via GitHub
garydgregory commented on code in PR #433: URL: https://github.com/apache/commons-compress/pull/433#discussion_r1388113674 ## src/main/java/org/apache/commons/compress/compressors/CompressorStreamFactory.java: ## @@ -522,6 +524,39 @@ public CompressorInputStream