Re: [PR] chore(deps): Update deps, add Node 20 to CI [cordova-serve]

2024-03-24 Thread via GitHub
codecov-commenter commented on PR #57: URL: https://github.com/apache/cordova-serve/pull/57#issuecomment-2017189641 ## [Codecov](https://app.codecov.io/gh/apache/cordova-serve/pull/57?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

[PR] chore(deps): Update deps, add Node 20 to CI [cordova-serve]

2024-03-24 Thread via GitHub
dpogue opened a new pull request, #57: URL: https://github.com/apache/cordova-serve/pull/57 ### Platforms affected All ### Motivation and Context Update some dependencies, but very minimally. This package appears to still support Node 14, and I don't want to

Re: [PR] feat: add privacy-manifest config support [cordova-ios]

2024-03-24 Thread via GitHub
BenLaKnet commented on PR #1406: URL: https://github.com/apache/cordova-ios/pull/1406#issuecomment-2017141038 I do not know how to test version 7.1.0-dev. Please help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] chore!: bump package to 6.0.0-dev [cordova-eslint]

2024-03-24 Thread via GitHub
dpogue commented on PR #41: URL: https://github.com/apache/cordova-eslint/pull/41#issuecomment-2016898495 This will need to be rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(deps): bump semver from 6.3.0 to 6.3.1 [cordova-eslint]

2024-03-24 Thread via GitHub
dependabot[bot] closed pull request #38: chore(deps): bump semver from 6.3.0 to 6.3.1 URL: https://github.com/apache/cordova-eslint/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(deps): bump word-wrap from 1.2.3 to 1.2.4 [cordova-eslint]

2024-03-24 Thread via GitHub
dependabot[bot] commented on PR #39: URL: https://github.com/apache/cordova-eslint/pull/39#issuecomment-2016898334 Looks like word-wrap is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] chore(deps): bump semver from 6.3.0 to 6.3.1 [cordova-eslint]

2024-03-24 Thread via GitHub
dpogue commented on PR #38: URL: https://github.com/apache/cordova-eslint/pull/38#issuecomment-2016898258 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] chore(deps): bump word-wrap from 1.2.3 to 1.2.4 [cordova-eslint]

2024-03-24 Thread via GitHub
dpogue commented on PR #39: URL: https://github.com/apache/cordova-eslint/pull/39#issuecomment-2016898217 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] chore(deps): package-lock rebuild & GHA versions [cordova-eslint]

2024-03-24 Thread via GitHub
dpogue merged PR #40: URL: https://github.com/apache/cordova-eslint/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore(deps): bump semver from 6.3.0 to 6.3.1 [cordova-eslint]

2024-03-24 Thread via GitHub
dependabot[bot] commented on PR #38: URL: https://github.com/apache/cordova-eslint/pull/38#issuecomment-2016898337 Looks like semver is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] chore(deps): bump word-wrap from 1.2.3 to 1.2.4 [cordova-eslint]

2024-03-24 Thread via GitHub
dependabot[bot] closed pull request #39: chore(deps): bump word-wrap from 1.2.3 to 1.2.4 URL: https://github.com/apache/cordova-eslint/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(deps): Update dependencies [cordova-eslint]

2024-03-24 Thread via GitHub
dpogue commented on PR #40: URL: https://github.com/apache/cordova-eslint/pull/40#issuecomment-2016886478 I downgraded so that we can merge the fix for the GHA warnings and resolve the npm security warnings, but it doesn't require a new version tagged. -- This is an automated message

Re: [PR] chore(deps): Update dependencies [cordova-eslint]

2024-03-24 Thread via GitHub
codecov-commenter commented on PR #40: URL: https://github.com/apache/cordova-eslint/pull/40#issuecomment-2016886458 ## [Codecov](https://app.codecov.io/gh/apache/cordova-eslint/pull/40?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] chore(deps): Update dependencies [cordova-eslint]

2024-03-24 Thread via GitHub
dpogue commented on PR #40: URL: https://github.com/apache/cordova-eslint/pull/40#issuecomment-2016876980 Ahh, I can downgrade that back to the previous version if we prefer (in which case this would just be bumping sub-dependencies). -- This is an automated message from the Apache Git

Re: [PR] chore(deps): Modernize some dependencies [cordova-common]

2024-03-24 Thread via GitHub
dpogue commented on PR #203: URL: https://github.com/apache/cordova-common/pull/203#issuecomment-2016876734 > Might want to rebuild the `package-lock.json` file once. Oops, good catch. I've regenerated package-lock.json -- This is an automated message from the Apache Git Service.

Re: [PR] chore: fix typo in license checker's ignored-packages config [cordova-common]

2024-03-24 Thread via GitHub
erisu merged PR #204: URL: https://github.com/apache/cordova-common/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore: fix typo in license checker's ignored-packages config [cordova-common]

2024-03-24 Thread via GitHub
codecov-commenter commented on PR #204: URL: https://github.com/apache/cordova-common/pull/204#issuecomment-2016835395 ##

[PR] chore: fix typo in license checker's ignored-packages config [cordova-common]

2024-03-24 Thread via GitHub
erisu opened a new pull request, #204: URL: https://github.com/apache/cordova-common/pull/204 ### Platforms affected n/a ### Motivation and Context Fixed a type in license checker config ### Description removed extra `@` ###

Re: [PR] feat: disable no-var for browser linting [cordova-eslint]

2024-03-24 Thread via GitHub
codecov-commenter commented on PR #42: URL: https://github.com/apache/cordova-eslint/pull/42#issuecomment-2016799464 ## [Codecov](https://app.codecov.io/gh/apache/cordova-eslint/pull/42?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

[PR] feat: disable no-var for browser usage [cordova-eslint]

2024-03-24 Thread via GitHub
erisu opened a new pull request, #42: URL: https://github.com/apache/cordova-eslint/pull/42 Disable no-var rule for browsers. Per Cordova-iOS todo comment: https://github.com/apache/cordova-ios/blob/master/.eslintrc.yml#L28 -- This is an automated message from the Apache Git

Re: [PR] chore!: bump package to 6.0.0-dev [cordova-eslint]

2024-03-24 Thread via GitHub
codecov-commenter commented on PR #41: URL: https://github.com/apache/cordova-eslint/pull/41#issuecomment-2016769969 ## [Codecov](https://app.codecov.io/gh/apache/cordova-eslint/pull/41?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] chore(deps): Modernize some dependencies [cordova-common]

2024-03-24 Thread via GitHub
erisu commented on PR #203: URL: https://github.com/apache/cordova-common/pull/203#issuecomment-2016765726 Might want to rebuild the `package-lock.json` file once. It appears the following packages are still listed in the lock file: ```json "fs-extra": "^11.1.0",

[PR] chore(deps): Update dependencies [cordova-eslint]

2024-03-24 Thread via GitHub
dpogue opened a new pull request, #40: URL: https://github.com/apache/cordova-eslint/pull/40 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] ci: add release audit workflow [cordova-common]

2024-03-24 Thread via GitHub
dpogue merged PR #202: URL: https://github.com/apache/cordova-common/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] ConfigParser: Allow engines and plugins to be set in the format returned by get [cordova-common]

2024-03-24 Thread via GitHub
dpogue commented on issue #39: URL: https://github.com/apache/cordova-common/issues/39#issuecomment-2016726149 We don't actually use `engine` and `plugin` tags now that those are handled with npm & package.json, so I'm going to close this. But it was a good suggestion at the time :) --

Re: [I] ConfigParser: Allow engines and plugins to be set in the format returned by get [cordova-common]

2024-03-24 Thread via GitHub
dpogue closed issue #39: ConfigParser: Allow engines and plugins to be set in the format returned by get URL: https://github.com/apache/cordova-common/issues/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] chore(deps): Modernize some dependencies [cordova-common]

2024-03-24 Thread via GitHub
codecov-commenter commented on PR #203: URL: https://github.com/apache/cordova-common/pull/203#issuecomment-2016721420 ##

[PR] chore(deps): Modernize some dependencies [cordova-common]

2024-03-24 Thread via GitHub
dpogue opened a new pull request, #203: URL: https://github.com/apache/cordova-common/pull/203 ### Platforms affected All ### Motivation and Context Bring some dependencies up to date and remove some dependencies that aren't needed with modern NodeJS APIs.

Re: [PR] ci: add release audit workflow [cordova-common]

2024-03-24 Thread via GitHub
codecov-commenter commented on PR #202: URL: https://github.com/apache/cordova-common/pull/202#issuecomment-2016712771 ##

[PR] ci: add release audit workflow [cordova-common]

2024-03-24 Thread via GitHub
erisu opened a new pull request, #202: URL: https://github.com/apache/cordova-common/pull/202 ### Platforms affected n/a ### Motivation and Context Add release auditing workflow to CI ### Description Added GitHub Action to run release