erisu commented on code in PR #1348:
URL: https://github.com/apache/cordova-docs/pull/1348#discussion_r1544207671


##########
www/docs/en/dev/config_ref/index.md:
##########
@@ -331,12 +331,15 @@ AndroidGradlePluginGoogleServicesVersion<br/>{% 
cdv_vartype semver %} {% cdv_pla
 AndroidGradlePluginGoogleServicesEnabled<br/>{% cdv_vartype boolean %} {% 
cdv_platform android %} | *Default: false* <br/>Enables Google Services. The 
`google-services.json` file will be required.
 GradlePluginKotlinEnabled<br/>{% cdv_vartype boolean %} {% cdv_platform 
android %} | *Default: false* <br/>Enables Kotlin plugin for Kotline support.
 AppendUserAgent<br/>{% cdv_vartype string %} {% cdv_platform android %} {% 
cdv_platform ios %} | If set, the value will append to the end of old UserAgent 
of webview. When using with OverrideUserAgent, this value will be ignored.
-BackgroundColor<br/>{% cdv_vartype string %} {% cdv_platform android %} {% 
cdv_platform ios %} | Sets the app's background color. Supports a four-byte hex 
value, with the first byte representing the alpha channel, and standard RGB 
values for the following three bytes. <br/>__Note__: `transparent` value will 
set the application tile background to the accent color on Windows.
+AutoHideSplashScreen<br/> {% cdv_vartype boolean %} {% cdv_platform android %} 
{% cdv_platform ios %} | *Default: true* <br/> Indicates whether to hide splash 
screen automatically or not. The splash screen is hidden after the amount of 
time specified in the `SplashScreenDelay` preference.
+BackgroundColor<br/>{% cdv_vartype string %} {% cdv_platform android %} {% 
cdv_platform ios %} | Sets the app's background color. Supports a four-byte hex 
value, with the first byte representing the alpha channel, and standard RGB 
values for the following three bytes.

Review Comment:
   I think `BackgroundColor` preference is no longer valid for Android.
   
   Android uses preference `AndroidWindowSplashScreenIconBackgroundColor`.
   
   `BackgroundColor` is also missing from this page: 
https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/core/features/splashscreen/index.md



##########
www/docs/en/dev/config_ref/index.md:
##########
@@ -362,6 +365,8 @@ PreferredContentMode<br/>{% cdv_vartype string %} {% 
cdv_platform ios %} | *Defa
 InAppBrowserStatusBarStyle<br/>{% cdv_vartype string %} {% cdv_platform ios %} 
| *Default: default* <br/>  Set text color style of the StatusBar for 
InAppBrowser for iOS. Valid values are: `lightcontent` and `default`.
 SetFullscreen<br/>{% cdv_vartype boolean %} {% cdv_platform android %} | 
*Default: false* <br/>  Same as the Fullscreen parameter in the global 
configuration of this xml file. This Android-specific element is deprecated in 
favor of the global Fullscreen element, and will be removed in a future version.
 ShowTitle<br/>{% cdv_vartype boolean %} {% cdv_platform android %} | *Default: 
false* <br/>  Show the title at the top of the screen.
+SplashScreenBackgroundColor<br/>{% cdv_vartype string %} {% cdv_platform ios 
%} | Sets the app's splashscreen background color. Supports a four-byte hex 
value, with the first byte representing the alpha channel, and standard RGB 
values for the following three bytes.

Review Comment:
   `SplashScreenBackgroundColor` should also be added to: 
https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/core/features/splashscreen/index.md



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to