shajz opened a new pull request, #633:
URL: https://github.com/apache/cordova-cli/pull/633
### Platforms affected
n/a
### Motivation and Context
Closes https://github.com/apache/cordova-cli/issues/625.
Telemetry relies on the `insight` package, whic
shajz commented on PR #633:
URL: https://github.com/apache/cordova-cli/pull/633#issuecomment-1856141123
Haha @breautek, which PR do we keep?
https://github.com/apache/cordova-cli/pull/632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
codecov-commenter commented on PR #633:
URL: https://github.com/apache/cordova-cli/pull/633#issuecomment-1856323602
##
[Codecov](https://app.codecov.io/gh/apache/cordova-cli/pull/633?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apac
dpogue commented on PR #633:
URL: https://github.com/apache/cordova-cli/pull/633#issuecomment-2173880156
Hi @shajz, thanks for the PR! This one seems slightly more complete than
#632 in that it also cleans up the documentation.
I'd really like to get this merged, if you have a chance
shajz commented on PR #633:
URL: https://github.com/apache/cordova-cli/pull/633#issuecomment-2173927506
Hi @dpogue, I've rebased on master and fixed the conflicts on the
`package.json` and `package-lock.json` files :)
I'll also mark the PR as ready for review, thanks for the interest
dpogue merged PR #633:
URL: https://github.com/apache/cordova-cli/pull/633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.ap
dpogue commented on PR #633:
URL: https://github.com/apache/cordova-cli/pull/633#issuecomment-2173956879
Thank you @shajz! 🎉
Apologies for letting this sit open for so long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
