ath0mas commented on PR #297:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/297#issuecomment-2236150327
sorry bad target repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ath0mas closed pull request #297: fix(android): remove broad media permissions
URL: https://github.com/apache/cordova-plugin-media-capture/pull/297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ath0mas opened a new pull request, #297:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/297
merge https://github.com/apache/cordova-plugin-media-capture/pull/295
(resolved conflicts in PR
[#20](https://github.com/ns0m/cordova-plugin-ns0m-media-capture/pull/20))
--
bmarsaud commented on code in PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1680805782
##
src/android/Capture.java:
##
@@ -234,7 +234,7 @@ private JSONObject getAudioVideoData(String filePath,
JSONObject obj, boolean vi
ath0mas commented on code in PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1680705396
##
src/android/Capture.java:
##
@@ -234,7 +234,7 @@ private JSONObject getAudioVideoData(String filePath,
JSONObject obj, boolean vi
bmarsaud commented on code in PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1675671169
##
plugin.xml:
##
@@ -78,11 +78,8 @@ xmlns:android="http://schemas.android.com/apk/res/android;
-
-
bmarsaud commented on code in PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1675666901
##
src/android/Capture.java:
##
@@ -234,7 +234,7 @@ private JSONObject getAudioVideoData(String filePath,
JSONObject obj, boolean vi
bmarsaud commented on code in PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1650993976
##
plugin.xml:
##
@@ -78,11 +78,8 @@ xmlns:android="http://schemas.android.com/apk/res/android;
-
-
ath0mas commented on code in PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1649753021
##
src/android/Capture.java:
##
@@ -234,7 +234,7 @@ private JSONObject getAudioVideoData(String filePath,
JSONObject obj, boolean vi
breautek commented on PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#issuecomment-2163543596
btw the android test are failing cause it's attempting to test against
cordova-android@13 which requires JDK 17, but this repo still is configured to
use JDK 11. So
breautek commented on PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#issuecomment-2163541277
> For Android 10, I would suggest this plugin be resilient to handle apps
that have opted-out of scoped storage by using the
bmarsaud opened a new pull request, #295:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/295
### Platforms affected
Android
### Motivation and Context
As discussed on #288, broad media permissions (`READ_MEDIA_IMAGES`,
`READ_MEDIA_VIDEO`,
12 matches
Mail list logo
