[ https://issues.apache.org/jira/browse/CB-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240168#comment-14240168 ]
Jesse MacFadyen edited comment on CB-8121 at 12/9/14 10:32 PM: --------------------------------------------------------------- Why is it okay for the {{cordova-lib}} dependency to be resolved ( and fail if not explicity npm installed )? The only people who will have this issue are us. Our users who install by typing {{npm install cordova}} will never have this issue. I think this is the wrong approach to using require, and to do this right, every require() would need to wrapped in a similar fashion. The node/npm community has existed for years without needing this, why should we approach this any differently? was (Author: purplecabbage): Why is it okay for the {{cordova-lib}} dependency to be resolved ( and fail if not explicity npm installed ) The only people who will have this issue are us. Our users who install by typing {{npm install cordova}} will never have this issue. I think this is the wrong approach to using require, and to do this right, every require() would need to wrapped in a similar fashion. The node/npm community has existed for years without needing this, why should we approach this any differently? > create.js use of module 'valid-identifier' doesn't trigger pretty error > ----------------------------------------------------------------------- > > Key: CB-8121 > URL: https://issues.apache.org/jira/browse/CB-8121 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib > Affects Versions: 4.1.3 > Reporter: Josh Soref > Assignee: Jesse MacFadyen > > {quote} > node cordova-mobile-spec/createmobilespec/createmobilespec.js > --blackberry10 > {quote} > {quote} > Creating project from local git repos. If you have any errors, it may be from > missing repositories. > {quote} > {quote} > To clone repositories: > ./cordova-coho/coho repo-clone -r mobile-spec -r plugin-test-framework -r > cli -r lib -r plugman -r blackberry10 -r js -r plugins > mkdir cordova-cli/node_modules > (cd cordova-lib/cordova-lib/ && npm install) > (cd cordova-plugman/ && npm install) > mkdir cordova-cli/node_modules > ln -s ../../cordova-lib/cordova-lib cordova-cli/node_modules > (cd cordova-cli && npm install) > {quote} > {quote} > To update all repositories: > ./cordova-coho/coho repo-update > {quote} > {quote} > Checking if you are using master branch of tools > refs/heads/docs-updates > refs/heads/master > refs/heads/master > refs/heads/master > Using non-master of one or more tools. > {quote} > {quote} > Creating project mobilespec... > Error: Cannot find module 'valid-identifier' > at Function.Module._resolveFilename (module.js:338:15) > at Function.Module._load (module.js:280:25) > at Module.require (module.js:364:17) > at require (module.js:380:17) > at Object.<anonymous> > (~/Cordova/cordova-lib/cordova-lib/src/cordova/create.js:34:26) > at Module._compile (module.js:456:26) > at Object.Module._extensions..js (module.js:474:10) > at Module.load (module.js:356:32) > at Function.Module._load (module.js:312:12) > at Module.require (module.js:364:17) > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org