[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682332#comment-13682332
]
Bryan Higgins commented on CB-3497:
---
Created a separate issue for validating the NDK tools
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675255#comment-13675255
]
Filip Maj commented on CB-3497:
---
I'm not sure a list discussion is necessary. Like I mentioned
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675248#comment-13675248
]
Lorin Beer commented on CB-3497:
we should move this to the dev list, but +1 on requiring ndk
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675243#comment-13675243
]
Filip Maj commented on CB-3497:
---
Here's my suggestion then:
- let's fold those requirements i
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675236#comment-13675236
]
Bryan Higgins commented on CB-3497:
---
Only usr/bin for the current NDK version. For example:
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675223#comment-13675223
]
Filip Maj commented on CB-3497:
---
Same. Do we need one specific location in the PATH, or two, et
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675219#comment-13675219
]
Bryan Higgins commented on CB-3497:
---
It would be difficult to integrate since the user may
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675205#comment-13675205
]
Filip Maj commented on CB-3497:
---
{{source}} did it!
So last step is need to integrate that {{s
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675194#comment-13675194
]
Bryan Higgins commented on CB-3497:
---
Fil - you need to run that script with "source"
If yo
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675195#comment-13675195
]
Bryan Higgins commented on CB-3497:
---
Perhaps we should call check_reqs within the create sc
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675140#comment-13675140
]
ASF subversion and git services commented on CB-3497:
-
Commit e5dc06c4bd7
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675114#comment-13675114
]
Bryan Higgins commented on CB-3497:
---
Give that another try with this commit:
https://git-w
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675117#comment-13675117
]
ASF subversion and git services commented on CB-3497:
-
Commit 6c397aa5b81
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674672#comment-13674672
]
Filip Maj commented on CB-3497:
---
Awesome, thanks.
As a reminder, always commit to master first
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674653#comment-13674653
]
Bryan Higgins commented on CB-3497:
---
Yeah, sorry about that. We combined it with CB-3380 an
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674635#comment-13674635
]
Lorin Beer commented on CB-3497:
go for it, I'll be tagging tomorrow, so there is time.
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674632#comment-13674632
]
Bryan Higgins commented on CB-3497:
---
Lorin, Fil, we have a version working for both Windows
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674580#comment-13674580
]
Filip Maj commented on CB-3497:
---
I will personally high-five both of you if this gets in for 2.
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674577#comment-13674577
]
Bryan Higgins commented on CB-3497:
---
If this does go in for 2.8, we should revert the chang
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674565#comment-13674565
]
Lorin Beer commented on CB-3497:
I'll do some additional testing. It may be where it's locate
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674540#comment-13674540
]
Jeffrey Heifetz commented on CB-3497:
-
It works fine without sudo for me on OSX. I wonder
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674534#comment-13674534
]
Lorin Beer commented on CB-3497:
if sudo is omitted, the command fails on osx
the workflow i
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674519#comment-13674519
]
Bryan Higgins commented on CB-3497:
---
Jeff is working on an alternate implementation here:
h
[
https://issues.apache.org/jira/browse/CB-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673814#comment-13673814
]
ASF subversion and git services commented on CB-3497:
-
Commit e4e444d7b60
24 matches
Mail list logo
