Github user haoch closed the pull request at:
https://github.com/apache/eagle/pull/799
---
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/922
@asdf2014 Thanks!
---
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/989
[MINOR] Upgrade jquery to v3.3.1
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/974
Merged.
---
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/974
LGTM, thanks very much!
---
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/972#discussion_r157673368
--- Diff: eagle-server/src/main/webapp/app/dev/public/js/ctrls/authCtrl.js
---
@@ -26,6 +26,14 @@
$scope.password
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/971
Add eagle v0.5.0 release doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/eagle site
Alternatively you can review and apply these
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/967
[MINOR] Docs: remove incubator words
- Docs: remove incubator words
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/eagle
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/965
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/959
@qingwen220 should it be included in `v0.5.0` release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/965
Should it be included in v0.5.0 release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/966
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/922
@asdf2014 what's the changes? If no, could you please help close it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/914
@jhsenjaliya how could I quickly have a try about the docker image? some
guide like building/quick starting?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/906
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/908
@baibaichen @chitin reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/904
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/901
[Doc] Merge doc source
* Merge doc source from: https://github.com/anyway1021/eagle-doc
* Uploaded to http://eagle.apache.org/docs/latest/
So that contributors could send patch about code
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/783
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/849
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/783
@r7raul1984 how do you think expose `CountMetricFilter` as a parameter to
choose which metric to convert as `count`, and the current hard-code behavior
should only be some kind of default
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/886
[MINOR][DOC] Add slack information in README
* Add slack information in README
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/eagle
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/849
@jhsenjaliya The shell scripts seems no correct
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/849#discussion_r106598634
--- Diff: eagle-assembly/src/main/conf/eagle.conf ---
@@ -75,7 +77,8 @@ metadata {
username = "root"
password = ""
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/849#discussion_r106598804
--- Diff: eagle-server-assembly/src/main/bin/eagle-server.sh ---
@@ -1,136 +0,0 @@
-#!/bin/bash
--- End diff --
Do you delete `eagle-env.sh
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/884
Related to #834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/884
[MINOR] Fix jdbc depenency problem in package assembly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/eagle FixJDBCLoader
Alternatively
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/880
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/881
[EAGLE-960] Fix Alert detail and policy link url
* Fix Alert detail and policy link url
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/eagle
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/871
@koone cool, please update once it's done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/871
@koone @chitin how about this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/869
@qingwen220 i think you are right, please move forward to merge it after
refining the configuration properties.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/869
The original idea is:
range = 1 hour
round = 0
apps_num = 0
do {
apps_num = query(current - range * (round+1), current - range(round))
round
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/869
A little confusing, for example, if you split the past 6 hours in to 6 time
range, `0~1`, `1~2`, `2~3`, `3~4`, `4ï½5`ï¼ when if `4~5` return some apps,
but `3~4` returned `0` apps, then will you
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/869
@qingwen220 What's the default value for each configurations as mentioned
above?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/873
[EAGLE-957] Add dashboard metadata entities and services
Add dashboard metadata entities and services
* org.apache.eagle.metadata.model.DashboardEntity
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/871
@koone could you please add a screenshot about the feature in jira ticket?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/868
[MINOR] Fix metadata updating bug by impl equals/hashCode
Fix metadata updating bug by impl equals/hashCode
You can merge this pull request into a Git repository by running:
$ git pull https
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/867
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/866
[MINOR] Fix AuthFilter to support REST Stream Proxy
* Support `@Auth(required=false)`
* Return `403` instead of `401` for `invalid access` other than
`unauthorized access`
You can merge this pull
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/865
[EAGLE-950] Add REST Stream Proxy for easy integration
https://issues.apache.org/jira/browse/EAGLE-950
You can merge this pull request into a Git repository by running:
$ git pull https
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/854#discussion_r104364892
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/test/ApplicationSimulatorImpl.java
---
@@ -74,24 +75,25 @@ public void start
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/853
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/852
[MINOR] Fix BasicAuthFilter when username/password is null
* Fix BasicAuthFilter when username/password is null
* Disable BasicAuthFilter when authentication is disabled.
You can merge this pull
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/851
[MINOR] Add Authorization into Access-Control-Allow-Headers header
Add `Authorization` into `Access-Control-Allow-Headers` header:
"Access-Control-Allow-Headers": "Or
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/795
OK, please move on to merge the PR directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/848
[EAGLE-932] Support group in stream definition
https://issues.apache.org/jira/browse/EAGLE-932
Support group in stream definition
You can merge this pull request into a Git repository by
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/845
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/842#discussion_r103380038
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/environment/builder/MetricDescriptor.java
---
@@ -1,201 +1,279
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/842#discussion_r103380011
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/environment/builder/ApplicationBuilder.java
---
@@ -1,127 +1,131
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/840
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/844
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/840#discussion_r103176287
--- Diff:
eagle-metric/eagle-hbase-web/src/main/webapp/app/apps/hbase/ctrls/overview.js
---
@@ -59,7 +59,10
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/842
[EAGLE-] Fix system metric collector
Sample system metric stream schema:
{
'timestamp': 1487918913569,
'metric': 'system.nic.transmit
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/840
@anyway1021 please confirm about the changes and deploy to QA to validate
whether https://issues.apache.org/jira/browse/EAGLE-924 is resolved.
---
If your project is set up for it, you can reply to
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/840
@zombieJ please help review about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/841
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/839#discussion_r102645230
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/test/java/org/apache/eagle/siddhiext/StringSubtractFunctionExtensionTest.java
---
@@ -0,0
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/839#discussion_r102645205
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/test/java/org/apache/eagle/siddhiext/StringSubtractFunctionExtensionTest.java
---
@@ -0,0
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/838
@DadanielZ merged, please pull latest code for testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/838
@DadanielZ please check the PR about `KafkaLog4jAppenderIT ` for debug once
build passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/838
[MINOR] Add kafka log4j appender integration test cases
* Add kafka log4j appender integration test cases `KafkaLog4jAppenderIT`
You can merge this pull request into a Git repository by running
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/837
[MINOR] Support source_host aside host in metric collector
Support source_host aside host in metric collector for case when requesting
host is not the actual host for reason like network settings
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/836
Build is related to unstable unit test case `MapRFSAuditLogAppProviderTest`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/836
Is this feature finished?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/812
Just worry about potential compatibility issue as `kafka` which was
refactored a lot recently and here are some tricky dependencies behavior in
`storm-kafka`
---
If your project is set up for it, you
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/831
Merged as Approved by @r7raul1984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/834
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/795
@DadanielZ is this PR still valid?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/796
@DadanielZ is this PR still valid?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/824
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/831
Building failure is caused by checkstyle problem, fixed in
43827444eb0e8fcd46ce6983bf456b920eb5b8b1
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/831
@r7raul1984 I have finished this PR, please help continue to review. If no
more problem, I will merge it after approved.
---
If your project is set up for it, you can reply to this email and have your
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/831#discussion_r102397848
--- Diff:
eagle-server/src/main/java/org/apache/eagle/server/authentication/config/UserAccount.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/831#discussion_r102385723
--- Diff:
eagle-server/src/main/java/org/apache/eagle/server/authentication/config/UserAccount.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/811
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/812
Have you tested about consuming `kafka:0.8.1` with `storm-kafka:1.0.2` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/825
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/831
@zombieJ please move on to refactor eagle login page after this PR merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/831
[EAGLE-918] Improve eagle auth to support
@PermitAll/DenyAll/RolesAllowed/Auth and API
* Improve eagle auth framework to support annotations under Jersey 1.9 and
Dropwizard 0.7.1
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/823
[MINOR] Support /streams?siteId=SITE_ID API
Support /streams?siteId=SITE_ID API to fix stream filter bug in #822
You can merge this pull request into a Git repository by running:
$ git pull https
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/822
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/812
@jhsenjaliya building failed, could you please check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/815
@DadanielZ the build failed, but I am unable to check this history log:
https://builds.apache.org/job/incubator-eagle-pr-reviewer/1594/, could you
please diagnose again?
---
If your project is set up
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/816
Build failed because #818 which has already been fixed now, so merge this
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/816
Will fix the UT exception in #818
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/818
[MINOR] Fix TestHdfsAuditLogApplication by support await RUNNING
Fix TestHdfsAuditLogApplication by supporting await RUNNING
Resolve Exception: App: HDFS_AUDIT_LOG_MONITOR_APP_TEST_SITE status
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/814
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/810
@r7raul1984 please merge by your self as @zombieJ already approved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/813
@zombieJ could you please help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/808
[MINOR] Add hadoop_jmx_metric_${siteId} to support dynamically changing
topic name
* Add hadoop_jmx_metric_${siteId} to support dynamically changing topic
name according site context
You can merge
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/797
@zombieJ how about the review progress?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/806
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/804
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/801
[EAGLE-895] Improve alert engine metadata to organize by siteId
https://issues.apache.org/jira/browse/EAGLE-895
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/799
[EAGLE-890] Add Job Scheduling Framework and HadoopHealthCheckApp
* Add Job Scheduling Framework based on quartz scheduling to support
clustering job scheduling and HA
* Add HadoopHealthCheckApp
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/795
@DadanielZ eagle currently requires `jdk-1.8` to compile, why the build
failed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/783
@r7raul1984 would you convert *all* counter metric to rate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/796
@wujinhu please help review the PR about app/server config changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/785
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
1 - 100 of 142 matches
Mail list logo
