[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric

2017-03-20 Thread r7raul1984
Github user r7raul1984 commented on the issue: https://github.com/apache/eagle/pull/783 @haoch Thanks. I will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric

2017-03-20 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/783 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric

2017-03-17 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/783 @r7raul1984 how do you think expose `CountMetricFilter` as a parameter to choose which metric to convert as `count`, and the current hard-code behavior should only be some kind of default implementatio

[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric

2017-02-07 Thread r7raul1984
Github user r7raul1984 commented on the issue: https://github.com/apache/eagle/pull/783 @haoch If metric name endswith "count" , it will be converted to rate. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric

2017-02-07 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/783 @r7raul1984 would you convert *all* counter metric to rate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have