[GitHub] eagle pull request #842: [EAGLE-928] Refine system metric schema design and ...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/eagle/pull/842 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] eagle pull request #842: [EAGLE-928] Refine system metric schema design and ...

2017-02-27 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/eagle/pull/842#discussion_r103380038 --- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/environment/builder/MetricDescriptor.java --- @@ -1,201 +1,279 @@ -/*

[GitHub] eagle pull request #842: [EAGLE-928] Refine system metric schema design and ...

2017-02-27 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/eagle/pull/842#discussion_r103380011 --- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/environment/builder/ApplicationBuilder.java --- @@ -1,127 +1,131 @@ -/*