[GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...

2015-01-18 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/290#issuecomment-70455214 Not entirely, all unit tests in MemorySegmentTest and MemoryManagerTest are executed for both, the old heap and the new off-heap implementation. Nevertheless, more

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-70440395 I created a modified version of this pull request. It does not yet register any extra serializers, but it uses the tests to verify that extra serializers work.

[jira] [Updated] (FLINK-1418) Make 'print()' output on the client command line, rather than on the task manager sysout

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-1418: Fix Version/s: (was: 0.9) > Make 'print()' output on the client command line, rather than on the

[jira] [Created] (FLINK-1418) Make 'print()' output on the client command line, rather than on the task manager sysout

2015-01-18 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-1418: --- Summary: Make 'print()' output on the client command line, rather than on the task manager sysout Key: FLINK-1418 URL: https://issues.apache.org/jira/browse/FLINK-1418

[jira] [Created] (FLINK-1417) Automatically register nested types at Kryo

2015-01-18 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-1417: --- Summary: Automatically register nested types at Kryo Key: FLINK-1417 URL: https://issues.apache.org/jira/browse/FLINK-1417 Project: Flink Issue Type: Improveme

[jira] [Resolved] (FLINK-1416) Dependency versions in quickstart archetypes are wrong

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1416. - Resolution: Fixed Fixed in 29c54a20dd89104ef5832c972ac10bbeed958ee1 > Dependency versions in quic

[jira] [Resolved] (FLINK-1399) Add support for registering Serializers with Kryo

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1399. - Resolution: Fixed Fix Version/s: 0.9 Fixed via a0b6af20beed6d12d0f33f6f58f323b20cc12961 and

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/290#issuecomment-70432006 At a first glance, this is entirely missing test cases for the DirectMemorySegment. Considering that this is code that an kill the JVM with segfaults if buggy, thi

[jira] [Created] (FLINK-1416) Dependency versions in quickstart archetypes are wrong

2015-01-18 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-1416: --- Summary: Dependency versions in quickstart archetypes are wrong Key: FLINK-1416 URL: https://issues.apache.org/jira/browse/FLINK-1416 Project: Flink Issue Type

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/319 [FLINK-1415] Akka cleanups This PR removes the akka.jobmanager.url config parameter to override the jobmanager address and port set in the configuration. Adds timeout heuristics to dedu

[jira] [Created] (FLINK-1415) Akka cleanups

2015-01-18 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-1415: Summary: Akka cleanups Key: FLINK-1415 URL: https://issues.apache.org/jira/browse/FLINK-1415 Project: Flink Issue Type: Improvement Reporter: Til

[jira] [Commented] (FLINK-1414) Remove quickstart-*.sh from git source and put them to the website's svn

2015-01-18 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281987#comment-14281987 ] Márton Balassi commented on FLINK-1414: --- When removing the scripts put some info to

[GitHub] flink pull request: Commits cherry-picked from the release 0.8 bra...

2015-01-18 Thread mbalassi
Github user mbalassi closed the pull request at: https://github.com/apache/flink/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] flink pull request: Commits cherry-picked from the release 0.8 bra...

2015-01-18 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/298#issuecomment-70429116 Thanks, done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70424921 Maybe we should offer users both options: register and default serializer. In some cases, you don't know the exact types and you want to go for a default serializer.

[jira] [Created] (FLINK-1414) Remove quickstart-*.sh from git source and put them to the website's svn

2015-01-18 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-1414: - Summary: Remove quickstart-*.sh from git source and put them to the website's svn Key: FLINK-1414 URL: https://issues.apache.org/jira/browse/FLINK-1414 Project: Fli

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70424146 The registration at Kryo seems to be a bit incomplete. Adding a default serializer does not to type/tag registration, which is very much desirable. Also, it registers

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70422236 I do not see how this can possibly work on a cluster... Everything is in static variables (in the client) that do not get transferred via serialization when moving the

[jira] [Resolved] (FLINK-1400) In local mode, the default TaskManager won't listen on the data port.

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1400. - Resolution: Won't Fix This is expected behavior: - A single task manager in local mode does not i

[jira] [Commented] (FLINK-655) Add support for both single and set of broadcast values

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281927#comment-14281927 ] Stephan Ewen commented on FLINK-655: I think it is fine to add functions for scalar val

[jira] [Commented] (FLINK-655) Add support for both single and set of broadcast values

2015-01-18 Thread Henry Saputra (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281923#comment-14281923 ] Henry Saputra commented on FLINK-655: - So, the option are: 1. Use this JIRA as vehicle

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-70421463 Look good. The test coverage is massive - very good for a delicate concept like this :-) One remaining issue is the naming of the methods/concepts and how they

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23135998 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/DualInputSemanticProperties.java --- @@ -56,218 +56,135 @@

[GitHub] flink pull request: Commits cherry-picked from the release 0.8 bra...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/298#issuecomment-70421138 I addressed the comments and committed the changes to the 0.9 master. I forgot to add the "This closes #298" message, thought. Marton, can you close this Pull Request

[jira] [Resolved] (FLINK-1384) Web Infoserver has unused JS libraries

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1384. - Resolution: Fixed Removed in 0.9 in f38e2039969f613c18edda2528e4e7b5018d46ad > Web Infoserver has

[jira] [Resolved] (FLINK-1382) Void is not added to TypeInfoParser

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1382. - Resolution: Fixed Fix Version/s: 0.9 Fixed in 9cd96df752ed03b8e649d82d6df71ab1f400ee70 > V

[jira] [Resolved] (FLINK-1206) Add option to the web client to specify default parallelism for a program

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1206. - Resolution: Fixed Fix Version/s: 0.9 Assignee: Mingliang Qi Fixed via d3072ba57877

[jira] [Resolved] (FLINK-1229) Synchronize WebClient arguments with command line arguments

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1229. - Resolution: Fixed Fix Version/s: 0.9 Assignee: Mingliang Qi Fixed via d3072ba57877

[GitHub] flink pull request: [FLINK-1229][FLINK-1206] Synchronize webclient...

2015-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1382][java] Adds the new basic types Vo...

2015-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23135475 --- Diff: flink-compiler/src/main/java/org/apache/flink/compiler/dag/AbstractPartialSolutionNode.java --- @@ -86,8 +87,8 @@ public void computeInterestin

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/318 [FLINK-1376] [runtime] Add proper shared slot release in case of a fatal TaskManager failure for 0.8 branch This PR introduces SharedSlots as being a special Slot type and as such being release

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/317 [FLINK-1376] [runtime] Add proper shared slot release in case of a fatal TaskManager failure This PR introduces SharedSlots as being a special Slot type and as such being released properly in c

[GitHub] flink pull request: Release 0.8 Preparations

2015-01-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/294#issuecomment-70418596 The changes have been merged to 0.8 and master (except for FLINK-1385, but this fix needs to be implemented differently for master. I'll do that as part of my yarn pull r

[GitHub] flink pull request: Release 0.8 Preparations

2015-01-18 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Created] (FLINK-1413) Add option to YARN client to use already deployed uberjar/flink files instead of redeploying on each YARN session

2015-01-18 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-1413: - Summary: Add option to YARN client to use already deployed uberjar/flink files instead of redeploying on each YARN session Key: FLINK-1413 URL: https://issues.apache.org/jira/br

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/309#issuecomment-70417368 Found an issue with the releasing of colocated task slots and the disposal of shared slots for colocation groups. Will open a new PR with fix and rebased code. ---

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/310#issuecomment-70417343 Found an issue with the releasing of colocated task slots and the disposal of shared slots for colocation groups. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1027] ignore invalid commandline option...

2015-01-18 Thread physikerwelt
Github user physikerwelt closed the pull request at: https://github.com/apache/flink/pull/161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Release 0.8 Preparations

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/294#issuecomment-70416739 What happens to this PR? Have all the commits been added to 0.8 or master? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/292#issuecomment-70416726 Thank you for the feedback. I'll address the inline comments. Regarding the questions: 1. The separation between `flink-yarn` and `flink-yarn-tests` exists be

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70416371 This would do it for now. However, the use of static variables to communicate between components is an antipattern and one that has caused problems before. I would lik

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/292#issuecomment-70415876 A good piece of work!. I like that there is a much better test coverage for the Yarn cluster now. @rmetzger Can you comment on a few open questions?

[GitHub] flink pull request: [FLINK-1229][FLINK-1206] Synchronize webclient...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/291#issuecomment-70415920 Looks good to be merged, in my opinion! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/292#discussion_r23134668 --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOIT.java --- @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache Softwar

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/292#discussion_r23134660 --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerIT.java --- @@ -0,0 +1,72 @@ +/** + * Licensed to the A

[jira] [Commented] (FLINK-1411) PlanVisualizer is not working

2015-01-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281857#comment-14281857 ] Robert Metzger commented on FLINK-1411: --- +1 for hosting the tool on the website (ver

[jira] [Commented] (FLINK-1370) Build website automatically

2015-01-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281854#comment-14281854 ] Robert Metzger commented on FLINK-1370: --- I talked to infra and it seems to be imposs

[jira] [Commented] (FLINK-655) Add support for both single and set of broadcast values

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281850#comment-14281850 ] Stephan Ewen commented on FLINK-655: Admittedly, there is a slight naming inconsistency

[jira] [Commented] (FLINK-1411) PlanVisualizer is not working

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281847#comment-14281847 ] Stephan Ewen commented on FLINK-1411: - I just saw that the JS libraries/images for the

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-70413969 Two questions relevant to the interplay with other code: - How does the `registerType()` interact with the registration of custom kryo serializers? - Why is

[jira] [Commented] (FLINK-1372) TaskManager and JobManager do not log startup settings any more

2015-01-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281843#comment-14281843 ] Stephan Ewen commented on FLINK-1372: - This should be fixed with some priority, actual

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-18 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-70413423 @StephanEwen would that look like this? ```java reverse(dataset.map(...)).filter(...) ``` Ive been thinking about the API overload issue a bit: could a D

[GitHub] flink pull request: [FLINK-1228] Add REST Interface to JobManager

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/297#issuecomment-70413324 Thanks for taking a go at this. It is going into a good direction. What needs to be adjusted is the way that the job manager gets accessed. The current code

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-70412946 This looks like a nice approach. Concerning the naming/packaging: How about we create a package `org.apache.flink.api.java.lib` with various classes with utili

[jira] [Closed] (FLINK-1412) Update Website Links - Optimizer Plan Visualization Tool

2015-01-18 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Neutatz closed FLINK-1412. Resolution: Duplicate I guess this is the same issue like [FLINK-1317] > Update Website Links - Opt

[jira] [Created] (FLINK-1412) Update Website Links - Optimizer Plan Visualization Tool

2015-01-18 Thread Felix Neutatz (JIRA)
Felix Neutatz created FLINK-1412: Summary: Update Website Links - Optimizer Plan Visualization Tool Key: FLINK-1412 URL: https://issues.apache.org/jira/browse/FLINK-1412 Project: Flink Issue