Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/351#issuecomment-72162452
To reduce code duplication and tracing, we could just throw the exception
inside createInput(InputFormat inputFormat, TypeInformation
producedType) by wrapping IllegalArg
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/236#issuecomment-72161285
Then it fails at runtime, which makes me very uneasy. But then again, stuff
can always fail at runtime when the user uses some strange subclass. Even more
so without this
[
https://issues.apache.org/jira/browse/FLINK-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297785#comment-14297785
]
Henry Saputra commented on FLINK-1452:
--
I like {{flink-contrib}} and it reflect the c
[
https://issues.apache.org/jira/browse/FLINK-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297756#comment-14297756
]
ASF GitHub Bot commented on FLINK-1460:
---
Github user hsaputra commented on the pull
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72111491
@coderxiang, ah that the tests do comparison in the after method so it is
hard to figure out which method fail. But seemed like other builds passed and I
am sure that you
[
https://issues.apache.org/jira/browse/FLINK-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297727#comment-14297727
]
ASF GitHub Bot commented on FLINK-1460:
---
Github user hsaputra commented on the pull
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72109489
HI @aljoscha, thanks.
If you could merge it before later tonight please do. Otherwise I could do
it later tonight if you did not have time to get to this one =)
---
[
https://issues.apache.org/jira/browse/FLINK-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297713#comment-14297713
]
ASF GitHub Bot commented on FLINK-1460:
---
Github user coderxiang commented on the pul
Github user coderxiang commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72107415
@hsaputra @aljoscha I failed one check which I don't have much idea about.
Could you please retest?
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/FLINK-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297692#comment-14297692
]
Chiwan Park commented on FLINK-1452:
+1 {{flink-staging}}
And, I think we can refer t
[
https://issues.apache.org/jira/browse/FLINK-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297687#comment-14297687
]
ASF GitHub Bot commented on FLINK-1422:
---
Github user zentol commented on the pull re
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/350#issuecomment-72105374
gotcha, I'll address the points mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/236#issuecomment-72103112
What would happen if a base class fulfills the POJO requirements, but the
subclass does not?
---
If your project is set up for it, you can reply to this email and hav
[
https://issues.apache.org/jira/browse/FLINK-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297602#comment-14297602
]
ASF GitHub Bot commented on FLINK-1422:
---
Github user fhueske commented on the pull r
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/350#issuecomment-72098340
Very good addition to the documentation!
I also agree with Alex (see FLINK-1422) to describe how functions can be
configured via the constructor, i.e., that function o
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/351
Improved exception for missing type of InputFormat
As per discussion on the dev mailing list.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twal
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/349#issuecomment-72042165
The change makes sense. The TypeExtractor can never get the types from `new
TypeSerializerInputFormat()` automatically, so passing them in the
constructor is correct.
Vasia Kalavri created FLINK-1462:
Summary: Add documentation guide for the graph API
Key: FLINK-1462
URL: https://issues.apache.org/jira/browse/FLINK-1462
Project: Flink
Issue Type: Task
[
https://issues.apache.org/jira/browse/FLINK-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296986#comment-14296986
]
Alexander Alexandrov commented on FLINK-1422:
-
+1 from me as well.
I recently
[
https://issues.apache.org/jira/browse/FLINK-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-1376:
Assignee: Till Rohrmann
> SubSlots are not properly released in case that a TaskManager fata
[
https://issues.apache.org/jira/browse/FLINK-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296972#comment-14296972
]
ASF GitHub Bot commented on FLINK-1193:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/348#discussion_r23773125
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/types/TypeInformationGenTest.scala
---
@@ -255,6 +255,53 @@ class TypeInformationGenTest {
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/350#issuecomment-72039131
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
[
https://issues.apache.org/jira/browse/FLINK-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296971#comment-14296971
]
ASF GitHub Bot commented on FLINK-1422:
---
Github user aljoscha commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296968#comment-14296968
]
Aljoscha Krettek commented on FLINK-1450:
-
I see the necessity in the streaming AP
[
https://issues.apache.org/jira/browse/FLINK-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296966#comment-14296966
]
ASF GitHub Bot commented on FLINK-1422:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/350
[FLINK-1422] Add withParameters() to documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/incubator-flink docu_parameters
Alterna
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/349
Added ResultTypeQueryable interface to TypeSerializerInputFormat.
It is currently impossible to use the `TypeSerializerInputFormat` with
generic Tuple types.
For example, [this example
[
https://issues.apache.org/jira/browse/FLINK-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296957#comment-14296957
]
Aljoscha Krettek commented on FLINK-1456:
-
I don't know if this is really necessar
[
https://issues.apache.org/jira/browse/FLINK-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296949#comment-14296949
]
ASF GitHub Bot commented on FLINK-1460:
---
Github user aljoscha commented on the pull
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72036147
+1, can you merge it @hsaputra or should I?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
[
https://issues.apache.org/jira/browse/FLINK-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296912#comment-14296912
]
Aljoscha Krettek commented on FLINK-1452:
-
Or {{flink-staging}}.
> Add "flink-con
[
https://issues.apache.org/jira/browse/FLINK-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296902#comment-14296902
]
Robert Metzger commented on FLINK-1447:
---
I just ran into the issue as well, on the l
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/236#issuecomment-72020646
I took @fhueske's rebase from #316.
I also added a switch to the TypeExtractor to force it to use Kryo, even
though it could analyse a type as a POJO. In some cas
[
https://issues.apache.org/jira/browse/FLINK-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296788#comment-14296788
]
ASF GitHub Bot commented on FLINK-1193:
---
GitHub user twalthr opened a pull request:
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/348
[FLINK-1193][java-api][scala-api] Complete support for multidimensional
arrays
This PR introduces official support for multidimensional arrays.
It contains bug fixes for TypeExtractor and S
Fabian Hueske created FLINK-1461:
Summary: Add sortPartition operator
Key: FLINK-1461
URL: https://issues.apache.org/jira/browse/FLINK-1461
Project: Flink
Issue Type: New Feature
Co
[
https://issues.apache.org/jira/browse/FLINK-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296712#comment-14296712
]
Fabian Hueske commented on FLINK-1105:
--
[~StephanEwen] Yes, I thought about adding a
[
https://issues.apache.org/jira/browse/FLINK-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296708#comment-14296708
]
ASF GitHub Bot commented on FLINK-1105:
---
GitHub user fhueske opened a pull request:
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/347
[FLINK-1105] Add support for locally sorted output
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink locallySortedOutput
Alternative
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/236#issuecomment-72006969
We could try and analyse the type as a POJO. If it is a POJO add it to the
PojoSerializer, otherwise, add it to the KryoSerializer.
---
If your project is set up for it
[
https://issues.apache.org/jira/browse/FLINK-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296610#comment-14296610
]
Stephan Ewen commented on FLINK-1459:
-
[~jsand] Stay tuned for a few days, it is going
42 matches
Mail list logo
