[
https://issues.apache.org/jira/browse/FLINK-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chiwan Park reassigned FLINK-1654:
--
Assignee: Chiwan Park
> Wrong scala example of POJO type in documentation
> ---
[
https://issues.apache.org/jira/browse/FLINK-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352498#comment-14352498
]
ASF GitHub Bot commented on FLINK-1651:
---
Github user hsaputra commented on the pull
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/460#issuecomment-77796609
Thx @StephanEwen, will merge this tomorrow unless someone else beats me to
it.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/461#issuecomment-77796550
Thx @StephanEwen, will merge this tomorrow unless someone beats me to it =)
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/459#issuecomment-77781300
thanks for the review Stephan! The synchronous call to executionGraph
restart was a very sneaky thing, I committed it by mistake while trying some
things out and it's
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/459#issuecomment-77780751
For the sake of structure, can you also squash a few cleanup commits and
prefix all commits consistently with issue numbers and component
(https://cwiki.apache.org/con
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/459#issuecomment-77780578
Nice first prototype. From my first tries, it seems to work with respect to
checkpointing Kafka state in a pipelined (non-blocking) fashion and to reuse it.
He
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/459#discussion_r26010235
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/invokable/operator/co/CoInvokable.java
---
@@ -8
[
https://issues.apache.org/jira/browse/FLINK-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri reassigned FLINK-1652:
Assignee: Vasia Kalavri
> Wrong superstep number in VertexCentricIteration in Collection mo
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/459#discussion_r26010116
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/StreamStateMonitor.scala
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/459#discussion_r26010092
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/KafkaConsumerIterator.j
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/459#discussion_r26010088
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/KafkaConsumerIterator.j
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/459#discussion_r26010038
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/KafkaConsumerIterator.j
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/459#discussion_r26009956
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -471,6 +508,7 @@ void jobVertexInFinalState(Execu
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/462#issuecomment-6685
Thanks @andralungu! We need to remember to also change the documentation
before we merge this :)
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/FLINK-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352287#comment-14352287
]
ASF GitHub Bot commented on FLINK-1632:
---
Github user vasia commented on the pull req
[
https://issues.apache.org/jira/browse/FLINK-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352282#comment-14352282
]
ASF GitHub Bot commented on FLINK-1632:
---
Github user vasia commented on a diff in th
[
https://issues.apache.org/jira/browse/FLINK-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352280#comment-14352280
]
ASF GitHub Bot commented on FLINK-1632:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/462#discussion_r26009469
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GraphMetrics.java
---
@@ -63,17 +63,17 @@ public static void main(String[] args
[
https://issues.apache.org/jira/browse/FLINK-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352281#comment-14352281
]
ASF GitHub Bot commented on FLINK-1632:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/462#discussion_r26009450
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -292,7 +291,7 @@ public ExecutionEnvironment getContext() {
*
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/462#discussion_r26009452
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -919,7 +918,7 @@ public K map(Vertex vertex) {
*t
[
https://issues.apache.org/jira/browse/FLINK-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Márton Balassi resolved FLINK-1429.
---
Resolution: Implemented
Done via 8c9ab85e and 7582390.
> Add documentation for streaming scal
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352264#comment-14352264
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user vasia commented on the pull req
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-4618
- Regarding annotations, I actually tried as many I could find :)) [This is
the commit]
(https://github.com/vasia/flink/blob/653cb21981a80c5790ca29804e39e4c3642aee2d/flink-s
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352261#comment-14352261
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-4317
Ona more thought: The triplet re-building in every iteration seems quite
expensive. Does it make sense to have the triplets (or quadruplets, with the
vertex value) as
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352260#comment-14352260
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-4282
The vertex-centric iterations use semantic annotations a lot to save
sorting/partitioning where possible. This results in a plan for the
vertex-centric iterations that
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352256#comment-14352256
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user vasia commented on the pull req
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-4172
Regarding the rest of the comments:
- shall we change the SumFunction, ApplyFunction, etc. to have 2 versions,
i.e. single-abstract-interface and rich? If yes, it should
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352254#comment-14352254
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26008902
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/ApplyFunction.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apach
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352250#comment-14352250
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26008874
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/ApplyFunction.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Soft
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352238#comment-14352238
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26008662
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -52,4 +52,35 @@ under the License.
test
+
+
+
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352052#comment-14352052
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-77750264
I am just dropping some more thoughts here ;-)
The interface seems a bit confusing. Right now, one has to first create the
iteration from the graph and then te
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352047#comment-14352047
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26005198
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/ApplyFunction.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apach
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352042#comment-14352042
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user rmetzger commented on a diff in
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26005153
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -52,4 +52,35 @@ under the License.
test
+
+
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352041#comment-14352041
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-77749391
In the core API, we have started to define all functions (map, join, ... -
here it would be SumFunction, ApplyFunction) as single-abstract-method
interfaces. That allo
[
https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352040#comment-14352040
]
ASF GitHub Bot commented on FLINK-1514:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-77749211
This adds a Guava dependency and does some Hadoop profile magic. We have to
be very careful when merging this to be consistent with changes in #454 by
@rmetzger
[
https://issues.apache.org/jira/browse/FLINK-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352034#comment-14352034
]
amit pal commented on FLINK-1450:
-
Hey Akshay,
You can go ahead and implement this featur
[
https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352026#comment-14352026
]
ASF GitHub Bot commented on FLINK-1472:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/439#issuecomment-77746861
Nice, looks good to me.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
[
https://issues.apache.org/jira/browse/FLINK-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352025#comment-14352025
]
ASF GitHub Bot commented on FLINK-1628:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/458#issuecomment-77746801
Looks good. Impressive test coverage!
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
[
https://issues.apache.org/jira/browse/FLINK-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352024#comment-14352024
]
ASF GitHub Bot commented on FLINK-1651:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/460#issuecomment-77746603
Good fix, good to merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/461#issuecomment-77746561
Makes sense, good to merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
[
https://issues.apache.org/jira/browse/FLINK-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351975#comment-14351975
]
Márton Balassi commented on FLINK-1534:
---
Dear Askhay,
Thanks for your interest in F
Github user qmlmoon commented on the pull request:
https://github.com/apache/flink/pull/439#issuecomment-77739274
The configuration view is separated into user and default now:
