Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/516#issuecomment-84741359
Will help review if more description about the direction of the patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/FLINK-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375250#comment-14375250
]
ASF GitHub Bot commented on FLINK-1767:
---
Github user hsaputra commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374890#comment-14374890
]
ASF GitHub Bot commented on FLINK-1655:
---
Github user gyfora commented on the pull
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/474#issuecomment-84575589
@gaborhermann, @rmetzger wwhat is the status of this PR? Some of the code
is already in, other parts are missing. Is the code considered ready?
---
If your project is
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/508#issuecomment-84592099
I personally don't like the sound of all these class names too much. It
seems to be too redundant and too long in most cases. I know the ...Invokables
weren't so much
[
https://issues.apache.org/jira/browse/FLINK-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374894#comment-14374894
]
ASF GitHub Bot commented on FLINK-1756:
---
Github user senorcarbone commented on the
[
https://issues.apache.org/jira/browse/FLINK-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374911#comment-14374911
]
ASF GitHub Bot commented on FLINK-1763:
---
GitHub user gyfora opened a pull request:
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/513
[FLINK-1763] [streaming] Remove cancel from SinkFunction
In addition, always calls the close method of the functions even if it was
cancelled.
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/FLINK-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374888#comment-14374888
]
ASF GitHub Bot commented on FLINK-1756:
---
Github user gyfora commented on the pull
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84591454
1 sec seems to be little to frequent until we make this very efficient. I
would put it around 3-5 sec.
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/FLINK-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374889#comment-14374889
]
ASF GitHub Bot commented on FLINK-1756:
---
Github user gyfora commented on the pull
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84591515
Other than this, it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374895#comment-14374895
]
Gyula Fora commented on FLINK-1763:
---
I wonder if we should do the same thing with the
[
https://issues.apache.org/jira/browse/FLINK-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374858#comment-14374858
]
ASF GitHub Bot commented on FLINK-1655:
---
Github user mbalassi commented on the pull
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/508#issuecomment-84576440
Nice, thanks for also updating the minor details.
`GroupedWindowBufferStreamOperator` is a bit long of a name for my taste, but
other than LGTM. :)
---
If your project
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84633164
@gyfora: Changed default checkpoint interval to 5 secs.
@senorcarbone: Thanks for the reminder on that. I do not have a really nice
idea for the compaction
[
https://issues.apache.org/jira/browse/FLINK-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375016#comment-14375016
]
ASF GitHub Bot commented on FLINK-1756:
---
Github user mbalassi commented on the pull
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/515
Rename the variable 'contentAdressable' to 'contentAddressable'
Rename the variable 'contentAdressable' to 'contentAddressable' in order to
better understanding.
You can merge this pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/506
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375078#comment-14375078
]
ASF GitHub Bot commented on FLINK-1688:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375076#comment-14375076
]
ASF GitHub Bot commented on FLINK-1763:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375077#comment-14375077
]
ASF GitHub Bot commented on FLINK-1756:
---
Github user asfgit closed the pull request
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/514
[FLINK-1768]Fix the bug of BlobServerConnection's LOG.
The LOG in class of BlobServerConnection should be created by classloader
of BlobServerConnection.class
You can merge this pull request
Sibao Hong created FLINK-1768:
-
Summary: Fix the bug of BlobServerConnection's LOG.
Key: FLINK-1768
URL: https://issues.apache.org/jira/browse/FLINK-1768
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375044#comment-14375044
]
ASF GitHub Bot commented on FLINK-1768:
---
GitHub user matadorhong opened a pull
[
https://issues.apache.org/jira/browse/FLINK-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Márton Balassi resolved FLINK-1688.
---
Resolution: Implemented
Fix Version/s: 0.9
Client version implemented via a3bc785 and
[
https://issues.apache.org/jira/browse/FLINK-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Márton Balassi resolved FLINK-1756.
---
Resolution: Implemented
Implemented via 2842e2f
Rename Stream Monitoring to Stream
[
https://issues.apache.org/jira/browse/FLINK-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375136#comment-14375136
]
ASF GitHub Bot commented on FLINK-1756:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84687727
Change looks good.
I miss some javadocs on the user facing methods ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/FLINK-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gevay reassigned FLINK-1767:
--
Assignee: Gabor Gevay
StreamExecutionEnvironment's execute should return JobExecutionResult
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/516
[FLINK-1767] [streaming] Make StreamExecutionEnvironment return
JobExecutionResult
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ggevay/flink
[
https://issues.apache.org/jira/browse/FLINK-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375182#comment-14375182
]
ASF GitHub Bot commented on FLINK-1767:
---
GitHub user ggevay opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Márton Balassi closed FLINK-1763.
-
Resolution: Implemented
Implemented via 35f3416
Remove cancel from streaming SinkFunction
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/484#issuecomment-84575241
No problem, thanks for the contribution. Cherry-picked and squashed your
commits. I've decided to make three changes:
1. The output was not necessarily flushed
[
https://issues.apache.org/jira/browse/FLINK-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374852#comment-14374852
]
ASF GitHub Bot commented on FLINK-1688:
---
Github user mbalassi commented on the pull
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/516#issuecomment-84743663
Yes, sorry for not providing a description.
I changed the return type of StreamExecutionEnvironment.execute() from void
to JobExecutionResult, and then added return
[
https://issues.apache.org/jira/browse/FLINK-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375261#comment-14375261
]
ASF GitHub Bot commented on FLINK-1767:
---
Github user ggevay commented on the pull
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/516#issuecomment-84741309
Could give more description about how you go about with the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375251#comment-14375251
]
ASF GitHub Bot commented on FLINK-1767:
---
Github user hsaputra commented on the pull
41 matches
Mail list logo
