[GitHub] flink pull request: [FLINK-1319][core] Add static code analysis fo...

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/729#issuecomment-105840358 The tests are failing with checkstyle violations. Can you fix those? --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-1319) Add static code analysis for UDFs

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560695#comment-14560695 ] ASF GitHub Bot commented on FLINK-1319: --- Github user StephanEwen commented on the

[GitHub] flink pull request: Implemented TwitterSourceFilter and adapted Tw...

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/695#issuecomment-105845451 I tried to merge this, but it is quite unmergeable. Before we can add this, we need you to rebase this pull request and squash all commits into one commit.

[GitHub] flink pull request: Flink Storm compatibility

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/573#issuecomment-105849950 Anything blocking this pull request, or can it be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-1319][core] Add static code analysis fo...

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/729#issuecomment-105814322 Indeed, this looks like an impressive addition. Let's get it into 0.9 as a beta feature! --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: basic TfidfTransformer

2015-05-27 Thread aalexandrov
Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/730#discussion_r31113442 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/TfIdfTransformer.scala --- @@ -0,0 +1,107 @@ +package

[GitHub] flink pull request: [core] cleanup tests for FileInputFormat

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/732#issuecomment-105840172 Seems reasonable. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2047] [ml] Rename CoCoA to SVM

2015-05-27 Thread thvasilo
GitHub user thvasilo opened a pull request: https://github.com/apache/flink/pull/733 [FLINK-2047] [ml] Rename CoCoA to SVM The CoCoA algorithm as implemented functions as an SVM classifier. As CoCoA mostly concerns the optimization process and not the actual learning

[jira] [Commented] (FLINK-2047) Rename CoCoA to SVM

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560719#comment-14560719 ] ASF GitHub Bot commented on FLINK-2047: --- GitHub user thvasilo opened a pull request:

[jira] [Commented] (FLINK-1952) Cannot run ConnectedComponents example: Could not allocate a slot on instance

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560726#comment-14560726 ] ASF GitHub Bot commented on FLINK-1952: --- Github user tillrohrmann commented on a

[GitHub] flink pull request: [FLINK-1952] [jobmanager] Rework and fix slot ...

2015-05-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/731#discussion_r31119327 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/Slot.java --- @@ -24,27 +24,40 @@ import

[jira] [Created] (FLINK-2097) Add support for JobSessions

2015-05-27 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-2097: --- Summary: Add support for JobSessions Key: FLINK-2097 URL: https://issues.apache.org/jira/browse/FLINK-2097 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-2073) Add contribution guide for FlinkML

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560708#comment-14560708 ] ASF GitHub Bot commented on FLINK-2073: --- Github user tillrohrmann commented on a

[GitHub] flink pull request: [FLINK-2073] [ml] [docs] Adds contribution gui...

2015-05-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/727#discussion_r31118088 --- Diff: docs/libs/ml/contribution_guide.md --- @@ -20,7 +21,329 @@ specific language governing permissions and limitations under the License.

[GitHub] flink pull request: [FLINK-2073] [ml] [docs] Adds contribution gui...

2015-05-27 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/727#issuecomment-105843688 I addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-2073) Add contribution guide for FlinkML

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560709#comment-14560709 ] ASF GitHub Bot commented on FLINK-2073: --- Github user tillrohrmann commented on the

[GitHub] flink pull request: [core] cleanup tests for FileInputFormat

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2073] [ml] [docs] Adds contribution gui...

2015-05-27 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/727#issuecomment-105861380 LGTM, only one minor comment. I also like the addition of descriptions for the fit and predict methods to each algorithm. --- If your project is set up for it, you can

[GitHub] flink pull request: basic TfidfTransformer

2015-05-27 Thread aalexandrov
Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/730#discussion_r31113926 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/TfIdfTransformer.scala --- @@ -0,0 +1,107 @@ +package

[jira] [Commented] (FLINK-2073) Add contribution guide for FlinkML

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560752#comment-14560752 ] ASF GitHub Bot commented on FLINK-2073: --- Github user thvasilo commented on the pull

[jira] [Commented] (FLINK-1319) Add static code analysis for UDFs

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560609#comment-14560609 ] ASF GitHub Bot commented on FLINK-1319: --- Github user StephanEwen commented on the

[jira] [Commented] (FLINK-2096) Remove implicit conversions in Streaming Scala API

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560700#comment-14560700 ] ASF GitHub Bot commented on FLINK-2096: --- Github user StephanEwen commented on the

[jira] [Commented] (FLINK-1319) Add static code analysis for UDFs

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560614#comment-14560614 ] ASF GitHub Bot commented on FLINK-1319: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-1319][core] Add static code analysis fo...

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/729#issuecomment-105816818 Looks very nice, seems to have a good test coverage as well. How well does it work with bytecode generated by the Scala Compiler? --- If your project is set

[GitHub] flink pull request: basic TfidfTransformer

2015-05-27 Thread aalexandrov
Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/730#discussion_r31114073 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/TfIdfTransformer.scala --- @@ -0,0 +1,107 @@ +package

[GitHub] flink pull request: [core] cleanup tests for FileInputFormat

2015-05-27 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/732 [core] cleanup tests for FileInputFormat followup of f2891ab857e00bc70eb025bb430f46f4f58355a5 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request: [FLINK-2004] Fix memory leak in presence of fa...

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/674#issuecomment-105846281 What is the status of this pull request? Any pending changes, or is it blocked by anything? --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-2004) Memory leak in presence of failed checkpoints in KafkaSource

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560713#comment-14560713 ] ASF GitHub Bot commented on FLINK-2004: --- Github user StephanEwen commented on the

[GitHub] flink pull request: Implemented TwitterSourceFilter and adapted Tw...

2015-05-27 Thread HilmiYildirim
Github user HilmiYildirim commented on the pull request: https://github.com/apache/flink/pull/695#issuecomment-105884995 Done. I hope every thing works fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Assigned] (FLINK-687) Add support for outer-joins

2015-05-27 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiwan Park reassigned FLINK-687: - Assignee: Chiwan Park Add support for outer-joins ---

[jira] [Commented] (FLINK-687) Add support for outer-joins

2015-05-27 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560864#comment-14560864 ] Chiwan Park commented on FLINK-687: --- Hi. I want to contribute patch for this issue. I am

[GitHub] flink pull request: [FLINK-2073] [ml] [docs] Adds contribution gui...

2015-05-27 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/727#issuecomment-105891978 Will merge it then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-1319) Add static code analysis for UDFs

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560921#comment-14560921 ] ASF GitHub Bot commented on FLINK-1319: --- Github user twalthr commented on the pull

[jira] [Assigned] (FLINK-2061) CSVReader: quotedStringParsing and includeFields yields ParseException

2015-05-27 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiwan Park reassigned FLINK-2061: -- Assignee: Chiwan Park CSVReader: quotedStringParsing and includeFields yields ParseException

[jira] [Commented] (FLINK-2061) CSVReader: quotedStringParsing and includeFields yields ParseException

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560962#comment-14560962 ] ASF GitHub Bot commented on FLINK-2061: --- GitHub user chiwanpark opened a pull

[GitHub] flink pull request: [FLINK-1874] [streaming] Connector breakup

2015-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/719#issuecomment-105914769 I'm not so sure about the module names. The parent is called. `flink-streaming-connectors-parent` The modules itself are called: ```diff + modules

[jira] [Created] (FLINK-2100) Add ITCases for all Table API examples

2015-05-27 Thread Timo Walther (JIRA)
Timo Walther created FLINK-2100: --- Summary: Add ITCases for all Table API examples Key: FLINK-2100 URL: https://issues.apache.org/jira/browse/FLINK-2100 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-1874) Break up streaming connectors into submodules

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560975#comment-14560975 ] ASF GitHub Bot commented on FLINK-1874: --- Github user rmetzger commented on the pull

[jira] [Updated] (FLINK-2100) Add ITCases for all Table API examples

2015-05-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-2100: Labels: starter (was: ) Add ITCases for all Table API examples

[jira] [Updated] (FLINK-2100) Add ITCases for all Table API examples

2015-05-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-2100: Issue Type: Test (was: New Feature) Add ITCases for all Table API examples

[jira] [Resolved] (FLINK-1905) Add tests for parallelism 1 for Kafka sources

2015-05-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-1905. --- Resolution: Fixed Resolved with the recently added tests. Add tests for parallelism 1 for

[jira] [Commented] (FLINK-687) Add support for outer-joins

2015-05-27 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561009#comment-14561009 ] Chiwan Park commented on FLINK-687: --- Yes. Splitting this issue into two sub issues is

[jira] [Commented] (FLINK-1962) Add Gelly Scala API

2015-05-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560828#comment-14560828 ] Aljoscha Krettek commented on FLINK-1962: - I'm afraid I don't have a better

[GitHub] flink pull request: [FLINK-1952] [jobmanager] Rework and fix slot ...

2015-05-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/731#discussion_r31128102 --- Diff: flink-tests/src/test/resources/log4j.properties --- @@ -0,0 +1,32 @@

[jira] [Commented] (FLINK-1952) Cannot run ConnectedComponents example: Could not allocate a slot on instance

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560877#comment-14560877 ] ASF GitHub Bot commented on FLINK-1952: --- Github user tillrohrmann commented on a

[jira] [Commented] (FLINK-2003) Building on some encrypted filesystems leads to File name too long error

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560871#comment-14560871 ] ASF GitHub Bot commented on FLINK-2003: --- Github user thvasilo commented on the pull

[jira] [Commented] (FLINK-2003) Building on some encrypted filesystems leads to File name too long error

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560872#comment-14560872 ] ASF GitHub Bot commented on FLINK-2003: --- Github user thvasilo closed the pull

[GitHub] flink pull request: [FLINK-2003] Building on some encrypted filesy...

2015-05-27 Thread thvasilo
Github user thvasilo closed the pull request at: https://github.com/apache/flink/pull/690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2003] Building on some encrypted filesy...

2015-05-27 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/690#issuecomment-105890348 OK, I'll close this PR and open up another one with the doc fixes. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-687) Add support for outer-joins

2015-05-27 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560892#comment-14560892 ] Fabian Hueske commented on FLINK-687: - Hi [~chiwanpark], this would be a great addition

[GitHub] flink pull request: [FLINK-1319][core] Add static code analysis fo...

2015-05-27 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/729#issuecomment-105897738 The bytecode generated from Scala Compiler is the same. That is not a problem for the analyzer. But Scala is not fully supported yet, because of the different Java/Scala

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31130185 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java --- @@ -40,9 +44,18 @@ private

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31136509 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -264,21 +266,21 @@ public void

[jira] [Commented] (FLINK-1952) Cannot run ConnectedComponents example: Could not allocate a slot on instance

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560860#comment-14560860 ] ASF GitHub Bot commented on FLINK-1952: --- Github user tillrohrmann commented on a

[GitHub] flink pull request: [FLINK-1952] [jobmanager] Rework and fix slot ...

2015-05-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/731#discussion_r31127537 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SharedSlotsTest.java --- @@ -0,0 +1,665 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2098) Checkpoint barrier initiation at source is not aligned with snapshotting

2015-05-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560901#comment-14560901 ] Aljoscha Krettek commented on FLINK-2098: - Is this the reason for the

[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-05-27 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/735#issuecomment-105913011 I will create an issue and assign it to me. I think I will heavily work on the Table API anyway the next time ;) --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31136136 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java --- @@ -119,10 +153,50 @@ public void shutdown()

[jira] [Assigned] (FLINK-2072) Add a quickstart guide for FlinkML

2015-05-27 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis reassigned FLINK-2072: -- Assignee: Theodore Vasiloudis Add a quickstart guide for FlinkML

[jira] [Closed] (FLINK-2073) Add contribution guide for FlinkML

2015-05-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-2073. Resolution: Fixed Added with c77947e94767565cc4f947a4ba86a960258a052a Add contribution guide for

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31130488 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java --- @@ -40,9 +44,18 @@ private

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31131135 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -334,6 +335,14 @@ extends Actor with ActorLogMessages with

[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/735#issuecomment-105910200 I thought we have ITCases for our examples to ensure that they are working? Maybe we should add those to these examples as well --- If your project is set up for

[jira] [Commented] (FLINK-2072) Add a quickstart guide for FlinkML

2015-05-27 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561024#comment-14561024 ] Theodore Vasiloudis commented on FLINK-2072: So for this I was thinking a

[jira] [Created] (FLINK-2098) Checkpoint barrier initiation at source is not aligned with snapshotting

2015-05-27 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-2098: --- Summary: Checkpoint barrier initiation at source is not aligned with snapshotting Key: FLINK-2098 URL: https://issues.apache.org/jira/browse/FLINK-2098 Project: Flink

[jira] [Created] (FLINK-2099) Add a SQL API

2015-05-27 Thread Timo Walther (JIRA)
Timo Walther created FLINK-2099: --- Summary: Add a SQL API Key: FLINK-2099 URL: https://issues.apache.org/jira/browse/FLINK-2099 Project: Flink Issue Type: New Feature Components:

[jira] [Commented] (FLINK-1952) Cannot run ConnectedComponents example: Could not allocate a slot on instance

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560879#comment-14560879 ] ASF GitHub Bot commented on FLINK-1952: --- Github user tillrohrmann commented on the

[GitHub] flink pull request: [FLINK-1952] [jobmanager] Rework and fix slot ...

2015-05-27 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/731#issuecomment-105890755 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31131305 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java --- @@ -137,9 +211,46 @@ void

[jira] [Commented] (FLINK-2047) Rename CoCoA to SVM

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560988#comment-14560988 ] ASF GitHub Bot commented on FLINK-2047: --- Github user tillrohrmann commented on the

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31134168 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java --- @@ -119,10 +153,50 @@ public void shutdown()

[jira] [Commented] (FLINK-2073) Add contribution guide for FlinkML

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560980#comment-14560980 ] ASF GitHub Bot commented on FLINK-2073: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-2094) Implement Word2Vec

2015-05-27 Thread Johannes (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561006#comment-14561006 ] Johannes commented on FLINK-2094: - Some information below, as I looked into this algorithm

[GitHub] flink pull request: [FLINK-2061] CSVReader: quotedStringParsing an...

2015-05-27 Thread chiwanpark
GitHub user chiwanpark opened a pull request: https://github.com/apache/flink/pull/734 [FLINK-2061] CSVReader: quotedStringParsing and includeFields yields ParseException Fix the bug in `GenericCsvInputFormat` when skipped field is quoted string. I also added a unit test for this

[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/735#issuecomment-105910800 Sorry for the rude comment. Thank you for fixing the issue. Very good catch ;) Maybe we should file a JIRA for adding ITCases for these examples ;) --- If your

[GitHub] flink pull request: [FLINK-2047] [ml] Rename CoCoA to SVM

2015-05-27 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/733#issuecomment-105918301 LGTM. Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2004] Fix memory leak in presence of fa...

2015-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/674#issuecomment-105926083 Sorry for not reacting. I was busy with other stuff but I'll now address your comments. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-2073) Add contribution guide for FlinkML

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560885#comment-14560885 ] ASF GitHub Bot commented on FLINK-2073: --- Github user tillrohrmann commented on the

[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-05-27 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/735 [hotfix] Remove execute() after print() in Table API examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/twalthr/flink tableApiExampleFix

[jira] [Commented] (FLINK-1422) Missing usage example for withParameters

2015-05-27 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561181#comment-14561181 ] Theodore Vasiloudis commented on FLINK-1422: Run into this by chance,

[GitHub] flink pull request: implement a simple session management

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-105982832 Looks very nice now. Few comments: - I suggest to keep the JobID in the JobGraph final and force it to be passed via the constructor. The JobGraphGenerator

[jira] [Created] (FLINK-2102) Add predict operation for LabeledVector

2015-05-27 Thread Theodore Vasiloudis (JIRA)
Theodore Vasiloudis created FLINK-2102: -- Summary: Add predict operation for LabeledVector Key: FLINK-2102 URL: https://issues.apache.org/jira/browse/FLINK-2102 Project: Flink Issue

[GitHub] flink pull request: implement a simple session management

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-105983100 After a chat with @mxm , we decided it would be good to merge this sooner and fix point 2 (keeping the actor system alive) in a separate patch. I'll try and address

[jira] [Commented] (FLINK-2101) Scheme Inference doesn't work for Tuple5

2015-05-27 Thread Rico Bergmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561147#comment-14561147 ] Rico Bergmann commented on FLINK-2101: -- Oops. You are right. Sorry for the

[jira] [Created] (FLINK-2101) Scheme Inference doesn't work for Tuple5

2015-05-27 Thread Rico Bergmann (JIRA)
Rico Bergmann created FLINK-2101: Summary: Scheme Inference doesn't work for Tuple5 Key: FLINK-2101 URL: https://issues.apache.org/jira/browse/FLINK-2101 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-2101) Scheme Inference doesn't work for Tuple5

2015-05-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561063#comment-14561063 ] Robert Metzger commented on FLINK-2101: --- Thank you for reporting the issue. I'll

[jira] [Commented] (FLINK-2101) Scheme Inference doesn't work for Tuple5

2015-05-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561068#comment-14561068 ] Stephan Ewen commented on FLINK-2101: - Type inference cannot work on generic,

[jira] [Commented] (FLINK-2081) Change order of restore state and open for Streaming Operators

2015-05-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561084#comment-14561084 ] Robert Metzger commented on FLINK-2081: --- Can we come to an agreement here? I think

[jira] [Commented] (FLINK-2101) Scheme Inference doesn't work for Tuple5

2015-05-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561072#comment-14561072 ] Robert Metzger commented on FLINK-2101: --- The {{KafkaITCase}} is the only code which

[GitHub] flink pull request: [FLINK-1952] [jobmanager] Rework and fix slot ...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/731 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-1952) Cannot run ConnectedComponents example: Could not allocate a slot on instance

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561106#comment-14561106 ] ASF GitHub Bot commented on FLINK-1952: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-1952] [jobmanager] Rework and fix slot ...

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/731#issuecomment-105945508 Thanks! I'll address the comments, remove the accidentally added `log4j.properties` file and merge this. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2004] Fix memory leak in presence of fa...

2015-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/674#issuecomment-105951860 I have those unit test style tests all in the KafkaITCase because they depend on the testing clusters started for the test. They all need at least a running

[jira] [Commented] (FLINK-2004) Memory leak in presence of failed checkpoints in KafkaSource

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561122#comment-14561122 ] ASF GitHub Bot commented on FLINK-2004: --- Github user rmetzger commented on the pull

[jira] [Commented] (FLINK-1874) Break up streaming connectors into submodules

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561038#comment-14561038 ] ASF GitHub Bot commented on FLINK-1874: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31137592 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java --- @@ -137,9 +211,46 @@ void

[GitHub] flink pull request: [FLINK-1874] [streaming] Connector breakup

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/719#issuecomment-105926196 Should we so clearly differentiate between the streaming and the batch connector projects? Why not have a `flink-connector-kafka` that contains both a batch

[jira] [Commented] (FLINK-2004) Memory leak in presence of failed checkpoints in KafkaSource

2015-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561037#comment-14561037 ] ASF GitHub Bot commented on FLINK-2004: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [scheduling] implement backtracking of interme...

2015-05-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/640#discussion_r31138771 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java --- @@ -71,6 +71,11 @@ protected void

[jira] [Closed] (FLINK-1952) Cannot run ConnectedComponents example: Could not allocate a slot on instance

2015-05-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-1952. --- Cannot run ConnectedComponents example: Could not allocate a slot on instance

  1   2   >