[
https://issues.apache.org/jira/browse/FLINK-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975849#comment-14975849
]
ASF GitHub Bot commented on FLINK-2918:
---
Github user smarthi commented on the pull r
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1299#issuecomment-151398008
@tillrohrmann There's an existing DataSet#write() api, don't think we need
a DataSet#writeAsSequenceFile().
---
If your project is set up for it, you can reply to this
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151402904
@mxm I have made some changes and now the *current* plan resides in the
`ContextEnvironment`. This required some changes in `StreamContextEnvironment`,
which now
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975886#comment-14975886
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user sachingoel0101 commented on the
[
https://issues.apache.org/jira/browse/FLINK-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-2883:
-
Issue Type: Task (was: Bug)
> Combinable reduce produces wrong result
> -
[
https://issues.apache.org/jira/browse/FLINK-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-2883:
-
Summary: Add documentation to forbid key-modifying ReduceFunction (was:
Combinable reduce produce
[
https://issues.apache.org/jira/browse/FLINK-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975997#comment-14975997
]
ASF GitHub Bot commented on FLINK-2920:
---
Github user fhueske commented on the pull r
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1302#issuecomment-151412816
Looks good to merge. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
[
https://issues.apache.org/jira/browse/FLINK-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-2922:
-
Labels: requires-design-doc (was: )
> Add Queryable Window Operator
> ---
[
https://issues.apache.org/jira/browse/FLINK-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-2476.
---
Resolution: Fixed
> Remove unwanted check null of input1 in ConnectedDataStream
>
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976071#comment-14976071
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098099
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public JobExecution
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098098
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public JobExecution
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976070#comment-14976070
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098268
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -909,7 +919,21 @@ private int handleError(Throwable t) {
}
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098234
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -271,18 +272,21 @@ public JobSubmissionResult
runDetached(PackagedProgra
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976078#comment-14976078
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976077#comment-14976077
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user mxm commented on a diff in the
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098367
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public J
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976079#comment-14976079
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user sachingoel0101 commented on a d
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098424
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -271,18 +272,21 @@ public JobSubmissionResult
runDetached(Pac
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976080#comment-14976080
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user sachingoel0101 commented on a d
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098720
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -909,7 +919,21 @@ private int handleError(Throwable t) {
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976084#comment-14976084
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user sachingoel0101 commented on a d
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151430438
Thanks. Looks much better. Let's make sure we don't break any classloader
or jar dependencies during job submission. This can cause annoyances for users
and we have to fix i
[
https://issues.apache.org/jira/browse/FLINK-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976089#comment-14976089
]
Vasia Kalavri commented on FLINK-2909:
--
Thank you [~greghogan]. Then, could you edit
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976087#comment-14976087
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user mxm commented on the pull reque
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151435402
Agreed. I'll build and test with the example programs in standalone mode
and on yarn. It should work perfectly though since `YarnSessionFIFOITCase`
checks both ba
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976104#comment-14976104
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user sachingoel0101 commented on the
[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976116#comment-14976116
]
ASF GitHub Bot commented on FLINK-2017:
---
Github user mliesenberg commented on a diff
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r43100940
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache So
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-151439931
I do see your point about the uselessness of only `check`, so I'll go ahead
and implement `applyTo`.
I'll update the PR tonight.
---
If your project is se
[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976122#comment-14976122
]
ASF GitHub Bot commented on FLINK-2017:
---
Github user mliesenberg commented on the pu
[
https://issues.apache.org/jira/browse/FLINK-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976126#comment-14976126
]
Fabian Hueske commented on FLINK-2907:
--
Hi Greg,
this is a really interesting idea.
[
https://issues.apache.org/jira/browse/FLINK-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-2907:
-
Labels: requires-design-doc (was: )
> Bloom filter for Join
> -
>
>
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r43101847
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Softwa
[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976130#comment-14976130
]
ASF GitHub Bot commented on FLINK-2017:
---
Github user fhueske commented on a diff in
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-151441146
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976131#comment-14976131
]
ASF GitHub Bot commented on FLINK-2017:
---
Github user fhueske commented on the pull r
[
https://issues.apache.org/jira/browse/FLINK-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-2922:
Attachment: FLINK-2922.pdf
Design Doc
> Add Queryable Window Operator
> ---
[
https://issues.apache.org/jira/browse/FLINK-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976143#comment-14976143
]
Aljoscha Krettek edited comment on FLINK-2922 at 10/27/15 10:13 AM:
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1299#issuecomment-151442975
Hi @smarthi,
I am not super familiar with Hadoop interface, but is the `hadoop2` switch
really necessary? Hadoop2 does also support the `mapred.*` interfaces, right?
[
https://issues.apache.org/jira/browse/FLINK-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976149#comment-14976149
]
ASF GitHub Bot commented on FLINK-2918:
---
Github user fhueske commented on the pull r
[
https://issues.apache.org/jira/browse/FLINK-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976217#comment-14976217
]
Chesnay Schepler commented on FLINK-2662:
-
I tried reproducing the error but the s
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151458018
@mxm , I have tested the build with the following commands:
1. Standalone cluster: `bin/flink run -d` for both streaming and batch
wordcount examples.
2. Y
[
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976226#comment-14976226
]
ASF GitHub Bot commented on FLINK-2797:
---
Github user sachingoel0101 commented on the
Andra Lungu created FLINK-2926:
--
Summary: Add a Strongly Connected Components Library Method
Key: FLINK-2926
URL: https://issues.apache.org/jira/browse/FLINK-2926
Project: Flink
Issue Type: Task
[
https://issues.apache.org/jira/browse/FLINK-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976461#comment-14976461
]
Martin Junghanns commented on FLINK-2905:
-
Hi, I agree with you that Option 3 is t
[
https://issues.apache.org/jira/browse/FLINK-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976488#comment-14976488
]
Vasia Kalavri commented on FLINK-2905:
--
I see what you mean, but I'm a bit confused b
[
https://issues.apache.org/jira/browse/FLINK-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976525#comment-14976525
]
Martin Junghanns commented on FLINK-2905:
-
Sorry for the confusion. In the example
[
https://issues.apache.org/jira/browse/FLINK-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976525#comment-14976525
]
Martin Junghanns edited comment on FLINK-2905 at 10/27/15 3:05 PM:
-
[
https://issues.apache.org/jira/browse/FLINK-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976558#comment-14976558
]
Vasia Kalavri commented on FLINK-2905:
--
This is still not clear to me.
Correct me if
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1301#issuecomment-151559475
@mxm, Can you look at this for the next RC?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Ufuk Celebi created FLINK-2927:
--
Summary: Provide default required configuration keys in flink-conf
of binary distribution
Key: FLINK-2927
URL: https://issues.apache.org/jira/browse/FLINK-2927
Project: F
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1303
[FLINK-2927] [runtime] Provide default required configuration keys in
flink-conf of binary distribution
@mxm, can you include this in the next RC?
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/FLINK-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976693#comment-14976693
]
ASF GitHub Bot commented on FLINK-2927:
---
GitHub user uce opened a pull request:
Ufuk Celebi created FLINK-2928:
--
Summary: Confusing job status visualisation in web frontend
Key: FLINK-2928
URL: https://issues.apache.org/jira/browse/FLINK-2928
Project: Flink
Issue Type: Impr
Ufuk Celebi created FLINK-2929:
--
Summary: Recovery of jobs on cluster restarts
Key: FLINK-2929
URL: https://issues.apache.org/jira/browse/FLINK-2929
Project: Flink
Issue Type: Improvement
Af
[
https://issues.apache.org/jira/browse/FLINK-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976712#comment-14976712
]
Aljoscha Krettek commented on FLINK-2929:
-
I think we have to fix it, yes. I'm not
Ufuk Celebi created FLINK-2930:
--
Summary: ExecutionConfig execution retry delay not respected
Key: FLINK-2930
URL: https://issues.apache.org/jira/browse/FLINK-2930
Project: Flink
Issue Type: Bug
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43151247
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/util/SplitStreamType.java
---
@@ -20,10 +20,11 @@
import org.apache.flink.strea
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976722#comment-14976722
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976724#comment-14976724
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43151435
--- Diff:
flink-contrib/flink-tweet-inputformat/src/main/java/org/apache/flink/contrib/tweetinputformat/model/tweet/entities/Entities.java
---
@@ -21,8 +21,8
[
https://issues.apache.org/jira/browse/FLINK-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976739#comment-14976739
]
Martin Junghanns commented on FLINK-2905:
-
I totally agree with your definition of
Gyula Fora created FLINK-2931:
-
Summary: Add global recovery timestamp to state restore
Key: FLINK-2931
URL: https://issues.apache.org/jira/browse/FLINK-2931
Project: Flink
Issue Type: Improvemen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43153252
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -314,7 +314,7 @@ public void remove() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43153270
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -327,7 +327,7 @@ void setInDegree(long inDeg
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976751#comment-14976751
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976753#comment-14976753
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976758#comment-14976758
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43153428
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java
---
@@ -206,7 +206,7 @@ void setOutput(Vertex ou
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43153436
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java
---
@@ -219,7 +219,7 @@ void setInDegree(long in
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976757#comment-14976757
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user fhueske commented on a diff in
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1304
[FLINK-2930] Respect ExecutionConfig execution retry delay
This only affects job recovery on non-master failures.
You can merge this pull request into a Git repository by running:
$ git pull https:
[
https://issues.apache.org/jira/browse/FLINK-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976769#comment-14976769
]
ASF GitHub Bot commented on FLINK-2930:
---
GitHub user uce opened a pull request:
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1303#issuecomment-151575894
+1 will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
[
https://issues.apache.org/jira/browse/FLINK-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976775#comment-14976775
]
ASF GitHub Bot commented on FLINK-2927:
---
Github user mxm commented on the pull reque
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976779#comment-14976779
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user fhueske commented on the pull r
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151576323
Hi @hczerpak, thanks a lot for the thorough cleaning of the JavaDocs!
I spotted just a few things that should be improved.
The commit history of your PR is also a
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1301#issuecomment-151577309
+1 looks good. will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976795#comment-14976795
]
ASF GitHub Bot commented on FLINK-2927:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/1305
Out-of-core state backend for JDBC databases
Detailed description incoming...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gyfora/flink master
Github user hczerpak commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43156806
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/util/SplitStreamType.java
---
@@ -20,10 +20,11 @@
import org.apache.flink.stre
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r43156865
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1223,6 +1230,51 @@ public long count() throws Exception {
fi
[
https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976806#comment-14976806
]
ASF GitHub Bot commented on FLINK-7:
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976805#comment-14976805
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user hczerpak commented on a diff in
Github user hczerpak commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43157321
--- Diff:
flink-contrib/flink-tweet-inputformat/src/main/java/org/apache/flink/contrib/tweetinputformat/model/tweet/entities/Entities.java
---
@@ -21,8 +21,
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976812#comment-14976812
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user hczerpak commented on a diff in
Github user hczerpak commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43157767
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -314,7 +314,7 @@ public void remove() {
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976817#comment-14976817
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user hczerpak commented on a diff in
GitHub user hczerpak reopened a pull request:
https://github.com/apache/flink/pull/1298
[FLINK-2559] Fix Javadoc Code Examples
Initially I've made only handful of fixes to javadocs, replacing few @ with
{@literal @}. Running mvn javadoc:javadoc revealed lots of javadoc problems:
Github user hczerpak commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151583330
Sure. I appreciate your comments. It was not always straightforward what to
do with errors. Could you please take a look at my comments above and say what
you think?
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976824#comment-14976824
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user hczerpak closed the pull reques
Github user hczerpak closed the pull request at:
https://github.com/apache/flink/pull/1298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976822#comment-14976822
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user hczerpak commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976823#comment-14976823
]
ASF GitHub Bot commented on FLINK-2559:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43158080
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -314,7 +314,7 @@ public void remove() {
1 - 100 of 125 matches
Mail list logo