[
https://issues.apache.org/jira/browse/FLINK-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026470#comment-15026470
]
Maximilian Michels commented on FLINK-3057:
---
Great. Thanks!
> [py] Provide a wa
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1404
[github] change tab size to 4 spaces
The default tab size on GitHub is 8 spaces. This change decreases the
tab size to 4. I think this will make reviewing of code on GitHub easier.
Left: tab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1404#issuecomment-159564917
Yes, please!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1404#issuecomment-159564852
This is very nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1402#issuecomment-159565360
I like this. Wonder if we can call the `createLeft(L value)` method just
`Left(L value)` (with a capital L to disambiguate against the accessor method
`left()`.
--
[
https://issues.apache.org/jira/browse/FLINK-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026573#comment-15026573
]
ASF GitHub Bot commented on FLINK-3075:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1399#issuecomment-159565479
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1402#issuecomment-159565868
I actually prefer Either.Left(left) as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1400#issuecomment-159566115
Can we change the signal handler such that it prints on "TERM" and "KILL" a
message that explicitly says that the process was killed from the outside? This
should sa
[
https://issues.apache.org/jira/browse/FLINK-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026574#comment-15026574
]
ASF GitHub Bot commented on FLINK-3067:
---
Github user StephanEwen commented on the pu
[
https://issues.apache.org/jira/browse/FLINK-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026578#comment-15026578
]
ASF GitHub Bot commented on FLINK-3075:
---
Github user gyfora commented on the pull re
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1402#issuecomment-159566437
I still think there's no reason for `Left` and `Right` to be public
classes, especially if you keep the static creation methods. But, if this is
just me, go ahead :)
---
[
https://issues.apache.org/jira/browse/FLINK-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026583#comment-15026583
]
ASF GitHub Bot commented on FLINK-3075:
---
Github user vasia commented on the pull req
[
https://issues.apache.org/jira/browse/FLINK-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-3059:
Assignee: jun aoki
> Javadoc fix for DataSet.writeAsText()
> ---
[
https://issues.apache.org/jira/browse/FLINK-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026589#comment-15026589
]
Chesnay Schepler commented on FLINK-788:
i tried propagating the withBroadcastSet()
[
https://issues.apache.org/jira/browse/FLINK-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026607#comment-15026607
]
Chesnay Schepler commented on FLINK-2186:
-
Could we allow users to pass a String t
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1402#issuecomment-159571467
I don't have strong feelings about having it either way (public/non-public
Left Right classes) now that the static names dont clash. What do you think
@StephanEwen ?
-
[
https://issues.apache.org/jira/browse/FLINK-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026610#comment-15026610
]
ASF GitHub Bot commented on FLINK-3075:
---
Github user gyfora commented on the pull re
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026612#comment-15026612
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45854121
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized TopologyCon
Robert Metzger created FLINK-3077:
-
Summary: Add "version" command to CliFrontend for showing the
version of the installation
Key: FLINK-3077
URL: https://issues.apache.org/jira/browse/FLINK-3077
Proj
GitHub user fversaci opened a pull request:
https://github.com/apache/flink/pull/1405
typo in DelimitedInputFormat
in both DelimitedInputFormat.java and DelimitedInputFormatSamplingTest.java
it's written loadGloablConfigParams insted of loadGlobalConfigParams, is it
safe to correct
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1401#issuecomment-159586011
Looks good, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
[
https://issues.apache.org/jira/browse/FLINK-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026665#comment-15026665
]
ASF GitHub Bot commented on FLINK-3072:
---
Github user StephanEwen commented on the pu
[
https://issues.apache.org/jira/browse/FLINK-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026668#comment-15026668
]
ASF GitHub Bot commented on FLINK-3072:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1401
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gyula Fora resolved FLINK-3072.
---
Resolution: Fixed
> DbStateBackendTest
> --
>
> Key: FLINK-3072
>
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1405#issuecomment-159588623
Good catch, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1403#issuecomment-159588695
Nice! Waiting for this for over a year now ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
[
https://issues.apache.org/jira/browse/FLINK-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026671#comment-15026671
]
Fabian Hueske commented on FLINK-3072:
--
Thanks for the quick fix [~gyfora]!
> DbStat
[
https://issues.apache.org/jira/browse/FLINK-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026672#comment-15026672
]
ASF GitHub Bot commented on FLINK-2906:
---
Github user StephanEwen commented on the pu
[
https://issues.apache.org/jira/browse/FLINK-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026700#comment-15026700
]
Gyula Fora commented on FLINK-3072:
---
No problem :)
> DbStateBackendTest
> -
[
https://issues.apache.org/jira/browse/FLINK-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026735#comment-15026735
]
Johann Kovacs commented on FLINK-2988:
--
>From my point of view this problem still per
Robert Metzger created FLINK-3078:
-
Summary: JobManager does not shutdown when checkpointed jobs are
running
Key: FLINK-3078
URL: https://issues.apache.org/jira/browse/FLINK-3078
Project: Flink
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1354#issuecomment-159609971
Thanks for the ping. I'll now test it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
[
https://issues.apache.org/jira/browse/FLINK-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026766#comment-15026766
]
ASF GitHub Bot commented on FLINK-3000:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1354#issuecomment-159613519
Tests passed
+1 to merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
[
https://issues.apache.org/jira/browse/FLINK-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026799#comment-15026799
]
ASF GitHub Bot commented on FLINK-3000:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-3078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi reassigned FLINK-3078:
--
Assignee: Ufuk Celebi
> JobManager does not shutdown when checkpointed jobs are running
> -
Robert Metzger created FLINK-3079:
-
Summary: Add utility for measuring the raw read throughput from a
Kafka topic
Key: FLINK-3079
URL: https://issues.apache.org/jira/browse/FLINK-3079
Project: Flink
Vasia Kalavri created FLINK-3080:
Summary: Cannot union a data stream with a product of itself
Key: FLINK-3080
URL: https://issues.apache.org/jira/browse/FLINK-3080
Project: Flink
Issue Type:
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1404#issuecomment-159637645
Yes
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1404#issuecomment-159637898
+1
I wonder why the rat plugin accepts the file without apache license header.
Are we ignoring dot files?
---
If your project is set up for it, you can reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1400#issuecomment-159638066
Great idea. Will do & merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
[
https://issues.apache.org/jira/browse/FLINK-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026921#comment-15026921
]
Gyula Fora commented on FLINK-3079:
---
Have you checked this project?
https://github.com/
[
https://issues.apache.org/jira/browse/FLINK-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026928#comment-15026928
]
ASF GitHub Bot commented on FLINK-3000:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1354#issuecomment-159641191
I'll merge this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
[
https://issues.apache.org/jira/browse/FLINK-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026934#comment-15026934
]
Robert Metzger commented on FLINK-3079:
---
Cool. I didn't know this one.
Kafka itself
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026931#comment-15026931
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mxm commented on the pull reque
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-159641971
I've rebased to the latest master and addressed your comments. I would like
to merge this and programmatically fix the multiple inputs issue afterwards.
---
If your project
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026943#comment-15026943
]
ASF GitHub Bot commented on FLINK-3000:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-3000.
---
Resolution: Fixed
Fix Version/s: (was: 0.10.1)
1.0.0
Resolved fo
[
https://issues.apache.org/jira/browse/FLINK-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026946#comment-15026946
]
ASF GitHub Bot commented on FLINK-3067:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1399#issuecomment-159644979
merging to release-0.10 and master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026949#comment-15026949
]
ASF GitHub Bot commented on FLINK-3067:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-3067.
---
Resolution: Fixed
Fix Version/s: 1.0.0
0.10.2
Merged fix for 0.10.2
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-159646696
That last fail looked like it happened in Kafka from something I never
touched? E.g. random. Is there anyway to just retry the travis-ci build?
---
If your project
[
https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026956#comment-15026956
]
ASF GitHub Bot commented on FLINK-1994:
---
Github user rawkintrevo commented on the pu
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-159648629
The Kafka tests are not written in a bullet proof way. It may happen that
the Kafka test-cluster has a hickup, in which case the tests cannot succeed...
You
[
https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026966#comment-15026966
]
ASF GitHub Bot commented on FLINK-1994:
---
Github user StephanEwen commented on the pu
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1406
[FLINK-3054] Remove R (return) type variable from SerializationSchema
- I removed the `JavaDefaultStringSchema`, `DummyStringSchema`,
`StringToByteSerializer` and used the `SimpleStringSchema` ever
[
https://issues.apache.org/jira/browse/FLINK-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026969#comment-15026969
]
ASF GitHub Bot commented on FLINK-3054:
---
GitHub user rmetzger opened a pull request:
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1404#issuecomment-159652327
@rmetzger I was also wondering why and turns out we do ignore dot files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1321#issuecomment-159655565
Hi @mxm, is there any further improvement needed on this? If not, I think
it should be merged.
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/FLINK-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026996#comment-15026996
]
ASF GitHub Bot commented on FLINK-2904:
---
Github user sachingoel0101 commented on the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1386#issuecomment-159656251
Hi @rmetzger, can you take another look? I need to base some further work
on this [related to cleaning up passing of task name, index, etc.].
---
If your project
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027003#comment-15027003
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user sachingoel0101 commented on the
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027013#comment-15027013
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885626
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/VerifyAndEnrichBolt.java
---
@@ -17,8 +17,6 @@
*/
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885529
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed t
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885615
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/RandomSpout.java
---
@@ -17,9 +17,6 @@
*/
package
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027014#comment-15027014
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027015#comment-15027015
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886387
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/WordCountLocal.java
---
@@ -57,16 +57,13 @@ public static void main
[
https://issues.apache.org/jira/browse/FLINK-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027028#comment-15027028
]
ASF GitHub Bot commented on FLINK-3054:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1406#issuecomment-159661154
Big +1 from my side.
It is API breaking, though, so we should add this to the list of API
changes for 1.0
---
If your project is set up for it, you can rep
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027027#comment-15027027
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027029#comment-15027029
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027033#comment-15027033
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886536
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/SpoutSourceWordCount.java
---
@@ -19,7 +19,6 @@
import b
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886615
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/operators/WordCountFileSpout.java
---
@@ -17,10 +17,9 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886597
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/operators/WordCountDataPojos.java
---
@@ -17,10 +17,10 @@
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027031#comment-15027031
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027040#comment-15027040
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886799
--- Diff:
flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBolt.java
---
@@ -17,8 +17,6 @@
*/
package org.apache.f
[
https://issues.apache.org/jira/browse/FLINK-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027039#comment-15027039
]
Stephan Ewen commented on FLINK-2186:
-
Enforcing to give the types properly makes this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1386#issuecomment-159662427
Hey @sachingoel0101, I think @StephanEwen is the best contact person here.
Since this affects a very important interface we shouldn't make any mistakes ;)
---
If your
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027047#comment-15027047
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027054#comment-15027054
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45887487
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -99,6 +111,7 @@ public void rebalance(final String n
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45887969
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarer.java
---
@@ -20,11 +20,9 @@
import backtype.storm.t
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027061#comment-15027061
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45888777
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the specif
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027078#comment-15027078
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r4594
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the specif
[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027081#comment-15027081
]
ASF GitHub Bot commented on FLINK-2837:
---
Github user mjsax commented on a diff in th
1 - 100 of 214 matches
Mail list logo
