[GitHub] flink pull request: [FLINK-3084] FsStateBackend backs up very smal...

2015-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-3084) File State Backend should not write very small state into files

2015-12-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3084. - Resolution: Fixed Fixed via d1ea365ef1fa979d40532bf3f114fc03284164bc > File State Backend should

[jira] [Closed] (FLINK-3084) File State Backend should not write very small state into files

2015-12-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3084. --- > File State Backend should not write very small state into files > --

[jira] [Commented] (FLINK-3084) File State Backend should not write very small state into files

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033350#comment-15033350 ] ASF GitHub Bot commented on FLINK-3084: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2015-12-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1421#issuecomment-160908584 I think solving a layout problem by removing another important UI element is not the way to go. Does it nor work to let the elements that do not fit in the o

[jira] [Commented] (FLINK-2928) Confusing job status visualisation in web frontend

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033415#comment-15033415 ] ASF GitHub Bot commented on FLINK-2928: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-3077][cli] Add version option to Cli.

2015-12-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1418#issuecomment-160908883 I think this code here should print the commit ID only when it is non null... --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-3077) Add "version" command to CliFrontend for showing the version of the installation

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033423#comment-15033423 ] ASF GitHub Bot commented on FLINK-3077: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46259453 --- Diff: docs/apis/cli.md --- @@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs. -s,--scheduledShow only sched

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033449#comment-15033449 ] ASF GitHub Bot commented on FLINK-2111: --- Github user rmetzger commented on a diff in

[jira] [Assigned] (FLINK-3080) Cannot union a data stream with a product of itself

2015-12-01 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-3080: --- Assignee: Aljoscha Krettek > Cannot union a data stream with a product of itself > --

[GitHub] flink pull request: Out-of-core state backend for JDBC databases

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1305#discussion_r46264109 --- Diff: flink-contrib/flink-streaming-contrib/src/main/java/org/apache/flink/contrib/streaming/state/DbStateBackend.java --- @@ -0,0 +1,248 @@ +/*

[GitHub] flink pull request: Out-of-core state backend for JDBC databases

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1305#discussion_r46264128 --- Diff: flink-contrib/flink-streaming-contrib/src/main/java/org/apache/flink/contrib/streaming/state/DbStateBackend.java --- @@ -0,0 +1,248 @@ +/*

[GitHub] flink pull request: Out-of-core state backend for JDBC databases

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1305#discussion_r46264229 --- Diff: flink-contrib/flink-streaming-contrib/src/main/java/org/apache/flink/contrib/streaming/state/DbStateBackend.java --- @@ -0,0 +1,248 @@ +/*

[GitHub] flink pull request: [FLINK-3092][Documentation]Fix Scala API quick...

2015-12-01 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1424#issuecomment-160934142 Yes, could you please go ahead, @chiwanpark ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[jira] [Commented] (FLINK-3092) Fix Scala API quick start word count example

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033511#comment-15033511 ] ASF GitHub Bot commented on FLINK-3092: --- Github user aljoscha commented on the pull

[jira] [Commented] (FLINK-3073) Activate streaming mode by default

2015-12-01 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033528#comment-15033528 ] Aljoscha Krettek commented on FLINK-3073: - Should we keep the distinction between

[jira] [Created] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-3093: - Summary: Introduce annotations for interface stability Key: FLINK-3093 URL: https://issues.apache.org/jira/browse/FLINK-3093 Project: Flink Issue Type: New

[GitHub] flink pull request: [FLINK-3092][Documentation]Fix Scala API quick...

2015-12-01 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1424#issuecomment-160944538 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (FLINK-3092) Fix Scala API quick start word count example

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033554#comment-15033554 ] ASF GitHub Bot commented on FLINK-3092: --- Github user chiwanpark commented on the pul

[GitHub] flink pull request: [FLINK-3092][Documentation]Fix Scala API quick...

2015-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3092) Fix Scala API quick start word count example

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033556#comment-15033556 ] ASF GitHub Bot commented on FLINK-3092: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-3092) Fix Scala API quick start word count example

2015-12-01 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiwan Park closed FLINK-3092. -- Resolution: Fixed > Fix Scala API quick start word count example > -

[jira] [Commented] (FLINK-3092) Fix Scala API quick start word count example

2015-12-01 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033558#comment-15033558 ] Chiwan Park commented on FLINK-3092: Fixed via 5a3d0728f007e7c69ced1104ef754bb6f17047f

[GitHub] flink pull request: [FLINK-3087] [Table-API] support multi count i...

2015-12-01 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/1414#issuecomment-160949963 Looks good. No objecttions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-3087) Table API do not support multi count in aggregation.

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033587#comment-15033587 ] ASF GitHub Bot commented on FLINK-3087: --- Github user twalthr commented on the pull r

[GitHub] flink pull request: [FLINK-3087] [Table-API] support multi count i...

2015-12-01 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1414#issuecomment-160956025 Ah, I see you changed it to my (wrong) suggestion. @ChengXiangLi Do you want to change it back to your initial version (plus maybe the fix for the naming and cleanExpr)

[jira] [Commented] (FLINK-3087) Table API do not support multi count in aggregation.

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033620#comment-15033620 ] ASF GitHub Bot commented on FLINK-3087: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

2015-12-01 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1425 [FLINK-3080] Relax restrictions of DataStream.union() Before, it would not allow unioning with predecessors (also transitive) and streams of differing parallelism. You can merge this pull reque

[jira] [Commented] (FLINK-3080) Cannot union a data stream with a product of itself

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033634#comment-15033634 ] ASF GitHub Bot commented on FLINK-3080: --- GitHub user aljoscha opened a pull request:

[jira] [Commented] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033648#comment-15033648 ] ASF GitHub Bot commented on FLINK-3093: --- GitHub user rmetzger opened a pull request:

[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...

2015-12-01 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1426 [FLINK-3093] Introduce annotations for interface stability With this pull request, I'm introducing annotations for marking the stability of certain Flink interfaces. The annotations are in

[jira] [Commented] (FLINK-2839) Failing test: OperatorStatsAccumulatorTest.testAccumulatorAllStatistics

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033650#comment-15033650 ] Robert Metzger commented on FLINK-2839: --- I saw a similar failure: https://s3.amazon

[jira] [Comment Edited] (FLINK-2839) Failing test: OperatorStatsAccumulatorTest.testAccumulatorAllStatistics

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033650#comment-15033650 ] Robert Metzger edited comment on FLINK-2839 at 12/1/15 1:07 PM:

[jira] [Commented] (FLINK-2600) Failing ElasticsearchSinkITCase.testNodeClient test case

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033652#comment-15033652 ] Robert Metzger commented on FLINK-2600: --- Another incident: https://s3.amazonaws.com

[jira] [Created] (FLINK-3094) FileStateBackend does not clean up job-id checkpoint directory

2015-12-01 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-3094: Summary: FileStateBackend does not clean up job-id checkpoint directory Key: FLINK-3094 URL: https://issues.apache.org/jira/browse/FLINK-3094 Project: Flink

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46276898 --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java --- @@ -224,7 +224,7 @@ static synchronized TopologyCon

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033669#comment-15033669 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46277213 --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java --- @@ -265,12 +264,12 @@ public void testOpen() throws Ex

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033674#comment-15033674 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46277659 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + * Licens

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033681#comment-15033681 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46277994 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + * Licens

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033685#comment-15033685 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46278142 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java --- @@ -0,0 +1,41 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033686#comment-15033686 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46278355 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,138 @@ +/* + * Licensed

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033690#comment-15033690 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46278994 --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java --- @@ -193,24 +189,22 @@ public void testCreateTop

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033699#comment-15033699 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46279370 --- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/exclamation/ExclamationWithBolt.java --- @@ -72,7 +71,7 @@ public static void m

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033704#comment-15033704 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033703#comment-15033703 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46279382 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,138 @@ +/* + * Licensed

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033721#comment-15033721 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46280916 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void testRequestPartitionS

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033727#comment-15033727 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46281582 --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java --- @@ -265,12 +264,12 @@ public void testOpen() throws

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033735#comment-15033735 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46282419 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033738#comment-15033738 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46282757 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the A

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1398#issuecomment-160982088 I've addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033741#comment-15033741 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033740#comment-15033740 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46283023 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033743#comment-15033743 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46283446 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033749#comment-15033749 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46282619 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46284023 --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java --- @@ -89,13 +99,9 @@ public BoltWrapper(final IRichBolt bo

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033755#comment-15033755 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033759#comment-15033759 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46284474 --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java --- @@ -44,16 +47,32 @@ /** The schema (ie, ordered f

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46284702 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1, JobStatus

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033767#comment-15033767 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46285044 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java --- @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Softwa

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46284171 --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java --- @@ -108,16 +114,13 @@ public BoltWrapper(final IRichBolt

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-12-01 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1398#issuecomment-160985940 If Travis is green please merge. You can fix the last tiny comments directly before merging. No need to update this PR. --- If your project is set up for it, you can repl

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033774#comment-15033774 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on the pull req

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033772#comment-15033772 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46285228 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3", "coffeei

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033776#comment-15033776 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46285468 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -402,21 +405,53 @@ public void onComplete(Throwable f

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033779#comment-15033779 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033785#comment-15033785 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46285844 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + * Licens

[jira] [Commented] (FLINK-2600) Failing ElasticsearchSinkITCase.testNodeClient test case

2015-12-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033783#comment-15033783 ] Stephan Ewen commented on FLINK-2600: - I think we should start making this a manual te

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033787#comment-15033787 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46286009 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3", "coffeeify": "^

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-12-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1243#issuecomment-160988124 Thank for your contribution @HilmiYildirim. I've merged your commit and put some changes on top of it in 9215b72422d3e638fe950b61fa01f2e4e04981a0. --- If your project is se

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033788#comment-15033788 ] ASF GitHub Bot commented on FLINK-2624: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033793#comment-15033793 ] ASF GitHub Bot commented on FLINK-2624: --- Github user mxm commented on the pull reque

[jira] [Updated] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-12-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2624: -- Fix Version/s: 1.0.0 > RabbitMQ source / sink should participate in checkpointing >

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46286476 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java --- @@ -0,0 +1,41 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033797#comment-15033797 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46286695 --- Diff: docs/apis/cli.md --- @@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs. -s,--scheduledShow only schedule

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033799#comment-15033799 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46287141 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1, JobStatusMessage

  1   2   >