[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174438711 Looks good to me! This is a critical fix :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114903#comment-15114903 ] ASF GitHub Bot commented on FLINK-3261: --- Github user gyfora commented on the pull re

[GitHub] flink pull request: [FLINK-3178] Don't Emit In-Flight Windows When...

2016-01-25 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1542#issuecomment-174439774 This seems to be straightforward :) Looks good :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[jira] [Commented] (FLINK-3178) Make Closing Behavior of Window Operators Configurable

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114910#comment-15114910 ] ASF GitHub Bot commented on FLINK-3178: --- Github user gyfora commented on the pull re

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174446152 I tested this as well. A Kafka test was previously failing, now its passing. --- If your project is set up for it, you can reply to this email and have your reply appea

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114936#comment-15114936 ] ASF GitHub Bot commented on FLINK-3261: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1537#discussion_r50669803 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -505,6 +506,88 @@ else if (pendingCheckpoints.size()

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114939#comment-15114939 ] ASF GitHub Bot commented on FLINK-3261: --- Github user uce commented on a diff in the

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114940#comment-15114940 ] ASF GitHub Bot commented on FLINK-3261: --- Github user uce commented on a diff in the

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1537#discussion_r50669903 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -505,6 +506,88 @@ else if (pendingCheckpoints.size()

[jira] [Commented] (FLINK-3279) Optionally disable DistinctOperator combiner

2016-01-25 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114942#comment-15114942 ] Fabian Hueske commented on FLINK-3279: -- With a hash-based reduce combiner (FLINK-2237

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1537#discussion_r50670120 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -854,7 +855,8 @@ private void notifyObservers(ExecutionState newState,

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114945#comment-15114945 ] ASF GitHub Bot commented on FLINK-3261: --- Github user uce commented on a diff in the

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1537#discussion_r50670074 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/checkpoint/DeclineCheckpoint.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Ap

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114946#comment-15114946 ] ASF GitHub Bot commented on FLINK-3261: --- Github user uce commented on a diff in the

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174448455 Ok, I'm addressing the comments about code-style and merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114950#comment-15114950 ] ASF GitHub Bot commented on FLINK-3261: --- Github user aljoscha commented on the pull

[jira] [Commented] (FLINK-3187) Decouple restart strategy from ExecutionGraph

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114954#comment-15114954 ] ASF GitHub Bot commented on FLINK-3187: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3187] Introduce RestartStrategy to deco...

2016-01-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1470#issuecomment-174450252 Whats the status of this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[jira] [Closed] (FLINK-3259) Redirect programming guides to new layout

2016-01-25 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-3259. -- Resolution: Implemented 1a5ce4d > Redirect programming guides to new layout > -

[jira] [Created] (FLINK-3282) Add FlinkRelNode interface.

2016-01-25 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-3282: Summary: Add FlinkRelNode interface. Key: FLINK-3282 URL: https://issues.apache.org/jira/browse/FLINK-3282 Project: Flink Issue Type: New Feature C

[jira] [Assigned] (FLINK-3198) Rename Grouping.getDataSet() method and add JavaDocs

2016-01-25 Thread Kostas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas reassigned FLINK-3198: - Assignee: Kostas > Rename Grouping.getDataSet() method and add JavaDocs > ---

[GitHub] flink pull request: [FLINK-3187] Introduce RestartStrategy to deco...

2016-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1470#issuecomment-174463868 Haven't received a +1 for merging yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-3187) Decouple restart strategy from ExecutionGraph

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115011#comment-15115011 ] ASF GitHub Bot commented on FLINK-3187: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-1904) Add cross() to Table API

2016-01-25 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115013#comment-15115013 ] Aljoscha Krettek commented on FLINK-1904: - [~fhueske] Does this fit into your plan

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[jira] [Resolved] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-3261. - Resolution: Fixed Fixed in https://github.com/apache/flink/commit/893a62f5428b7088aec

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115021#comment-15115021 ] ASF GitHub Bot commented on FLINK-3261: --- Github user aljoscha closed the pull reques

[jira] [Commented] (FLINK-1904) Add cross() to Table API

2016-01-25 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115026#comment-15115026 ] Fabian Hueske commented on FLINK-1904: -- No, we can keep it open. We will need to sup

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115033#comment-15115033 ] ASF GitHub Bot commented on FLINK-3226: --- GitHub user ChengXiangLi opened a pull requ

[GitHub] flink pull request: Add FlinkRelNode interface.

2016-01-25 Thread ChengXiangLi
GitHub user ChengXiangLi opened a pull request: https://github.com/apache/flink/pull/1544 Add FlinkRelNode interface. Add FlinkRelNode interface as it's depended by both FLINK-3226 and FLINK-3227, the implementation would be added in FLINK-3226. You can merge this pull request into

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-01-25 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115034#comment-15115034 ] Chengxiang Li commented on FLINK-3226: -- Yes, that make senes, i have create a PR(htt

[GitHub] flink pull request: [FLINK-3187] Introduce RestartStrategy to deco...

2016-01-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1470#discussion_r50679685 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -237,53 +236,26 @@ public ExecutionConfig setParallelism(int paralleli

[jira] [Commented] (FLINK-3187) Decouple restart strategy from ExecutionGraph

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115040#comment-15115040 ] ASF GitHub Bot commented on FLINK-3187: --- Github user uce commented on a diff in the

[GitHub] flink pull request: [FLINK-3282] Add FlinkRelNode interface.

2016-01-25 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1544#issuecomment-174471324 Thanks for this PR @ChengXiangLi. This PR assumes that the code generation happens during the Calcite translation process, because the interfaces return concrete

[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115042#comment-15115042 ] ASF GitHub Bot commented on FLINK-3282: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3187] Introduce RestartStrategy to deco...

2016-01-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1470#discussion_r50681234 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java --- @@ -0,0 +1,113 @@ +/* + * Licens

[jira] [Commented] (FLINK-3187) Decouple restart strategy from ExecutionGraph

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115052#comment-15115052 ] ASF GitHub Bot commented on FLINK-3187: --- Github user uce commented on a diff in the

[GitHub] flink pull request: [FLINK-3187] Introduce RestartStrategy to deco...

2016-01-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1470#discussion_r50681471 --- Diff: docs/apis/fault_tolerance.md --- @@ -193,73 +193,169 @@ state updates) of Flink coupled with bundled sinks: [Back to top](#top) +Res

[jira] [Commented] (FLINK-3187) Decouple restart strategy from ExecutionGraph

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115054#comment-15115054 ] ASF GitHub Bot commented on FLINK-3187: --- Github user uce commented on a diff in the

[jira] [Assigned] (FLINK-3225) Optimize logical Table API plans in Calcite

2016-01-25 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-3225: Assignee: Fabian Hueske > Optimize logical Table API plans in Calcite > ---

[GitHub] flink pull request: [FLINK-3187] Introduce RestartStrategy to deco...

2016-01-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1470#discussion_r50682036 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java --- @@ -0,0 +1,116 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-3187) Decouple restart strategy from ExecutionGraph

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115056#comment-15115056 ] ASF GitHub Bot commented on FLINK-3187: --- Github user uce commented on a diff in the

[GitHub] flink pull request: [FLINK-3187] Introduce RestartStrategy to deco...

2016-01-25 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1470#issuecomment-174477502 Changes look very good. I've tried it out with the two provided `RestartStrategies` and it works like a charm. ;) (I didn't try to write a custom strategy, but that is OK I

[jira] [Commented] (FLINK-3187) Decouple restart strategy from ExecutionGraph

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115059#comment-15115059 ] ASF GitHub Bot commented on FLINK-3187: --- Github user uce commented on the pull reque

[jira] [Created] (FLINK-3283) Failed Kafka 0.9 test on duplicate message

2016-01-25 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-3283: -- Summary: Failed Kafka 0.9 test on duplicate message Key: FLINK-3283 URL: https://issues.apache.org/jira/browse/FLINK-3283 Project: Flink Issue Type: Test

[jira] [Commented] (FLINK-1666) Clean-up Field Expression Code

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115063#comment-15115063 ] ASF GitHub Bot commented on FLINK-1666: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-1045] Remove Combinable annotation.

2016-01-25 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1522#issuecomment-174478827 Any feedback for this PR? Otherwise, I'll merge it tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] flink pull request: [FLINK-1666] [FLINK-1903] [FLINK-3233] Refacto...

2016-01-25 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1520#issuecomment-174478748 Any feedback for this PR? Otherwise, I'll merge it tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[jira] [Commented] (FLINK-1045) Remove Combinable Annotation

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115065#comment-15115065 ] ASF GitHub Bot commented on FLINK-1045: --- Github user fhueske commented on the pull r

[jira] [Assigned] (FLINK-3281) IndexOutOfBoundsException when range-partitioning empty DataSet

2016-01-25 Thread Fridtjof Sander (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fridtjof Sander reassigned FLINK-3281: -- Assignee: Chengxiang Li Thanks, it's yours. > IndexOutOfBoundsException when range-par

[GitHub] flink pull request: [FLINK-3282] Add FlinkRelNode interface.

2016-01-25 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1544#issuecomment-174479220 Hi, @fhueske , What about `Project` and `Agggregate`? they are translated to `FlinkMap` and `FlinkReduce` which includes `MapFunction` and `GroupReduceFunction`. To

[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115068#comment-15115068 ] ASF GitHub Bot commented on FLINK-3282: --- Github user ChengXiangLi commented on the p

[GitHub] flink pull request: [FLINK-3256] Fix colocation group re-instantia...

2016-01-25 Thread senorcarbone
Github user senorcarbone commented on the pull request: https://github.com/apache/flink/pull/1526#issuecomment-174486113 I guess this fix ok to merge. Any objections? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (FLINK-3256) Invalid execution graph cleanup for jobs with colocation groups

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115097#comment-15115097 ] ASF GitHub Bot commented on FLINK-3256: --- Github user senorcarbone commented on the p

[jira] [Created] (FLINK-3284) Broken web link: Hadoop compatibility in Flink

2016-01-25 Thread Slim Baltagi (JIRA)
Slim Baltagi created FLINK-3284: --- Summary: Broken web link: Hadoop compatibility in Flink Key: FLINK-3284 URL: https://issues.apache.org/jira/browse/FLINK-3284 Project: Flink Issue Type: Task

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174491828 Good fix. I think if we want to be on the super safe side, actually all tasks should always report back to the JobManager that they received the "TriggerChec

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115129#comment-15115129 ] ASF GitHub Bot commented on FLINK-3261: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-01-25 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/1517#issuecomment-174492669 I have added a commit to this PR that adds the chained version of `ReduceCombineDriver`. (It doesn't have the sort-based code, only the hash-based.) --- If your project

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115138#comment-15115138 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on the pull re

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread senorcarbone
Github user senorcarbone commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174500162 Looks cool. Just so I understand exactly, what is wrong again if the Coordinator simply aborts expired checkpoint attempts? Wouldn't the protocol be the same, w

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115155#comment-15115155 ] ASF GitHub Bot commented on FLINK-3261: --- Github user senorcarbone commented on the p

[GitHub] flink pull request: [hotfix] [docs] Add missing licenses to progra...

2016-01-25 Thread ggevay
GitHub user ggevay opened a pull request: https://github.com/apache/flink/pull/1545 [hotfix] [docs] Add missing licenses to programming guide redirects. The recently added files `flink/docs/apis/programming_guide.md` and `flink/docs/apis/streaming_guide.md` (in 1a5ce4da9a6cc92a5a64

[jira] [Commented] (FLINK-2246) Add chained combine driver strategy for ReduceFunction

2016-01-25 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115174#comment-15115174 ] Gabor Gevay commented on FLINK-2246: I have added a commit to https://github.com/apach

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174505573 @senorcarbone Yes, it works correctly with the timeouts, the job can just hang for a long time, especially in tests this occurred several times. --- If your project is

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115176#comment-15115176 ] ASF GitHub Bot commented on FLINK-3261: --- Github user aljoscha commented on the pull

[jira] [Created] (FLINK-3285) Skip Maven deployment of flink-java8

2016-01-25 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3285: - Summary: Skip Maven deployment of flink-java8 Key: FLINK-3285 URL: https://issues.apache.org/jira/browse/FLINK-3285 Project: Flink Issue Type: Sub-

[GitHub] flink pull request: [hotfix] [docs] Add missing licenses to progra...

2016-01-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1545#issuecomment-174510830 awesome, thank you. I'll merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] flink pull request: [hotfix] [docs] Add missing licenses to progra...

2016-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115200#comment-15115200 ] ASF GitHub Bot commented on FLINK-2523: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-01-25 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1546 FLINK-2523: making the task cancellation interval configurable. FLINK-2523: Makes the task cancellation interval configurable. You can merge this pull request into a Git repository by running: $ g

[GitHub] flink pull request: [hotfix] [docs] Add missing licenses to progra...

2016-01-25 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1545#issuecomment-174512560 Sorry about that :8ball: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115201#comment-15115201 ] ASF GitHub Bot commented on FLINK-2523: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-01-25 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1546#discussion_r50694061 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java --- @@ -60,6 +60,7 @@ public static void

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1546#discussion_r50694370 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java --- @@ -60,6 +60,7 @@ public static void mai

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115205#comment-15115205 ] ASF GitHub Bot commented on FLINK-2523: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request: [FLINK-3282] Add FlinkRelNode interface.

2016-01-25 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/1544#issuecomment-174515248 Initially, I thought it makes sense to separate the code generation from the optimization (and thus from Calcite). So that we could replace Calcite easily at any time. B

[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115219#comment-15115219 ] ASF GitHub Bot commented on FLINK-3282: --- Github user twalthr commented on the pull r

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115235#comment-15115235 ] ASF GitHub Bot commented on FLINK-2523: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-01-25 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1546#issuecomment-174518267 Thank you for this patch. The idea is good, but I think it needs a bit of improvement: - The value is pulled in a fairly complicated way though all the lay

[GitHub] flink pull request: [FLINK-3282] Add FlinkRelNode interface.

2016-01-25 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1544#issuecomment-174518788 Yes, my initial idea was also to separate between 1) translating to the correct job structure and 2) translation to actual DataSet program. So basically the same motivat

[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115239#comment-15115239 ] ASF GitHub Bot commented on FLINK-3282: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3271) Using webhdfs in a flink topology throws classnotfound exception

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115245#comment-15115245 ] ASF GitHub Bot commented on FLINK-3271: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: FLINK-3271: Include jetty-util in the dist jar

2016-01-25 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1543#issuecomment-174519860 The idea sounds very good. The `lib` folder should not pack the Hadoop classes into the same uberjar as Flink, but have separate fat jars for Flink and the Hadoop de

[GitHub] flink pull request: FLINK-3271: Include jetty-util in the dist jar

2016-01-25 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1543#issuecomment-174520036 If this is the approach you suggest to go for, please open a JIRA for this... --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-3271) Using webhdfs in a flink topology throws classnotfound exception

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115250#comment-15115250 ] ASF GitHub Bot commented on FLINK-3271: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1546#issuecomment-174520820 The `JobManagerITCase` is completely commented out. I guess this is a testing artifact. --- If your project is set up for it, you can reply to this email and have

[jira] [Created] (FLINK-3286) Remove JDEB Debian Package code from flink-dist

2016-01-25 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-3286: --- Summary: Remove JDEB Debian Package code from flink-dist Key: FLINK-3286 URL: https://issues.apache.org/jira/browse/FLINK-3286 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115251#comment-15115251 ] ASF GitHub Bot commented on FLINK-2523: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115258#comment-15115258 ] ASF GitHub Bot commented on FLINK-3261: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-3286) Remove JDEB Debian Package code from flink-dist

2016-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115259#comment-15115259 ] Till Rohrmann commented on FLINK-3286: -- +1 > Remove JDEB Debian Package code from fl

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread senorcarbone
Github user senorcarbone commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174521693 Wow, I see your point. Then a single abort message back to the Coordinator is enough in this case. Why 10 min btw? --- If your project is set up for it, you can re

[GitHub] flink pull request: [FLINK-3246] Remove unnecessary '-parent' suff...

2016-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3256] Fix colocation group re-instantia...

2016-01-25 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1526#issuecomment-174521559 Looks good, +1 to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[jira] [Commented] (FLINK-3286) Remove JDEB Debian Package code from flink-dist

2016-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115264#comment-15115264 ] Robert Metzger commented on FLINK-3286: --- +1 > Remove JDEB Debian Package code from

[jira] [Commented] (FLINK-3255) Chaining behavior should not depend on parallelism

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115262#comment-15115262 ] ASF GitHub Bot commented on FLINK-3255: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-3256) Invalid execution graph cleanup for jobs with colocation groups

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115260#comment-15115260 ] ASF GitHub Bot commented on FLINK-3256: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-3261) Tasks should eagerly report back when they cannot start a checkpoint

2016-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115265#comment-15115265 ] ASF GitHub Bot commented on FLINK-3261: --- Github user senorcarbone commented on the p

[jira] [Closed] (FLINK-3255) Chaining behavior should not depend on parallelism

2016-01-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3255. --- > Chaining behavior should not depend on parallelism > --

[jira] [Resolved] (FLINK-3255) Chaining behavior should not depend on parallelism

2016-01-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3255. - Resolution: Fixed Fixed via 7ee719f7e577728fa253f64ad5bd15881b6ddd25 > Chaining behavior should n

  1   2   >