[GitHub] flink pull request: Enhance Partitioned State and use it in Window...

2016-02-01 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1562#issuecomment-177839471 @gyfora you're right, I will add default implementations for ListState and ReducingState and use them in the DbStateBackend. For RocksDB there are custom implementation

[GitHub] flink pull request: [FLINK-3225] Implemented optimization of Table...

2016-02-01 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1559#issuecomment-177854554 @ChengXiangLi, just added you on Skype. I'll write a mail to coordinate the time :-) --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-3225) Optimize logical Table API plans in Calcite

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125949#comment-15125949 ] ASF GitHub Bot commented on FLINK-3225: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3033) Redis Source Connector

2016-02-01 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125950#comment-15125950 ] Matthias J. Sax commented on FLINK-3033: [~neo20iitkgp] please assign the JIRA to

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-02-01 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125952#comment-15125952 ] Matthias J. Sax commented on FLINK-3034: @ [~neo20iitkgp] please assign the JIRA t

[jira] [Created] (FLINK-3308) [py] Remove debug mode

2016-02-01 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-3308: --- Summary: [py] Remove debug mode Key: FLINK-3308 URL: https://issues.apache.org/jira/browse/FLINK-3308 Project: Flink Issue Type: Improvement

[GitHub] flink pull request: [FLINK-3300] fix concurrency bug in YarnJobMan...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-3300) Concurrency Bug in Yarn JobManager

2016-02-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-3300. --- Resolution: Fixed Fixed in 2a49eaaf3c949864457aee0ffd99343a50ac7285. > Concurrency Bu

[jira] [Commented] (FLINK-3300) Concurrency Bug in Yarn JobManager

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125977#comment-15125977 ] ASF GitHub Bot commented on FLINK-3300: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-2870) Add support for accumulating/discarding for Event-Time Windows

2016-02-01 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125979#comment-15125979 ] Fabian Hueske commented on FLINK-2870: -- [~shikhar], the late-arrival strategy for def

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-02-01 Thread PJ Van Aeken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126027#comment-15126027 ] PJ Van Aeken commented on FLINK-2055: - For Flink batch, I think HFileOutputFormat2 is

[jira] [Issue Comment Deleted] (FLINK-1509) Streaming Group Reduce Combiner

2016-02-01 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeyhun Karimov updated FLINK-1509: -- Comment: was deleted (was: I will give a try to this problem) > Streaming Group Reduce Combiner

[jira] [Updated] (FLINK-1509) Streaming Group Reduce Combiner

2016-02-01 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeyhun Karimov updated FLINK-1509: -- Assignee: (was: Jeyhun Karimov) > Streaming Group Reduce Combiner >

[jira] [Updated] (FLINK-2184) Cannot get last element with maxBy/minBy

2016-02-01 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeyhun Karimov updated FLINK-2184: -- Assignee: (was: Jeyhun Karimov) > Cannot get last element with maxBy/minBy > ---

[jira] [Updated] (FLINK-3177) Add Stream Operator that Discards Late Elements

2016-02-01 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeyhun Karimov updated FLINK-3177: -- Assignee: (was: Jeyhun Karimov) > Add Stream Operator that Discards Late Elements >

[jira] [Updated] (FLINK-2390) Replace iteration timeout with algorithm for detecting termination

2016-02-01 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeyhun Karimov updated FLINK-2390: -- Assignee: (was: Jeyhun Karimov) > Replace iteration timeout with algorithm for detecting ter

[jira] [Created] (FLINK-3309) [py] Resolve maven warnings

2016-02-01 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-3309: --- Summary: [py] Resolve maven warnings Key: FLINK-3309 URL: https://issues.apache.org/jira/browse/FLINK-3309 Project: Flink Issue Type: Improvement

[jira] [Assigned] (FLINK-3034) Redis SInk Connector

2016-02-01 Thread subhankar biswas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] subhankar biswas reassigned FLINK-3034: --- Assignee: subhankar biswas > Redis SInk Connector > > >

[jira] [Assigned] (FLINK-3033) Redis Source Connector

2016-02-01 Thread subhankar biswas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] subhankar biswas reassigned FLINK-3033: --- Assignee: subhankar biswas > Redis Source Connector > -- > >

[jira] [Resolved] (FLINK-3307) RMQSourceTest failure

2016-02-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-3307. --- Resolution: Duplicate > RMQSourceTest failure > - > >

[jira] [Resolved] (FLINK-3301) Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState

2016-02-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-3301. --- Resolution: Duplicate > Ineffective synchronization in MessageAcknowledgingSourceBase#

[jira] [Reopened] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-02-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reopened FLINK-3265: --- Assignee: (was: Robert Metzger) Seems to be still some synchronization issue in

[jira] [Commented] (FLINK-3301) Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126148#comment-15126148 ] ASF GitHub Bot commented on FLINK-3301: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-02-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1560#discussion_r51408033 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java --- @@ -177,21 +177,19 @@ protec

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-02-01 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-177954808 Since it looks like I've gathered enough feedback, I'm closing the PR so that I can keep working on it and not burden on the CI system. Sorry for the WIP PR, I'll

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-02-01 Thread stefanobaghino
Github user stefanobaghino closed the pull request at: https://github.com/apache/flink/pull/1536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126192#comment-15126192 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino closed the pull

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126191#comment-15126191 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on the

[jira] [Commented] (FLINK-3179) Combiner is not injected if Reduce or GroupReduce input is explicitly partitioned

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126204#comment-15126204 ] ASF GitHub Bot commented on FLINK-3179: --- Github user ramkrish86 commented on the pul

[GitHub] flink pull request: FLINK-3179 Combiner is not injected if Reduce ...

2016-02-01 Thread ramkrish86
Github user ramkrish86 commented on the pull request: https://github.com/apache/flink/pull/1553#issuecomment-177957906 I went through the code. In both cases of WordCount program with and without explicit partition `[Map] --hash-partition--> [Reduce]` `[Map] --partition--> [Par

[jira] [Assigned] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-02-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reassigned FLINK-3265: - Assignee: Maximilian Michels > RabbitMQ Source not threadsafe: ConcurrentModifica

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-02-01 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126221#comment-15126221 ] ramkrishna.s.vasudevan commented on FLINK-2055: --- Thanks for your inputs. For

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-02-01 Thread PJ Van Aeken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126231#comment-15126231 ] PJ Van Aeken commented on FLINK-2055: - Indeed the example that you described uses the

[jira] [Comment Edited] (FLINK-2055) Implement Streaming HBaseSink

2016-02-01 Thread PJ Van Aeken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126231#comment-15126231 ] PJ Van Aeken edited comment on FLINK-2055 at 2/1/16 2:11 PM: -

[jira] [Comment Edited] (FLINK-2055) Implement Streaming HBaseSink

2016-02-01 Thread PJ Van Aeken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126231#comment-15126231 ] PJ Van Aeken edited comment on FLINK-2055 at 2/1/16 2:22 PM: -

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-02-01 Thread PJ Van Aeken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126287#comment-15126287 ] PJ Van Aeken commented on FLINK-2055: - There appears to be a version mismatch which is

[GitHub] flink pull request: FLINK-3179 Combiner is not injected if Reduce ...

2016-02-01 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1553#issuecomment-177997324 The `GroupReduceWithCombineProperties.instanciate()` method checks the shipping strategy of the input channel. In case of the `WordCount` example *without* explicit hash

[jira] [Commented] (FLINK-3179) Combiner is not injected if Reduce or GroupReduce input is explicitly partitioned

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126305#comment-15126305 ] ASF GitHub Bot commented on FLINK-3179: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1568 FLINK-3254: Adding functionality to support the CombineFunction contract. Solves ISSUE-3254: now a function that implements the GroupReduceFunction and the CombineFunction interfaces will be executed w

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126309#comment-15126309 ] ASF GitHub Bot commented on FLINK-3254: --- GitHub user kl0u opened a pull request:

[jira] [Commented] (FLINK-3301) Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126313#comment-15126313 ] ASF GitHub Bot commented on FLINK-3301: --- Github user tedyu closed the pull request a

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51425707 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/util/CombineToGroupCombineWrapper.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51425852 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/util/CombineToGroupCombineWrapper.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126318#comment-15126318 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126319#comment-15126319 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-02-01 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/flink/pull/1560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51426746 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java --- @@ -119,6 +123,8 @@ private void checkCombinability() {

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51427090 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java --- @@ -156,8 +162,8 @@ public boolean isCombinable() {

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126338#comment-15126338 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51427409 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/util/CombineToGroupCombineWrapper.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126329#comment-15126329 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on a diff in

[jira] [Resolved] (FLINK-3305) Remove JavaKaffee serializer util

2016-02-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3305. - Resolution: Fixed Fixed via b6110dc35a17340653a39209038041a5e28054b4 > Remove JavaKaffee serializ

[jira] [Closed] (FLINK-3306) Auto type registration at Kryo is buggy

2016-02-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3306. --- > Auto type registration at Kryo is buggy > --- > > Ke

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51427575 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java --- @@ -193,7 +199,11 @@ public SingleInputSemanticProperties

[jira] [Closed] (FLINK-3305) Remove JavaKaffee serializer util

2016-02-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3305. --- > Remove JavaKaffee serializer util > - > > Key: FLINK-330

[jira] [Resolved] (FLINK-3306) Auto type registration at Kryo is buggy

2016-02-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3306. - Resolution: Fixed Fixed via c4bc47afa6147dd25d8b579e764b30c9c13ee8ea > Auto type registration at

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51427689 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java --- @@ -156,8 +162,8 @@ public boolean isCombinable() {

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126345#comment-15126345 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126347#comment-15126347 ] ASF GitHub Bot commented on FLINK-3254: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request: [FLINK-3296] Remove 'flushing' behavior of the...

2016-02-01 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1563#discussion_r51428065 --- Diff: docs/apis/streaming/index.md --- @@ -1768,6 +1768,11 @@ greater than 1, the output will also be prepended with the identifier of the tas

[jira] [Commented] (FLINK-3296) DataStream.write*() methods are not flushing properly

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126351#comment-15126351 ] ASF GitHub Bot commented on FLINK-3296: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51428276 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/ReduceWithCombinerITCase.java --- @@ -0,0 +1,377 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126353#comment-15126353 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126339#comment-15126339 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1568#issuecomment-178011362 Thanks for the PR. I had a few minor comments. Looks good otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126373#comment-15126373 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3296] Remove 'flushing' behavior of the...

2016-02-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1563#issuecomment-178020653 Code looks good. I would like to update the docs to include a bit more info (like in the inline comment) and at least refer to the `addSink(...)` method, for fault t

[jira] [Commented] (FLINK-3296) DataStream.write*() methods are not flushing properly

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126388#comment-15126388 ] ASF GitHub Bot commented on FLINK-3296: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...

2016-02-01 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1569 [FLINK-3265][tests] adapt RabbitMQ checkpointing test to runtime behavior This reverts the previous fix as this was merely a bug in the test. The methods `snapshotState` and `notifyCheckpointComplete`

[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...

2016-02-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1569#discussion_r51432473 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java --- @@ -219,7

[jira] [Commented] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126399#comment-15126399 ] ASF GitHub Bot commented on FLINK-3265: --- GitHub user mxm opened a pull request:

[jira] [Commented] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126403#comment-15126403 ] ASF GitHub Bot commented on FLINK-3265: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-02-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1560#issuecomment-178029684 Thanks for the pull request. The issue has been identified in the meantime. It is only a testing issue and not a synchronization issue in the RMQSource. --- If your project

[jira] [Commented] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126411#comment-15126411 ] ASF GitHub Bot commented on FLINK-3265: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...

2016-02-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1569#discussion_r51432976 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java --- @@ -219,7 +140,

[jira] [Commented] (FLINK-3301) Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126410#comment-15126410 ] ASF GitHub Bot commented on FLINK-3301: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: FLINK-3271: Include jetty-util in the dist jar

2016-02-01 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/flink/pull/1543#issuecomment-178038559 Hi @StephanEwen how does separating out hadoop classes solve the classloader problem? Since even if the jars are different, they will be loaded in parent c

[jira] [Commented] (FLINK-3271) Using webhdfs in a flink topology throws classnotfound exception

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126432#comment-15126432 ] ASF GitHub Bot commented on FLINK-3271: --- Github user abhishekagarwal87 commented on

[jira] [Commented] (FLINK-2678) DataSet API does not support multi-dimensional arrays as keys

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126421#comment-15126421 ] ASF GitHub Bot commented on FLINK-2678: --- Github user sbcd90 commented on the pull re

[jira] [Commented] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126437#comment-15126437 ] ASF GitHub Bot commented on FLINK-3265: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-02-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-3265. - Resolution: Fixed The root cause of the entire issue was a test case not testing under run

[GitHub] flink pull request: FLINK-3271: Include jetty-util in the dist jar

2016-02-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1543#issuecomment-178044858 If I understood your suggestion at the beginning correctly, you wanted to allow users to delete the "Hadoop jar" in the lib folder and replace it with their own cust

[jira] [Commented] (FLINK-3271) Using webhdfs in a flink topology throws classnotfound exception

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126452#comment-15126452 ] ASF GitHub Bot commented on FLINK-3271: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1568#issuecomment-178039470 Thanks a lot for the comments @fhueske . They are already integrated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126435#comment-15126435 ] ASF GitHub Bot commented on FLINK-3254: --- Github user kl0u commented on the pull requ

[jira] [Commented] (FLINK-2348) IterateExampleITCase failing

2016-02-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126465#comment-15126465 ] Stephan Ewen commented on FLINK-2348: - Had this problem again. On Travis, the 5000 ms

[jira] [Commented] (FLINK-3271) Using webhdfs in a flink topology throws classnotfound exception

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126469#comment-15126469 ] ASF GitHub Bot commented on FLINK-3271: --- Github user abhishekagarwal87 commented on

[GitHub] flink pull request: FLINK-3271: Include jetty-util in the dist jar

2016-02-01 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/flink/pull/1543#issuecomment-178048690 seems to be some misunderstanding. That was not the intention. I suggested relocating hadoop classes so that any hadoop classes in the application are loaded t

[GitHub] flink pull request: FLINK-3271: Include jetty-util in the dist jar

2016-02-01 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/flink/pull/1543#issuecomment-178049275 webhdfs api works with this commit but there could be similar classNotFound problems in future. --- If your project is set up for it, you can reply to this em

[jira] [Commented] (FLINK-3271) Using webhdfs in a flink topology throws classnotfound exception

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126475#comment-15126475 ] ASF GitHub Bot commented on FLINK-3271: --- Github user abhishekagarwal87 commented on

[jira] [Commented] (FLINK-3254) CombineFunction interface not respected

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126515#comment-15126515 ] ASF GitHub Bot commented on FLINK-3254: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1568#issuecomment-178060233 Good to merge. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-3276) Move runtime parts of flink-streaming-java to flink-runtime

2016-02-01 Thread Subhobrata Dey (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126524#comment-15126524 ] Subhobrata Dey commented on FLINK-3276: --- Hello Maximilian, If nobody else is workin

[GitHub] flink pull request: [FLINK-2678]DataSet API does not support multi...

2016-02-01 Thread sbcd90
Github user sbcd90 commented on the pull request: https://github.com/apache/flink/pull/1566#issuecomment-178034715 @StephanEwen could you also help reviewing the code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[jira] [Commented] (FLINK-2678) DataSet API does not support multi-dimensional arrays as keys

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126588#comment-15126588 ] ASF GitHub Bot commented on FLINK-2678: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2678]DataSet API does not support multi...

2016-02-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1566#discussion_r51448517 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java --- @@ -0,0 +1,205 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2678]DataSet API does not support multi...

2016-02-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1566#discussion_r51453182 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java --- @@ -0,0 +1,205 @@ +/* + * Licensed

[jira] [Commented] (FLINK-2678) DataSet API does not support multi-dimensional arrays as keys

2016-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126635#comment-15126635 ] ASF GitHub Bot commented on FLINK-2678: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-3276) Move runtime parts of flink-streaming-java to flink-runtime

2016-02-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126652#comment-15126652 ] Maximilian Michels commented on FLINK-3276: --- Hi [~sbcd90]! This requires some mo

  1   2   >