[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-02-10 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140522#comment-15140522 ] Robert Metzger commented on FLINK-2055: --- I think nobody is currently working on an H

[jira] [Commented] (FLINK-3368) Kafka 0.8 consumer fails to recover from broker shutdowns

2016-02-10 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140540#comment-15140540 ] Robert Metzger commented on FLINK-3368: --- Flink's mechanism to detect the leading bro

[GitHub] flink pull request: [FLINK-3260] [runtime] Enforce terminal state ...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1613#discussion_r52432150 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -107,7 +108,7 @@ private static final Atomic

[jira] [Commented] (FLINK-3260) ExecutionGraph gets stuck in state FAILING

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140547#comment-15140547 ] ASF GitHub Bot commented on FLINK-3260: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-3260] [runtime] Enforce terminal state ...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1613#issuecomment-182277343 Thanks for the review @StephanEwen. The problem is that the test case for the problem is inherently unstable on Travis, because it depends on timeouts. I do

[jira] [Commented] (FLINK-3260) ExecutionGraph gets stuck in state FAILING

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140563#comment-15140563 ] ASF GitHub Bot commented on FLINK-3260: --- Github user tillrohrmann commented on the p

[jira] [Closed] (FLINK-3256) Invalid execution graph cleanup for jobs with colocation groups

2016-02-10 Thread Paris Carbone (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paris Carbone closed FLINK-3256. > Invalid execution graph cleanup for jobs with colocation groups >

[GitHub] flink pull request: [FLINK-3260] [runtime] Enforce terminal state ...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1613#discussion_r52438500 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -107,7 +108,7 @@ private static final AtomicR

[jira] [Commented] (FLINK-3260) ExecutionGraph gets stuck in state FAILING

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140602#comment-15140602 ] ASF GitHub Bot commented on FLINK-3260: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-3260) ExecutionGraph gets stuck in state FAILING

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140617#comment-15140617 ] ASF GitHub Bot commented on FLINK-3260: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-3260] [runtime] Enforce terminal state ...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1613#discussion_r52441996 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -107,7 +108,7 @@ private static final Atomic

[GitHub] flink pull request: [FLINK-3366] Rename @Experimental annotation t...

2016-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1585 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140619#comment-15140619 ] ASF GitHub Bot commented on FLINK-3234: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-3366) Rename @Experimental annotation to @PublicEvolving

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140618#comment-15140618 ] ASF GitHub Bot commented on FLINK-3366: --- Github user asfgit closed the pull request

[GitHub] flink pull request: Increase test timeouts

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1611#issuecomment-182316078 Changes look good to me. +1 for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-1723) Add cross validation for model evaluation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140630#comment-15140630 ] ASF GitHub Bot commented on FLINK-1723: --- Github user chobeat commented on the pull r

[jira] [Closed] (FLINK-3366) Rename @Experimental annotation to @PublicEvolving

2016-02-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3366. Resolution: Done Done with 572855daad452eab169bc2ca27f9f1e4476df656 > Rename @Experimental annotati

[jira] [Closed] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3234. Resolution: Implemented Implemented with 0a63797a6a5418b2363bca25bd77c33c217ff257 > SortPartition d

[GitHub] flink pull request: [FLINK-3107] [runtime] Start checkpoint ID cou...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1610#issuecomment-182319123 Failing tests are the yarn tests and thus most likely unrelated. Changes look good to me :-) +1 for merging. --- If your project is set up for it, you can

[jira] [Commented] (FLINK-3107) ZooKeeperCheckpointIDCounter.start() can block JobManager actor

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140636#comment-15140636 ] ASF GitHub Bot commented on FLINK-3107: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-1723] [ml] [WIP] Add cross validation f...

2016-02-10 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/891#issuecomment-182317008 No news? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink pull request: [FLINK-3372] Setting custom YARN application n...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1607#issuecomment-182321297 Changes look good to me :-) +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Commented] (FLINK-3372) Setting custom YARN application name is ignored

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140641#comment-15140641 ] ASF GitHub Bot commented on FLINK-3372: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: Increase test timeouts

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1611#issuecomment-182322496 Looks good, +1 Please merge soon, will be great to have CI builds more reliable again. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140649#comment-15140649 ] ASF GitHub Bot commented on FLINK-2991: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1605#discussion_r52444710 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java --- @@ -0,0 +1,175 @@

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1605#discussion_r52444796 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java --- @@ -0,0 +1,175 @@

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140651#comment-15140651 ] ASF GitHub Bot commented on FLINK-2991: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140656#comment-15140656 ] ASF GitHub Bot commented on FLINK-2991: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1605#discussion_r52445422 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the A

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1605#discussion_r52445522 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the A

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140658#comment-15140658 ] ASF GitHub Bot commented on FLINK-2991: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1605#discussion_r52445570 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the A

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140660#comment-15140660 ] ASF GitHub Bot commented on FLINK-2991: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1605#discussion_r52446045 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/GenericFoldingState.java --- @@ -0,0 +1,126 @@ +/** + * Licensed to the Apa

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140666#comment-15140666 ] ASF GitHub Bot commented on FLINK-2991: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-3311) Add a connector for streaming data into Cassandra

2016-02-10 Thread Andrea Sella (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140677#comment-15140677 ] Andrea Sella commented on FLINK-3311: - Hi [~rmetzger], Meanwhile [~Zentol] is doing re

[jira] [Comment Edited] (FLINK-3311) Add a connector for streaming data into Cassandra

2016-02-10 Thread Andrea Sella (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140677#comment-15140677 ] Andrea Sella edited comment on FLINK-3311 at 2/10/16 11:49 AM: -

[jira] [Commented] (FLINK-3311) Add a connector for streaming data into Cassandra

2016-02-10 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140701#comment-15140701 ] Robert Metzger commented on FLINK-3311: --- Its fine to do it in one PR. Chesnay is ab

[GitHub] flink pull request: [docs] Fixed typo in Storm Compatibility page

2016-02-10 Thread geoand
GitHub user geoand opened a pull request: https://github.com/apache/flink/pull/1618 [docs] Fixed typo in Storm Compatibility page SomeType.**classs** -> SomeType.**class** You can merge this pull request into a Git repository by running: $ git pull https://github.com/geoand/fli

[jira] [Commented] (FLINK-3368) Kafka 0.8 consumer fails to recover from broker shutdowns

2016-02-10 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140731#comment-15140731 ] Gyula Fora commented on FLINK-3368: --- Thanks Robert for the detailed explanation. It suck

[GitHub] flink pull request: [docs] Fixed typo in Storm Compatibility page

2016-02-10 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1618#issuecomment-182382559 Thanks! Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink pull request: [docs] Fixed typo in Storm Compatibility page

2016-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1618 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52458969 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java --- @@ -52,6 +52,30 @@ */ public class Reduc

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52459053 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java --- @@ -45,9 +45,12 @@ public RandomAccessInputView(ArrayLi

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140784#comment-15140784 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140786#comment-15140786 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52459151 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/resettable/AbstractBlockResettableIterator.java --- @@ -83,6 +83,7 @@ protected Abs

[GitHub] flink pull request: [docs] Fixed typo in Storm Compatibility page

2016-02-10 Thread geoand
Github user geoand commented on the pull request: https://github.com/apache/flink/pull/1618#issuecomment-182386278 You're welcome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140788#comment-15140788 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3373] [build] Shade away Hadoop's HTTP ...

2016-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1615 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52459830 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apa

[jira] [Commented] (FLINK-3373) Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140798#comment-15140798 ] ASF GitHub Bot commented on FLINK-3373: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140797#comment-15140797 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52459974 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apa

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460049 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apa

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140803#comment-15140803 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140806#comment-15140806 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460226 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apa

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140808#comment-15140808 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460590 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apa

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460659 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java --- @@ -52,6 +52,30 @@ */ public class Reduce

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460684 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java --- @@ -45,9 +45,12 @@ public RandomAccessInputView(ArrayLis

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140818#comment-15140818 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in t

[GitHub] flink pull request: [FLINK-3226] Implement a CodeGenerator for an ...

2016-02-10 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1595#issuecomment-182390675 Hey @twalthr, I merged this yesterday but the PR didn't automatically close. Could you please close it manually? Thanks! --- If your project is set up for it, you can

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140816#comment-15140816 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in t

[GitHub] flink pull request: [FLINK-3335] [runtime] Fix DataSourceTask obje...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1616#issuecomment-182390682 I am very hesitant to introduce an "always copy" step in the data sources. Some data sources create Avro or Thrift types which are incredibly expensive to copy.

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140817#comment-15140817 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460672 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apa

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140812#comment-15140812 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460698 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/resettable/AbstractBlockResettableIterator.java --- @@ -83,6 +83,7 @@ protected Abst

[GitHub] flink pull request: [FLINK-3341] Make 'auto.offset.reset' compatib...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1597#issuecomment-182390919 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[jira] [Commented] (FLINK-3335) Fix DataSourceTask object reuse when disabled

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140820#comment-15140820 ] ASF GitHub Bot commented on FLINK-3335: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140821#comment-15140821 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in t

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140819#comment-15140819 ] ASF GitHub Bot commented on FLINK-3226: --- Github user vasia commented on the pull req

[jira] [Commented] (FLINK-3341) Kafka connector's 'auto.offset.reset' inconsistent with Kafka

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140822#comment-15140822 ] ASF GitHub Bot commented on FLINK-3341: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460829 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apa

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460943 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java --- @@ -102,7 +102,7 @@ public void testCom

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140823#comment-15140823 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461048 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java --- @@ -100,340 +101,371 @@ @Test publ

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140826#comment-15140826 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140829#comment-15140829 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3372] Setting custom YARN application n...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1607#issuecomment-182391709 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461236 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReduceHashTableTest.java --- @@ -0,0 +1,501 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461306 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [FLINK-3372] Setting custom YARN application n...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1607#issuecomment-182391843 Will add this as well to 0.10-SNAPSHOT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[jira] [Commented] (FLINK-3372) Setting custom YARN application name is ignored

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140830#comment-15140830 ] ASF GitHub Bot commented on FLINK-3372: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461281 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140833#comment-15140833 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3226] Translate logical aggregations to...

2016-02-10 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1600#issuecomment-182392029 I've rebased this one on top of `tableOnCalcite` which includes #1595. Regarding the average aggregate, I went for @tillrohrmann's suggestion of adding 0.5. That m

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140834#comment-15140834 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140831#comment-15140831 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140835#comment-15140835 ] ASF GitHub Bot commented on FLINK-3226: --- Github user vasia commented on the pull req

[jira] [Commented] (FLINK-3372) Setting custom YARN application name is ignored

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140832#comment-15140832 ] ASF GitHub Bot commented on FLINK-3372: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461392 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apac

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140836#comment-15140836 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in t

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461679 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the Apac

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140838#comment-15140838 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in t

[jira] [Commented] (FLINK-3356) JobClientActorRecoveryITCase.testJobClientRecovery

2016-02-10 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140840#comment-15140840 ] Matthias J. Sax commented on FLINK-3356: https://travis-ci.org/mjsax/flink/jobs/10

  1   2   3   >