[GitHub] flink issue #2673: [FLINK-4864] [table] Shade Calcite dependency in flink-ta...

2016-10-23 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2673 Besides the compilation problem , Calcite has a bug [CALCITE-1461](https://issues.apache.org/jira/browse/CALCITE-1461) which will break shading. Maybe we should wait for this issue solved and release

[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601148#comment-15601148 ] ASF GitHub Bot commented on FLINK-4864: --- Github user wuchong commented on the issue:

[GitHub] flink pull request #2428: [FLINK-4517] scala code refactoring

2016-10-23 Thread shijinkui
Github user shijinkui closed the pull request at: https://github.com/apache/flink/pull/2428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Commented] (FLINK-4517) scala code refactoring

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601123#comment-15601123 ] ASF GitHub Bot commented on FLINK-4517: --- Github user shijinkui closed the pull reque

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601014#comment-15601014 ] ASF GitHub Bot commented on FLINK-4280: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2509: [FLINK-4280][kafka-connector] Explicit start position con...

2016-10-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2509 Rebased on recent Kafka consumer changes, fixed failing Kafka 0.10 exactly-once tests, and added integration tests (`testStartFromEarliestOffsets`, `testStartFromLatestOffsets`, and `testStartFromG

[jira] [Commented] (FLINK-4883) Prevent UDFs implementations through Scala singleton objects

2016-10-23 Thread Renkai Ge (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600886#comment-15600886 ] Renkai Ge commented on FLINK-4883: -- I want to work on this issue. > Prevent UDFs impleme

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600782#comment-15600782 ] ASF GitHub Bot commented on FLINK-4469: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2653: [FLINK-4469] [table] Add support for user defined table f...

2016-10-23 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2653 Hi @fhueske @twalthr , do you have any thoughts on this pull request ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[jira] [Commented] (FLINK-4879) class KafkaTableSource should be public just like KafkaTableSink

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600715#comment-15600715 ] ASF GitHub Bot commented on FLINK-4879: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...

2016-10-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2678 +1 this looks fine to me, no problem with making it public. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[jira] [Commented] (FLINK-4879) class KafkaTableSource should be public just like KafkaTableSink

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600680#comment-15600680 ] ASF GitHub Bot commented on FLINK-4879: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...

2016-10-23 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2678 +1 to merge this. I think it's fine to make `KafkaTableSource` public, just like `FlinkKafkaConsumerBase`. --- If your project is set up for it, you can reply to this email and have your reply appea

[jira] [Commented] (FLINK-4879) class KafkaTableSource should be public just like KafkaTableSink

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600634#comment-15600634 ] ASF GitHub Bot commented on FLINK-4879: --- Github user hzyuemeng1 commented on the iss

[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...

2016-10-23 Thread hzyuemeng1
Github user hzyuemeng1 commented on the issue: https://github.com/apache/flink/pull/2678 @wuchong can u help me to inform someone to merge this pr,thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[jira] [Commented] (FLINK-4879) class KafkaTableSource should be public just like KafkaTableSink

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600615#comment-15600615 ] ASF GitHub Bot commented on FLINK-4879: --- Github user hzyuemeng1 commented on the iss

[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...

2016-10-23 Thread hzyuemeng1
Github user hzyuemeng1 commented on the issue: https://github.com/apache/flink/pull/2678 @fhueske @rmetzger ,thanks all for review this pr,I am very interesting in Table SQL,can anyone merge this pr? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] flink issue #2618: [FLINK-4800] Refactor the ContinuousFileMonitoringFunctio...

2016-10-23 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 Hi @mxm. I already have a rebased version of this PR. I am just not committing it because all the commits are squashed and it will mess up the review. Let me know when you want me to push it.

[jira] [Commented] (FLINK-4800) Introduce the TimestampedFileInputSplit for Continuous File Processing

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600258#comment-15600258 ] ASF GitHub Bot commented on FLINK-4800: --- Github user kl0u commented on the issue:

[jira] [Updated] (FLINK-4800) Introduce the TimestampedFileInputSplit for Continuous File Processing

2016-10-23 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-4800: -- Summary: Introduce the TimestampedFileInputSplit for Continuous File Processing (was: Introduce

[jira] [Updated] (FLINK-4800) Introduce the TimestampedFileInputSplit in the Continuous File Processing

2016-10-23 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-4800: -- Summary: Introduce the TimestampedFileInputSplit in the Continuous File Processing (was: Refact

[jira] [Updated] (FLINK-4800) Refactor the ContinuousFileMonitoringFunction code and the related tests.

2016-10-23 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-4800: -- Description: Introduce the TimestampedFileInputSplit which extends the class FileInputSplit and

[jira] [Commented] (FLINK-4866) Make Trigger.clear() Abstract to Enforce Implementation

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600203#comment-15600203 ] ASF GitHub Bot commented on FLINK-4866: --- Github user aljoscha commented on the issue

[GitHub] flink issue #2672: [FLINK-4866] [streaming] Make Trigger.clear() Abstract to...

2016-10-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2672 Thanks for your work. 👍 I'll be merging this tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[jira] [Commented] (FLINK-4789) Avoid Kafka partition discovery on restore and share consumer instance for discovery and data consumption

2016-10-23 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599874#comment-15599874 ] Robert Metzger commented on FLINK-4789: --- This comment is wrong and needs to be updat

[GitHub] flink pull request #2684: Add EvaluateDataSet Operation for LabeledVector - ...

2016-10-23 Thread tfournier314
GitHub user tfournier314 opened a pull request: https://github.com/apache/flink/pull/2684 Add EvaluateDataSet Operation for LabeledVector - This closes #4865 Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into conside

[GitHub] flink pull request #2668: Add EvaluateDataSetOperation for LabeledVector. Th...

2016-10-23 Thread tfournier314
Github user tfournier314 closed the pull request at: https://github.com/apache/flink/pull/2668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] flink issue #2668: Add EvaluateDataSetOperation for LabeledVector. This clos...

2016-10-23 Thread tfournier314
Github user tfournier314 commented on the issue: https://github.com/apache/flink/pull/2668 I'm using IntelliJ and I can't remove scala doc and use java doc instead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[jira] [Created] (FLINK-4889) Make InstanceManager independent of ActorRef

2016-10-23 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4889: Summary: Make InstanceManager independent of ActorRef Key: FLINK-4889 URL: https://issues.apache.org/jira/browse/FLINK-4889 Project: Flink Issue Type: Improv

[jira] [Closed] (FLINK-4847) Let RpcEndpoint.start/shutDown throw exceptions

2016-10-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4847. Resolution: Fixed Fixed via f63f972932e152822603d7a8bb8bf74bf3f05441 > Let RpcEndpoint.start/shutDo

[jira] [Commented] (FLINK-4851) Add FatalErrorHandler and MetricRegistry to ResourceManager

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599397#comment-15599397 ] ASF GitHub Bot commented on FLINK-4851: --- Github user tillrohrmann closed the pull re

[GitHub] flink issue #2651: [FLINK-4847] Let RpcEndpoint.start/shutDown throw excepti...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2651 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4847) Let RpcEndpoint.start/shutDown throw exceptions

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599400#comment-15599400 ] ASF GitHub Bot commented on FLINK-4847: --- Github user tillrohrmann closed the pull re

[jira] [Commented] (FLINK-4851) Add FatalErrorHandler and MetricRegistry to ResourceManager

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599396#comment-15599396 ] ASF GitHub Bot commented on FLINK-4851: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-4847) Let RpcEndpoint.start/shutDown throw exceptions

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599399#comment-15599399 ] ASF GitHub Bot commented on FLINK-4847: --- Github user tillrohrmann commented on the i

[jira] [Closed] (FLINK-4851) Add FatalErrorHandler and MetricRegistry to ResourceManager

2016-10-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4851. Resolution: Fixed Fixed via f38bf4484df3e022f389357059ca984c5e3f76a6 > Add FatalErrorHandler and Me

[GitHub] flink pull request #2651: [FLINK-4847] Let RpcEndpoint.start/shutDown throw ...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/2651 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] flink pull request #2655: [FLINK-4851] [rm] Introduce FatalErrorHandler and ...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/2655 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Closed] (FLINK-4853) Clean up JobManager registration at the ResourceManager

2016-10-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4853. Resolution: Fixed Fixed via 0e965ae3e00454575a8920fce7b97842fdb9e3a9 > Clean up JobManager registra

[GitHub] flink issue #2655: [FLINK-4851] [rm] Introduce FatalErrorHandler and MetricR...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2655 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4853) Clean up JobManager registration at the ResourceManager

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599393#comment-15599393 ] ASF GitHub Bot commented on FLINK-4853: --- Github user tillrohrmann closed the pull re

[jira] [Commented] (FLINK-4853) Clean up JobManager registration at the ResourceManager

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599392#comment-15599392 ] ASF GitHub Bot commented on FLINK-4853: --- Github user tillrohrmann commented on the i

[jira] [Closed] (FLINK-4871) Add memory calculation for TaskManagers and forward MetricRegistry

2016-10-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4871. Resolution: Fixed Fixed via 80b6c2a015fa12bd73dfe8ccdb3930de0396e623 > Add memory calculation for T

[GitHub] flink pull request #2657: [FLINK-4853] [rm] Harden job manager registration ...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/2657 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (FLINK-4871) Add memory calculation for TaskManagers and forward MetricRegistry

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599388#comment-15599388 ] ASF GitHub Bot commented on FLINK-4871: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2657: [FLINK-4853] [rm] Harden job manager registration at the ...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2657 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[jira] [Commented] (FLINK-4871) Add memory calculation for TaskManagers and forward MetricRegistry

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599389#comment-15599389 ] ASF GitHub Bot commented on FLINK-4871: --- Github user tillrohrmann closed the pull re

[GitHub] flink pull request #2669: [FLINK-4871] [mini cluster] Add memory calculation...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/2669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] flink issue #2669: [FLINK-4871] [mini cluster] Add memory calculation for Ta...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2669 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Closed] (FLINK-4882) Cleanup throws exception clause in HighAvailabilityServices

2016-10-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4882. Resolution: Fixed Fixed via 0de5689632bd1f8eac6e436959d80d31df9e5ef9 > Cleanup throws exception cla

[GitHub] flink issue #2679: [FLINK-4882] [flip-6] Remove exceptions from HighAvailabi...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2679 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4882) Cleanup throws exception clause in HighAvailabilityServices

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599376#comment-15599376 ] ASF GitHub Bot commented on FLINK-4882: --- Github user tillrohrmann closed the pull re

[jira] [Commented] (FLINK-4882) Cleanup throws exception clause in HighAvailabilityServices

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599375#comment-15599375 ] ASF GitHub Bot commented on FLINK-4882: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #2679: [FLINK-4882] [flip-6] Remove exceptions from HighA...

2016-10-23 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/2679 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599239#comment-15599239 ] ASF GitHub Bot commented on FLINK-3035: --- Github user aljoscha commented on the issue

[GitHub] flink issue #1617: [FLINK-3035] Redis as State Backend

2016-10-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/1617 @fhueske I'm in favour of closing both, yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur