[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88215090 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -97

[jira] [Created] (FLINK-5078) Introduce annotations for classes copied from Calcite

2016-11-16 Thread Timo Walther (JIRA)
Timo Walther created FLINK-5078: --- Summary: Introduce annotations for classes copied from Calcite Key: FLINK-5078 URL: https://issues.apache.org/jira/browse/FLINK-5078 Project: Flink Issue Type:

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670129#comment-15670129 ] ASF GitHub Bot commented on FLINK-5056: --- Github user kl0u commented on the issue:

[GitHub] flink issue #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2797 Done @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670124#comment-15670124 ] ASF GitHub Bot commented on FLINK-5056: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88211157 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -972,

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670106#comment-15670106 ] ASF GitHub Bot commented on FLINK-5056: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88209971 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkFaultToleranceITCase.ja

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670081#comment-15670081 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670082#comment-15670082 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88206960 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkFaultToleranceITCase.

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88207666 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -57

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670084#comment-15670084 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670083#comment-15670083 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88208586 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -57

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88208047 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -97

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670070#comment-15670070 ] Kostas Kloudas commented on FLINK-2646: --- Big +1 for the feature as well. To revive

[jira] [Commented] (FLINK-5076) Shutting down TM when shutting down new mini cluster

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670062#comment-15670062 ] ASF GitHub Bot commented on FLINK-5076: --- GitHub user ifndef-SleePy opened a pull req

[GitHub] flink pull request #2817: [FLINK-5076] Shutting down TM when shutting down m...

2016-11-16 Thread ifndef-SleePy
GitHub user ifndef-SleePy opened a pull request: https://github.com/apache/flink/pull/2817 [FLINK-5076] Shutting down TM when shutting down mini cluster. This PR [#5076](https://issues.apache.org/jira/browse/FLINK-5076) adds shutting down task manager when shutting down new mini clu

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670043#comment-15670043 ] ASF GitHub Bot commented on FLINK-5056: --- Github user kl0u commented on the issue:

[GitHub] flink issue #2797: [FLINK-5056] Makes the BucketingSink rescalable.

2016-11-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2797 Hi @zentol . I integrated your last comments. Now for the your last question, the answer is that the only way to distinguish between the two types of files is by their filename (prefix and suf

[GitHub] flink pull request #2816: [backport] [FLINK-5073] Use Executor to run ZooKee...

2016-11-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2816#discussion_r88204552 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java --- @@ -237,11 +242,12 @@ public static CompletedCheckpointStore crea

[jira] [Commented] (FLINK-5073) ZooKeeperCompleteCheckpointStore executes blocking delete operation in ZooKeeper client thread

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670029#comment-15670029 ] ASF GitHub Bot commented on FLINK-5073: --- Github user zentol commented on a diff in t

[jira] [Assigned] (FLINK-5075) Kinesis consumer incorrectly determines shards as newly discovered when tested against Kinesalite

2016-11-16 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-5075: -- Assignee: Tzu-Li (Gordon) Tai > Kinesis consumer incorrectly determines shards

[jira] [Updated] (FLINK-5075) Kinesis consumer incorrectly determines shards as newly discovered when tested against Kinesalite

2016-11-16 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-5075: --- Assignee: (was: Tzu-Li (Gordon) Tai) > Kinesis consumer incorrectly determines sha

[jira] [Updated] (FLINK-5013) Flink Kinesis connector doesn't work on old EMR versions

2016-11-16 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-5013: --- Fix Version/s: 1.1.4 > Flink Kinesis connector doesn't work on old EMR versions >

[jira] [Commented] (FLINK-5073) ZooKeeperCompleteCheckpointStore executes blocking delete operation in ZooKeeper client thread

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669777#comment-15669777 ] ASF GitHub Bot commented on FLINK-5073: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-5073) ZooKeeperCompleteCheckpointStore executes blocking delete operation in ZooKeeper client thread

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669775#comment-15669775 ] ASF GitHub Bot commented on FLINK-5073: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #2816: [backport] [FLINK-5073] Use Executor to run ZooKee...

2016-11-16 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2816 [backport] [FLINK-5073] Use Executor to run ZooKeeper callbacks in ZooKeeperStateHandleStore Backport of #2815 for the release-1.1 branch. Use dedicated Executor to run ZooKeeper callb

[GitHub] flink pull request #2815: [FLINK-5073] Use Executor to run ZooKeeper callbac...

2016-11-16 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2815 [FLINK-5073] Use Executor to run ZooKeeper callbacks in ZooKeeperStateHandleStore Use dedicated Executor to run ZooKeeper callbacks in ZooKeeperStateHandleStore instead of running it in th

<    1   2   3