[jira] [Commented] (FLINK-5226) Eagerly project unused attributes

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731472#comment-15731472 ] ASF GitHub Bot commented on FLINK-5226: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2926: [FLINK-5226] [table] Use correct DataSetCostFactor...

2016-12-07 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2926#discussion_r91460589 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCalc.scala --- @@ -73,7 +75,11 @@ class

[GitHub] flink pull request #2926: [FLINK-5226] [table] Use correct DataSetCostFactor...

2016-12-07 Thread beyond1920
Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/2926#discussion_r91455098 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCalc.scala --- @@ -73,7 +75,11 @@ class

[jira] [Commented] (FLINK-5226) Eagerly project unused attributes

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731343#comment-15731343 ] ASF GitHub Bot commented on FLINK-5226: --- Github user beyond1920 commented on a diff in the pull

[jira] [Commented] (FLINK-2821) Change Akka configuration to allow accessing actors from different URLs

2016-12-07 Thread Philipp von dem Bussche (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731314#comment-15731314 ] Philipp von dem Bussche commented on FLINK-2821: Hello [~mxm], some more feedback on my

[jira] [Commented] (FLINK-4883) Prevent UDFs implementations through Scala singleton objects

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731208#comment-15731208 ] ASF GitHub Bot commented on FLINK-4883: --- Github user Renkai commented on the issue:

[GitHub] flink issue #2729: [FLINK-4883]Prevent UDFs implementations through Scala si...

2016-12-07 Thread Renkai
Github user Renkai commented on the issue: https://github.com/apache/flink/pull/2729 Hi, @aljoscha keep a balance in freedom and safety is really a hardwork. I think we could just give a warning to users, but fail and exit directly. --- If your project is set up for it, you can

[jira] [Commented] (FLINK-4997) Extending Window Function Metadata

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731158#comment-15731158 ] ASF GitHub Bot commented on FLINK-4997: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2756: [FLINK-4997] Extending Window Function Metadata

2016-12-07 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2756 @manuzhang I finished reviewing and the code is good to go but I'm currently adding more tests before merging this because I realised that we are lacking there a bit. See

[jira] [Commented] (FLINK-4997) Extending Window Function Metadata

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731132#comment-15731132 ] ASF GitHub Bot commented on FLINK-4997: --- Github user manuzhang commented on the issue:

[GitHub] flink issue #2756: [FLINK-4997] Extending Window Function Metadata

2016-12-07 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/flink/pull/2756 @VenturaDelMonte Any updates here ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #2961: [FLINK-5266] [table] eagerly project unused fields...

2016-12-07 Thread KurtYoung
GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/2961 [FLINK-5266] [table] eagerly project unused fields when selecting aggregation fields This PR is based on #2926 , only the second commit is related. I add a "plan" test directory to hold

[jira] [Commented] (FLINK-5266) Eagerly project unused fields when selecting aggregation fields

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730904#comment-15730904 ] ASF GitHub Bot commented on FLINK-5266: --- GitHub user KurtYoung opened a pull request:

[jira] [Commented] (FLINK-5220) Flink SQL projection pushdown

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730815#comment-15730815 ] ASF GitHub Bot commented on FLINK-5220: --- Github user beyond1920 commented on a diff in the pull

[jira] [Commented] (FLINK-5220) Flink SQL projection pushdown

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730809#comment-15730809 ] ASF GitHub Bot commented on FLINK-5220: --- Github user beyond1920 commented on the issue:

[GitHub] flink pull request #2923: [FLINK-5220] [Table API & SQL] Flink SQL projectio...

2016-12-07 Thread beyond1920
Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/2923#discussion_r91429660 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchScan.scala --- @@ -45,7 +45,8 @@ abstract class

[GitHub] flink issue #2923: [FLINK-5220] [Table API & SQL] Flink SQL projection pushd...

2016-12-07 Thread beyond1920
Github user beyond1920 commented on the issue: https://github.com/apache/flink/pull/2923 @fhueske , thanks for your review. I have already modified the pr based on your advice, including following main changes: 1. Adapt the cost model for the BatchTableSourceScan 2. Modify

[jira] [Commented] (FLINK-5226) Eagerly project unused attributes

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730719#comment-15730719 ] ASF GitHub Bot commented on FLINK-5226: --- Github user KurtYoung commented on the issue:

[GitHub] flink issue #2926: [FLINK-5226] [table] Use correct DataSetCostFactory and i...

2016-12-07 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/2926 Cool, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-4992) Expose String parameter for timers in Timely functions and TimerService

2016-12-07 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730286#comment-15730286 ] Jamie Grier commented on FLINK-4992: Another use case here is just simply attaching whatever data you

[jira] [Commented] (FLINK-3871) Add Kafka TableSource with Avro serialization

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730136#comment-15730136 ] ASF GitHub Bot commented on FLINK-3871: --- Github user mushketyk commented on the issue:

[GitHub] flink issue #2762: [FLINK-3871] Add Kafka TableSource with Avro serializatio...

2016-12-07 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2762 Hi @fhueske , Sorry, I am still relatively new to Flink so I don't have the full context. Could you elaborate why this is an issue and how does this shortcoming affect this PR?

[GitHub] flink issue #2564: [FLINK-2254] Add BipartiateGraph class

2016-12-07 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2564 Hi @greghogan, I've updated the PR according to your review and rebased it on top of the `master` branch. The only thing that I didn't change is the message in the `assertEquals`

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730132#comment-15730132 ] ASF GitHub Bot commented on FLINK-2254: --- Github user mushketyk commented on the issue:

[jira] [Assigned] (FLINK-5283) InputStream should be closed in RocksDBKeyedStateBackend#restoreOldSavepointKeyedState

2016-12-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reassigned FLINK-5283: - Assignee: Stefan Richter > InputStream should be closed in >

[jira] [Updated] (FLINK-5283) InputStream should be closed in RocksDBKeyedStateBackend#restoreOldSavepointKeyedState

2016-12-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5283: -- Description: {code} HashMap namedStates =

[jira] [Updated] (FLINK-5283) InputStream should be closed in RocksDBKeyedStateBackend#restoreOldSavepointKeyedState

2016-12-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5283: -- Description: {code} HashMap namedStates =

[jira] [Updated] (FLINK-5283) InputStream should be closed in RocksDBKeyedStateBackend#restoreOldSavepointKeyedState

2016-12-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5283: -- Summary: InputStream should be closed in RocksDBKeyedStateBackend#restoreOldSavepointKeyedState (was:

[jira] [Created] (FLINK-5283) CheckpointStateOutputStream should be closed in finally block in SavepointV0Serializer#convertKeyedBackendState()

2016-12-07 Thread Ted Yu (JIRA)
Ted Yu created FLINK-5283: - Summary: CheckpointStateOutputStream should be closed in finally block in SavepointV0Serializer#convertKeyedBackendState() Key: FLINK-5283 URL: https://issues.apache.org/jira/browse/FLINK-5283

[jira] [Created] (FLINK-5282) CheckpointStateOutputStream should be closed in finally block in SavepointV0Serializer#convertKeyedBackendState()

2016-12-07 Thread Ted Yu (JIRA)
Ted Yu created FLINK-5282: - Summary: CheckpointStateOutputStream should be closed in finally block in SavepointV0Serializer#convertKeyedBackendState() Key: FLINK-5282 URL: https://issues.apache.org/jira/browse/FLINK-5282

[GitHub] flink issue #2762: [FLINK-3871] Add Kafka TableSource with Avro serializatio...

2016-12-07 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2762 Hi @mushketyk, while reviewing your PR I noticed a significant shortcoming of the `TableSource` interface. `TableSource` does not support nested schemas. IMO, this needs to be fixed before we can

[jira] [Commented] (FLINK-3871) Add Kafka TableSource with Avro serialization

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729420#comment-15729420 ] ASF GitHub Bot commented on FLINK-3871: --- Github user fhueske commented on the issue:

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2919 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729407#comment-15729407 ] ASF GitHub Bot commented on FLINK-4554: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-4554) Add support for array types

2016-12-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4554. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed in 4414008551b2843d98b3caddbb171fa1934e1f40.

[jira] [Updated] (FLINK-3871) Add Kafka TableSource with Avro serialization

2016-12-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-3871: - Description: Add a Kafka TableSource which supports Avro serialized data. The

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729396#comment-15729396 ] ASF GitHub Bot commented on FLINK-4554: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2919: [FLINK-4554] [table] Add support for array types

2016-12-07 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2919 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #2919: [FLINK-4554] [table] Add support for array types

2016-12-07 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2919 Thanks for the update. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729394#comment-15729394 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729389#comment-15729389 ] ASF GitHub Bot commented on FLINK-4554: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2919: [FLINK-4554] [table] Add support for array types

2016-12-07 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2919 Thanks for reviewing my PR. I hope I addressed all your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Created] (FLINK-5281) Extend KafkaJsonTableSources to support nested data

2016-12-07 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-5281: Summary: Extend KafkaJsonTableSources to support nested data Key: FLINK-5281 URL: https://issues.apache.org/jira/browse/FLINK-5281 Project: Flink Issue

[jira] [Created] (FLINK-5280) Extend TableSource to support nested data

2016-12-07 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-5280: Summary: Extend TableSource to support nested data Key: FLINK-5280 URL: https://issues.apache.org/jira/browse/FLINK-5280 Project: Flink Issue Type:

[jira] [Commented] (FLINK-5278) Improve Task and checkpoint logging

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729286#comment-15729286 ] Ufuk Celebi commented on FLINK-5278: Merged in b046038 (release-1.1). Merge for master pending. >

[jira] [Commented] (FLINK-5278) Improve Task and checkpoint logging

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729278#comment-15729278 ] ASF GitHub Bot commented on FLINK-5278: --- Github user uce commented on the issue:

[jira] [Created] (FLINK-5279) Improve error message when trying to access keyed state in non-keyed operator

2016-12-07 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5279: -- Summary: Improve error message when trying to access keyed state in non-keyed operator Key: FLINK-5279 URL: https://issues.apache.org/jira/browse/FLINK-5279 Project:

[jira] [Commented] (FLINK-5114) PartitionState update with finished execution fails

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729209#comment-15729209 ] ASF GitHub Bot commented on FLINK-5114: --- Github user uce commented on the issue:

[GitHub] flink issue #2913: [backport] [FLINK-5114] [network] Handle partition produc...

2016-12-07 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2913 I removed the `findExecutionAttemptWithId` and only check the latest attempt. If that does not match the expected producer attempt, I answer with a `PartitionProducerDisposedException` to which the

[jira] [Resolved] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-12-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4469. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed in 684defbf33168e34657bc1a25607adb53be248c5.

[GitHub] flink pull request #2951: [docs] clarify default restart behavior when check...

2016-12-07 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/2951 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2951: [docs] clarify default restart behavior when checkpointin...

2016-12-07 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2951 Sorry, I missed your comment. We can open another PR to clarify that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2951: [docs] clarify default restart behavior when checkpointin...

2016-12-07 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2951 Also, this PR is open but the change is already there in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-5278) Improve Task and checkpoint logging

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729153#comment-15729153 ] ASF GitHub Bot commented on FLINK-5278: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #2960: [backport] [FLINK-5278] Improve task and checkpoin...

2016-12-07 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2960 [backport] [FLINK-5278] Improve task and checkpoint related logging Backport of #2959 for release-1.1. Improve logging of Task and checkpoint logic. cc @uce You can merge

[jira] [Commented] (FLINK-5278) Improve Task and checkpoint logging

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729152#comment-15729152 ] ASF GitHub Bot commented on FLINK-5278: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #2959: [FLINK-5278] Improve task and checkpoint related l...

2016-12-07 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2959 [FLINK-5278] Improve task and checkpoint related logging Improve logging of Task and checkpoint logic. cc @uce You can merge this pull request into a Git repository by running:

[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-07 Thread mindprince
Github user mindprince closed the pull request at: https://github.com/apache/flink/pull/2954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2954: [docs] Note that numberOfExecutionRetries and executionRe...

2016-12-07 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2954 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #2955: [backport] Improve some follow up exceptions

2016-12-07 Thread uce
Github user uce closed the pull request at: https://github.com/apache/flink/pull/2955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (FLINK-5274) LocalInputChannel throws NPE if partition reader is released

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5274. -- Resolution: Fixed Fix Version/s: 1.1.4 1.2.0 555a687 (master), 1b472d2

[jira] [Closed] (FLINK-5275) InputChanelDeploymentDescriptors throws misleading Exception if producer failed/cancelled

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5275. -- Resolution: Fixed Fix Version/s: 1.1.4 1.2.0 4410c04 (master), 4526005

[jira] [Closed] (FLINK-5276) ExecutionVertex archiving can throw NPE with many previous attempts

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5276. -- Resolution: Fixed Fixed in 75b48e (release-1.1) > ExecutionVertex archiving can throw NPE with many

[GitHub] flink pull request #2957: [FLINK-5276] [eg] Check for null when archiving pr...

2016-12-07 Thread uce
Github user uce closed the pull request at: https://github.com/apache/flink/pull/2957 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5276) ExecutionVertex archiving can throw NPE with many previous attempts

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729109#comment-15729109 ] ASF GitHub Bot commented on FLINK-5276: --- Github user uce closed the pull request at:

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729094#comment-15729094 ] ASF GitHub Bot commented on FLINK-4469: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2653 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729081#comment-15729081 ] ASF GitHub Bot commented on FLINK-4469: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2653: [FLINK-4469] [table] Add support for user defined table f...

2016-12-07 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2653 Thanks. Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2016-12-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729014#comment-15729014 ] Fabian Hueske commented on FLINK-3850: -- The annotations do not need to be code generated. They

[jira] [Created] (FLINK-5278) Improve Task and checkpoint logging

2016-12-07 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-5278: Summary: Improve Task and checkpoint logging Key: FLINK-5278 URL: https://issues.apache.org/jira/browse/FLINK-5278 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-5059) only serialise events once in RecordWriter#broadcastEvent

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728924#comment-15728924 ] ASF GitHub Bot commented on FLINK-5059: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-12-07 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r91306180 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java --- @@ -131,35 +132,30 @@ private void sendToTarget(T

[jira] [Assigned] (FLINK-5277) missing unit test for ensuring ResultPartition#add always recycles buffers

2016-12-07 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber reassigned FLINK-5277: -- Assignee: Nico Kruber > missing unit test for ensuring ResultPartition#add always recycles

[jira] [Created] (FLINK-5277) missing unit test for ensuring ResultPartition#add always recycles buffers

2016-12-07 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-5277: -- Summary: missing unit test for ensuring ResultPartition#add always recycles buffers Key: FLINK-5277 URL: https://issues.apache.org/jira/browse/FLINK-5277 Project: Flink

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2016-12-07 Thread Nikolay Vasilishin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728834#comment-15728834 ] Nikolay Vasilishin commented on FLINK-3850: --- Hi, [~fhueske]! I've read a topic about forward

[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728764#comment-15728764 ] ASF GitHub Bot commented on FLINK-4704: --- GitHub user ex00 opened a pull request:

[jira] [Commented] (FLINK-5276) ExecutionVertex archiving can throw NPE with many previous attempts

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728763#comment-15728763 ] ASF GitHub Bot commented on FLINK-5276: --- Github user StefanRRichter commented on the issue:

[GitHub] flink pull request #2958: [FLINK-4704] Move Table API to org.apache.flink.ta...

2016-12-07 Thread ex00
GitHub user ex00 opened a pull request: https://github.com/apache/flink/pull/2958 [FLINK-4704] Move Table API to org.apache.flink.table Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink issue #2957: [FLINK-5276] [eg] Check for null when archiving prior exe...

2016-12-07 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2957 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-5276) ExecutionVertex archiving can throw NPE with many previous attempts

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728761#comment-15728761 ] ASF GitHub Bot commented on FLINK-5276: --- GitHub user uce opened a pull request:

[GitHub] flink pull request #2957: [FLINK-5276] [eg] Check for null when archiving pr...

2016-12-07 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2957 [FLINK-5276] [eg] Check for null when archiving prior execution attempts The `EvictingBoundedList` returns the default value for all evicted elements. This could lead to NPE when archiving an

[jira] [Assigned] (FLINK-5276) ExecutionVertex archiving can throw NPE with many previous attempts

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-5276: -- Assignee: Ufuk Celebi (was: Stefan Richter) > ExecutionVertex archiving can throw NPE with

[jira] [Commented] (FLINK-5223) Add documentation of UDTF in Table API & SQL

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728747#comment-15728747 ] ASF GitHub Bot commented on FLINK-5223: --- GitHub user wuchong opened a pull request:

[GitHub] flink pull request #2956: [FLINK-5223] [doc] Add documentation of UDTF in Ta...

2016-12-07 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/2956 [FLINK-5223] [doc] Add documentation of UDTF in Table API & SQL Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[jira] [Updated] (FLINK-5276) ExecutionVertex archiving can throw NPE with many previous attempts

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi updated FLINK-5276: --- Fix Version/s: (was: 1.2.0) > ExecutionVertex archiving can throw NPE with many previous attempts

[jira] [Updated] (FLINK-5276) ExecutionVertex archiving can throw NPE with many previous attempts

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi updated FLINK-5276: --- Description: I saw a NPE while archiving a ExecutionVertex: {code} execution graph

[GitHub] flink issue #2954: [docs] Note that numberOfExecutionRetries and executionRe...

2016-12-07 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2954 Merged in c024b0b6cae16a0b668d864c77e923820c262087 but forgot to include the "This closes #2954" message in the commit, could you close the PR? --- If your project is set up for it, you can reply to

[GitHub] flink pull request #2781: [FLINK-5041] Savepoint backwards compatibility 1.1...

2016-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2781 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5041) Implement savepoint backwards compatibility 1.1 -> 1.2

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728721#comment-15728721 ] Ufuk Celebi commented on FLINK-5041: Subtasks FLINK-5042 and FLINK-5043 implemented in in af3bf83

[jira] [Commented] (FLINK-5041) Implement savepoint backwards compatibility 1.1 -> 1.2

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728719#comment-15728719 ] ASF GitHub Bot commented on FLINK-5041: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-5043) Converting keyed state from Flink 1.1 backend implementations to their new counterparts in 1.2

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5043. -- Resolution: Implemented Fix Version/s: 1.2.0 Implemented in af3bf83 (master). > Converting

[jira] [Closed] (FLINK-5042) Convert old savepoints to new savepoints

2016-12-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5042. -- Resolution: Implemented Fix Version/s: 1.2.0 Implemented in af3bf83 (master). > Convert old

[jira] [Created] (FLINK-5276) ExecutionVertex archiving can throw NPE with many previous attempts

2016-12-07 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5276: -- Summary: ExecutionVertex archiving can throw NPE with many previous attempts Key: FLINK-5276 URL: https://issues.apache.org/jira/browse/FLINK-5276 Project: Flink

[GitHub] flink pull request #2955: [backport] Improve some follow up exceptions

2016-12-07 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2955 [backport] Improve some follow up exceptions Improves follow up Exceptions when the job failed in a different place: 1) Check partition state if returned buffer is null in `LocalInputChannel`.

[jira] [Created] (FLINK-5275) InputChanelDeploymentDescriptors throws misleading Exception if producer failed/cancelled

2016-12-07 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5275: -- Summary: InputChanelDeploymentDescriptors throws misleading Exception if producer failed/cancelled Key: FLINK-5275 URL: https://issues.apache.org/jira/browse/FLINK-5275

[jira] [Created] (FLINK-5274) LocalInputChannel throws NPE if partition reader is released

2016-12-07 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5274: -- Summary: LocalInputChannel throws NPE if partition reader is released Key: FLINK-5274 URL: https://issues.apache.org/jira/browse/FLINK-5274 Project: Flink

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2016-12-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728604#comment-15728604 ] Fabian Hueske commented on FLINK-3850: -- Thanks for picking up this issue [~nvasilishin]! Please let

[GitHub] flink issue #2729: [FLINK-4883]Prevent UDFs implementations through Scala si...

2016-12-07 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2729 The problem is that this doesn't even work if the user correctly implements a thread safe UDF. If the UDF is an object then things such as the `RuntimeContext` will be the same for different

[jira] [Commented] (FLINK-4883) Prevent UDFs implementations through Scala singleton objects

2016-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728598#comment-15728598 ] ASF GitHub Bot commented on FLINK-4883: --- Github user aljoscha commented on the issue:

  1   2   >