[jira] [Comment Edited] (FLINK-4758) Remove IOReadableWritable from classes where not needed

2016-12-27 Thread jiwengang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782230#comment-15782230 ] jiwengang edited comment on FLINK-4758 at 12/28/16 6:53 AM: ju

[jira] [Comment Edited] (FLINK-4758) Remove IOReadableWritable from classes where not needed

2016-12-27 Thread jiwengang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782230#comment-15782230 ] jiwengang edited comment on FLINK-4758 at 12/28/16 6:50 AM: ju

[jira] [Commented] (FLINK-4758) Remove IOReadableWritable from classes where not needed

2016-12-27 Thread jiwengang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782230#comment-15782230 ] jiwengang commented on FLINK-4758: -- just remove the interface? Does the implementation c

[GitHub] flink issue #3048: Clarified the import path of the Breeze DenseVector

2016-12-27 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/flink/pull/3048 Locally the tests just pass. Looking at the error logs, it doesn't have to do with the changes in the PR, for example: ``` java.io.FileNotFoundException: build-target/lib/flink-dist-*.jar (No su

[jira] [Comment Edited] (FLINK-4920) Add a Scala Function Gauge

2016-12-27 Thread Pattarawat Chormai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15781253#comment-15781253 ] Pattarawat Chormai edited comment on FLINK-4920 at 12/27/16 9:04 PM: ---

[jira] [Commented] (FLINK-4920) Add a Scala Function Gauge

2016-12-27 Thread Pattarawat Chormai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15781253#comment-15781253 ] Pattarawat Chormai commented on FLINK-4920: --- @Chesney Thanks for your suggestion

[jira] [Commented] (FLINK-5280) Extend TableSource to support nested data

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780914#comment-15780914 ] ASF GitHub Bot commented on FLINK-5280: --- Github user mushketyk commented on the issu

[GitHub] flink issue #3039: [FLINK-5280] Update TableSource to support nested data

2016-12-27 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3039 Hi @fhueske, @wuchong Thank you for your reviews. I think creating three abstract classes is a good idea, since we don't expect any new types of table sources, so there will not b

[jira] [Commented] (FLINK-5280) Extend TableSource to support nested data

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780667#comment-15780667 ] ASF GitHub Bot commented on FLINK-5280: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3039: [FLINK-5280] Update TableSource to support nested data

2016-12-27 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3039 Thanks for working on this @mushketyk and the reviews @wuchong. I just add a comment regarding the Scala trait with implemented function. I'll do a more thorough review in the next days.

[GitHub] flink pull request #3039: [FLINK-5280] Update TableSource to support nested ...

2016-12-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3039#discussion_r93943868 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -111,24 +112,17

[jira] [Commented] (FLINK-5395) support locally build distribution by script create_release_files.sh

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780661#comment-15780661 ] ASF GitHub Bot commented on FLINK-5395: --- GitHub user shijinkui opened a pull request

[jira] [Commented] (FLINK-5280) Extend TableSource to support nested data

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780663#comment-15780663 ] ASF GitHub Bot commented on FLINK-5280: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3049: [FLINK-5395] [Build System] support locally build ...

2016-12-27 Thread shijinkui
GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3049 [FLINK-5395] [Build System] support locally build distribution by script create_release_files.sh create_release_files.sh is build flink release only. It's hard to build custom local Flink release

[jira] [Updated] (FLINK-5395) support locally build distribution by script create_release_files.sh

2016-12-27 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shijinkui updated FLINK-5395: - Description: create_release_files.sh is build flink release only. It's hard to build custom local Flink r

[GitHub] flink pull request #3048: Clarified the import path of the Breeze DenseVecto...

2016-12-27 Thread Fokko
GitHub user Fokko opened a pull request: https://github.com/apache/flink/pull/3048 Clarified the import path of the Breeze DenseVector Guys, I'm working on an extension of the ml library on Flink, but I stumbled upon this. Since it is such a trivial fix, I didn't created a

[jira] [Updated] (FLINK-5376) Misleading log statements in UnorderedStreamElementQueue

2016-12-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5376: -- Description: The following are two examples where ordered stream element queue is mentioned: {code} LOG.

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2016-12-27 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780544#comment-15780544 ] Fabian Hueske commented on FLINK-3849: -- Do you mean we need a single rule for pushing

[jira] [Commented] (FLINK-5358) Support RowTypeInfo extraction in TypeExtractor by Row instance

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780533#comment-15780533 ] ASF GitHub Bot commented on FLINK-5358: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3027: [FLINK-5358] add RowTypeInfo exctraction in TypeExtractor

2016-12-27 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3027 Thanks @tonycox. PR is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink pull request #3027: [FLINK-5358] add RowTypeInfo exctraction in TypeEx...

2016-12-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3027#discussion_r93937117 --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/TypeExtractorTest.java --- @@ -345,8 +346,25 @@ public CustomType cross(CustomType fir

[jira] [Commented] (FLINK-5358) Support RowTypeInfo extraction in TypeExtractor by Row instance

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780528#comment-15780528 ] ASF GitHub Bot commented on FLINK-5358: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-5392) flink-dist build failed when change scala version to 2.11

2016-12-27 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780523#comment-15780523 ] Fabian Hueske commented on FLINK-5392: -- There is another PR addressing this issue: h

[jira] [Closed] (FLINK-5396) flink-dist replace scala version in opt.xml by change-scala-version.sh

2016-12-27 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-5396. Resolution: Duplicate Duplicate of FLINK-5392. I'll add a link to PR [#3047|https://github.com/apach

[jira] [Commented] (FLINK-4088) Add interface to save and load TableSources

2016-12-27 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780452#comment-15780452 ] Fabian Hueske commented on FLINK-4088: -- A Scala trait can be used as a Java interface

[jira] [Commented] (FLINK-5396) flink-dist replace scala version in opt.xml by change-scala-version.sh

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780308#comment-15780308 ] ASF GitHub Bot commented on FLINK-5396: --- GitHub user shijinkui opened a pull request

[GitHub] flink pull request #3047: [FLINK-5396] [Build System] flink-dist replace sca...

2016-12-27 Thread shijinkui
GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3047 [FLINK-5396] [Build System] flink-dist replace scala version in opt.x… flink-dist have configured for replacing bin.xml, but not opt.xml - [X] General - The pull request references

[jira] [Updated] (FLINK-5396) flink-dist replace scala version in opt.xml by change-scala-version.sh

2016-12-27 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shijinkui updated FLINK-5396: - Component/s: Build System > flink-dist replace scala version in opt.xml by change-scala-version.sh > -

[jira] [Created] (FLINK-5396) flink-dist replace scala version in opt.xml by change-scala-version.sh

2016-12-27 Thread shijinkui (JIRA)
shijinkui created FLINK-5396: Summary: flink-dist replace scala version in opt.xml by change-scala-version.sh Key: FLINK-5396 URL: https://issues.apache.org/jira/browse/FLINK-5396 Project: Flink

[jira] [Created] (FLINK-5395) support locally build distribution by script create_release_files.sh

2016-12-27 Thread shijinkui (JIRA)
shijinkui created FLINK-5395: Summary: support locally build distribution by script create_release_files.sh Key: FLINK-5395 URL: https://issues.apache.org/jira/browse/FLINK-5395 Project: Flink I

[jira] [Updated] (FLINK-5394) the estimateRowCount method of DataSetCalc didn't work

2016-12-27 Thread zhangjing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangjing updated FLINK-5394: - Description: The estimateRowCount method of DataSetCalc didn't work now. If I run the following code, ` T

[jira] [Updated] (FLINK-5394) the estimateRowCount method of DataSetCalc didn't work

2016-12-27 Thread zhangjing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangjing updated FLINK-5394: - Description: The estimateRowCount method of DataSetCalc didn't work now. If I run the following code, ` T

[jira] [Updated] (FLINK-5394) the estimateRowCount method of DataSetCalc didn't work

2016-12-27 Thread zhangjing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangjing updated FLINK-5394: - Description: The estimateRowCount method of DataSetCalc didn't work now. If I run the following code, ` T

[jira] [Updated] (FLINK-5394) the estimateRowCount method of DataSetCalc didn't work

2016-12-27 Thread zhangjing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangjing updated FLINK-5394: - Description: The estimateRowCount method of DataSetCalc didn't work now. If I run the following code, ` T

[jira] [Updated] (FLINK-5394) the estimateRowCount method of DataSetCalc didn't work

2016-12-27 Thread zhangjing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangjing updated FLINK-5394: - Description: The estimateRowCount method of DataSetCalc didn't work now. If I run the following code, ` T

[jira] [Created] (FLINK-5394) the estimateRowCount method of DataSetCalc didn't work

2016-12-27 Thread zhangjing (JIRA)
zhangjing created FLINK-5394: Summary: the estimateRowCount method of DataSetCalc didn't work Key: FLINK-5394 URL: https://issues.apache.org/jira/browse/FLINK-5394 Project: Flink Issue Type: Bug

[GitHub] flink pull request #3036: [FLINK-5368] Throw exception if kafka topic doesn'...

2016-12-27 Thread HungUnicorn
GitHub user HungUnicorn reopened a pull request: https://github.com/apache/flink/pull/3036 [FLINK-5368] Throw exception if kafka topic doesn't exist As a developer when reading data from many topics, I want Kafka consumer to show something if any topic is not available. Th

[jira] [Commented] (FLINK-5368) Let Kafka consumer show something when it fails to read one topic out of topic list

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780140#comment-15780140 ] ASF GitHub Bot commented on FLINK-5368: --- GitHub user HungUnicorn reopened a pull req

[jira] [Commented] (FLINK-5368) Let Kafka consumer show something when it fails to read one topic out of topic list

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780108#comment-15780108 ] ASF GitHub Bot commented on FLINK-5368: --- Github user HungUnicorn closed the pull req

[GitHub] flink pull request #3036: [FLINK-5368] Throw exception if kafka topic doesn'...

2016-12-27 Thread HungUnicorn
Github user HungUnicorn closed the pull request at: https://github.com/apache/flink/pull/3036 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5368) Let Kafka consumer show something when it fails to read one topic out of topic list

2016-12-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780093#comment-15780093 ] ASF GitHub Bot commented on FLINK-5368: --- Github user HungUnicorn commented on a diff

[GitHub] flink pull request #3036: [FLINK-5368] Throw exception if kafka topic doesn'...

2016-12-27 Thread HungUnicorn
Github user HungUnicorn commented on a diff in the pull request: https://github.com/apache/flink/pull/3036#discussion_r93916373 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java --- @@ -208,13 +

[jira] [Closed] (FLINK-4670) Add watch mechanism on current RPC framework

2016-12-27 Thread zhangjing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangjing closed FLINK-4670. Resolution: Not A Problem > Add watch mechanism on current RPC framework > -