[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...

2017-01-18 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3150 Hi, @twalthr thanks a lot for the review. I have updated the PR according to your comments. Let me know if I miss something,thanks again!! --- If your project is set up for it, you can r

[GitHub] flink pull request #3157: [FLINK-5508] [mesos] Introduce ZooKeeperUtilityFac...

2017-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3157 [FLINK-5508] [mesos] Introduce ZooKeeperUtilityFactory to create ZooKeeper utility classes This PR is based on #3155 and #3156. This commit adds utility classes to abstract the Curator

[jira] [Commented] (FLINK-5508) Remove Mesos dynamic class loading

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828267#comment-15828267 ] ASF GitHub Bot commented on FLINK-5508: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-5462) Flink job fails due to java.util.concurrent.CancellationException while snapshotting

2017-01-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828276#comment-15828276 ] Robert Metzger commented on FLINK-5462: --- I've looked through this and other logs wit

[jira] [Commented] (FLINK-5508) Remove Mesos dynamic class loading

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828272#comment-15828272 ] ASF GitHub Bot commented on FLINK-5508: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #3158: [backport] [FLINK-5508] [FLINK-5496] [FLINK-5495] ...

2017-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3158 [backport] [FLINK-5508] [FLINK-5496] [FLINK-5495] Fix Mesos HA problems This PR is a backport of #3155, #3156 and #3157 onto the `release-1.2` branch. `da3358a` fixes: The ZooKeep

[jira] [Commented] (FLINK-4693) Add session group-windows for batch tables

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828268#comment-15828268 ] ASF GitHub Bot commented on FLINK-4693: --- Github user sunjincheng121 commented on the

[jira] [Commented] (FLINK-5496) ClassCastException when using Mesos HA mode

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828266#comment-15828266 ] ASF GitHub Bot commented on FLINK-5496: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #3156: [FLINK-5496] [mesos] Relocate Mesos Protobuf depen...

2017-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3156 [FLINK-5496] [mesos] Relocate Mesos Protobuf dependency to avoid version conflicts This PR is based on #3155. Only relocate Mesos Protobuf dependency in flink-mesos. This avoids probl

[jira] [Commented] (FLINK-5495) ZooKeeperMesosWorkerStore cannot be instantiated

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828265#comment-15828265 ] ASF GitHub Bot commented on FLINK-5495: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #3155: [FLINK-5495] [mesos] Provide executor to ZooKeeper...

2017-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3155 [FLINK-5495] [mesos] Provide executor to ZooKeeperMesosWorkerStore The ZooKeeperMesosWorkerStore instantiates a ZooKeeperStateHandleStore which requires an Executor instance. This executor

[jira] [Created] (FLINK-5553) Job fails during deployment with IllegalStateException from subpartition request

2017-01-18 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-5553: - Summary: Job fails during deployment with IllegalStateException from subpartition request Key: FLINK-5553 URL: https://issues.apache.org/jira/browse/FLINK-5553 Proj

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 And could you extend with `StreamTableSource` also ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828240#comment-15828240 ] ASF GitHub Bot commented on FLINK-2168: --- Github user tonycox commented on the issue:

[jira] [Updated] (FLINK-5553) Job fails during deployment with IllegalStateException from subpartition request

2017-01-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-5553: -- Attachment: application-1484132267957-0076 > Job fails during deployment with IllegalStateExcept

[GitHub] flink pull request #3117: [FLINK-5480] Introduce user-provided hash for JobV...

2017-01-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3117#discussion_r96651445 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java --- @@ -96,18 +9

[jira] [Assigned] (FLINK-4752) Improve session window documentation

2017-01-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-4752: Assignee: Fabian Hueske > Improve session window documentation > --

[jira] [Commented] (FLINK-5548) Move checks for DataStreamRel validity into constructor

2017-01-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828221#comment-15828221 ] Fabian Hueske commented on FLINK-5548: -- Thanks for checking [~jark], I had assumed th

[jira] [Commented] (FLINK-5468) Restoring from a semi async rocksdb statebackend (1.1) to 1.2 fails with ClassNotFoundException

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828218#comment-15828218 ] ASF GitHub Bot commented on FLINK-5468: --- Github user StefanRRichter commented on the

[jira] [Closed] (FLINK-5548) Move checks for DataStreamRel validity into constructor

2017-01-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-5548. Resolution: Invalid > Move checks for DataStreamRel validity into constructor >

[GitHub] flink issue #3119: [FLINK-5468] Improved error message for migrating semi as...

2017-01-18 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3119 I changed the PR like @StephanEwen suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-5480) User-provided hashes for operators

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828215#comment-15828215 ] ASF GitHub Bot commented on FLINK-5480: --- Github user StefanRRichter commented on a d

[jira] [Closed] (FLINK-5484) Kryo serialization changed between 1.1 and 1.2

2017-01-18 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5484. -- Resolution: Fixed Fix Version/s: 1.3.0 1.2.0 Fixed in 931929b (release-1.1), 5

[jira] [Commented] (FLINK-4693) Add session group-windows for batch tables

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828173#comment-15828173 ] ASF GitHub Bot commented on FLINK-4693: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2017-01-18 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828174#comment-15828174 ] Ufuk Celebi commented on FLINK-2608: Reverted in a7644b1 (release-1.2), 586f818 (maste

[GitHub] flink pull request #3150: [FLINK-4693][tableApi] Add session group-windows f...

2017-01-18 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3150#discussion_r96645923 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateReduceGroupFunction.scala --- @@ -

[jira] [Commented] (FLINK-5484) Kryo serialization changed between 1.1 and 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828169#comment-15828169 ] ASF GitHub Bot commented on FLINK-5484: --- Github user uce closed the pull request at:

[GitHub] flink pull request #3152: [FLINK-5484] [serialization] Revert Chill version ...

2017-01-18 Thread uce
Github user uce closed the pull request at: https://github.com/apache/flink/pull/3152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[jira] [Commented] (FLINK-4693) Add session group-windows for batch tables

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828166#comment-15828166 ] ASF GitHub Bot commented on FLINK-4693: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3150: [FLINK-4693][tableApi] Add session group-windows f...

2017-01-18 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3150#discussion_r96645235 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateReduceGroupFunction.scala ---

[jira] [Reopened] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2017-01-18 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reopened FLINK-2608: Have to reopen this because we can't update our Chill dependency without breaking savepoint compatabili

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 I think it can be solved in different issue to provide a new api in `table.api` for selecting from HBase --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-5527) QueryableState: requesting a non-existing key in MemoryStateBackend or FsStateBackend does not return the default value

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828150#comment-15828150 ] ASF GitHub Bot commented on FLINK-5527: --- Github user NicoK commented on the issue:

[GitHub] flink issue #3142: [FLINK-5527][query] querying a non-existing key does not ...

2017-01-18 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3142 I saw that deprecation but nonetheless the default value is exposed which is why a consistent behaviour is needed. Since the state descriptor says "that is the value if nothing is set", I woul

[jira] [Commented] (FLINK-4693) Add session group-windows for batch tables

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828142#comment-15828142 ] ASF GitHub Bot commented on FLINK-4693: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #3150: [FLINK-4693][tableApi] Add session group-windows f...

2017-01-18 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3150#discussion_r96642258 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetWindowAggregateITCase.scala --- @@ -119,4 +119,35 @@ class

[jira] [Commented] (FLINK-5480) User-provided hashes for operators

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828125#comment-15828125 ] ASF GitHub Bot commented on FLINK-5480: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-5480) User-provided hashes for operators

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828124#comment-15828124 ] ASF GitHub Bot commented on FLINK-5480: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #3117: [FLINK-5480] Introduce user-provided hash for JobV...

2017-01-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3117#discussion_r96640105 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphUserHashHasher.java --- @@ -18,27 +18,29 @@ package or

[GitHub] flink pull request #3117: [FLINK-5480] Introduce user-provided hash for JobV...

2017-01-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3117#discussion_r96640591 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java --- @@ -96,18 +98,19 @@

[jira] [Commented] (FLINK-5548) Move checks for DataStreamRel validity into constructor

2017-01-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828108#comment-15828108 ] Jark Wu commented on FLINK-5548: I think you mean {{DataSetRel}}, right? I only find {{Dat

[GitHub] flink pull request #3143: [FLINK-5530] fix race condition in AbstractRocksDB...

2017-01-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3143#discussion_r96638594 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java --- @@ -132,55 +132,95 @@ p

[jira] [Commented] (FLINK-5530) race condition in AbstractRocksDBState#getSerializedValue

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828105#comment-15828105 ] ASF GitHub Bot commented on FLINK-5530: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #3143: [FLINK-5530] fix race condition in AbstractRocksDB...

2017-01-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3143#discussion_r96638710 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java --- @@ -132,55 +132,95 @@ p

[jira] [Commented] (FLINK-5530) race condition in AbstractRocksDBState#getSerializedValue

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828107#comment-15828107 ] ASF GitHub Bot commented on FLINK-5530: --- Github user NicoK commented on a diff in th

[jira] [Assigned] (FLINK-5047) Add sliding group-windows for batch tables

2017-01-18 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-5047: --- Assignee: Timo Walther > Add sliding group-windows for batch tables > ---

[jira] [Commented] (FLINK-5530) race condition in AbstractRocksDBState#getSerializedValue

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828102#comment-15828102 ] ASF GitHub Bot commented on FLINK-5530: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #2702: [FLINK-4942] Improve processing performance of Hea...

2017-01-18 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/2702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-4942) Improve processing performance of HeapInternalTimerService with key groups

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828100#comment-15828100 ] ASF GitHub Bot commented on FLINK-4942: --- Github user StefanRRichter closed the pull

[GitHub] flink pull request #3143: [FLINK-5530] fix race condition in AbstractRocksDB...

2017-01-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3143#discussion_r96638478 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java --- @@ -132,55 +132,95 @@ p

[jira] [Commented] (FLINK-5530) race condition in AbstractRocksDBState#getSerializedValue

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828101#comment-15828101 ] ASF GitHub Bot commented on FLINK-5530: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #3143: [FLINK-5530] fix race condition in AbstractRocksDB...

2017-01-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3143#discussion_r96638451 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java --- @@ -242,6 +245,132 @@ public void testValueState() throws Ex

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828093#comment-15828093 ] ASF GitHub Bot commented on FLINK-2168: --- Github user ramkrish86 commented on the iss

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3149 Thanks @tonycox .Yes I am fine with it. I can try. Anyway I t hink there is more to do from my side. Now am not sure how to register the table with the valid family name and column name. It is onl

[GitHub] flink pull request #3154: [FLINK-5549] [core] TypeExtractor fails with Runti...

2017-01-18 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/3154 [FLINK-5549] [core] TypeExtractor fails with RuntimeException, but should use GenericTypeInfo Fixes FLINK-5549. You can merge this pull request into a Git repository by running: $ git pull htt

[jira] [Commented] (FLINK-5549) TypeExtractor fails with RuntimeException, but should use GenericTypeInfo

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828077#comment-15828077 ] ASF GitHub Bot commented on FLINK-5549: --- GitHub user twalthr opened a pull request:

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828074#comment-15828074 ] ASF GitHub Bot commented on FLINK-5092: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-5480) User-provided hashes for operators

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828075#comment-15828075 ] ASF GitHub Bot commented on FLINK-5480: --- Github user StefanRRichter commented on the

[GitHub] flink issue #3117: [FLINK-5480] Introduce user-provided hash for JobVertexes

2017-01-18 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3117 Thanks a lot for the reviews @zentol and @uce . I made another commit that addresses the review comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2017-01-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2836 Ok, cool. We should certainly exclude classes under "org.apache.flink.runtime.messages". I'll have to tid through the report some more to find others, but i guess we can add them later on too

[jira] [Commented] (FLINK-4693) Add session group-windows for batch tables

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828070#comment-15828070 ] ASF GitHub Bot commented on FLINK-4693: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3150: [FLINK-4693][tableApi] Add session group-windows f...

2017-01-18 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3150#discussion_r96635999 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetWindowAggregateITCase.scala --- @@ -119,4 +119,35 @

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 @fhueske what do you think about to throw `Tuple` (`T extends Tuple`) out of `org.apache.flink.addons.hbase.TableInputFormat` and implement this abstract class in your `HBaseTableSourceI

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828072#comment-15828072 ] ASF GitHub Bot commented on FLINK-2168: --- Github user tonycox commented on the issue:

[GitHub] flink issue #3152: [FLINK-5484] [serialization] Revert Chill version update

2017-01-18 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3152 Good fix and test +1 to merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (FLINK-5484) Kryo serialization changed between 1.1 and 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828071#comment-15828071 ] ASF GitHub Bot commented on FLINK-5484: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-5512) RabbitMQ documentation should inform that exactly-once holds for RMQSource only when parallelism is 1

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828064#comment-15828064 ] ASF GitHub Bot commented on FLINK-5512: --- Github user tzulitai commented on the issue

[GitHub] flink issue #3136: [FLINK-5512] [doc] Improve RabbitMQ documentation

2017-01-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3136 Thanks @StephanEwen and @alpinegizmo for the review. I think the re-wording for "of a queue" is definitely an improvement. I'll change it to your suggestion and merge this by the end of t

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2017-01-18 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @zentol > Is there a way to exclude certain files? Sure. It setups like in other plugins by include\exclude section in plugin configuration. >Is there a way to see how

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828049#comment-15828049 ] ASF GitHub Bot commented on FLINK-5092: --- Github user BorisOsipov commented on the is

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828034#comment-15828034 ] ASF GitHub Bot commented on FLINK-5092: --- Github user zentol commented on the issue:

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2017-01-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2836 @kenmy Thank you, this helped me a lot :) @BorisOsipov From a quick glance the aggregation appears to be working. This is really cool stuff. We'll have to go through the pom changes ag

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828027#comment-15828027 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828024#comment-15828024 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828025#comment-15828025 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828019#comment-15828019 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828022#comment-15828022 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828031#comment-15828031 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828018#comment-15828018 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828021#comment-15828021 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828030#comment-15828030 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828023#comment-15828023 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828026#comment-15828026 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828028#comment-15828028 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96629618 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828029#comment-15828029 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[jira] [Commented] (FLINK-5502) Add documentation about migrating functions from 1.1 to 1.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828020#comment-15828020 ] ASF GitHub Bot commented on FLINK-5502: --- Github user alpinegizmo commented on a diff

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96630446 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96612039 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[jira] [Commented] (FLINK-5549) TypeExtractor fails with RuntimeException, but should use GenericTypeInfo

2017-01-18 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828016#comment-15828016 ] Timo Walther commented on FLINK-5549: - I will fix that. > TypeExtractor fails with Ru

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96628840 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96613974 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96628280 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96628469 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96630636 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96630180 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96614280 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96612338 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96629758 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-01-18 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/3130#discussion_r96628699 --- Diff: docs/dev/migration.md --- @@ -25,9 +25,326 @@ under the License. * This will be replaced by the TOC {:toc} -## Flink 1.1 to 1

<    1   2   3   4   >