[GitHub] flink issue #3898: [FLINK-6492] Fix unclosed DataOutputViewStream usage

2017-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3898 ah ... yes indeed, thanks for reminding me. I'll merge this to master and 1.3; it should be ok if it ends up missing in the 1.3.0 release. --- If your project is set up for it, you can reply to thi

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021109#comment-16021109 ] ASF GitHub Bot commented on FLINK-6492: --- Github user tzulitai commented on the issue

[jira] [Updated] (FLINK-6679) Document HeapStatebackend

2017-05-23 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-6679: --- Component/s: Documentation > Document HeapStatebackend > - > >

[jira] [Created] (FLINK-6681) Update "Upgrading the Flink Framework Version" section for 1.2 -> 1.3

2017-05-23 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6681: --- Summary: Update "Upgrading the Flink Framework Version" section for 1.2 -> 1.3 Key: FLINK-6681 URL: https://issues.apache.org/jira/browse/FLINK-6681 Project: Fl

[jira] [Created] (FLINK-6680) App & Flink migration guide: updates for the 1.3 release

2017-05-23 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-6680: -- Summary: App & Flink migration guide: updates for the 1.3 release Key: FLINK-6680 URL: https://issues.apache.org/jira/browse/FLINK-6680 Project: Flink Issue Type

[jira] [Commented] (FLINK-6537) Umbrella issue for fixes to incremental snapshots

2017-05-23 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1602#comment-1602 ] Gyula Fora commented on FLINK-6537: --- Thanks a lot for looking into this. I wont be able

[jira] [Assigned] (FLINK-6478) Add documentation on how to upgrade serializers for managed state

2017-05-23 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-6478: -- Assignee: Tzu-Li (Gordon) Tai > Add documentation on how to upgrade serializers

[jira] [Updated] (FLINK-6478) Add documentation on how to upgrade serializers for managed state

2017-05-23 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-6478: --- Issue Type: Sub-task (was: Improvement) Parent: FLINK-6674 > Add documentatio

[jira] [Commented] (FLINK-6515) KafkaConsumer checkpointing fails because of ClassLoader issues

2017-05-23 Thread Yassine Marzougui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021115#comment-16021115 ] Yassine Marzougui commented on FLINK-6515: -- Hi, I'm still bumping into this issue

[GitHub] flink issue #3971: [FLINK-6477][web] Waiting the metrics retrieved from the ...

2017-05-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3971 -1. You may end up blocking the netty thread for up to 10 seconds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Closed] (FLINK-6681) Update "Upgrading the Flink Framework Version" section for 1.2 -> 1.3

2017-05-23 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6681. --- Resolution: Duplicate > Update "Upgrading the Flink Framework Version" section for 1.2 -> 1.3

[jira] [Commented] (FLINK-6477) The first time to click Taskmanager cannot get the actual data

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021119#comment-16021119 ] ASF GitHub Bot commented on FLINK-6477: --- Github user zentol commented on the issue:

[jira] [Created] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-05-23 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6682: --- Summary: Improve error message in case parallelism exceeds maxParallelism Key: FLINK-6682 URL: https://issues.apache.org/jira/browse/FLINK-6682 Project: Flink

[jira] [Commented] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-05-23 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021128#comment-16021128 ] Chesnay Schepler commented on FLINK-6682: - The error message should include which

[GitHub] flink issue #3964: [FLINK-6660][docs] expand the connectors overview page

2017-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3964 Thanks for the update, I think its an improvement. +1, merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-6660) expand the streaming connectors overview page

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021141#comment-16021141 ] ASF GitHub Bot commented on FLINK-6660: --- Github user tzulitai commented on the issue

[GitHub] flink issue #3948: [FLINK-5376] Fix log statement in UnorderedStreamElementQ...

2017-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3948 +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[jira] [Closed] (FLINK-6603) Enable checkstyle on test sources

2017-05-23 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-6603. - Resolution: Implemented master: 12b4185c6c09101b64e12a84c33dc4d28f95cff9 > Enable checkstyle on test sour

[jira] [Commented] (FLINK-5376) Misleading log statements in UnorderedStreamElementQueue

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021149#comment-16021149 ] ASF GitHub Bot commented on FLINK-5376: --- Github user tzulitai commented on the issue

[jira] [Created] (FLINK-6683) building with Scala 2.11 no longer uses change-scala-version.sh

2017-05-23 Thread David Anderson (JIRA)
David Anderson created FLINK-6683: - Summary: building with Scala 2.11 no longer uses change-scala-version.sh Key: FLINK-6683 URL: https://issues.apache.org/jira/browse/FLINK-6683 Project: Flink

[jira] [Commented] (FLINK-6683) building with Scala 2.11 no longer uses change-scala-version.sh

2017-05-23 Thread David Anderson (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021163#comment-16021163 ] David Anderson commented on FLINK-6683: --- Would it be possible to also clarify the si

[GitHub] flink issue #3916: [FLINK-6590] Integrate automatic docs generation

2017-05-23 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/3916 I was just wondering if the generated files should be part of the codebase. Shouldn't they only be generated in the build process? --- If your project is set up for it, you can reply to this email

[jira] [Comment Edited] (FLINK-6683) building with Scala 2.11 no longer uses change-scala-version.sh

2017-05-23 Thread David Anderson (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021163#comment-16021163 ] David Anderson edited comment on FLINK-6683 at 5/23/17 1:07 PM:

[jira] [Commented] (FLINK-6590) Integrate generated tables into documentation

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021168#comment-16021168 ] ASF GitHub Bot commented on FLINK-6590: --- Github user dawidwys commented on the issue

[GitHub] flink issue #3964: [FLINK-6660][docs] expand the connectors overview page

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3964 I have a question on the names "predefined" and "bundled". There is also the 3rd category of connectors from Bahir. Perhaps this can be reconsidered in the following update. --- If your project i

[jira] [Commented] (FLINK-6660) expand the streaming connectors overview page

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021171#comment-16021171 ] ASF GitHub Bot commented on FLINK-6660: --- Github user greghogan commented on the issu

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r117985885 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/package.scala --- @@ -40,7 +44,11 @@ package object scala { pr

[jira] [Commented] (FLINK-6658) Use scala Collections in scala CEP API

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021172#comment-16021172 ] ASF GitHub Bot commented on FLINK-6658: --- Github user kl0u commented on a diff in the

[GitHub] flink issue #3964: [FLINK-6660][docs] expand the connectors overview page

2017-05-23 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/3964 @greghogan Yeah, I'm not entirely satisfied with "predefined" and "bundled", but those were the terms already used in the documentation, and I didn't want to introduce new terminology unless it's

[jira] [Commented] (FLINK-6660) expand the streaming connectors overview page

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021182#comment-16021182 ] ASF GitHub Bot commented on FLINK-6660: --- Github user alpinegizmo commented on the is

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r117989704 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -296,25 +294,94 @@ class PatternStream[T](jPatte

[jira] [Commented] (FLINK-6658) Use scala Collections in scala CEP API

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021184#comment-16021184 ] ASF GitHub Bot commented on FLINK-6658: --- Github user kl0u commented on a diff in the

[jira] [Created] (FLINK-6684) Remove AsyncCheckpointRunnable from StreamTask

2017-05-23 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-6684: - Summary: Remove AsyncCheckpointRunnable from StreamTask Key: FLINK-6684 URL: https://issues.apache.org/jira/browse/FLINK-6684 Project: Flink Issue Type: Im

[jira] [Commented] (FLINK-6431) Activate strict checkstyle for flink-metrics

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021187#comment-16021187 ] ASF GitHub Bot commented on FLINK-6431: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #3968: [FLINK-6431] [metrics] Activate strict checkstyle ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3968#discussion_r117988627 --- Diff: flink-metrics/pom.xml --- @@ -60,4 +60,42 @@ under the License. + + +

[jira] [Commented] (FLINK-6431) Activate strict checkstyle for flink-metrics

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021189#comment-16021189 ] ASF GitHub Bot commented on FLINK-6431: --- Github user greghogan commented on a diff i

[jira] [Commented] (FLINK-6431) Activate strict checkstyle for flink-metrics

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021188#comment-16021188 ] ASF GitHub Bot commented on FLINK-6431: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #3968: [FLINK-6431] [metrics] Activate strict checkstyle ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3968#discussion_r117989481 --- Diff: flink-metrics/pom.xml --- @@ -60,4 +60,42 @@ under the License. + + +

[GitHub] flink pull request #3968: [FLINK-6431] [metrics] Activate strict checkstyle ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3968#discussion_r117987690 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -146,44 +146,38 @@ public voi

[jira] [Created] (FLINK-6685) SafetyNetCloseableRegistry is closed prematurely in Task::triggerCheckpointBarrier

2017-05-23 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-6685: - Summary: SafetyNetCloseableRegistry is closed prematurely in Task::triggerCheckpointBarrier Key: FLINK-6685 URL: https://issues.apache.org/jira/browse/FLINK-6685 Pr

[jira] [Commented] (FLINK-6685) SafetyNetCloseableRegistry is closed prematurely in Task::triggerCheckpointBarrier

2017-05-23 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021192#comment-16021192 ] Stefan Richter commented on FLINK-6685: --- For the release, we can fix this by reusing

[jira] [Commented] (FLINK-6590) Integrate generated tables into documentation

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021194#comment-16021194 ] ASF GitHub Bot commented on FLINK-6590: --- Github user zentol commented on the issue:

[GitHub] flink issue #3916: [FLINK-6590] Integrate automatic docs generation

2017-05-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3916 That's a good point. I'll need to checkout how we're building the docs and whether we can just generate the docs before calling `build-docs.sh`. --- If your project is set up for it, you can reply to

[GitHub] flink issue #3964: [FLINK-6660][docs] expand the connectors overview page

2017-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3964 "3rd party connectors" doesn't seem suitable. There are also some self hosted connectors, AFAIK. Perhaps simply "Connectors in Apache Bahir"? Either way, I'll proceed to merge this. The naming c

[jira] [Commented] (FLINK-6660) expand the streaming connectors overview page

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021198#comment-16021198 ] ASF GitHub Bot commented on FLINK-6660: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #3972: [FLINK-6662] [errMsg] Improve error message if rec...

2017-05-23 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3972 [FLINK-6662] [errMsg] Improve error message if recovery from RetrievableStateHandles fails When recovering state from a ZooKeeperStateHandleStore it can happen that the deserialization fai

[jira] [Commented] (FLINK-6662) ClassNotFoundException: o.a.f.r.j.t.JobSnapshottingSettings recovering job

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021206#comment-16021206 ] ASF GitHub Bot commented on FLINK-6662: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-6537) Umbrella issue for fixes to incremental snapshots

2017-05-23 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021248#comment-16021248 ] Stefan Richter commented on FLINK-6537: --- So this is not strictly related to incremen

[GitHub] flink pull request #3964: [FLINK-6660][docs] expand the connectors overview ...

2017-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3964 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3898: [FLINK-6492] Fix unclosed DataOutputViewStream usa...

2017-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3898 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6660) expand the streaming connectors overview page

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021253#comment-16021253 ] ASF GitHub Bot commented on FLINK-6660: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021252#comment-16021252 ] ASF GitHub Bot commented on FLINK-6492: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-23 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-6492. Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 Fixed for mas

[jira] [Resolved] (FLINK-6660) expand the streaming connectors overview page

2017-05-23 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-6660. Resolution: Fixed Fix Version/s: 1.4.0 1.3.0 Thanks for th

[jira] [Commented] (FLINK-6515) KafkaConsumer checkpointing fails because of ClassLoader issues

2017-05-23 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021275#comment-16021275 ] Robert Metzger commented on FLINK-6515: --- Are you sure that you've re-build your user

[GitHub] flink issue #3960: [FLINK-6654][build] let 'flink-dist' properly depend on '...

2017-05-23 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3960 Not sure about the initial issue. For me the command worked (without yoru changes on the 1.3 branch) ``` [INFO]

[jira] [Commented] (FLINK-6654) missing maven dependency on "flink-shaded-hadoop2-uber" in flink-dist

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021287#comment-16021287 ] ASF GitHub Bot commented on FLINK-6654: --- Github user rmetzger commented on the issue

[GitHub] flink pull request #3968: [FLINK-6431] [metrics] Activate strict checkstyle ...

2017-05-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3968#discussion_r118016840 --- Diff: flink-metrics/pom.xml --- @@ -60,4 +60,42 @@ under the License. + + +

[jira] [Commented] (FLINK-6431) Activate strict checkstyle for flink-metrics

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021291#comment-16021291 ] ASF GitHub Bot commented on FLINK-6431: --- Github user zentol commented on a diff in t

[GitHub] flink issue #3968: [FLINK-6431] [metrics] Activate strict checkstyle in flin...

2017-05-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3968 I've included the sources, change the path and added the removed comment. Moving on to the other 2 checkstyle PRs... --- If your project is set up for it, you can reply to this email and have your re

[jira] [Commented] (FLINK-6431) Activate strict checkstyle for flink-metrics

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021318#comment-16021318 ] ASF GitHub Bot commented on FLINK-6431: --- Github user zentol commented on the issue:

[GitHub] flink issue #3960: [FLINK-6654][build] let 'flink-dist' properly depend on '...

2017-05-23 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3960 you probably need to clean up your whole source with `mvn clean` and try from there - I'm not quite sure, my initial command will clean up everything that is not in the dependencies of the flink-dist p

[jira] [Commented] (FLINK-6654) missing maven dependency on "flink-shaded-hadoop2-uber" in flink-dist

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021323#comment-16021323 ] ASF GitHub Bot commented on FLINK-6654: --- Github user NicoK commented on the issue:

[jira] [Commented] (FLINK-6431) Activate strict checkstyle for flink-metrics

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021326#comment-16021326 ] ASF GitHub Bot commented on FLINK-6431: --- Github user greghogan commented on the issu

[GitHub] flink issue #3968: [FLINK-6431] [metrics] Activate strict checkstyle in flin...

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3968 +1 to merge after Travis gives the green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[jira] [Commented] (FLINK-6675) Activate strict checkstyle for flink-annotations

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021327#comment-16021327 ] ASF GitHub Bot commented on FLINK-6675: --- Github user greghogan commented on the issu

[GitHub] flink issue #3970: [FLINK-6675] Activate strict checkstyle for flink-annotat...

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3970 +1 to merge after Travis gives the green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink pull request #3972: [FLINK-6662] [errMsg] Improve error message if rec...

2017-05-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3972#discussion_r118026253 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java --- @@ -376,8 +377,14 @@ private static Comp

[jira] [Commented] (FLINK-6662) ClassNotFoundException: o.a.f.r.j.t.JobSnapshottingSettings recovering job

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021337#comment-16021337 ] ASF GitHub Bot commented on FLINK-6662: --- Github user zentol commented on a diff in t

[GitHub] flink issue #3969: [FLINK-6432] [py] Activate strict checkstyle for flink-py...

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3969 +1 to merge after Travis gives the green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[jira] [Commented] (FLINK-6432) Activate strict checkstyle for flink-python

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021341#comment-16021341 ] ASF GitHub Bot commented on FLINK-6432: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-6515) KafkaConsumer checkpointing fails because of ClassLoader issues

2017-05-23 Thread Yassine Marzougui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021344#comment-16021344 ] Yassine Marzougui commented on FLINK-6515: -- Yes, I used flink.version=1.4-SNAPSHO

[GitHub] flink issue #3943: [FLINK-6617][table] Improve JAVA and SCALA logical plans ...

2017-05-23 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3943 Hi @twalthr Thanks a log for your reviewing. I completely agree with your suggestions. I petty want refactoring the test structure. I have updated the PR. according your comments. Th

[jira] [Commented] (FLINK-6617) Improve JAVA and SCALA logical plans consistent test

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021398#comment-16021398 ] ASF GitHub Bot commented on FLINK-6617: --- Github user sunjincheng121 commented on the

[jira] [Created] (FLINK-6686) Improve UDXF(UDF,UDTF,UDAF) test case

2017-05-23 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6686: -- Summary: Improve UDXF(UDF,UDTF,UDAF) test case Key: FLINK-6686 URL: https://issues.apache.org/jira/browse/FLINK-6686 Project: Flink Issue Type: Sub-task

[GitHub] flink pull request #3958: [FLINK-6650][table] Improve the error message for ...

2017-05-23 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3958#discussion_r118038355 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -629,8 +629,7 @@ abstract class S

[jira] [Commented] (FLINK-6650) Fix Non-windowed group-aggregate error when using append-table mode.

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021408#comment-16021408 ] ASF GitHub Bot commented on FLINK-6650: --- Github user sunjincheng121 commented on a d

[GitHub] flink issue #3958: [FLINK-6650][table] Improve the error message for toAppen...

2017-05-23 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3958 Hi @twalthr Thanks for review the PR. I have updated the PR. According your comment. Best, SunJincheng --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-6650) Fix Non-windowed group-aggregate error when using append-table mode.

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021414#comment-16021414 ] ASF GitHub Bot commented on FLINK-6650: --- Github user sunjincheng121 commented on the

[jira] [Created] (FLINK-6687) Activate strict checkstyle for flink-runtime-web

2017-05-23 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6687: --- Summary: Activate strict checkstyle for flink-runtime-web Key: FLINK-6687 URL: https://issues.apache.org/jira/browse/FLINK-6687 Project: Flink Issue Ty

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3973 [FLINK-6687] [web] Activate strict checkstyle for flink-runtime-web Lot's of missing javadocs, trailing spaces in javadocs, trailing tabs and missing dots. Very little code is affected. You

[jira] [Commented] (FLINK-6687) Activate strict checkstyle for flink-runtime-web

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021433#comment-16021433 ] ASF GitHub Bot commented on FLINK-6687: --- GitHub user zentol opened a pull request:

[jira] [Created] (FLINK-6688) Activate strict checkstyle in flink-test-utils

2017-05-23 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6688: --- Summary: Activate strict checkstyle in flink-test-utils Key: FLINK-6688 URL: https://issues.apache.org/jira/browse/FLINK-6688 Project: Flink Issue Type

[jira] [Commented] (FLINK-6038) Add deep links to Apache Bahir Flink streaming connector documentations

2017-05-23 Thread David Anderson (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021471#comment-16021471 ] David Anderson commented on FLINK-6038: --- I'm thinking of linking to the github READM

[jira] [Created] (FLINK-6689) Remote StreamExecutionEnvironment fails to submit jobs against LocalFlinkMiniCluster

2017-05-23 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-6689: -- Summary: Remote StreamExecutionEnvironment fails to submit jobs against LocalFlinkMiniCluster Key: FLINK-6689 URL: https://issues.apache.org/jira/browse/FLINK-6689 Projec

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-23 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r118050667 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -296,25 +294,94 @@ class PatternStream[T](jP

[jira] [Commented] (FLINK-6658) Use scala Collections in scala CEP API

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021495#comment-16021495 ] ASF GitHub Bot commented on FLINK-6658: --- Github user dawidwys commented on a diff in

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r118051044 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -296,25 +294,94 @@ class PatternStream[T](jPatte

[jira] [Commented] (FLINK-6658) Use scala Collections in scala CEP API

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021497#comment-16021497 ] ASF GitHub Bot commented on FLINK-6658: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-23 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r118055738 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -296,25 +294,94 @@ class PatternStream[T](jP

[jira] [Commented] (FLINK-6658) Use scala Collections in scala CEP API

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021514#comment-16021514 ] ASF GitHub Bot commented on FLINK-6658: --- Github user dawidwys commented on a diff in

[GitHub] flink pull request #3972: [FLINK-6662] [errMsg] Improve error message if rec...

2017-05-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3972#discussion_r118068470 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java --- @@ -376,8 +377,14 @@ private stati

[GitHub] flink issue #3972: [FLINK-6662] [errMsg] Improve error message if recovery f...

2017-05-23 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3972 Thanks for the review @zentol. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-6662) ClassNotFoundException: o.a.f.r.j.t.JobSnapshottingSettings recovering job

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021591#comment-16021591 ] ASF GitHub Bot commented on FLINK-6662: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-6662) ClassNotFoundException: o.a.f.r.j.t.JobSnapshottingSettings recovering job

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021589#comment-16021589 ] ASF GitHub Bot commented on FLINK-6662: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #3972: [FLINK-6662] [errMsg] Improve error message if rec...

2017-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3972 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6662) ClassNotFoundException: o.a.f.r.j.t.JobSnapshottingSettings recovering job

2017-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021599#comment-16021599 ] ASF GitHub Bot commented on FLINK-6662: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-6662) ClassNotFoundException: o.a.f.r.j.t.JobSnapshottingSettings recovering job

2017-05-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-6662. -- Resolution: Fixed Fix Version/s: 1.4.0 1.3.0 1.4.0: ac6e5c9a03177ad188

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3973#discussion_r118058165 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -100,26 +101,27 @@ privat

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3973#discussion_r118056115 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java --- @@ -29,15 +34,8 @@ import io.netty.handl

<    1   2   3   >