[GitHub] flink pull request #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass...

2017-06-11 Thread wangmiao1981
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/flink/pull/4106 [FLINK-6788]:Remove unused GenericFlatTypePostPass/AbstractSchema class Removed two unused classes by deleting corresponding files. Build Success. Run `mvn clean verify` Optimizer

[GitHub] flink pull request #4092: [FLINK-6876] [streaming] Correct the comments of D...

2017-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4092 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4092: [FLINK-6876] [streaming] Correct the comments of DataStre...

2017-06-11 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4092 merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...

2017-06-11 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/4105 [FLINK-6888] [table] Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala class Currently the `ACC TypeInformation of

[jira] [Comment Edited] (FLINK-6402) Consider removing annotation for REAPER_THREAD_LOCK in SafetyNetCloseableRegistry#doRegister()

2017-06-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986965#comment-15986965 ] Ted Yu edited comment on FLINK-6402 at 6/11/17 10:24 PM: - Pardon the typo. The

[jira] [Updated] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

2017-06-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6493: -- Description: {code} && ((partitionStateSerializer == null && ((Snapshot)

[jira] [Updated] (FLINK-6838) RescalingITCase fails in master branch

2017-06-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6838: -- Description: {code} Tests in error: RescalingITCase.testSavepointRescalingInKeyedState[1] » JobExecution Job

[jira] [Closed] (FLINK-6859) StateCleaningCountTrigger should not delete timer

2017-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-6859. -- Resolution: Fixed > StateCleaningCountTrigger should not delete timer >

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046010#comment-16046010 ] sunjincheng commented on FLINK-6888: Yes, I just want you know the history. I also hope we can improve

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-11 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045992#comment-16045992 ] Jark Wu commented on FLINK-6888: Hi [~sunjincheng121], you are right that all the build-in AGGs work good

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-11 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4086 @greghogan With the latest plugin version (5.6.1) the import layout is adjusted as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045991#comment-16045991 ] ASF GitHub Bot commented on FLINK-6865: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6817) Fix NPE when preceding is not set in OVER window

2017-06-11 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045987#comment-16045987 ] Jark Wu commented on FLINK-6817: Fixed in 5f63bf98c3dc7c1fe28630300b68179b6700dcad for master > Fix NPE

[jira] [Commented] (FLINK-6817) Fix NPE when preceding is not set in OVER window

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045986#comment-16045986 ] ASF GitHub Bot commented on FLINK-6817: --- GitHub user wuchong opened a pull request:

[GitHub] flink pull request #4104: [FLINK-6817] [table] Add OverWindowWithPreceding c...

2017-06-11 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/4104 [FLINK-6817] [table] Add OverWindowWithPreceding class to guide users apply preceding in over window This PR is same as #4055 but against to branch 1.3 Thanks for contributing to Apache

[jira] [Commented] (FLINK-6817) Fix NPE when preceding is not set in OVER window

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045982#comment-16045982 ] ASF GitHub Bot commented on FLINK-6817: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4055: [FLINK-6817] [table] Fix NPE when preceding is not...

2017-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4055 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6883) Serializer for collection of Scala case classes are generated with different anonymous class names in 1.3

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045980#comment-16045980 ] ASF GitHub Bot commented on FLINK-6883: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #4103: [FLINK-6883] [scala, state] Fix restore of Scala t...

2017-06-11 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/4103 [FLINK-6883] [scala, state] Fix restore of Scala type states This PR is based on #4090. Together with #4090 as a whole, this PR fixes restoring savepoints of Scala type states. ## What

[jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045979#comment-16045979 ] ASF GitHub Bot commented on FLINK-6841: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #4061: [FLINK-6841][table]Using TableSourceTable for both Stream...

2017-06-11 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4061 Hi, @wuchong Thanks for your reviewing. I meant from the perspective of grammar is allow batch table source to implement the `DefinedProctimeAttribute` and `DefinedRowtimeAttribute`. We are

[jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045974#comment-16045974 ] ASF GitHub Bot commented on FLINK-6841: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #4061: [FLINK-6841][table]Using TableSourceTable for both...

2017-06-11 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4061#discussion_r121282026 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalTableSourceUtilTest.scala --- @@ -42,7 +42,7 @@ class

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045969#comment-16045969 ] ASF GitHub Bot commented on FLINK-6886: --- GitHub user sunjincheng121 opened a pull request:

[GitHub] flink pull request #4102: [FLINK-6886][table]Fix Timestamp field can not be ...

2017-06-11 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/4102 [FLINK-6886][table]Fix Timestamp field can not be selected in event t… In this JIRA. will fix the exception when we run the folllows SQL: `SELECT name, max(num) as myMax,

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045963#comment-16045963 ] ASF GitHub Bot commented on FLINK-6886: --- Github user sunjincheng121 closed the pull request at:

[GitHub] flink pull request #4101: [FLINK-6886][table]Fix Timestamp field can not be ...

2017-06-11 Thread sunjincheng121
Github user sunjincheng121 closed the pull request at: https://github.com/apache/flink/pull/4101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #4101: Fix Timestamp field can not be selected in event t...

2017-06-11 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/4101 Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type. In this JIRA. will fix the exception when we run the folllows SQL: `SELECT name,

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045957#comment-16045957 ] sunjincheng commented on FLINK-6888: Hi, [~jark] when we dev the UDAG, we using

[jira] [Updated] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6886: --- Description: Currently for event-time window(group/over), When contain `Timestamp` type field in

[jira] [Updated] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-11 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-6888: --- Description: Currently the {{ACC}} TypeInformation of

[jira] [Created] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-11 Thread Jark Wu (JIRA)
Jark Wu created FLINK-6888: -- Summary: Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class Key: FLINK-6888 URL: https://issues.apache.org/jira/browse/FLINK-6888

[jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045897#comment-16045897 ] ASF GitHub Bot commented on FLINK-6841: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4061: [FLINK-6841][table]Using TableSourceTable for both Stream...

2017-06-11 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4061 @twalthr @sunjincheng121 `DefinedProctimeAttribute` and `DefinedRowtimeAttribute` doesn't work in batch table source, currently. BTW, I don't think batch table source needs

[jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045894#comment-16045894 ] ASF GitHub Bot commented on FLINK-6841: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #4061: [FLINK-6841][table]Using TableSourceTable for both...

2017-06-11 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4061#discussion_r121278080 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalTableSourceUtilTest.scala --- @@ -42,7 +42,7 @@ class

[jira] [Created] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

2017-06-11 Thread Jark Wu (JIRA)
Jark Wu created FLINK-6887: -- Summary: Split up CodeGenerator into several specific CodeGenerator Key: FLINK-6887 URL: https://issues.apache.org/jira/browse/FLINK-6887 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-6884) Incompatible TableSource#getReturnType and actual input type should fail faster

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045881#comment-16045881 ] ASF GitHub Bot commented on FLINK-6884: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4100: [FLINK-6884][table] Improve confused exception informatio...

2017-06-11 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4100 Good job! +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-6817) Fix NPE when preceding is not set in OVER window

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045877#comment-16045877 ] ASF GitHub Bot commented on FLINK-6817: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4055: [FLINK-6817] [table] Fix NPE when preceding is not set in...

2017-06-11 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4055 merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Created] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-11 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6886: -- Summary: Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type. Key: FLINK-6886 URL: https://issues.apache.org/jira/browse/FLINK-6886

[jira] [Commented] (FLINK-5776) Improve XXMapRunner support create instance by carrying constructor parameters

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045848#comment-16045848 ] ASF GitHub Bot commented on FLINK-5776: --- Github user sunjincheng121 closed the pull request at:

[GitHub] flink pull request #3418: [FLINK-5776][Table API & SQL]Improve XXMapRunner s...

2017-06-11 Thread sunjincheng121
Github user sunjincheng121 closed the pull request at: https://github.com/apache/flink/pull/3418 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-6884) Incompatible TableSource#getReturnType and actual input type should fail faster

2017-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045843#comment-16045843 ] ASF GitHub Bot commented on FLINK-6884: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #4100: [FLINK-6884][table] Improve confused exception informatio...

2017-06-11 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4100 HI @fhueske Thanks very much for your reviewing. Update the PR. according your comments. Best, SunJincheng --- If your project is set up for it, you can reply to this email and