[jira] [Commented] (FLINK-6904) Support for quantifier range to CEP's pattern API

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048691#comment-16048691 ] ASF GitHub Bot commented on FLINK-6904: --- GitHub user dianfu opened a pull request:

[GitHub] flink pull request #4121: [FLINK-6904] [cep] Support for quantifier range to...

2017-06-13 Thread dianfu
GitHub user dianfu opened a pull request: https://github.com/apache/flink/pull/4121 [FLINK-6904] [cep] Support for quantifier range to CEP's pattern API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Assigned] (FLINK-6904) Support for quantifier range to CEP's pattern API

2017-06-13 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-6904: -- Assignee: Dian Fu > Support for quantifier range to CEP's pattern API >

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048652#comment-16048652 ] ASF GitHub Bot commented on FLINK-6888: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #4105: [FLINK-6888] [table] Can not determine TypeInformation of...

2017-06-13 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4105 @wuchong thanks for the update. It's looks pretty good for me now. + to merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048638#comment-16048638 ] ASF GitHub Bot commented on FLINK-6888: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4105: [FLINK-6888] [table] Can not determine TypeInformation of...

2017-06-13 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4105 Thanks @StephanEwen . This PR is aiming to fix the issues you mentioned: it used `TypeExtractor` for Scala code. @sunjincheng121 I addressed all your comments. Could you please have a

[GitHub] flink pull request #4120: [FLINK-6836] [tests] Fix YARNSessionCapacitySchedu...

2017-06-13 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4120 [FLINK-6836] [tests] Fix YARNSessionCapacitySchedulerITCase to work with Hadoop 2.6.5, 2.7.3 and 2.8.0 Due to MNG-5899, maven cannot resolve dependency reduced poms in a multi project build.

[jira] [Commented] (FLINK-6836) Failing YARNSessionCapacitySchedulerITCase.testTaskManagerFailure

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048440#comment-16048440 ] ASF GitHub Bot commented on FLINK-6836: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #4119: [docs] Fix typos (Souce -> Source)

2017-06-13 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/4119 [docs] Fix typos (Souce -> Source) This changes occurrences of *Souce* in the documentation to *Source*. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048241#comment-16048241 ] ASF GitHub Bot commented on FLINK-6888: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4105: [FLINK-6888] [table] Can not determine TypeInformation of...

2017-06-13 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4105 Is the code ever called from Java code, or is that purely within the Scala code base? Just FYI, the design principles in the DataStream and DataSet API are: - Never run

[jira] [Updated] (FLINK-6911) StatsD Metrics name should escape spaces

2017-06-13 Thread Chris Dail (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Dail updated FLINK-6911: -- Description: The StatsDReporter does not escape spaces in the metric name. It is generally accepted

[jira] [Created] (FLINK-6911) StatsD Metrics name should escape spaces

2017-06-13 Thread Chris Dail (JIRA)
Chris Dail created FLINK-6911: - Summary: StatsD Metrics name should escape spaces Key: FLINK-6911 URL: https://issues.apache.org/jira/browse/FLINK-6911 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-6910) Metrics value for lastCheckpointExternalPath is not valid

2017-06-13 Thread Chris Dail (JIRA)
Chris Dail created FLINK-6910: - Summary: Metrics value for lastCheckpointExternalPath is not valid Key: FLINK-6910 URL: https://issues.apache.org/jira/browse/FLINK-6910 Project: Flink Issue

[jira] [Updated] (FLINK-6909) Flink should support Lombok POJO

2017-06-13 Thread Md Kamaruzzaman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Md Kamaruzzaman updated FLINK-6909: --- Fix Version/s: 1.2.1 > Flink should support Lombok POJO > >

[jira] [Created] (FLINK-6909) Flink should support Lombok POJO

2017-06-13 Thread Md Kamaruzzaman (JIRA)
Md Kamaruzzaman created FLINK-6909: -- Summary: Flink should support Lombok POJO Key: FLINK-6909 URL: https://issues.apache.org/jira/browse/FLINK-6909 Project: Flink Issue Type: Wish

[GitHub] flink pull request #4102: [FLINK-6886][table]Fix Timestamp field can not be ...

2017-06-13 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4102#discussion_r121694007 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -715,15 +715,8 @@ abstract class

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047963#comment-16047963 ] ASF GitHub Bot commented on FLINK-6886: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047962#comment-16047962 ] ASF GitHub Bot commented on FLINK-6886: --- Github user wuchong commented on a diff in the pull

[GitHub] flink issue #4102: [FLINK-6886][table]Fix Timestamp field can not be selecte...

2017-06-13 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4102 I think the root cause is that TUMBLE_START inherits the wrong type (`TimeIndicatorRelDataType`) from rowtime column. So maybe a better solution is to re-create a `RelDataType` from

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047912#comment-16047912 ] ASF GitHub Bot commented on FLINK-6788: --- Github user zentol commented on the issue:

[GitHub] flink issue #4118: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4118 +1 to merge :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047901#comment-16047901 ] ASF GitHub Bot commented on FLINK-6788: --- Github user wangmiao1981 commented on the issue:

[GitHub] flink issue #4118: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/flink/pull/4118 @zentol I opened a new PR as I really messed up the old one. Sorry for wasting your time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047900#comment-16047900 ] ASF GitHub Bot commented on FLINK-6788: --- GitHub user wangmiao1981 opened a pull request:

[GitHub] flink pull request #4118: [FLINK-6788]:Remove unused GenericFlatTypePostPass...

2017-06-13 Thread wangmiao1981
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/flink/pull/4118 [FLINK-6788]:Remove unused GenericFlatTypePostPass/AbstractSchema class Removed two unused classes by deleting corresponding files. Build Success. Run mvn clean verify Optimizer module

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047890#comment-16047890 ] ASF GitHub Bot commented on FLINK-6788: --- Github user wangmiao1981 commented on the issue:

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047891#comment-16047891 ] ASF GitHub Bot commented on FLINK-6788: --- Github user wangmiao1981 closed the pull request at:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/flink/pull/4106 It seems that I massed up this PR. Let me close it and resubmit a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass...

2017-06-13 Thread wangmiao1981
Github user wangmiao1981 closed the pull request at: https://github.com/apache/flink/pull/4106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047866#comment-16047866 ] ASF GitHub Bot commented on FLINK-6788: --- Github user zentol commented on the issue:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4106 well it's ok, but now you could just remove the first 2 commits in the branch. :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047854#comment-16047854 ] ASF GitHub Bot commented on FLINK-6788: --- Github user wangmiao1981 commented on the issue:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/flink/pull/4106 I did one revert and recommit. Is it acceptable now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047846#comment-16047846 ] ASF GitHub Bot commented on FLINK-6788: --- Github user zentol commented on the issue:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4106 You still have to re-create the commit so the settings are applied to it. I would do it like this: ``` git reset HEAD^ git add * git commit ``` --- If your project is set

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/flink/pull/4106 flink_ws_05_31 m.wang$ git config --list remote.origin.url=g...@github.com:wangmiao1981/flink.git remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047838#comment-16047838 ] ASF GitHub Bot commented on FLINK-6788: --- Github user wangmiao1981 commented on the issue:

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047829#comment-16047829 ] ASF GitHub Bot commented on FLINK-6788: --- Github user wangmiao1981 commented on the issue:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/flink/pull/4106 let me do one more thing to set git user and git email. Just a second. I am using a new laptop now :) Thanks! --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047821#comment-16047821 ] ASF GitHub Bot commented on FLINK-6788: --- Github user zentol commented on the issue:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4106 Much better. Are you aware that the commit will not be attributed to your github account (because the username/email aren't in sync between your local git and your account)? The changes

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047810#comment-16047810 ] ASF GitHub Bot commented on FLINK-6788: --- Github user wangmiao1981 commented on the issue:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/flink/pull/4106 @zentol Thanks for your time! It is strange that it includes a merge. Let me rebase my branch and push again. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047733#comment-16047733 ] ASF GitHub Bot commented on FLINK-6788: --- Github user zentol commented on the issue:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4106 We are aware that some tests are unstable; we don't need to re-run travis. Could you rework your branch so that it doesn't include a merge commit by re-basing it on-top of the current master?

[jira] [Closed] (FLINK-6859) StateCleaningCountTrigger should not delete timer

2017-06-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6859. --- Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 1.3:

[jira] [Reopened] (FLINK-6859) StateCleaningCountTrigger should not delete timer

2017-06-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-6859: - haven't merged it for 1.3 yet. > StateCleaningCountTrigger should not delete timer >

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047718#comment-16047718 ] ASF GitHub Bot commented on FLINK-6788: --- Github user wangmiao1981 commented on the issue:

[GitHub] flink issue #4106: [FLINK-6788]:Remove unused GenericFlatTypePostPass/Abstra...

2017-06-13 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/flink/pull/4106 retest please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Created] (FLINK-6908) start-cluster.sh accepts batch/streaming mode argument

2017-06-13 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6908: --- Summary: start-cluster.sh accepts batch/streaming mode argument Key: FLINK-6908 URL: https://issues.apache.org/jira/browse/FLINK-6908 Project: Flink

[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...

2017-06-13 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4074 @zentol Thanks a bunch for your review. I have updated the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-6488) Mark deprecated for 'start-local.sh' and 'stop-local' scripts

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047697#comment-16047697 ] ASF GitHub Bot commented on FLINK-6488: --- Github user zhangminglei commented on the issue:

[jira] [Updated] (FLINK-6488) Mark deprecated for 'start-local.sh' and 'stop-local' scripts

2017-06-13 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-6488: Summary: Mark deprecated for 'start-local.sh' and 'stop-local' scripts (was: Mark deprecated for

[jira] [Commented] (FLINK-6776) Use skip instead of seek for small forward repositioning in DFS streams

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047680#comment-16047680 ] ASF GitHub Bot commented on FLINK-6776: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #4019: [FLINK-6776] [runtime] Use skip instead of seek for small...

2017-06-13 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4019 Updated with comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink pull request #4019: [FLINK-6776] [runtime] Use skip instead of seek fo...

2017-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4019#discussion_r121632647 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java --- @@ -89,4 +99,14 @@ public long skip(long n)

[jira] [Commented] (FLINK-6776) Use skip instead of seek for small forward repositioning in DFS streams

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047664#comment-16047664 ] ASF GitHub Bot commented on FLINK-6776: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink issue #4108: [FLINK-6685] Adjust scopes of SafetyNetCloseableRegistry ...

2017-06-13 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4108 @tillrohrmann thanks for the review and the merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Resolved] (FLINK-6685) SafetyNetCloseableRegistry is closed prematurely in Task::triggerCheckpointBarrier

2017-06-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-6685. -- Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 1.4.0:

[jira] [Commented] (FLINK-6813) Add TIMESTAMPDIFF supported in SQL

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047658#comment-16047658 ] ASF GitHub Bot commented on FLINK-6813: --- GitHub user sunjincheng121 opened a pull request:

[GitHub] flink pull request #4108: [FLINK-6685] Adjust scopes of SafetyNetCloseableRe...

2017-06-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4117: [FLINK-6813][table]Add TIMESTAMPDIFF supported in ...

2017-06-13 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/4117 [FLINK-6813][table]Add TIMESTAMPDIFF supported in SQL In this PR. I have Add TIMESTAMPDIFF supported in SQL. 1. timestampDiff(unit, timestamp,timestamp) keep consistent with calcite.

[jira] [Commented] (FLINK-6776) Use skip instead of seek for small forward repositioning in DFS streams

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047654#comment-16047654 ] ASF GitHub Bot commented on FLINK-6776: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #4019: [FLINK-6776] [runtime] Use skip instead of seek fo...

2017-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4019#discussion_r121630151 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java --- @@ -31,11 +31,15 @@ */ public final

[jira] [Commented] (FLINK-6769) Replace usage of deprecated FileSystem#create(Path, boolean)

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047650#comment-16047650 ] ASF GitHub Bot commented on FLINK-6769: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #4116: [FLINK-6769] Replace usage of deprecated FileSyste...

2017-06-13 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4116 [FLINK-6769] Replace usage of deprecated FileSystem#create(Path, boolean) You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6769

[jira] [Commented] (FLINK-6776) Use skip instead of seek for small forward repositioning in DFS streams

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047644#comment-16047644 ] ASF GitHub Bot commented on FLINK-6776: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4019: [FLINK-6776] [runtime] Use skip instead of seek fo...

2017-06-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4019#discussion_r121627730 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java --- @@ -89,4 +99,14 @@ public long skip(long n)

[GitHub] flink pull request #4019: [FLINK-6776] [runtime] Use skip instead of seek fo...

2017-06-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4019#discussion_r121627538 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java --- @@ -31,11 +31,15 @@ */ public final

[GitHub] flink pull request #4019: [FLINK-6776] [runtime] Use skip instead of seek fo...

2017-06-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4019#discussion_r121627666 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java --- @@ -89,4 +99,14 @@ public long skip(long n)

[jira] [Commented] (FLINK-6776) Use skip instead of seek for small forward repositioning in DFS streams

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047668#comment-16047668 ] ASF GitHub Bot commented on FLINK-6776: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047634#comment-16047634 ] ASF GitHub Bot commented on FLINK-6888: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...

2017-06-13 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4105#discussion_r121625889 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -329,6 +337,41 @@ object

[GitHub] flink pull request #4019: [FLINK-6776] [runtime] Use skip instead of seek fo...

2017-06-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4019#discussion_r121631955 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java --- @@ -31,11 +31,15 @@ */ public final

[jira] [Commented] (FLINK-6685) SafetyNetCloseableRegistry is closed prematurely in Task::triggerCheckpointBarrier

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047661#comment-16047661 ] ASF GitHub Bot commented on FLINK-6685: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-6685) SafetyNetCloseableRegistry is closed prematurely in Task::triggerCheckpointBarrier

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047659#comment-16047659 ] ASF GitHub Bot commented on FLINK-6685: --- Github user asfgit closed the pull request at:

[jira] [Created] (FLINK-6907) Remove TupleGenerator in flink-java

2017-06-13 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6907: --- Summary: Remove TupleGenerator in flink-java Key: FLINK-6907 URL: https://issues.apache.org/jira/browse/FLINK-6907 Project: Flink Issue Type:

[GitHub] flink pull request #4115: [FLINK-6863] Remove batchdependency from streaming...

2017-06-13 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4115 [FLINK-6863] Remove batchdependency from streaming-examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6863 Alternatively you

[jira] [Resolved] (FLINK-6905) Support for zeroOrMore to CEP's pattern API

2017-06-13 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu resolved FLINK-6905. Resolution: Not A Problem Just found that this can be implemented with oneOrMore().optional(). > Support

[GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...

2017-06-13 Thread hustfxj
Github user hustfxj commented on a diff in the pull request: https://github.com/apache/flink/pull/4105#discussion_r121624773 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -329,6 +337,41 @@ object

[jira] [Commented] (FLINK-6776) Use skip instead of seek for small forward repositioning in DFS streams

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047643#comment-16047643 ] ASF GitHub Bot commented on FLINK-6776: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-6776) Use skip instead of seek for small forward repositioning in DFS streams

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047645#comment-16047645 ] ASF GitHub Bot commented on FLINK-6776: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-6863) Fully separate streaming examples

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047631#comment-16047631 ] ASF GitHub Bot commented on FLINK-6863: --- GitHub user zentol opened a pull request:

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047629#comment-16047629 ] ASF GitHub Bot commented on FLINK-6888: --- Github user hustfxj commented on a diff in the pull

[jira] [Comment Edited] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-06-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047627#comment-16047627 ] Chesnay Schepler edited comment on FLINK-6682 at 6/13/17 9:12 AM: -- It

[jira] [Commented] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-06-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047627#comment-16047627 ] Chesnay Schepler commented on FLINK-6682: - It should probably be moved to

[jira] [Commented] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-06-13 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047618#comment-16047618 ] mingleizhang commented on FLINK-6682: - Yes. [~Zentol] I know what you mean. It is really dont give any

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047614#comment-16047614 ] ASF GitHub Bot commented on FLINK-6865: --- Github user zentol commented on the issue:

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4086 I've updated the PR: - revert mentioning of strict checkstyle - include note about not adjusted star import settings - remove not about archetype modules as they are no longer valid

[jira] [Resolved] (FLINK-6744) Flaky ExecutionGraphSchedulingTest

2017-06-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-6744. -- Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 1.4.0:

[jira] [Commented] (FLINK-6744) Flaky ExecutionGraphSchedulingTest

2017-06-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047602#comment-16047602 ] Till Rohrmann commented on FLINK-6744: -- I think the reason for the flakey test is the too aggressive

[jira] [Assigned] (FLINK-6744) Flaky ExecutionGraphSchedulingTest

2017-06-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-6744: Assignee: Till Rohrmann > Flaky ExecutionGraphSchedulingTest >

[jira] [Commented] (FLINK-6901) Flip checkstyle configuration files

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047597#comment-16047597 ] ASF GitHub Bot commented on FLINK-6901: --- Github user zentol commented on the issue:

[GitHub] flink issue #4112: [FLINK-6901] Flip checkstyle configuration files

2017-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4112 I've adjusted the suppressions file to properly work on windows (slashes...), and resolves the few issues in flink-runtime. I'm a bit unsure about the change in the NettyBufferPool, @uce does

[jira] [Commented] (FLINK-6488) Mark deprecated for 'start-local.sh' script

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047594#comment-16047594 ] ASF GitHub Bot commented on FLINK-6488: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6488) Mark deprecated for 'start-local.sh' script

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047590#comment-16047590 ] ASF GitHub Bot commented on FLINK-6488: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6488) Mark deprecated for 'start-local.sh' script

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047592#comment-16047592 ] ASF GitHub Bot commented on FLINK-6488: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6488) Mark deprecated for 'start-local.sh' script

2017-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047593#comment-16047593 ] ASF GitHub Bot commented on FLINK-6488: --- Github user zentol commented on a diff in the pull request:

  1   2   >