[jira] [Commented] (FLINK-4423) Introduce a Clock utility for monotonous system timestamps

2017-07-20 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095743#comment-16095743 ] mingleizhang commented on FLINK-4423: - [~StephanEwen] This is a very interesting topic indeed . One

[jira] [Issue Comment Deleted] (FLINK-4421) Make clocks and time measurements monotonous

2017-07-20 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-4421: Comment: was deleted (was: Hi, [~StephanEwen]. Thanks for reporting this. I would like to know,

[jira] [Comment Edited] (FLINK-4421) Make clocks and time measurements monotonous

2017-07-20 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095699#comment-16095699 ] mingleizhang edited comment on FLINK-4421 at 7/21/17 2:46 AM: -- Hi,

[jira] [Commented] (FLINK-4421) Make clocks and time measurements monotonous

2017-07-20 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095699#comment-16095699 ] mingleizhang commented on FLINK-4421: - Hi, Stephan. Thanks for reporting this. I would like to know,

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095610#comment-16095610 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095608#comment-16095608 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095605#comment-16095605 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #4379: [FLINK-7194] [table] Add methods for type hints to...

2017-07-20 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4379#discussion_r128660377 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala --- @@ -80,11 +80,11 @@

[GitHub] flink pull request #4379: [FLINK-7194] [table] Add methods for type hints to...

2017-07-20 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4379#discussion_r128659642 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala --- @@ -17,6 +17,8 @@ */

[GitHub] flink pull request #4379: [FLINK-7194] [table] Add methods for type hints to...

2017-07-20 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4379#discussion_r128662028 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -314,7 +314,28 @@

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095607#comment-16095607 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095606#comment-16095606 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095609#comment-16095609 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #4379: [FLINK-7194] [table] Add methods for type hints to...

2017-07-20 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4379#discussion_r128658352 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumWithRetractAggFunction.scala --- @@ -191,10

[GitHub] flink pull request #4379: [FLINK-7194] [table] Add methods for type hints to...

2017-07-20 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4379#discussion_r128658053 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala --- @@ -136,8 +137,26 @@ abstract

[GitHub] flink pull request #4379: [FLINK-7194] [table] Add methods for type hints to...

2017-07-20 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4379#discussion_r128657888 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala --- @@ -136,8 +137,26 @@ abstract

[GitHub] flink issue #4365: [FLINK-6747] [docs] Add documentation for dynamic tables.

2017-07-20 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4365 Hi @fhueske Thanks for the update. The PR. looks pretty good to me. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-6747) Table API / SQL Docs: Streaming Page

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095571#comment-16095571 ] ASF GitHub Bot commented on FLINK-6747: --- Github user sunjincheng121 commented on the issue:

[jira] [Commented] (FLINK-6747) Table API / SQL Docs: Streaming Page

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095567#comment-16095567 ] ASF GitHub Bot commented on FLINK-6747: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #4365: [FLINK-6747] [docs] Add documentation for dynamic ...

2017-07-20 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4365#discussion_r128656745 --- Diff: docs/dev/table/streaming.md --- @@ -22,21 +22,166 @@ specific language governing permissions and limitations under the License.

[jira] [Commented] (FLINK-6333) Utilize Bloomfilters in RocksDb

2017-07-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095490#comment-16095490 ] Ted Yu commented on FLINK-6333: --- Looks like rocksdb issue 1964 can be closed. > Utilize Bloomfilters in

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095481#comment-16095481 ] ASF GitHub Bot commented on FLINK-6998: --- Github user zhenzhongxu commented on the issue:

[GitHub] flink issue #4187: [FLINK-6998][Kafka Connector] Add kafka offset commit met...

2017-07-20 Thread zhenzhongxu
Github user zhenzhongxu commented on the issue: https://github.com/apache/flink/pull/4187 @tzulitai all tests passing now. let me know if this looks ok now, also let me know if you want me to go ahead squash all commits. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-5987) Upgrade zookeeper dependency to 3.4.10

2017-07-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095475#comment-16095475 ] Ted Yu commented on FLINK-5987: --- lgtm > Upgrade zookeeper dependency to 3.4.10 >

[jira] [Updated] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2017-07-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-4534: -- Description: Iteration over state.bucketStates is protected by synchronization in other methods, except for

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095464#comment-16095464 ] ASF GitHub Bot commented on FLINK-7143: --- Github user stevenzwu commented on a diff in the pull

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-20 Thread stevenzwu
Github user stevenzwu commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128642917 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-20 Thread stevenzwu
Github user stevenzwu commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128642186 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095460#comment-16095460 ] ASF GitHub Bot commented on FLINK-7143: --- Github user stevenzwu commented on a diff in the pull

[jira] [Created] (FLINK-7240) Externalized RocksDB can fail with stackoverflow

2017-07-20 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-7240: --- Summary: Externalized RocksDB can fail with stackoverflow Key: FLINK-7240 URL: https://issues.apache.org/jira/browse/FLINK-7240 Project: Flink Issue

[jira] [Commented] (FLINK-7176) Failed builds (due to compilation) don't upload logs

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095042#comment-16095042 ] ASF GitHub Bot commented on FLINK-7176: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4330: [FLINK-7176] [travis] Improve error handling

2017-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7176) Failed builds (due to compilation) don't upload logs

2017-07-20 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095041#comment-16095041 ] Chesnay Schepler commented on FLINK-7176: - 1.4: b3b35dbf5271dc8a64b06a575d3a8ed37df4ef35 > Failed

[jira] [Commented] (FLINK-4474) Add docs about Testing & Test Utilities

2017-07-20 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094948#comment-16094948 ] Elias Levy commented on FLINK-4474: --- Reupping this issue. There is a need for a section in the

[jira] [Commented] (FLINK-6747) Table API / SQL Docs: Streaming Page

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094933#comment-16094933 ] ASF GitHub Bot commented on FLINK-6747: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4365: [FLINK-6747] [docs] Add documentation for dynamic tables.

2017-07-20 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4365 Thanks for the feedback @sunjincheng121. I updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-6747) Table API / SQL Docs: Streaming Page

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094932#comment-16094932 ] ASF GitHub Bot commented on FLINK-6747: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4365: [FLINK-6747] [docs] Add documentation for dynamic ...

2017-07-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4365#discussion_r128566720 --- Diff: docs/dev/table/streaming.md --- @@ -22,21 +22,166 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-7221) JDBCOutputFormat swallows errors on last batch

2017-07-20 Thread Ken Geis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094924#comment-16094924 ] Ken Geis commented on FLINK-7221: - [~fhueske], I'd be glad to submit a patch. I'm currently on vacation,

[GitHub] flink issue #4380: Time sort with offset/fetch without retraction

2017-07-20 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4380 Hi @rtudoran, thanks for updating the PR. I had a brief look at it and as I said before, I don't think we need additional ProcessFunctions for any of the `ORDER BY *time ASC OFFSET x FETCH

[jira] [Commented] (FLINK-7174) Bump dependency of Kafka 0.10.x to the latest one

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094892#comment-16094892 ] ASF GitHub Bot commented on FLINK-7174: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4321: [FLINK-7174] Bump Kafka 0.10 dependency to 0.10.2.1

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4321 This patch looks good. As a minor comment: I would prefer to not have `hasAssignedPartitions` as a field, but rather return it from the `reassignPartitions()` method and have it only as

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-07-20 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094859#comment-16094859 ] Fabian Hueske commented on FLINK-6233: -- # You shouldn't need to do anything. Both {{ltime}} and

[jira] [Commented] (FLINK-6075) ORDER BY *time ASC

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094855#comment-16094855 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran closed the pull request at:

[jira] [Commented] (FLINK-6075) ORDER BY *time ASC

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094854#comment-16094854 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran commented on the issue:

[GitHub] flink pull request #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-07-20 Thread rtudoran
Github user rtudoran closed the pull request at: https://github.com/apache/flink/pull/4263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-07-20 Thread rtudoran
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/4263 @fhueske ,@wuchong I am closing this PR as i opened a new one for offset/fetch without retraction Check #4380 --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #4380: Time sort with offset/fetch without retraction

2017-07-20 Thread rtudoran
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/4380 @fhueske ,@wuchong As mentioned in PR #4263 I re-implemented the offset/fetch support for *time without retraction. You can find things in this PR. In principle things should be easy to follow

[GitHub] flink pull request #4380: Time sort with offset/fetch without retraction

2017-07-20 Thread rtudoran
GitHub user rtudoran opened a pull request: https://github.com/apache/flink/pull/4380 Time sort with offset/fetch without retraction Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #4379: [FLINK-7194] [table] Add methods for type hints to...

2017-07-20 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/4379 [FLINK-7194] [table] Add methods for type hints to UDAGG interface. - [X] General - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text") - The pull request

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094838#comment-16094838 ] ASF GitHub Bot commented on FLINK-7194: --- GitHub user fhueske opened a pull request:

[jira] [Commented] (FLINK-7174) Bump dependency of Kafka 0.10.x to the latest one

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094820#comment-16094820 ] ASF GitHub Bot commented on FLINK-7174: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4321: [FLINK-7174] Bump Kafka 0.10 dependency to 0.10.2.1

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4321 I think the new pull request description template would have been awesome here ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #4015: [FLINK-6301] [flink-connector-kafka-0.10] Upgrading Kafka...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4015 Thank you, @vidhu5269 for diagnosing that and suggesting this fix. Like @tzulitai mentioned, we need to adjust some more Flink code to be able to use the new Kafka version

[jira] [Commented] (FLINK-6301) Flink KafkaConnector09 leaks memory on reading compressed messages due to a Kafka consumer bug

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094796#comment-16094796 ] ASF GitHub Bot commented on FLINK-6301: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-07-20 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094719#comment-16094719 ] Xingcan Cui commented on FLINK-6233: [~fhueske], thanks for the explanation. It' quite clear. There's

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094698#comment-16094698 ] ASF GitHub Bot commented on FLINK-7216: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4364: [FLINK-7216] [distr. coordination] Guard against concurre...

2017-07-20 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4364 +1 for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094694#comment-16094694 ] ASF GitHub Bot commented on FLINK-7216: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4364: [FLINK-7216] [distr. coordination] Guard against c...

2017-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4364#discussion_r128515844 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategyTest.java --- @@ -0,0 +1,128 @@ +/*

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094691#comment-16094691 ] ASF GitHub Bot commented on FLINK-7216: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-7231) SlotSharingGroups are not always released in time for new restarts

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094693#comment-16094693 ] ASF GitHub Bot commented on FLINK-7231: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4370: [FLINK-7231] [distr. coordination] Fix slot release affec...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4370 Thanks for the review! Merging this... The commit by Niko was probably because github was slightly out of sync with the apache git repo and thought that commit was part of the

[GitHub] flink pull request #4364: [FLINK-7216] [distr. coordination] Guard against c...

2017-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4364#discussion_r128515593 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java --- @@ -581,6 +565,106 @@ public void

[jira] [Commented] (FLINK-7231) SlotSharingGroups are not always released in time for new restarts

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094688#comment-16094688 ] ASF GitHub Bot commented on FLINK-7231: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #4370: [FLINK-7231] [distr. coordination] Fix slot releas...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4370#discussion_r128514948 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java --- @@ -661,10 +682,117 @@ public void

[jira] [Commented] (FLINK-7234) Fix CombineHint documentation

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094683#comment-16094683 ] ASF GitHub Bot commented on FLINK-7234: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4372 Thanks for trying out the discussed template @greghogan I think for docs, you can invoke the *(The sections below can be removed for hotfixes of typos)* clause ;-) --- If your project

[jira] [Commented] (FLINK-6747) Table API / SQL Docs: Streaming Page

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094681#comment-16094681 ] ASF GitHub Bot commented on FLINK-6747: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4365: [FLINK-6747] [docs] Add documentation for dynamic ...

2017-07-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4365#discussion_r128513830 --- Diff: docs/dev/table/streaming.md --- @@ -22,21 +22,166 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094678#comment-16094678 ] ASF GitHub Bot commented on FLINK-7216: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094676#comment-16094676 ] ASF GitHub Bot commented on FLINK-7216: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink issue #4364: [FLINK-7216] [distr. coordination] Guard against concurre...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4364 Thanks for the reviews. Addressing the comments, rerunning tests, and merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request #4364: [FLINK-7216] [distr. coordination] Guard against c...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4364#discussion_r128512830 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java --- @@ -189,6 +189,35 @@ public static void

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094670#comment-16094670 ] ASF GitHub Bot commented on FLINK-7216: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #4364: [FLINK-7216] [distr. coordination] Guard against c...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4364#discussion_r128512192 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategyTest.java --- @@ -0,0 +1,128 @@ +/*

[jira] [Commented] (FLINK-6747) Table API / SQL Docs: Streaming Page

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094669#comment-16094669 ] ASF GitHub Bot commented on FLINK-6747: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094668#comment-16094668 ] ASF GitHub Bot commented on FLINK-7216: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #4365: [FLINK-6747] [docs] Add documentation for dynamic ...

2017-07-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4365#discussion_r128512155 --- Diff: docs/dev/table/streaming.md --- @@ -22,21 +22,166 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request #4364: [FLINK-7216] [distr. coordination] Guard against c...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4364#discussion_r128511963 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java --- @@ -581,6 +565,106 @@ public void

[GitHub] flink pull request #4364: [FLINK-7216] [distr. coordination] Guard against c...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4364#discussion_r128510738 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java --- @@ -581,6 +565,106 @@ public void

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094663#comment-16094663 ] ASF GitHub Bot commented on FLINK-7216: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094653#comment-16094653 ] ASF GitHub Bot commented on FLINK-7216: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #4364: [FLINK-7216] [distr. coordination] Guard against c...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4364#discussion_r128509863 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java --- @@ -581,6 +565,106 @@ public void

[jira] [Commented] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094654#comment-16094654 ] ASF GitHub Bot commented on FLINK-7216: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #4364: [FLINK-7216] [distr. coordination] Guard against c...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4364#discussion_r128509787 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java --- @@ -159,34 +161,6 @@ public void

[jira] [Closed] (FLINK-7233) TaskManagerHeapSizeCalculationJavaBashTest failed on Travis

2017-07-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-7233. --- > TaskManagerHeapSizeCalculationJavaBashTest failed on Travis >

[jira] [Resolved] (FLINK-7233) TaskManagerHeapSizeCalculationJavaBashTest failed on Travis

2017-07-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-7233. - Resolution: Fixed Assignee: Nico Kruber Fix Version/s: 1.3.2

[jira] [Commented] (FLINK-7233) TaskManagerHeapSizeCalculationJavaBashTest failed on Travis

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094652#comment-16094652 ] ASF GitHub Bot commented on FLINK-7233: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4378: [FLINK-7233][tests] fix instable TaskManagerHeapSi...

2017-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-07-20 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094649#comment-16094649 ] Fabian Hueske commented on FLINK-6233: -- Hi, let me answer your questions: # That is correct.

[jira] [Closed] (FLINK-6654) missing maven dependency on "flink-shaded-hadoop2-uber" in flink-dist

2017-07-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-6654. --- > missing maven dependency on "flink-shaded-hadoop2-uber" in flink-dist >

[jira] [Resolved] (FLINK-6654) missing maven dependency on "flink-shaded-hadoop2-uber" in flink-dist

2017-07-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-6654. - Resolution: Fixed Fix Version/s: 1.3.2 Release Note: Fixed in - 1.3.2 via

[jira] [Commented] (FLINK-6654) missing maven dependency on "flink-shaded-hadoop2-uber" in flink-dist

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094635#comment-16094635 ] ASF GitHub Bot commented on FLINK-6654: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3960: [FLINK-6654][build] let 'flink-dist' properly depe...

2017-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-07-20 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094634#comment-16094634 ] Xingcan Cui commented on FLINK-6233: Hi [~fhueske], thanks for sharing. I totally agree to your first

[GitHub] flink pull request #:

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/d2a68f0edfd58c182480f0457755b0ddd66c2c76#commitcomment-23203221 In flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java: In

[jira] [Commented] (FLINK-7233) TaskManagerHeapSizeCalculationJavaBashTest failed on Travis

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094627#comment-16094627 ] ASF GitHub Bot commented on FLINK-7233: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4378: [FLINK-7233][tests] fix instable TaskManagerHeapSizeCalcu...

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4378 Good fix! Merging to `master` and `release-1.3`... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-07-20 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r128499164 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -535,4 +654,21 @@ object

  1   2   >