[jira] [Commented] (FLINK-7394) Implement basic InputChannel for credit-based logic

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171117#comment-16171117 ] ASF GitHub Bot commented on FLINK-7394: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4499: [FLINK-7394][core] Implement basic InputChannel for credi...

2017-09-18 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4499 @NicoK , I have submitted the updates based on the latest first PR. And this PR only concerns about the exclusive buffers management. I would submit the other issues in separate PRs later. ---

[jira] [Commented] (FLINK-7394) Implement basic InputChannel for credit-based logic

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171114#comment-16171114 ] ASF GitHub Bot commented on FLINK-7394: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-18 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r139596400 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -183,18 +214,40 @@ void notify

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171072#comment-16171072 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139591493 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/RowTimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,83 @@ +/*

[jira] [Created] (FLINK-7642) Upgrade maven surefire plugin to 2.19.1

2017-09-18 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7642: - Summary: Upgrade maven surefire plugin to 2.19.1 Key: FLINK-7642 URL: https://issues.apache.org/jira/browse/FLINK-7642 Project: Flink Issue Type: Improvement R

[jira] [Commented] (FLINK-7394) Implement basic InputChannel for credit-based logic

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171068#comment-16171068 ] ASF GitHub Bot commented on FLINK-7394: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-18 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r139590215 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -100,7 +122,16 @@ public Remot

[jira] [Commented] (FLINK-7635) support sideOutput in ProcessWindowFunciton & ProcessAllWindowFunction

2017-09-18 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171061#comment-16171061 ] Bowen Li commented on FLINK-7635: - [~foxss] Thank you very much for pointing out the direc

[jira] [Commented] (FLINK-7394) Implement basic InputChannel for credit-based logic

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171059#comment-16171059 ] ASF GitHub Bot commented on FLINK-7394: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-18 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r139589040 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -72,6 +79,21 @@ */

[jira] [Commented] (FLINK-7620) Supports user defined optimization phase

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171028#comment-16171028 ] ASF GitHub Bot commented on FLINK-7620: --- GitHub user godfreyhe opened a pull request

[GitHub] flink pull request #4682: [FLINK-7620] [table] Supports user defined optimiz...

2017-09-18 Thread godfreyhe
GitHub user godfreyhe opened a pull request: https://github.com/apache/flink/pull/4682 [FLINK-7620] [table] Supports user defined optimization phase ## What is the purpose of the change *This pull request makes Flink supports user defined optimization phase. before this PR,

[jira] [Commented] (FLINK-7636) Introduce Flink RelOptTable, and remove tableSource from all TableSourceScan node constructor

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171024#comment-16171024 ] ASF GitHub Bot commented on FLINK-7636: --- GitHub user beyond1920 opened a pull reques

[GitHub] flink pull request #4681: [FLINK-7636][Table API & SQL]Introduce Flink RelOp...

2017-09-18 Thread beyond1920
GitHub user beyond1920 opened a pull request: https://github.com/apache/flink/pull/4681 [FLINK-7636][Table API & SQL]Introduce Flink RelOptTable, and remove tableSource from all TableSourceScan node constructor ## What is the purpose of the change There are two ways to fetc

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171021#comment-16171021 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139585456 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,74 @@ +/*

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139580604 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -130,6 +130,72 @@ abstract class Str

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171012#comment-16171012 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171013#comment-16171013 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on a diff

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139582270 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala --- @@ -762,13 +763,10 @@ class Table( * @tparam T

[jira] [Created] (FLINK-7641) Loss of JobManager in HA mode should not cause jobs to fail

2017-09-18 Thread Elias Levy (JIRA)
Elias Levy created FLINK-7641: - Summary: Loss of JobManager in HA mode should not cause jobs to fail Key: FLINK-7641 URL: https://issues.apache.org/jira/browse/FLINK-7641 Project: Flink Issue Ty

[jira] [Created] (FLINK-7640) Dashboard should display information about JobManager cluster in HA mode

2017-09-18 Thread Elias Levy (JIRA)
Elias Levy created FLINK-7640: - Summary: Dashboard should display information about JobManager cluster in HA mode Key: FLINK-7640 URL: https://issues.apache.org/jira/browse/FLINK-7640 Project: Flink

[jira] [Commented] (FLINK-7635) support sideOutput in ProcessWindowFunciton & ProcessAllWindowFunction

2017-09-18 Thread Chen Qin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170922#comment-16170922 ] Chen Qin commented on FLINK-7635: - [~phoenixjiangnan] there are good reference in PorcessF

[jira] [Assigned] (FLINK-7635) support sideOutput in ProcessWindowFunciton & ProcessAllWindowFunction

2017-09-18 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-7635: --- Assignee: Bowen Li > support sideOutput in ProcessWindowFunciton & ProcessAllWindowFunction > ---

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-18 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r139553991 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -106,8 +240,191

[jira] [Commented] (FLINK-6563) Expose time indicator attributes in the KafkaTableSource

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170804#comment-16170804 ] ASF GitHub Bot commented on FLINK-6563: --- Github user haohui commented on a diff in t

[jira] [Closed] (FLINK-7639) TaskExecutorITCase is flakey

2017-09-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7639. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via b23c37eef04ee00b93eeebc2c70b7740caf303cb >

[jira] [Created] (FLINK-7639) TaskExecutorITCase is flakey

2017-09-18 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7639: Summary: TaskExecutorITCase is flakey Key: FLINK-7639 URL: https://issues.apache.org/jira/browse/FLINK-7639 Project: Flink Issue Type: Bug Componen

[jira] [Commented] (FLINK-7580) Let LeaderGatewayRetriever implementations automatically retry failed gateway retrieval operations

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170730#comment-16170730 ] ASF GitHub Bot commented on FLINK-7580: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4643: [FLINK-7580] Automatically retry failed gateway re...

2017-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4643 ---

[jira] [Closed] (FLINK-7580) Let LeaderGatewayRetriever implementations automatically retry failed gateway retrieval operations

2017-09-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7580. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via 51d9a748d40f29b197b2d77fe8aa1b2439737da3 >

[jira] [Commented] (FLINK-7533) Retry failed gateway retrievals in the LeaderGatewayRetriever

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170727#comment-16170727 ] ASF GitHub Bot commented on FLINK-7533: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4602: [FLINK-7533] Let LeaderGatewayRetriever retry fail...

2017-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4602 ---

[jira] [Closed] (FLINK-7533) Retry failed gateway retrievals in the LeaderGatewayRetriever

2017-09-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7533. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via 51b48f33bb68014663d74548467ed88afd3bb3a3 >

[jira] [Commented] (FLINK-7533) Retry failed gateway retrievals in the LeaderGatewayRetriever

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170721#comment-16170721 ] ASF GitHub Bot commented on FLINK-7533: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4602: [FLINK-7533] Let LeaderGatewayRetriever retry fail...

2017-09-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4602#discussion_r139540782 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebHandler.java --- @@ -0,0 +1,32 @@ +/* + * Licensed to the Apac

[GitHub] flink pull request #4602: [FLINK-7533] Let LeaderGatewayRetriever retry fail...

2017-09-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4602#discussion_r139539960 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -137,7 +138,6 @@ public TaskMa

[jira] [Commented] (FLINK-7533) Retry failed gateway retrievals in the LeaderGatewayRetriever

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170716#comment-16170716 ] ASF GitHub Bot commented on FLINK-7533: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7533) Retry failed gateway retrievals in the LeaderGatewayRetriever

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170714#comment-16170714 ] ASF GitHub Bot commented on FLINK-7533: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4602: [FLINK-7533] Let LeaderGatewayRetriever retry fail...

2017-09-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4602#discussion_r139539778 --- Diff: flink-core/src/main/java/org/apache/flink/util/OptionalConsumer.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (FLINK-7459) Introduce RedirectHandler for the WebRuntimeMonitor

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170711#comment-16170711 ] ASF GitHub Bot commented on FLINK-7459: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4551: [FLINK-7459] Generalize Flink's redirection logic

2017-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4551 ---

[jira] [Closed] (FLINK-7459) Introduce RedirectHandler for the WebRuntimeMonitor

2017-09-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7459. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via 41dba8bb71fd615bcab219a48708fb2b9c4762be >

[jira] [Commented] (FLINK-7458) Generalize GatewayRetriever for WebRuntimeMonitor

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170709#comment-16170709 ] ASF GitHub Bot commented on FLINK-7458: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-7458) Generalize GatewayRetriever for WebRuntimeMonitor

2017-09-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7458. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via 6ad0d3519585a825499245493f4bc77dac77d439 >

[GitHub] flink pull request #4549: [FLINK-7458] Generalize GatewayRetriever for WebRu...

2017-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4549 ---

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170676#comment-16170676 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170687#comment-16170687 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170685#comment-16170685 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170672#comment-16170672 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170693#comment-16170693 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170674#comment-16170674 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170680#comment-16170680 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170690#comment-16170690 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170694#comment-16170694 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170671#comment-16170671 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170688#comment-16170688 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170692#comment-16170692 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170670#comment-16170670 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170681#comment-16170681 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170683#comment-16170683 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170673#comment-16170673 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170679#comment-16170679 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170684#comment-16170684 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170669#comment-16170669 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170682#comment-16170682 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170691#comment-16170691 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170678#comment-16170678 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170675#comment-16170675 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170686#comment-16170686 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170677#comment-16170677 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170689#comment-16170689 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139525613 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -502,23 +521,130 @@ abstract class TableEnviro

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139525263 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -502,23 +521,130 @@ abstract class TableEnviro

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139530317 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala --- @@ -800,6 +798,68 @@ class Table( } /**

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139470670 --- Diff: docs/dev/table/common.md --- @@ -458,7 +595,7 @@ Table API and SQL queries are translated into [DataStream]({{ site.baseurl }}/de A Tabl

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139468211 --- Diff: docs/dev/table/common.md --- @@ -387,6 +433,59 @@ Table revenue = tableEnv.sql(""" +The following example shows how to specify

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139466642 --- Diff: docs/dev/table/common.md --- @@ -236,6 +236,52 @@ tableEnv.registerTableSource("CsvTable", csvSource) {% top %} +### Register a

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139472344 --- Diff: docs/dev/table/sql.md --- @@ -169,6 +202,37 @@ Flink SQL uses a lexical policy for identifier (table, attribute, function names Operations

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139522124 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -106,6 +106,56 @@ abstract class BatchTab

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139470224 --- Diff: docs/dev/table/common.md --- @@ -407,6 +506,14 @@ A batch `Table` can only be written to a `BatchTableSink`, while a streaming tab Pleas

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139471847 --- Diff: docs/dev/table/sql.md --- @@ -89,15 +117,16 @@ val result2 = tableEnv.sql( Supported Syntax -Flink parses SQL u

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139471292 --- Diff: docs/dev/table/sql.md --- @@ -49,15 +49,29 @@ DataStream> ds = env.addSource(...); // SQL query with an inlined (unregistered) table

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139526993 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -502,23 +521,130 @@ abstract class TableEnviro

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139468366 --- Diff: docs/dev/table/common.md --- @@ -387,6 +433,59 @@ Table revenue = tableEnv.sql(""" +The following example shows how to specify

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139529093 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -554,10 +680,14 @@ abstract class TableEnviron

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139471593 --- Diff: docs/dev/table/sql.md --- @@ -71,15 +85,29 @@ val ds: DataStream[(Long, String, Integer)] = env.addSource(...) // SQL query with an inli

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139471468 --- Diff: docs/dev/table/common.md --- @@ -387,6 +433,59 @@ Table revenue = tableEnv.sql(""" +The following example shows how to specify

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139530556 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkPlannerImpl.scala --- @@ -85,16 +84,15 @@ class FlinkPlannerImpl(

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139472638 --- Diff: docs/dev/table/tableApi.md --- @@ -146,6 +146,39 @@ Operations The Table API supports the following operations. Please note that not all

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139529681 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala --- @@ -762,13 +763,10 @@ class Table( * @tparam T The

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139524452 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -502,23 +521,130 @@ abstract class TableEnviro

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139526149 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -502,23 +521,130 @@ abstract class TableEnviro

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139473008 --- Diff: docs/dev/table/tableApi.md --- @@ -146,6 +146,39 @@ Operations The Table API supports the following operations. Please note that not all

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139473338 --- Diff: docs/dev/table/sql.md --- @@ -169,6 +202,37 @@ Flink SQL uses a lexical policy for identifier (table, attribute, function names Operations

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139470942 --- Diff: docs/dev/table/sql.md --- @@ -49,15 +49,29 @@ DataStream> ds = env.addSource(...); // SQL query with an inlined (unregistered) table

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139468885 --- Diff: docs/dev/table/common.md --- @@ -407,6 +506,14 @@ A batch `Table` can only be written to a `BatchTableSink`, while a streaming tab Pleas

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r139524209 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -502,23 +521,130 @@ abstract class TableEnviro

  1   2   3   >