[jira] [Commented] (FLINK-7788) Allow port range for queryable state client proxy.

2017-10-17 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208891#comment-16208891 ] Kostas Kloudas commented on FLINK-7788: --- Merged at 5338f856b42422189246130cc24575416

[jira] [Closed] (FLINK-7788) Allow port range for queryable state client proxy.

2017-10-17 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-7788. - Resolution: Fixed > Allow port range for queryable state client proxy. > -

[jira] [Commented] (FLINK-5920) Make port (range) of queryable state server configurable

2017-10-17 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208890#comment-16208890 ] Kostas Kloudas commented on FLINK-5920: --- Merged at 717a7dc81d066dc7d6e1a17099c0f5e1b

[jira] [Closed] (FLINK-5920) Make port (range) of queryable state server configurable

2017-10-17 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-5920. - Resolution: Fixed > Make port (range) of queryable state server configurable > ---

[GitHub] flink pull request #4814: [FLINK-5920][FLINK-7788][QS] Allow to specify a ra...

2017-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4814 ---

[jira] [Commented] (FLINK-5920) Make port (range) of queryable state server configurable

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1620#comment-1620 ] ASF GitHub Bot commented on FLINK-5920: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4838: [FLINK-7826][QS] Add support for all types of stat...

2017-10-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4838#discussion_r145326904 --- Diff: flink-queryable-state/flink-queryable-state-java/src/test/java/org/apache/flink/queryablestate/state/ImmutableAggregatingStateTest.java --- @@ -0

[jira] [Commented] (FLINK-7826) Add support for all types of state to the QueryableStateClient.

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208876#comment-16208876 ] ASF GitHub Bot commented on FLINK-7826: --- Github user aljoscha commented on a diff in

[jira] [Commented] (FLINK-5920) Make port (range) of queryable state server configurable

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208871#comment-16208871 ] ASF GitHub Bot commented on FLINK-5920: --- Github user aljoscha commented on the issue

[GitHub] flink issue #4814: [FLINK-5920][FLINK-7788][QS] Allow to specify a range of ...

2017-10-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4814 The changes look good! Could you please merge this as soon as possible, we're in a bit of a hurry with the release. 😅 ---

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208868#comment-16208868 ] ASF GitHub Bot commented on FLINK-7076: --- Github user suez1224 commented on a diff in

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145325673 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile reso

[jira] [Created] (FLINK-7864) Support side-outputs in CoProcessFunction

2017-10-17 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-7864: --- Summary: Support side-outputs in CoProcessFunction Key: FLINK-7864 URL: https://issues.apache.org/jira/browse/FLINK-7864 Project: Flink Issue Type: Imp

[jira] [Commented] (FLINK-7703) Port JobExceptionsHandler to new REST endpoint

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208814#comment-16208814 ] ASF GitHub Bot commented on FLINK-7703: --- Github user zjureel commented on the issue:

[GitHub] flink issue #4843: [FLINK-7703] Port JobExceptionsHandler to new REST endpoi...

2017-10-17 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4843 @zentol Thank you for your review. I think you're right about ExecutionExceptionsInfo and JobExceptionsInfo, and I have fixed them already. THX ---

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208693#comment-16208693 ] ASF GitHub Bot commented on FLINK-7853: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145299001 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CorrelateITCase.scala --- @@ -82,6 +82,45 @@ class CorrelateI

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208686#comment-16208686 ] ASF GitHub Bot commented on FLINK-7853: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145298482 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CorrelateITCase.scala --- @@ -82,6 +82,42 @@ class CorrelateIT

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208674#comment-16208674 ] ASF GitHub Bot commented on FLINK-7608: --- Github user yew1eb commented on a diff in t

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145295629 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogram.java --- @@ -0,0 +1,51 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208661#comment-16208661 ] ASF GitHub Bot commented on FLINK-7608: --- Github user yew1eb commented on a diff in t

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145294253 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogramStatistics.java --- @@ -0,0 +1,71 @@ +/* + * Lic

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208657#comment-16208657 ] ASF GitHub Bot commented on FLINK-7608: --- Github user yew1eb commented on a diff in t

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145293354 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogramStatistics.java --- @@ -0,0 +1,71 @@ +/* + * Lic

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145293108 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogram.java --- @@ -0,0 +1,51 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208656#comment-16208656 ] ASF GitHub Bot commented on FLINK-7608: --- Github user yew1eb commented on a diff in t

[GitHub] flink issue #4661: [FLINK-4831][metrics] Implement a slf4j metric reporter

2017-10-17 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4661 CC @zentol ---

[jira] [Commented] (FLINK-4831) Implement a slf4j metric reporter

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208652#comment-16208652 ] ASF GitHub Bot commented on FLINK-4831: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #4794: [build][minor] Add missing licenses

2017-10-17 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4794 @StephanEwen, I see, we need a script to automatically check the headers licenses. I will think about how to implement this script... ---

[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208645#comment-16208645 ] ASF GitHub Bot commented on FLINK-7758: --- Github user yew1eb commented on a diff in t

[GitHub] flink pull request #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4769#discussion_r143331183 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java --- @@ -543,6

[jira] [Commented] (FLINK-7843) Improve and enhance documentation for system metrics

2017-10-17 Thread Hai Zhou UTC+8 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208643#comment-16208643 ] Hai Zhou UTC+8 commented on FLINK-7843: --- Hi [~Zentol], what do you think about this

[jira] [Commented] (FLINK-7737) On HCFS systems, FSDataOutputStream does not issue hsync only hflush which leads to data loss

2017-10-17 Thread Vijay Srinivasaraghavan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208634#comment-16208634 ] Vijay Srinivasaraghavan commented on FLINK-7737: I am trying to understand

[jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208539#comment-16208539 ] ASF GitHub Bot commented on FLINK-7854: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208537#comment-16208537 ] ASF GitHub Bot commented on FLINK-7854: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208540#comment-16208540 ] ASF GitHub Bot commented on FLINK-7854: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208538#comment-16208538 ] ASF GitHub Bot commented on FLINK-7854: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4846: [FLINK-7854] [table] Reject lateral table outer jo...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4846#discussion_r145277609 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkCalciteSqlValidator.scala --- @@ -48,4 +49,19 @@ class FlinkCalcite

[GitHub] flink pull request #4846: [FLINK-7854] [table] Reject lateral table outer jo...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4846#discussion_r145268283 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CorrelateTest.scala --- @@ -75,20 +76,29 @@ class CorrelateTest e

[GitHub] flink pull request #4846: [FLINK-7854] [table] Reject lateral table outer jo...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4846#discussion_r145267860 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/CorrelateTest.scala --- @@ -102,6 +107,23 @@ class CorrelateTest e

[GitHub] flink pull request #4846: [FLINK-7854] [table] Reject lateral table outer jo...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4846#discussion_r145268307 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CorrelateTest.scala --- @@ -102,6 +112,22 @@ class CorrelateTest

[jira] [Commented] (FLINK-2976) Save and load checkpoints manually

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208503#comment-16208503 ] ASF GitHub Bot commented on FLINK-2976: --- Github user coveralls commented on the issu

[GitHub] flink issue #1434: [FLINK-2976] Allow to trigger checkpoints manually

2017-10-17 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/flink/pull/1434 [![Coverage Status](https://coveralls.io/builds/13763854/badge)](https://coveralls.io/builds/13763854) Changes Unknown when pulling **d9743343ec0c268a99c46ec7324a603506827c78 on uce:2

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145260916 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CorrelateITCase.scala --- @@ -82,6 +82,45 @@ class Correlat

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145257154 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -476,20 +481,30 @@ case class Join(

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208452#comment-16208452 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208444#comment-16208444 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208445#comment-16208445 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208447#comment-16208447 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208449#comment-16208449 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208441#comment-16208441 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208451#comment-16208451 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145261361 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CorrelateITCase.scala --- @@ -82,6 +82,42 @@ class Correlate

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145259863 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/CorrelateTest.scala --- @@ -93,9 +98,25 @@ class CorrelateTest e

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208448#comment-16208448 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208443#comment-16208443 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145260893 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CorrelateITCase.scala --- @@ -82,6 +82,42 @@ class Correlate

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208446#comment-16208446 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208442#comment-16208442 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145254351 --- Diff: docs/dev/table/tableApi.md --- @@ -695,6 +698,7 @@ val split: TableFunction[_] = new MySplitUDTF() // join val result: Table = table

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145260567 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/CorrelateTest.scala --- @@ -93,9 +98,25 @@ class CorrelateTest e

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208453#comment-16208453 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145262038 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CorrelateITCase.scala --- @@ -82,6 +82,45 @@ class Correlat

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208450#comment-16208450 ] ASF GitHub Bot commented on FLINK-7853: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145260250 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/table/CorrelateTest.scala --- @@ -99,6 +104,21 @@ class CorrelateTest

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145253439 --- Diff: docs/dev/table/tableApi.md --- @@ -574,6 +574,7 @@ Table result = orders Joins a table with a the results of a

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145260098 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/CorrelateTest.scala --- @@ -73,13 +74,17 @@ class CorrelateTest

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145253567 --- Diff: docs/dev/table/tableApi.md --- @@ -687,6 +689,7 @@ val result: Table = table Batch Streaming Joins a tabl

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4842#discussion_r145253981 --- Diff: docs/dev/table/tableApi.md --- @@ -583,7 +584,8 @@ tEnv.registerFunction("split", split); // join Table orders = tableEnv.scan("Orders");

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208238#comment-16208238 ] Fabian Hueske commented on FLINK-7548: -- Thanks for the comments [~twalthr] and [~xccu

[jira] [Created] (FLINK-7863) Make MetricFetcher work with RestfulGateway

2017-10-17 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7863: Summary: Make MetricFetcher work with RestfulGateway Key: FLINK-7863 URL: https://issues.apache.org/jira/browse/FLINK-7863 Project: Flink Issue Type: Sub-tas

[jira] [Resolved] (FLINK-7794) Link Broken in -- https://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/connectors/index.html

2017-10-17 Thread Paul Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Wu resolved FLINK-7794. Resolution: Fixed Release Note: Someone fixed the issue. > Link Broken in -- > https://ci.apache.org/

[jira] [Commented] (FLINK-7839) Creating Quickstart project for SNAPSHOT version fails

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207807#comment-16207807 ] ASF GitHub Bot commented on FLINK-7839: --- GitHub user mcfongtw opened a pull request:

[GitHub] flink pull request #4848: [FLINK-7839] [doc] Add a note on possible maven fa...

2017-10-17 Thread mcfongtw
GitHub user mcfongtw opened a pull request: https://github.com/apache/flink/pull/4848 [FLINK-7839] [doc] Add a note on possible maven failure for creating quickstart project ## What is the purpose of the change This only applies before project release; {%site

[jira] [Updated] (FLINK-7849) Remove guava shading from hcatalog connector

2017-10-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7849: Priority: Minor (was: Blocker) > Remove guava shading from hcatalog connector > ---

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207782#comment-16207782 ] Xingcan Cui commented on FLINK-7548: Hi [~fhueske], sorry for the late reply. I'll fir

[jira] [Updated] (FLINK-7846) Remove guava shading from ES2 connector

2017-10-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7846: Priority: Minor (was: Blocker) > Remove guava shading from ES2 connector >

[jira] [Commented] (FLINK-7783) Don't always remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()

2017-10-17 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207783#comment-16207783 ] Aljoscha Krettek commented on FLINK-7783: - We should never delete checkpoints that

[GitHub] flink pull request #4847: [hotfix][doc]CEP docs review to remove weasel word...

2017-10-17 Thread ChrisChinchilla
GitHub user ChrisChinchilla opened a pull request: https://github.com/apache/flink/pull/4847 [hotfix][doc]CEP docs review to remove weasel words, fix passive voice, typos… As requested, backport from 1.4. Ref - https://github.com/apache/flink/pull/4816 You can merge this

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207717#comment-16207717 ] Timo Walther commented on FLINK-7548: - Thanks for the proposal [~fhueske]. I like the

[jira] [Commented] (FLINK-6173) flink-table not pack-in com.fasterxml.jackson.* in after #FLINK-5414

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207674#comment-16207674 ] ASF GitHub Bot commented on FLINK-6173: --- Github user zentol commented on the issue:

[GitHub] flink issue #4837: [FLINK-6173] [table] Clean-up flink-table jar and depende...

2017-10-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4837 the table examples no longer build on travis. ---

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145132472 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apa

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145126703 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apa

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145125984 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apa

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207657#comment-16207657 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207655#comment-16207655 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207658#comment-16207658 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207659#comment-16207659 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145133848 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -439,7 +439,7 @@ public Che

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145125538 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apa

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207656#comment-16207656 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-7648) Port TaskManagersHandler to new REST endpoint

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207654#comment-16207654 ] ASF GitHub Bot commented on FLINK-7648: --- Github user zentol commented on the issue:

[GitHub] flink issue #4824: [FLINK-7648] [flip6] Add TaskManagersHandler

2017-10-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4824 The handler related commits look good to me. ---

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207634#comment-16207634 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207636#comment-16207636 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207632#comment-16207632 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207635#comment-16207635 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207633#comment-16207633 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in t

  1   2   >