[
https://issues.apache.org/jira/browse/FLINK-7879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212261#comment-16212261
]
ASF GitHub Bot commented on FLINK-7879:
---
GitHub user yew1eb opened a pull request:
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4867
[FLINK-7879][travis] Only execute apache-rat in one build profile
## What is the purpose of the change
Improve travis build times by skipping redundant checkstyle executions.
## Brie
[
https://issues.apache.org/jira/browse/FLINK-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212252#comment-16212252
]
ASF GitHub Bot commented on FLINK-6907:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4865
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4850
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4864
---
[
https://issues.apache.org/jira/browse/FLINK-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-6907.
---
Resolution: Fixed
1.4: 61c26295881d737c22f17f1a9d15d8c4475f2085
> Adjust TupleGenerator javad
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4843
@zjureel Can you close this PR? I've already merged it.
---
[
https://issues.apache.org/jira/browse/FLINK-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212250#comment-16212250
]
ASF GitHub Bot commented on FLINK-7703:
---
Github user zentol commented on the issue:
Hai Zhou UTC+8 created FLINK-7879:
-
Summary: only execute apache-rat in one build profile
Key: FLINK-7879
URL: https://issues.apache.org/jira/browse/FLINK-7879
Project: Flink
Issue Type: Impr
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4865
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4864
merging.
---
[
https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212247#comment-16212247
]
ASF GitHub Bot commented on FLINK-7765:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4777
Looks good to me. Please create follow-up JIRAs for the remaining modules.
---
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212239#comment-16212239
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145885868
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325 @@
+/*
+
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4863#discussion_r145885278
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreTest.java
---
@@ -183,11 +179,120 @@ publi
[
https://issues.apache.org/jira/browse/FLINK-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212237#comment-16212237
]
ASF GitHub Bot commented on FLINK-7783:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212228#comment-16212228
]
ASF GitHub Bot commented on FLINK-7783:
---
Github user StefanRRichter commented on the
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4863
@aljoscha from the top of my head, I think some concerns are invalid. After
being added to to the checkpoint store, the incremental handles should be
complete and self contained - all placehol
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4851
Also from our offline discussion, I would suggest that this behaves as: if
an operator with a given ID participated in a checkpoint, it should be marked
as restored. From this definition, all
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212183#comment-16212183
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on the
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145879846
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325 @@
+/*
+
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212175#comment-16212175
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212174#comment-16212174
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145879772
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325 @@
+/*
+
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145878649
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325 @@
+/*
+
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212165#comment-16212165
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212163#comment-16212163
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145878457
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325 @@
+/*
+
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212158#comment-16212158
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145878181
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325 @@
+/*
+
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145877990
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325 @@
+/*
+
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212155#comment-16212155
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212153#comment-16212153
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212152#comment-16212152
]
ASF GitHub Bot commented on FLINK-4866:
---
Github user vim-wj closed the pull request
Github user vim-wj closed the pull request at:
https://github.com/apache/flink/pull/4866
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145877847
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325 @@
+/*
+
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145877337
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/AcknowledgeStreamMockEnvironment.java
---
@@ -0,0 +1,65 @@
[
https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212145#comment-16212145
]
ASF GitHub Bot commented on FLINK-7623:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter closed FLINK-5372.
-
Resolution: Fixed
Merged in dbf4c86
> Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoint
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4855
---
[
https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212141#comment-16212141
]
ASF GitHub Bot commented on FLINK-5372:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212136#comment-16212136
]
ASF GitHub Bot commented on FLINK-5372:
---
Github user StefanRRichter commented on the
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4855
Thanks for the review! Will merge this.
---
GitHub user vim-wj reopened a pull request:
https://github.com/apache/flink/pull/4866
Function extends java.io.Serializable, so SourceFunction needn't extends
Serializable again
Function extends java.io.Serializable, so SourceFunction needn't extends
Serializable again
You can mer
Github user vim-wj closed the pull request at:
https://github.com/apache/flink/pull/4866
---
Github user vim-wj commented on the issue:
https://github.com/apache/flink/pull/4866
Function extends java.io.Serializable, so SourceFunction needn't extends
Serializable again
---
GitHub user vim-wj opened a pull request:
https://github.com/apache/flink/pull/4866
SourceFunction
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, p
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4865
[hotfix] Fix typos that double "the" word
Remove double "the" word in document and comments.
You can merge this pull request into a Git repository by running:
$ git pull https://githu
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shuai.xu updated FLINK-7878:
Labels: flip-6 (was: )
> Extend the resource type user can define in ResourceSpec
> ---
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shuai.xu reassigned FLINK-7878:
---
Assignee: shuai.xu
> Extend the resource type user can define in ResourceSpec
> -
shuai.xu created FLINK-7878:
---
Summary: Extend the resource type user can define in ResourceSpec
Key: FLINK-7878
URL: https://issues.apache.org/jira/browse/FLINK-7878
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212025#comment-16212025
]
Keren Zhu commented on FLINK-7669:
--
I encountered exactly the same problem a few days ago
[
https://issues.apache.org/jira/browse/FLINK-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xingcan Cui updated FLINK-7865:
---
Description:
To cover up the improper translation of lateral table left outer join
(CALCITE-2004), we
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4794
We already have a script, it is the RAT plugin:
https://github.com/apache/flink/blob/master/pom.xml#L957
You only need to make sure that these files are not excluded from the
check...
[
https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211807#comment-16211807
]
Ryan Hobbs commented on FLINK-7737:
---
I believe the SYNC_BLOCK flag is sufficient. My un
[
https://issues.apache.org/jira/browse/FLINK-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-7621:
-
Issue Type: Improvement (was: Bug)
> Fix Inconsistency of CaseSensitive Configuration
> -
[
https://issues.apache.org/jira/browse/FLINK-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-7618:
-
Issue Type: New Feature (was: Bug)
> Add BINARY supported in FlinkTypeFactory
> -
[
https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske closed FLINK-7730.
Resolution: Fixed
Fix Version/s: 1.3.0
1.4.0
Fixed by rejecting queries wi
[
https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211609#comment-16211609
]
Piotr Nowojski edited comment on FLINK-7737 at 10/19/17 7:38 PM:
---
[
https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211609#comment-16211609
]
Piotr Nowojski commented on FLINK-7737:
---
I have started looking into this. Are you s
[
https://issues.apache.org/jira/browse/FLINK-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-7865:
-
Issue Type: New Feature (was: Sub-task)
Parent: (was: FLINK-7730)
> Remove predicate
[
https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211592#comment-16211592
]
ASF GitHub Bot commented on FLINK-5498:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3379
Hi @lincoln-lil, I fixed FLINK-5498 with PR #4858 as a by product to fix
FLINK-7755.
The implementation of #4858 is memory safe (based on the proposal we
discussed in FLINK-5498).
Could
[
https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske closed FLINK-7854.
Resolution: Fixed
Fix Version/s: 1.3.3
Fixed for 1.3.3 with 1d10cee91a12734de09b8c96654373092
[
https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Nowojski reassigned FLINK-7737:
-
Assignee: Piotr Nowojski
> On HCFS systems, FSDataOutputStream does not issue hsync only
[
https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211517#comment-16211517
]
ASF GitHub Bot commented on FLINK-6225:
---
Github user PangZhi commented on the issue:
Github user PangZhi commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol thx, fixed.
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4846
---
[
https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211369#comment-16211369
]
ASF GitHub Bot commented on FLINK-7854:
---
Github user asfgit closed the pull request
Ted Yu created FLINK-7877:
-
Summary: Fix compilation against the Hadoop 3 beta1 release
Key: FLINK-7877
URL: https://issues.apache.org/jira/browse/FLINK-7877
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211343#comment-16211343
]
Bowen Li commented on FLINK-7864:
-
With the latest master branch, I found I cannot run {{S
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211302#comment-16211302
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145752342
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -269,4 +315,49 @@ private void decode
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211297#comment-16211297
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145750939
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -37,18 +43,29 @@
import ja
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211293#comment-16211293
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145750093
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -37,18 +43,29 @@
import ja
[
https://issues.apache.org/jira/browse/FLINK-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211289#comment-16211289
]
Sendoh commented on FLINK-7697:
---
Would be very nice to contain the following information so
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211288#comment-16211288
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145749291
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,6 +211,53 @@ public voi
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211272#comment-16211272
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211274#comment-16211274
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145746280
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -378,32 +387,47 @@ public
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145746120
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -304,12 +304,21 @@ public
[
https://issues.apache.org/jira/browse/FLINK-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske closed FLINK-7802.
Resolution: Fixed
Fixed for 1.3.3 with 024d8f5779406d88f44fda51aa47c2bdbc63a226
Fixed for 1.4.0 with
[
https://issues.apache.org/jira/browse/FLINK-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske closed FLINK-7759.
Resolution: Fixed
Fix Version/s: 1.3.3
Fixed for 1.3.3 with 28b65f9a779bb76e603e2951896fefe2d
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4846
Great thanks a lot! The PR looks good. Will merge it.
---
[
https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211195#comment-16211195
]
ASF GitHub Bot commented on FLINK-7854:
---
Github user fhueske commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211186#comment-16211186
]
ASF GitHub Bot commented on FLINK-5968:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211189#comment-16211189
]
ASF GitHub Bot commented on FLINK-5968:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211187#comment-16211187
]
ASF GitHub Bot commented on FLINK-5968:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211188#comment-16211188
]
ASF GitHub Bot commented on FLINK-5968:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4833#discussion_r145726822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala
---
@@ -52,7 +52,7 @@ import
org.apache.flink.table.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4833#discussion_r145726800
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -52,11 +52,12 @@ import
org.apache.flink.tab
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4833#discussion_r145728875
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -67,7 +67,7 @@ abstract cla
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4833#discussion_r145731146
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -67,7 +67,7 @@ abstract cla
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4846
Hi @fhueske, the PR has been updated.
---
[
https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211176#comment-16211176
]
ASF GitHub Bot commented on FLINK-7854:
---
Github user xccui commented on the issue:
1 - 100 of 190 matches
Mail list logo