[jira] [Commented] (FLINK-7879) only execute apache-rat in one build profile

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212261#comment-16212261 ] ASF GitHub Bot commented on FLINK-7879: --- GitHub user yew1eb opened a pull request:

[GitHub] flink pull request #4867: [FLINK-7879][travis] Only execute apache-rat in on...

2017-10-19 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4867 [FLINK-7879][travis] Only execute apache-rat in one build profile ## What is the purpose of the change Improve travis build times by skipping redundant checkstyle executions. ## Brie

[jira] [Commented] (FLINK-6907) Adjust TupleGenerator javadocs in flink-java

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212252#comment-16212252 ] ASF GitHub Bot commented on FLINK-6907: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4865: [hotfix] Fix typos that double "the" word

2017-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4865 ---

[GitHub] flink pull request #4850: [FLINK-6907][core] Extend TupleGenerator javadocs

2017-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4850 ---

[GitHub] flink pull request #4864: [hotfix] fix typos in comments in RuntimeContext.j...

2017-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4864 ---

[jira] [Closed] (FLINK-6907) Adjust TupleGenerator javadocs in flink-java

2017-10-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6907. --- Resolution: Fixed 1.4: 61c26295881d737c22f17f1a9d15d8c4475f2085 > Adjust TupleGenerator javad

[GitHub] flink issue #4843: [FLINK-7703] Port JobExceptionsHandler to new REST endpoi...

2017-10-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4843 @zjureel Can you close this PR? I've already merged it. ---

[jira] [Commented] (FLINK-7703) Port JobExceptionsHandler to new REST endpoint

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212250#comment-16212250 ] ASF GitHub Bot commented on FLINK-7703: --- Github user zentol commented on the issue:

[jira] [Created] (FLINK-7879) only execute apache-rat in one build profile

2017-10-19 Thread Hai Zhou UTC+8 (JIRA)
Hai Zhou UTC+8 created FLINK-7879: - Summary: only execute apache-rat in one build profile Key: FLINK-7879 URL: https://issues.apache.org/jira/browse/FLINK-7879 Project: Flink Issue Type: Impr

[GitHub] flink issue #4865: [hotfix] Fix typos that double "the" word

2017-10-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4865 merging. ---

[GitHub] flink issue #4864: [hotfix] fix typos in comments in RuntimeContext.java

2017-10-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4864 merging. ---

[jira] [Commented] (FLINK-7765) Enable dependency convergence

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212247#comment-16212247 ] ASF GitHub Bot commented on FLINK-7765: --- Github user zentol commented on the issue:

[GitHub] flink issue #4777: [FLINK-7765] Enable dependency convergence

2017-10-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4777 Looks good to me. Please create follow-up JIRAs for the remaining modules. ---

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212239#comment-16212239 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145885868 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java --- @@ -0,0 +1,325 @@ +/* +

[GitHub] flink pull request #4863: [FLINK-7783] Don't always remove checkpoints in Zo...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4863#discussion_r145885278 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreTest.java --- @@ -183,11 +179,120 @@ publi

[jira] [Commented] (FLINK-7783) Don't always remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212237#comment-16212237 ] ASF GitHub Bot commented on FLINK-7783: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-7783) Don't always remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212228#comment-16212228 ] ASF GitHub Bot commented on FLINK-7783: --- Github user StefanRRichter commented on the

[GitHub] flink issue #4863: [FLINK-7783] Don't always remove checkpoints in ZooKeeper...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4863 @aljoscha from the top of my head, I think some concerns are invalid. After being added to to the checkpoint store, the incremental handles should be complete and self contained - all placehol

[GitHub] flink issue #4851: [FLINK-7623][tests] Add tests to make sure operator is ne...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4851 Also from our offline discussion, I would suggest that this behaves as: if an operator with a given ID participated in a checkpoint, it should be marked as restored. From this definition, all

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212183#comment-16212183 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on the

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145879846 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java --- @@ -0,0 +1,325 @@ +/* +

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212175#comment-16212175 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212174#comment-16212174 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145879772 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java --- @@ -0,0 +1,325 @@ +/* +

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145878649 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java --- @@ -0,0 +1,325 @@ +/* +

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212165#comment-16212165 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212163#comment-16212163 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145878457 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java --- @@ -0,0 +1,325 @@ +/* +

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212158#comment-16212158 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145878181 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java --- @@ -0,0 +1,325 @@ +/* +

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145877990 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java --- @@ -0,0 +1,325 @@ +/* +

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212155#comment-16212155 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212153#comment-16212153 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-4866) Make Trigger.clear() Abstract to Enforce Implementation

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212152#comment-16212152 ] ASF GitHub Bot commented on FLINK-4866: --- Github user vim-wj closed the pull request

[GitHub] flink pull request #4866: [FLINK-4866]SourceFunction needn't extends Seriali...

2017-10-19 Thread vim-wj
Github user vim-wj closed the pull request at: https://github.com/apache/flink/pull/4866 ---

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145877847 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java --- @@ -0,0 +1,325 @@ +/* +

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4851#discussion_r145877337 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/AcknowledgeStreamMockEnvironment.java --- @@ -0,0 +1,65 @@

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212145#comment-16212145 ] ASF GitHub Bot commented on FLINK-7623: --- Github user StefanRRichter commented on a d

[jira] [Closed] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2017-10-19 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-5372. - Resolution: Fixed Merged in dbf4c86 > Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoint

[GitHub] flink pull request #4855: [FLINK-5372] [tests] Fix RocksDBAsyncSnapshotTest....

2017-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4855 ---

[jira] [Commented] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212141#comment-16212141 ] ASF GitHub Bot commented on FLINK-5372: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212136#comment-16212136 ] ASF GitHub Bot commented on FLINK-5372: --- Github user StefanRRichter commented on the

[GitHub] flink issue #4855: [FLINK-5372] [tests] Fix RocksDBAsyncSnapshotTest.testCan...

2017-10-19 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4855 Thanks for the review! Will merge this. ---

[GitHub] flink pull request #4866: Function extends java.io.Serializable, so SourceFu...

2017-10-19 Thread vim-wj
GitHub user vim-wj reopened a pull request: https://github.com/apache/flink/pull/4866 Function extends java.io.Serializable, so SourceFunction needn't extends Serializable again Function extends java.io.Serializable, so SourceFunction needn't extends Serializable again You can mer

[GitHub] flink pull request #4866: SourceFunction

2017-10-19 Thread vim-wj
Github user vim-wj closed the pull request at: https://github.com/apache/flink/pull/4866 ---

[GitHub] flink issue #4866: SourceFunction

2017-10-19 Thread vim-wj
Github user vim-wj commented on the issue: https://github.com/apache/flink/pull/4866 Function extends java.io.Serializable, so SourceFunction needn't extends Serializable again ---

[GitHub] flink pull request #4866: SourceFunction

2017-10-19 Thread vim-wj
GitHub user vim-wj opened a pull request: https://github.com/apache/flink/pull/4866 SourceFunction *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, p

[GitHub] flink pull request #4865: [hotfix] Fix typos that double "the" word

2017-10-19 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4865 [hotfix] Fix typos that double "the" word Remove double "the" word in document and comments. You can merge this pull request into a Git repository by running: $ git pull https://githu

[jira] [Updated] (FLINK-7878) Extend the resource type user can define in ResourceSpec

2017-10-19 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu updated FLINK-7878: Labels: flip-6 (was: ) > Extend the resource type user can define in ResourceSpec > ---

[jira] [Assigned] (FLINK-7878) Extend the resource type user can define in ResourceSpec

2017-10-19 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu reassigned FLINK-7878: --- Assignee: shuai.xu > Extend the resource type user can define in ResourceSpec > -

[jira] [Created] (FLINK-7878) Extend the resource type user can define in ResourceSpec

2017-10-19 Thread shuai.xu (JIRA)
shuai.xu created FLINK-7878: --- Summary: Extend the resource type user can define in ResourceSpec Key: FLINK-7878 URL: https://issues.apache.org/jira/browse/FLINK-7878 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7669) org.apache.flink.api.common.ExecutionConfig cannot be cast to org.apache.flink.api.common.ExecutionConfig

2017-10-19 Thread Keren Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212025#comment-16212025 ] Keren Zhu commented on FLINK-7669: -- I encountered exactly the same problem a few days ago

[jira] [Updated] (FLINK-7865) Remove predicate restrictions on TableFunction left outer join

2017-10-19 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui updated FLINK-7865: --- Description: To cover up the improper translation of lateral table left outer join (CALCITE-2004), we

[GitHub] flink issue #4794: [build][minor] Add missing licenses

2017-10-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4794 We already have a script, it is the RAT plugin: https://github.com/apache/flink/blob/master/pom.xml#L957 You only need to make sure that these files are not excluded from the check...

[jira] [Commented] (FLINK-7737) On HCFS systems, FSDataOutputStream does not issue hsync only hflush which leads to data loss

2017-10-19 Thread Ryan Hobbs (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211807#comment-16211807 ] Ryan Hobbs commented on FLINK-7737: --- I believe the SYNC_BLOCK flag is sufficient. My un

[jira] [Updated] (FLINK-7621) Fix Inconsistency of CaseSensitive Configuration

2017-10-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-7621: - Issue Type: Improvement (was: Bug) > Fix Inconsistency of CaseSensitive Configuration > -

[jira] [Updated] (FLINK-7618) Add BINARY supported in FlinkTypeFactory

2017-10-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-7618: - Issue Type: New Feature (was: Bug) > Add BINARY supported in FlinkTypeFactory > -

[jira] [Closed] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7730. Resolution: Fixed Fix Version/s: 1.3.0 1.4.0 Fixed by rejecting queries wi

[jira] [Comment Edited] (FLINK-7737) On HCFS systems, FSDataOutputStream does not issue hsync only hflush which leads to data loss

2017-10-19 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211609#comment-16211609 ] Piotr Nowojski edited comment on FLINK-7737 at 10/19/17 7:38 PM: ---

[jira] [Commented] (FLINK-7737) On HCFS systems, FSDataOutputStream does not issue hsync only hflush which leads to data loss

2017-10-19 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211609#comment-16211609 ] Piotr Nowojski commented on FLINK-7737: --- I have started looking into this. Are you s

[jira] [Updated] (FLINK-7865) Remove predicate restrictions on TableFunction left outer join

2017-10-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-7865: - Issue Type: New Feature (was: Sub-task) Parent: (was: FLINK-7730) > Remove predicate

[jira] [Commented] (FLINK-5498) Add support for left/right outer joins with non-equality predicates (and 1+ equality predicates)

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211592#comment-16211592 ] ASF GitHub Bot commented on FLINK-5498: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3379: [FLINK-5498] [table] Add support for left/right outer joi...

2017-10-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3379 Hi @lincoln-lil, I fixed FLINK-5498 with PR #4858 as a by product to fix FLINK-7755. The implementation of #4858 is memory safe (based on the proposal we discussed in FLINK-5498). Could

[jira] [Closed] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7854. Resolution: Fixed Fix Version/s: 1.3.3 Fixed for 1.3.3 with 1d10cee91a12734de09b8c96654373092

[jira] [Assigned] (FLINK-7737) On HCFS systems, FSDataOutputStream does not issue hsync only hflush which leads to data loss

2017-10-19 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-7737: - Assignee: Piotr Nowojski > On HCFS systems, FSDataOutputStream does not issue hsync only

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211517#comment-16211517 ] ASF GitHub Bot commented on FLINK-6225: --- Github user PangZhi commented on the issue:

[GitHub] flink issue #3748: [FLINK-6225] [Cassandra Connector] add CassandraTableSink

2017-10-19 Thread PangZhi
Github user PangZhi commented on the issue: https://github.com/apache/flink/pull/3748 @zentol thx, fixed. ---

[GitHub] flink pull request #4846: [FLINK-7854] [table] Reject lateral table outer jo...

2017-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4846 ---

[jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211369#comment-16211369 ] ASF GitHub Bot commented on FLINK-7854: --- Github user asfgit closed the pull request

[jira] [Created] (FLINK-7877) Fix compilation against the Hadoop 3 beta1 release

2017-10-19 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7877: - Summary: Fix compilation against the Hadoop 3 beta1 release Key: FLINK-7877 URL: https://issues.apache.org/jira/browse/FLINK-7877 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7864) Support side-outputs in CoProcessFunction

2017-10-19 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211343#comment-16211343 ] Bowen Li commented on FLINK-7864: - With the latest master branch, I found I cannot run {{S

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211302#comment-16211302 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-19 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r145752342 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -269,4 +315,49 @@ private void decode

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211297#comment-16211297 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-19 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r145750939 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -37,18 +43,29 @@ import ja

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211293#comment-16211293 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-19 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r145750093 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -37,18 +43,29 @@ import ja

[jira] [Commented] (FLINK-7697) Add metrics for Elasticsearch Sink

2017-10-19 Thread Sendoh (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211289#comment-16211289 ] Sendoh commented on FLINK-7697: --- Would be very nice to contain the following information so

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211288#comment-16211288 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-19 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r145749291 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -208,6 +211,53 @@ public voi

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211272#comment-16211272 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211274#comment-16211274 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-19 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r145746280 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -378,32 +387,47 @@ public

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-19 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r145746120 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -304,12 +304,21 @@ public

[jira] [Closed] (FLINK-7802) Exception occur when empty field collection was pushed into CSVTableSource

2017-10-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7802. Resolution: Fixed Fixed for 1.3.3 with 024d8f5779406d88f44fda51aa47c2bdbc63a226 Fixed for 1.4.0 with

[jira] [Closed] (FLINK-7759) Fix Bug that fieldName with Boolean prefix can't be parsed by ExpressionParser.

2017-10-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7759. Resolution: Fixed Fix Version/s: 1.3.3 Fixed for 1.3.3 with 28b65f9a779bb76e603e2951896fefe2d

[GitHub] flink issue #4846: [FLINK-7854] [table] Reject lateral table outer joins wit...

2017-10-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4846 Great thanks a lot! The PR looks good. Will merge it. ---

[jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211195#comment-16211195 ] ASF GitHub Bot commented on FLINK-7854: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-5968) Document WindowedStream.aggregate()

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211186#comment-16211186 ] ASF GitHub Bot commented on FLINK-5968: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-5968) Document WindowedStream.aggregate()

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211189#comment-16211189 ] ASF GitHub Bot commented on FLINK-5968: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-5968) Document WindowedStream.aggregate()

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211187#comment-16211187 ] ASF GitHub Bot commented on FLINK-5968: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-5968) Document WindowedStream.aggregate()

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211188#comment-16211188 ] ASF GitHub Bot commented on FLINK-5968: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r145726822 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala --- @@ -52,7 +52,7 @@ import org.apache.flink.table.

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r145726800 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala --- @@ -52,11 +52,12 @@ import org.apache.flink.tab

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r145728875 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -67,7 +67,7 @@ abstract cla

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r145731146 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -67,7 +67,7 @@ abstract cla

[GitHub] flink issue #4846: [FLINK-7854] [table] Reject lateral table outer joins wit...

2017-10-19 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4846 Hi @fhueske, the PR has been updated. ---

[jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211176#comment-16211176 ] ASF GitHub Bot commented on FLINK-7854: --- Github user xccui commented on the issue:

  1   2   >