[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307128#comment-16307128
]
ASF GitHub Bot commented on FLINK-8331:
---
Github user sunjincheng121 commented on the issue:
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5218
@fhueske Thanks for the review.
I have updated the PR according your comments. And I have extended the
`RowCsvInputFormatTest.testTailingEmptyFields` method for
[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307125#comment-16307125
]
ASF GitHub Bot commented on FLINK-8331:
---
Github user sunjincheng121 commented on a diff in the pull
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159134590
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final
[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307041#comment-16307041
]
ASF GitHub Bot commented on FLINK-8331:
---
Github user sunjincheng121 commented on a diff in the pull
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159132545
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final
[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306920#comment-16306920
]
ASF GitHub Bot commented on FLINK-8331:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306922#comment-16306922
]
ASF GitHub Bot commented on FLINK-8331:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306921#comment-16306921
]
ASF GitHub Bot commented on FLINK-8331:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306923#comment-16306923
]
ASF GitHub Bot commented on FLINK-8331:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159127981
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/FieldParserTest.java ---
@@ -43,4 +43,38 @@ public void testEndsWithDelimiter() throws
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159128212
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/FieldParserTest.java ---
@@ -43,4 +43,38 @@ public void testEndsWithDelimiter() throws
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159127955
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/FieldParserTest.java ---
@@ -43,4 +43,38 @@ public void testEndsWithDelimiter() throws
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159128322
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final String
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/5218
[FLINK-8331][core] FieldParser do not correctly set EMPT_COLUMN error state.
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To
[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306771#comment-16306771
]
ASF GitHub Bot commented on FLINK-8331:
---
GitHub user sunjincheng121 opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306744#comment-16306744
]
ASF GitHub Bot commented on FLINK-8329:
---
Github user GJL commented on the issue:
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5216
There are some checkstyle violations:
```
[ERROR]
src/main/java/org/apache/flink/yarn/cli/YarnApplicationStatusMonitor.java:[33,8]
(imports) UnusedImports: Unused import:
18 matches
Mail list logo
