[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-11 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160885887 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to the

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321841#comment-16321841 ] ASF GitHub Bot commented on FLINK-7511: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-8405) Keyed State in broadcasted data steam.

2018-01-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321848#comment-16321848 ] Fabian Hueske commented on FLINK-8405: -- Connecting a keyed stream and a broadcasted s

[jira] [Commented] (FLINK-7949) AsyncWaitOperator is not restarting when queue is full

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321849#comment-16321849 ] ASF GitHub Bot commented on FLINK-7949: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #4924: [FLINK-7949] AsyncWaitOperator is not restarting when que...

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4924 Thanks a lot for this fix @bartektartanus. The changes look good to me. Merging your PR :-) ---

[jira] [Commented] (FLINK-8405) Keyed State in broadcasted data steam.

2018-01-11 Thread Marek Barak (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321854#comment-16321854 ] Marek Barak commented on FLINK-8405: Thank you [~fhueske] for your answer. I agree tha

[jira] [Comment Edited] (FLINK-8405) Keyed State in broadcasted data steam.

2018-01-11 Thread Marek Barak (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321854#comment-16321854 ] Marek Barak edited comment on FLINK-8405 at 1/11/18 8:28 AM: -

[jira] [Closed] (FLINK-8405) Keyed State in broadcasted data steam.

2018-01-11 Thread Marek Barak (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marek Barak closed FLINK-8405. -- Resolution: Duplicate > Keyed State in broadcasted data steam. > --

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-11 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160895447 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to the Apac

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321884#comment-16321884 ] ASF GitHub Bot commented on FLINK-7511: --- Github user kl0u commented on a diff in the

[jira] [Created] (FLINK-8411) inconsistent behavior between HeapListState#add() and RocksDBListState#add()

2018-01-11 Thread Bowen Li (JIRA)
Bowen Li created FLINK-8411: --- Summary: inconsistent behavior between HeapListState#add() and RocksDBListState#add() Key: FLINK-8411 URL: https://issues.apache.org/jira/browse/FLINK-8411 Project: Flink

[jira] [Commented] (FLINK-8403) Flink Gelly examples hanging without returning result

2018-01-11 Thread flora karniav (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321886#comment-16321886 ] flora karniav commented on FLINK-8403: -- Yes, that was it! I think it would be a good

[jira] [Updated] (FLINK-8411) inconsistent behavior between HeapListState#add() and RocksDBListState#add()

2018-01-11 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8411: Priority: Critical (was: Major) > inconsistent behavior between HeapListState#add() and RocksDBListState#ad

[jira] [Assigned] (FLINK-8411) inconsistent behavior between HeapListState#add() and RocksDBListState#add()

2018-01-11 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-8411: --- Assignee: Bowen Li > inconsistent behavior between HeapListState#add() and RocksDBListState#add() > -

[jira] [Closed] (FLINK-8403) Flink Gelly examples hanging without returning result

2018-01-11 Thread flora karniav (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] flora karniav closed FLINK-8403. Resolution: Not A Bug Fix Version/s: 1.3.2 > Flink Gelly examples hanging without returning r

[jira] [Updated] (FLINK-8411) inconsistent behavior between HeapListState#add() and RocksDBListState#add()

2018-01-11 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8411: Description: You can see that {{HeapListState#add(null)}} will result in the whole state being cleared or w

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321900#comment-16321900 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StefanRRichter commented on the

[GitHub] flink issue #5248: [FLINK-5823] [checkpoints] State backends now also handle...

2018-01-11 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5248 Yes, that is a pretty good summary. `CompletedCheckpointsRegistry` or maybe just `CompletedCheckpoints` might already be a good enough name, after all it is just a queue. One more com

[GitHub] flink pull request #5281: [FLINK-7938] support addAll() in ListState

2018-01-11 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5281 [FLINK-7938] support addAll() in ListState ## What is the purpose of the change support `addAll()` in `ListState`, so Flink can be more efficient in adding elements to `ListState` in batc

[jira] [Commented] (FLINK-7938) support addAll() in ListState

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321906#comment-16321906 ] ASF GitHub Bot commented on FLINK-7938: --- GitHub user bowenli86 opened a pull request

[jira] [Resolved] (FLINK-8400) Use the lexicographic smallest attribute as the common group id when extract unique key

2018-01-11 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8400. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in 1.5: e44700061fb9bf1813f86ef223ecf285b1f9d8

[GitHub] flink pull request #5273: [FLINK-8400] [table] Use the lexicographic smalles...

2018-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5273 ---

[jira] [Commented] (FLINK-8400) Use the lexicographic smallest attribute as the common group id when extract unique key

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321948#comment-16321948 ] ASF GitHub Bot commented on FLINK-8400: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321964#comment-16321964 ] ASF GitHub Bot commented on FLINK-8345: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-11 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r160904948 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/BroadcastConnectedStream.java --- @@ -0,0 +1,216 @@ +/* + * Lice

[jira] [Commented] (FLINK-8411) inconsistent behavior between HeapListState#add() and RocksDBListState#add()

2018-01-11 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321968#comment-16321968 ] Stefan Richter commented on FLINK-8411: --- Yes, I agree. Would you like to make a PR o

[jira] [Comment Edited] (FLINK-8411) inconsistent behavior between HeapListState#add() and RocksDBListState#add()

2018-01-11 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321968#comment-16321968 ] Stefan Richter edited comment on FLINK-8411 at 1/11/18 9:46 AM:

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-11 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160908934 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to the

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321983#comment-16321983 ] ASF GitHub Bot commented on FLINK-7511: --- Github user pnowojski commented on a diff i

[jira] [Created] (FLINK-8412) Show outdated warning for 1.3 docs

2018-01-11 Thread Timo Walther (JIRA)
Timo Walther created FLINK-8412: --- Summary: Show outdated warning for 1.3 docs Key: FLINK-8412 URL: https://issues.apache.org/jira/browse/FLINK-8412 Project: Flink Issue Type: Bug Comp

[jira] [Created] (FLINK-8413) Checkpointing in flink doesnt maintain the snapshot state

2018-01-11 Thread suganya (JIRA)
suganya created FLINK-8413: -- Summary: Checkpointing in flink doesnt maintain the snapshot state Key: FLINK-8413 URL: https://issues.apache.org/jira/browse/FLINK-8413 Project: Flink Issue Type: Bug

[GitHub] flink pull request #5278: [FLINK-8404] [tests] Mark Flip-6 tests with Flip6 ...

2018-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5278 ---

[GitHub] flink pull request #4924: [FLINK-7949] AsyncWaitOperator is not restarting w...

2018-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4924 ---

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2018-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5184 ---

[jira] [Commented] (FLINK-7949) AsyncWaitOperator is not restarting when queue is full

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322066#comment-16322066 ] ASF GitHub Bot commented on FLINK-7949: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322065#comment-16322065 ] ASF GitHub Bot commented on FLINK-8234: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8404) Mark Flip-6 tests with Flip6 annotation

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322067#comment-16322067 ] ASF GitHub Bot commented on FLINK-8404: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-7949) AsyncWaitOperator is not restarting when queue is full

2018-01-11 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7949. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 6593e0f9e6db9d862afadeeae79e0afa2590fd73

[jira] [Closed] (FLINK-8404) Mark Flip-6 tests with Flip6 annotation

2018-01-11 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8404. Resolution: Fixed Fixed via 8353123b39ea49cc5b3bd9d324972bf6ae02f2a6 > Mark Flip-6 tests with Flip6

[jira] [Closed] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2018-01-11 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8234. Resolution: Fixed Fixed via 08e550c98674738ab883ea84c0350093c9765ab6 > Cache JobExecutionResult fro

[jira] [Resolved] (FLINK-8412) Show outdated warning for 1.3 docs

2018-01-11 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8412. - Resolution: Fixed Fixed in 0c1cdb2cc3e5becab9344c2b9b30cad14b62331a > Show outdated warning for 1

[GitHub] flink pull request #5282: [FLINK-6352] [kafka] Timestamp-based offset config...

2018-01-11 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5282 [FLINK-6352] [kafka] Timestamp-based offset configuration for FlinkKafkaConsumer ## What is the purpose of the change This PR is based on @zjureel's initial efforts on the feature in #3915

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322108#comment-16322108 ] ASF GitHub Bot commented on FLINK-6352: --- GitHub user tzulitai opened a pull request:

[GitHub] flink issue #5282: [FLINK-6352] [kafka] Timestamp-based offset configuration...

2018-01-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5282 cc @zjureel ---

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322109#comment-16322109 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on the issue

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2018-01-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3915 Hi @zjureel, I went ahead to address my own review / concerns with the change in another PR that is based on your current work: #5282. I hope that is okay, and would be great if you would like to re

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322119#comment-16322119 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #5194: [FLINK-8233][flip6] Add JobExecutionResultHandler

2018-01-11 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5194#discussion_r160942627 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandlerTest.java --- @@ -0,0 +1,160 @@ +/* + * License

[jira] [Commented] (FLINK-8233) Expose JobExecutionResult via HTTP

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322126#comment-16322126 ] ASF GitHub Bot commented on FLINK-8233: --- Github user GJL commented on a diff in the

[jira] [Updated] (FLINK-8371) Buffers are not recycled in a non-spilled SpillableSubpartition upon release

2018-01-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8371: Fix Version/s: 1.5.0 > Buffers are not recycled in a non-spilled SpillableSubpartition upon

[jira] [Updated] (FLINK-8406) BucketingSink does not detect hadoop file systems

2018-01-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8406: Fix Version/s: 1.4.1 1.5.0 > BucketingSink does not detect hadoop file sy

[jira] [Updated] (FLINK-8413) Snapshot state of aggregated data is not maintained in flink's checkpointing

2018-01-11 Thread suganya (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] suganya updated FLINK-8413: --- Summary: Snapshot state of aggregated data is not maintained in flink's checkpointing (was: Snapshote state o

[jira] [Updated] (FLINK-8413) Snapshote state of aggregated data is not maintained in flink's checkpointing

2018-01-11 Thread suganya (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] suganya updated FLINK-8413: --- Summary: Snapshote state of aggregated data is not maintained in flink's checkpointing (was: Checkpointing in

[jira] [Updated] (FLINK-5728) FlinkKafkaProducer should flush on checkpoint by default

2018-01-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-5728: Fix Version/s: 1.5.0 > FlinkKafkaProducer should flush on checkpoint by default > --

[jira] [Updated] (FLINK-5704) Deprecate FlinkKafkaConsumer constructors in favor of improvements to decoupling from Kafka offset committing

2018-01-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-5704: Fix Version/s: 1.5.0 > Deprecate FlinkKafkaConsumer constructors in favor of improvements to

[GitHub] flink pull request #5224: [FLINK-8338] [flip6] Make CustomCommandLines non s...

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5224#discussion_r160946952 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/util/MockedCliFrontend.java --- @@ -20,40 +20,22 @@ import org.apache.flin

[jira] [Commented] (FLINK-8338) Make CustomCommandLines non static in CliFrontend

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322158#comment-16322158 ] ASF GitHub Bot commented on FLINK-8338: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5283: Fixed doc typo in DataStream API

2018-01-11 Thread elbaulp
GitHub user elbaulp opened a pull request: https://github.com/apache/flink/pull/5283 Fixed doc typo in DataStream API Miss-spelled multiple as muplitple You can merge this pull request into a Git repository by running: $ git pull https://github.com/elbaulp/flink fix-doc-typo A

[GitHub] flink issue #5224: [FLINK-8338] [flip6] Make CustomCommandLines non static i...

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5224 Thanks for your review @GJL. I've addressed your comments and rebased onto the latest master. ---

[jira] [Commented] (FLINK-8338) Make CustomCommandLines non static in CliFrontend

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322168#comment-16322168 ] ASF GitHub Bot commented on FLINK-8338: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #5194: [FLINK-8233][flip6] Add JobExecutionResultHandler

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5194#discussion_r160950656 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandlerTest.java --- @@ -0,0 +1,160 @@ +/* +

[jira] [Commented] (FLINK-8233) Expose JobExecutionResult via HTTP

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322173#comment-16322173 ] ASF GitHub Bot commented on FLINK-8233: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #:

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/commit/a03cdfabe6eab48509b42a6831a21e488b9c3e80#commitcomment-26789565 In .travis.yml: In .travis.yml on line 93: You're right. I'll correct it. ---

[GitHub] flink issue #5188: [FLINK-8296] [kafka] Rework FlinkKafkaConsumerBaseTest to...

2018-01-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5188 Thank you for the review @pnowojski! Have addressed your comments. ---

[jira] [Commented] (FLINK-8296) Rework FlinkKafkaConsumerBestTest to not use Java reflection for dependency injection

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322189#comment-16322189 ] ASF GitHub Bot commented on FLINK-8296: --- Github user tzulitai commented on the issue

[jira] [Commented] (FLINK-8413) Snapshot state of aggregated data is not maintained in flink's checkpointing

2018-01-11 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322191#comment-16322191 ] Stefan Richter commented on FLINK-8413: --- Can you share a (minimal) code example that

[jira] [Comment Edited] (FLINK-8413) Snapshot state of aggregated data is not maintained in flink's checkpointing

2018-01-11 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322191#comment-16322191 ] Stefan Richter edited comment on FLINK-8413 at 1/11/18 1:25 PM:

[GitHub] flink issue #5283: Fixed doc typo in DataStream API

2018-01-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5283 Thanks, good catch! @elbaulp can you include the `[hotfix]` and `[doc]` tags to the commit message? All our commit requires proper tags to indicate the issue id (or `hotfix` for typos), and

[jira] [Created] (FLINK-8414) Gelly performance seriously decreases when using the suggested parallelism configuration

2018-01-11 Thread flora karniav (JIRA)
flora karniav created FLINK-8414: Summary: Gelly performance seriously decreases when using the suggested parallelism configuration Key: FLINK-8414 URL: https://issues.apache.org/jira/browse/FLINK-8414

[jira] [Updated] (FLINK-8414) Gelly performance seriously decreases when using the suggested parallelism configuration

2018-01-11 Thread flora karniav (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] flora karniav updated FLINK-8414: - Description: I am running Gelly examples with different datasets in a cluster of 5 machines (1 Jo

[jira] [Closed] (FLINK-7499) double buffer release in SpillableSubpartitionView

2018-01-11 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-7499. -- Resolution: Fixed Fix Version/s: 1.4.1 > double buffer release in SpillableSubpartitionView > ---

[jira] [Comment Edited] (FLINK-7499) double buffer release in SpillableSubpartitionView

2018-01-11 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319953#comment-16319953 ] Nico Kruber edited comment on FLINK-7499 at 1/11/18 2:13 PM: -

[jira] [Comment Edited] (FLINK-7499) double buffer release in SpillableSubpartitionView

2018-01-11 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319953#comment-16319953 ] Nico Kruber edited comment on FLINK-7499 at 1/11/18 2:13 PM: -

[jira] [Closed] (FLINK-8371) Buffers are not recycled in a non-spilled SpillableSubpartition upon release

2018-01-11 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-8371. -- Resolution: Fixed Fix Version/s: 1.4.1 Merged. 1.5.0: 4c3f6075bcad0e85db947d7db7817a678d21a85e 1

[GitHub] flink pull request #5275: [FLINK-7499][io] fix double buffer release in Spil...

2018-01-11 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/5275 ---

[GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5225#discussion_r160970084 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java --- @@ -51,45 +45,23 @@ public String getId() { }

[GitHub] flink issue #5276: [FLINK-8371][network] always recycle Buffers when releasi...

2018-01-11 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5276 closed via 71ede3992afe8f6907dd3c6c1e232c5b745048b4 ---

[GitHub] flink issue #5275: [FLINK-7499][io] fix double buffer release in SpillableSu...

2018-01-11 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5275 closed via a316989e5dfbb1dc0d555193425a4d6bd5f42d8d ---

[GitHub] flink pull request #5276: [FLINK-8371][network] always recycle Buffers when ...

2018-01-11 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/5276 ---

[jira] [Commented] (FLINK-8339) Let CustomCommandLine return a ClusterDescriptor

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322269#comment-16322269 ] ASF GitHub Bot commented on FLINK-8339: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8371) Buffers are not recycled in a non-spilled SpillableSubpartition upon release

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322270#comment-16322270 ] ASF GitHub Bot commented on FLINK-8371: --- Github user NicoK commented on the issue:

[jira] [Commented] (FLINK-8371) Buffers are not recycled in a non-spilled SpillableSubpartition upon release

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322271#comment-16322271 ] ASF GitHub Bot commented on FLINK-8371: --- Github user NicoK closed the pull request a

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322268#comment-16322268 ] ASF GitHub Bot commented on FLINK-7499: --- Github user NicoK closed the pull request a

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322267#comment-16322267 ] ASF GitHub Bot commented on FLINK-7499: --- Github user NicoK commented on the issue:

[GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5225#discussion_r160970851 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Ex

[GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5225#discussion_r160970724 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java --- @@ -51,45 +45,23 @@ public String getId() { }

[jira] [Commented] (FLINK-8339) Let CustomCommandLine return a ClusterDescriptor

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322274#comment-16322274 ] ASF GitHub Bot commented on FLINK-8339: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8339) Let CustomCommandLine return a ClusterDescriptor

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322275#comment-16322275 ] ASF GitHub Bot commented on FLINK-8339: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...

2018-01-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5225#discussion_r160972443 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Ex

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322298#comment-16322298 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-11 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r160942938 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java --- @@ -316,7 +292,38 @@ private void i

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322294#comment-16322294 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322289#comment-16322289 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322297#comment-16322297 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8339) Let CustomCommandLine return a ClusterDescriptor

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322285#comment-16322285 ] ASF GitHub Bot commented on FLINK-8339: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322287#comment-16322287 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322295#comment-16322295 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-11 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r160948522 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TestTaskStateManager.java --- @@ -0,0 +1,185 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322304#comment-16322304 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322290#comment-16322290 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff i

  1   2   3   >