[jira] [Resolved] (FLINK-8427) Checkstyle for org.apache.flink.optimizer.costs

2018-01-15 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan resolved FLINK-8427. --- Resolution: Won't Fix Assignee: (was: Greg Hogan) > Checkstyle for

[GitHub] flink pull request #5294: [FLINK-8427] [optimizer] Checkstyle for org.apache...

2018-01-15 Thread greghogan
Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/5294 ---

[jira] [Commented] (FLINK-6813) Add TIMESTAMPDIFF supported in SQL

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326189#comment-16326189 ] ASF GitHub Bot commented on FLINK-6813: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #4117: [FLINK-6813][table]Add TIMESTAMPDIFF supported in ...

2018-01-15 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4117#discussion_r161504809 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -702,12 +703,15 @@ object

[jira] [Commented] (FLINK-8316) The CsvTableSink and the CsvInputFormat are not in sync

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326183#comment-16326183 ] ASF GitHub Bot commented on FLINK-8316: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #5210: [FLINK-8316] [table] The CsvTableSink and the CsvInputFor...

2018-01-15 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5210 @xccui sorry for the late reply. Sometimes we add new feature when we have the requirement. :) Can you give me a example about add the trailing delimiter as a new feature? Thanks,

[jira] [Commented] (FLINK-8289) The RestServerEndpoint should return the address with real ip when getRestAdddress

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326181#comment-16326181 ] ASF GitHub Bot commented on FLINK-8289: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-15 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5190 Great to hear @shuai-xu. Then let's close this PR and open a new JIRA issue to separate the bind and advertised REST address for the client. ---

[jira] [Commented] (FLINK-8432) Add openstack swift filesystem

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326175#comment-16326175 ] ASF GitHub Bot commented on FLINK-8432: --- Github user jelmerk commented on the issue:

[GitHub] flink issue #5296: [FLINK-8432] [filesystem-connector] Add support for opens...

2018-01-15 Thread jelmerk
Github user jelmerk commented on the issue: https://github.com/apache/flink/pull/5296 Hi @tillrohrmann Those files with a lot of changes are unfortunately copied from hadoop, the readme file contains more information about how this works. I am not overly happy about the this

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326168#comment-16326168 ] ASF GitHub Bot commented on FLINK-7511: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r161497658 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326164#comment-16326164 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supported

2018-01-15 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5241 @fhueske Thanks for your review and suggestion about FLINK-8355, I have fixed the FLINK-8355 issue in this PR. I appreciate if you can review the change again. Best, Jincheng ---

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2018-01-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5133 merging. ---

[jira] [Commented] (FLINK-8082) Bump version compatibility check to 1.4

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326139#comment-16326139 ] ASF GitHub Bot commented on FLINK-8082: --- Github user zentol commented on the issue:

[GitHub] flink issue #5262: [FLINK-8082][build] Bump flink version for japicmp plugin

2018-01-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5262 merging. ---

[GitHub] flink issue #5293: [hotfix][docs] Mention maven dependency for RocksDB state...

2018-01-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5293 merging. ---

[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326137#comment-16326137 ] ASF GitHub Bot commented on FLINK-8401: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326136#comment-16326136 ] ASF GitHub Bot commented on FLINK-8401: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...

2018-01-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161489425 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6

[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...

2018-01-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161489395 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6

[jira] [Assigned] (FLINK-8230) NPE in OrcRowInputFormat on nested structs

2018-01-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-8230: Assignee: Fabian Hueske > NPE in OrcRowInputFormat on nested structs >

[jira] [Updated] (FLINK-8230) NPE in OrcRowInputFormat on nested structs

2018-01-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-8230: - Fix Version/s: 1.4.1 > NPE in OrcRowInputFormat on nested structs >

[jira] [Updated] (FLINK-8230) NPE in OrcRowInputFormat on nested structs

2018-01-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-8230: - Priority: Blocker (was: Minor) > NPE in OrcRowInputFormat on nested structs >

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326109#comment-16326109 ] ASF GitHub Bot commented on FLINK-7511: --- Github user dawidwys commented on a diff in the pull

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-15 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r161483614 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to the

[jira] [Assigned] (FLINK-8421) HeapInternalTimerService should reconfigure compatible key / namespace serializers on restore

2018-01-15 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-8421: -- Assignee: Tzu-Li (Gordon) Tai > HeapInternalTimerService should reconfigure

[jira] [Commented] (FLINK-8289) The RestServerEndpoint should return the address with real ip when getRestAdddress

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326045#comment-16326045 ] ASF GitHub Bot commented on FLINK-8289: --- Github user shuai-xu commented on the issue:

[jira] [Commented] (FLINK-8433) Update code example for "Managed Operator State" documentation

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326047#comment-16326047 ] ASF GitHub Bot commented on FLINK-8433: --- GitHub user zhangminglei opened a pull request:

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-15 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/5190 @tillrohrmann , In fact, the original problem I'm concerned with has been fix by your commit "[FLINK-8119] [flip6] Wire correct Flip6 components in Flip6YarnClusterDescriptor", which set the

[GitHub] flink pull request #5298: [FLINK-8433] [doc] Remove ununsed CheckpointedRest...

2018-01-15 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/5298 [FLINK-8433] [doc] Remove ununsed CheckpointedRestoring interface ## What is the purpose of the change *Update the document, as the ```CheckpointedRestoring``` interface introduced in

[jira] [Commented] (FLINK-8433) Update code example for "Managed Operator State" documentation

2018-01-15 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326024#comment-16326024 ] mingleizhang commented on FLINK-8433: - I will take into this issue soon. > Update code example for

[jira] [Commented] (FLINK-8434) The new yarn resource manager should take over the running task managers after failover

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326011#comment-16326011 ] ASF GitHub Bot commented on FLINK-8434: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #5297: [FLINK-8434] Take over the running task manager af...

2018-01-15 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5297 [FLINK-8434] Take over the running task manager after yarn app master failvoer ## What is the purpose of the change *This pull request makes the yarn resource manager could take over

[jira] [Updated] (FLINK-8434) The new yarn resource manager should take over the running task managers after failover

2018-01-15 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu updated FLINK-8434: Description: The app master which container the job master and yarn resource manager may failover during

[jira] [Created] (FLINK-8434) The new yarn resource manager should take over the running task managers after failover

2018-01-15 Thread shuai.xu (JIRA)
shuai.xu created FLINK-8434: --- Summary: The new yarn resource manager should take over the running task managers after failover Key: FLINK-8434 URL: https://issues.apache.org/jira/browse/FLINK-8434 Project:

[jira] [Commented] (FLINK-4504) Support user to decide whether the result of an operator is presistent

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325996#comment-16325996 ] ASF GitHub Bot commented on FLINK-4504: --- Github user shuai-xu closed the pull request at:

[jira] [Commented] (FLINK-4444) Add a DFSInputChannel and DFSSubPartition

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325995#comment-16325995 ] ASF GitHub Bot commented on FLINK-: --- Github user shuai-xu closed the pull request at:

[GitHub] flink pull request #2675: [FLINK-4504][dataset api]Support user to decide wh...

2018-01-15 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/2675 ---

[GitHub] flink pull request #2674: [FLINK-4444][runtime]Add a InputChannel and Result...

2018-01-15 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/2674 ---

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325989#comment-16325989 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161450876 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java --- @@ -199,6 +199,19 @@ public

<    1   2