[GitHub] flink pull request #5895: Fix kerberos security configuration for YarnTaskEx...

2018-04-23 Thread suez1224
Github user suez1224 closed the pull request at: https://github.com/apache/flink/pull/5895 ---

[GitHub] flink pull request #5895: Fix kerberos security configuration for YarnTaskEx...

2018-04-23 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5895 Fix kerberos security configuration for YarnTaskExecutor ## What is the purpose of the change Fix broken YARN kerberos integration for flip-6. ## Brief change log

[GitHub] flink pull request #5896: [FLINK-8286][Security] Fix kerberos security confi...

2018-04-23 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5896 [FLINK-8286][Security] Fix kerberos security configuration for YarnTaskExecutor ## What is the purpose of the change Fix broken YARN kerberos integration for flip-6. ## Brief

[jira] [Commented] (FLINK-8286) Fix Flink-Yarn-Kerberos integration for flip-6

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447648#comment-16447648 ] ASF GitHub Bot commented on FLINK-8286: --- GitHub user suez1224 opened a pull request:

[jira] [Assigned] (FLINK-9234) Commons Logging is missing from shaded Flink Table library

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-9234: --- Assignee: Timo Walther > Commons Logging is missing from shaded Flink Table library > ---

[GitHub] flink issue #5878: [FLINK-9216][Streaming] Fix comparator violation

2018-04-23 Thread Xpray
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/5878 @StephanEwen I've added a test case, please have a look. Best. ---

[jira] [Commented] (FLINK-9216) Fix comparator violation

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447681#comment-16447681 ] ASF GitHub Bot commented on FLINK-9216: --- Github user Xpray commented on the issue:

[GitHub] flink pull request #5885: [FLINK-8715] Remove usage of StateDescriptor in st...

2018-04-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5885#discussion_r183309701 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -1177

[jira] [Commented] (FLINK-8715) RocksDB does not propagate reconfiguration of serializer to the states

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447724#comment-16447724 ] ASF GitHub Bot commented on FLINK-8715: --- Github user tzulitai commented on a diff in

[GitHub] flink issue #5688: [FLINK-6968][Table API & SQL] Add Queryable table sink.

2018-04-23 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/flink/pull/5688 @suez1224 Conflict resolved. ---

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447755#comment-16447755 ] ASF GitHub Bot commented on FLINK-6968: --- Github user liurenjie1024 commented on the

[GitHub] flink pull request #5897: [FLINK-9234] [table] Fix missing dependencies for ...

2018-04-23 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/5897 [FLINK-9234] [table] Fix missing dependencies for external catalogs ## What is the purpose of the change This PR adds the required dependencies `commons-logging` (via `slf4j`) and `commons-

[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447811#comment-16447811 ] ASF GitHub Bot commented on FLINK-9234: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-04-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5897 @zentol @EronWright would be great if you could verify my changes ---

[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447809#comment-16447809 ] ASF GitHub Bot commented on FLINK-9234: --- GitHub user twalthr opened a pull request:

[jira] [Created] (FLINK-9237) Some description about The FsStateBackend in the Docs。

2018-04-23 Thread liuzhixin (JIRA)
liuzhixin created FLINK-9237: Summary: Some description about The FsStateBackend in the Docs。 Key: FLINK-9237 URL: https://issues.apache.org/jira/browse/FLINK-9237 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-9237) Some description about The FsStateBackend in the Docs。

2018-04-23 Thread liuzhixin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhixin updated FLINK-9237: - Priority: Minor (was: Major) > Some description about The FsStateBackend in the Docs。 > -

[jira] [Updated] (FLINK-9237) Some description about The FsStateBackend in the Docs。

2018-04-23 Thread liuzhixin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhixin updated FLINK-9237: - Issue Type: Wish (was: Bug) > Some description about The FsStateBackend in the Docs。 > --

[jira] [Assigned] (FLINK-9237) Some description about The FsStateBackend in the Docs。

2018-04-23 Thread yuqi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi reassigned FLINK-9237: --- Assignee: yuqi > Some description about The FsStateBackend in the Docs。 > ---

[jira] [Created] (FLINK-9238) There are some questions about BuckeingSink when sinking data to S3.

2018-04-23 Thread liuzhixin (JIRA)
liuzhixin created FLINK-9238: Summary: There are some questions about BuckeingSink when sinking data to S3. Key: FLINK-9238 URL: https://issues.apache.org/jira/browse/FLINK-9238 Project: Flink

[jira] [Commented] (FLINK-9237) Some description about The FsStateBackend in the Docs。

2018-04-23 Thread yuqi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447913#comment-16447913 ] yuqi commented on FLINK-9237: - Yes, according to the code, `false` means enable asynchronous c

[jira] [Created] (FLINK-9239) Reintroduce example program in quickstarts

2018-04-23 Thread Timo Walther (JIRA)
Timo Walther created FLINK-9239: --- Summary: Reintroduce example program in quickstarts Key: FLINK-9239 URL: https://issues.apache.org/jira/browse/FLINK-9239 Project: Flink Issue Type: Improvemen

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447974#comment-16447974 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447970#comment-16447970 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5888#discussion_r183356514 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -231,18 +243,20 @@ public void

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5888#discussion_r18334 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -180,10 +180,22 @@ public void

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5888#discussion_r183355330 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -180,10 +180,22 @@ public void

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447972#comment-16447972 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5888#discussion_r183356576 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -231,18 +243,20 @@ public void

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447975#comment-16447975 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447976#comment-16447976 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5888#discussion_r183355953 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -180,10 +180,22 @@ public void

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447971#comment-16447971 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5888#discussion_r183357018 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java --- @@ -96,9 +108,26 @@ public void testFullArch

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5888#discussion_r183356809 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -231,18 +243,20 @@ public void

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447973#comment-16447973 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHa...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5893#discussion_r183360526 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfoTest.java --- @@ -0,0 +1,57 @@ +/* + * Li

[GitHub] flink pull request #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHa...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5893#discussion_r183358123 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/SubtasksAllAccumulatorsHandler.java --- @@ -0,0 +1,93 @@ +/* + * Lice

[GitHub] flink pull request #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHa...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5893#discussion_r183359424 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfo.java --- @@ -0,0 +1,139 @@ +/* + * Licen

[GitHub] flink pull request #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHa...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5893#discussion_r183360065 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/SubtasksAllAccumulatorsHandler.java --- @@ -0,0 +1,93 @@ +/* + * Lice

[GitHub] flink pull request #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHa...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5893#discussion_r183357592 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/SubtasksAllAccumulatorsHandler.java --- @@ -0,0 +1,93 @@ +/* + * Lice

[GitHub] flink pull request #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHa...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5893#discussion_r183360560 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfoTest.java --- @@ -0,0 +1,57 @@ +/* + * Li

[GitHub] flink pull request #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHa...

2018-04-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5893#discussion_r183357875 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfo.java --- @@ -0,0 +1,139 @@ +/* + * Licen

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447988#comment-16447988 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447990#comment-16447990 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447987#comment-16447987 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447984#comment-16447984 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447986#comment-16447986 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447985#comment-16447985 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447989#comment-16447989 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on a diff in t

[jira] [Assigned] (FLINK-9239) Reintroduce example program in quickstarts

2018-04-23 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-9239: --- Assignee: mingleizhang > Reintroduce example program in quickstarts > ---

[jira] [Commented] (FLINK-9239) Reintroduce example program in quickstarts

2018-04-23 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447998#comment-16447998 ] mingleizhang commented on FLINK-9239: - I would choose a {{WordCount}} as an example fo

[jira] [Commented] (FLINK-9239) Reintroduce example program in quickstarts

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448007#comment-16448007 ] Timo Walther commented on FLINK-9239: - We should discuss this issue first. Maybe a lit

[GitHub] flink pull request #5898: [FLINK-9229] [table] Fix literal handling in code ...

2018-04-23 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/5898 [FLINK-9229] [table] Fix literal handling in code generation ## What is the purpose of the change This PR fixes wrong usages of `generateNonNullLiteral`. It has been used at locations where

[jira] [Commented] (FLINK-9229) Fix literal handling in code generation

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448013#comment-16448013 ] ASF GitHub Bot commented on FLINK-9229: --- GitHub user twalthr opened a pull request:

[jira] [Commented] (FLINK-9239) Reintroduce example program in quickstarts

2018-04-23 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448018#comment-16448018 ] mingleizhang commented on FLINK-9239: - Hi, [~twalthr] It is a good idea. How about usi

[jira] [Commented] (FLINK-9239) Reintroduce example program in quickstarts

2018-04-23 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448027#comment-16448027 ] mingleizhang commented on FLINK-9239: - After thinking a little while, Only for you sai

[jira] [Commented] (FLINK-9113) Data loss in BucketingSink when writing to local filesystem

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448029#comment-16448029 ] Timo Walther commented on FLINK-9113: - I will also apply this fix to the 1.4 branch. F

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5893 @zentol thanks for your review. I have updated the PR. ---

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448030#comment-16448030 ] ASF GitHub Bot commented on FLINK-9212: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #5890: [FLINK-8999] [e2e] Ensure the job has an operator with op...

2018-04-23 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5890 Hello, @StefanRRichter . Could you review this code please ? ---

[jira] [Commented] (FLINK-8999) Ensure the job has an operator with operator state.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448034#comment-16448034 ] ASF GitHub Bot commented on FLINK-8999: --- Github user zhangminglei commented on the i

[jira] [Commented] (FLINK-9113) Data loss in BucketingSink when writing to local filesystem

2018-04-23 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448035#comment-16448035 ] Kostas Kloudas commented on FLINK-9113: --- I am fine with backporting the fix to 1.4,

[jira] [Commented] (FLINK-9239) Reintroduce example program in quickstarts

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448038#comment-16448038 ] Timo Walther commented on FLINK-9239: - What is your opinion on this [~StephanEwen]? >

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448040#comment-16448040 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on the issue:

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5893 You have not changed the type of `SubtasksAllAccumulatorsInfo#jobVertexId` to `JobVertexID`. ---

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5893 i saw legacy/SubtasksAllAccumulatorsHandler.java used gen.writeStringField("id", jobVertex.getJobVertexId().toString());. if i change the type of `SubtasksAllAccumulatorsInfo#jobVertexId` to

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448042#comment-16448042 ] ASF GitHub Bot commented on FLINK-9212: --- Github user yew1eb commented on the issue:

[jira] [Commented] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-23 Thread Triones Deng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448079#comment-16448079 ] Triones Deng commented on FLINK-9231: - [~yuzhih...@gmail.com] I notice that there are

[GitHub] flink issue #5888: [FLINK-9194] [histroyserver] Finished jobs are not archiv...

2018-04-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5888 I'm currently preparing a PR for adding HistoryServer support to Flip6 and will integrate this PR into that one. ---

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448092#comment-16448092 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on the issue:

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5893 You have to use the `JobVertexIDSerializer` for that field. ---

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448110#comment-16448110 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on the issue:

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5893 see `JobVertexDetailsInfo` on how to use it. ---

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448136#comment-16448136 ] ASF GitHub Bot commented on FLINK-9212: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448142#comment-16448142 ] Ted Yu commented on FLINK-9231: --- Sounds good to me. > Enable SO_REUSEADDR on listen sockets

[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Only log the exception when ...

2018-04-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5879 I think it is fine that exceptions are logged under debug, it's just that we use exceptions in the normal life-cycle. I'm wondering if we could replace these kind of exceptions with a special `Expecte

[jira] [Commented] (FLINK-9215) TaskManager Releasing - org.apache.flink.util.FlinkException

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448160#comment-16448160 ] ASF GitHub Bot commented on FLINK-9215: --- Github user zentol commented on the issue:

[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Only log the exception when ...

2018-04-23 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 @zentol Thanks for you reply, I prefer the way to introduce a `ExpectedLifecycleException`, I think maybe it could be used in some other places in the future. Addressing this... ---

[jira] [Commented] (FLINK-9215) TaskManager Releasing - org.apache.flink.util.FlinkException

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448172#comment-16448172 ] ASF GitHub Bot commented on FLINK-9215: --- Github user sihuazhou commented on the issu

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5893 @zentol thanks you. I updated the code. :laughing: ---

[jira] [Commented] (FLINK-9212) Port SubtasksAllAccumulatorsHandler to new REST endpoint

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448178#comment-16448178 ] ASF GitHub Bot commented on FLINK-9212: --- Github user yew1eb commented on the issue:

[jira] [Commented] (FLINK-9080) Flink Scheduler goes OOM, suspecting a memory leak

2018-04-23 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448183#comment-16448183 ] Stefan Richter commented on FLINK-9080: --- [~rohsing] could you somehow provide your h

[GitHub] flink pull request #5899: Klink

2018-04-23 Thread bitsilly
GitHub user bitsilly opened a pull request: https://github.com/apache/flink/pull/5899 Klink *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please g

[GitHub] flink issue #5899: Klink

2018-04-23 Thread bitsilly
Github user bitsilly commented on the issue: https://github.com/apache/flink/pull/5899 OK ---

[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Only log the exception when ...

2018-04-23 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 Hi @zentol I updated the PR, it's already for another review. ---

[jira] [Commented] (FLINK-9215) TaskManager Releasing - org.apache.flink.util.FlinkException

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448212#comment-16448212 ] ASF GitHub Bot commented on FLINK-9215: --- Github user sihuazhou commented on the issu

[GitHub] flink issue #5899: Klink

2018-04-23 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5899 Hi @bitsilly thanks for the works. I think maybe it better to describe your purpose of this PR and link with the corresponding JIRA(if this is not a hotfix). There is a guide template when you open

[jira] [Reopened] (FLINK-8600) BucketingSink errors out when used with Presto filesystem

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reopened FLINK-8600: - > BucketingSink errors out when used with Presto filesystem >

[jira] [Commented] (FLINK-8600) BucketingSink errors out when used with Presto filesystem

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448255#comment-16448255 ] Timo Walther commented on FLINK-8600: - Fixed in 1.4.3: b4a886149cc5432fdb58c8785047399

[jira] [Updated] (FLINK-8600) BucketingSink errors out when used with Presto filesystem

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-8600: Fix Version/s: 1.4.3 > BucketingSink errors out when used with Presto filesystem > -

[jira] [Resolved] (FLINK-8600) BucketingSink errors out when used with Presto filesystem

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8600. - Resolution: Fixed > BucketingSink errors out when used with Presto filesystem > --

[jira] [Commented] (FLINK-9113) Data loss in BucketingSink when writing to local filesystem

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448259#comment-16448259 ] Timo Walther commented on FLINK-9113: - Fixed in 1.4.3: 896797be71e920110aa270402d03196

[jira] [Updated] (FLINK-9113) Data loss in BucketingSink when writing to local filesystem

2018-04-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-9113: Fix Version/s: 1.4.3 > Data loss in BucketingSink when writing to local filesystem > ---

[jira] [Updated] (FLINK-9207) Client returns SUCCESS(0) return code for canceled job

2018-04-23 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-9207: Priority: Blocker (was: Minor) > Client returns SUCCESS(0) return code for canceled job > -

[GitHub] flink issue #5610: [FLINK-8537][table]Add a Kafka table source factory with ...

2018-04-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5610 Thank you for the PR @xccui. The code very looks good to me. I will fix some minor things during merge. ---

[jira] [Commented] (FLINK-8537) Add a Kafka table source factory with Avro format support

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448306#comment-16448306 ] ASF GitHub Bot commented on FLINK-8537: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5890: [FLINK-8999] [e2e] Ensure the job has an operator with op...

2018-04-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5890 Hi @zhangminglei . I think there might unfortunately be a small misunderstanding: this issue was a subtask for the task of creating a single general purpose test job, i.e. a single job that co

[jira] [Commented] (FLINK-8999) Ensure the job has an operator with operator state.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448315#comment-16448315 ] ASF GitHub Bot commented on FLINK-8999: --- Github user StefanRRichter commented on the

[jira] [Comment Edited] (FLINK-9237) Some description about The FsStateBackend in the Docs。

2018-04-23 Thread yuqi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447913#comment-16447913 ] yuqi edited comment on FLINK-9237 at 4/23/18 3:36 PM: -- Yes, according

  1   2   >