[jira] [Commented] (FLINK-8986) End-to-end test: REST

2018-04-26 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455771#comment-16455771 ] Rong Rong commented on FLINK-8986: -- Hi [~Zentol], I addressed most of your comments and created another

[GitHub] flink issue #5916: [hotfix][tests] remove redundant rebalance in SuccessAfte...

2018-04-26 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5916 LGTM :) ---

[jira] [Comment Edited] (FLINK-7795) Utilize error-prone to discover common coding mistakes

2018-04-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345955#comment-16345955 ] Ted Yu edited comment on FLINK-7795 at 4/27/18 3:29 AM: error-prone has JDK 8

[jira] [Commented] (FLINK-9214) YarnClient should be stopped in YARNSessionCapacitySchedulerITCase#testDetachedPerJobYarnClusterInternal

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455703#comment-16455703 ] ASF GitHub Bot commented on FLINK-9214: --- Github user tedyu commented on the issue:

[GitHub] flink issue #5892: [FLINK-9214] YarnClient should be stopped in YARNSessionC...

2018-04-26 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/5892 lgtm ---

[jira] [Commented] (FLINK-9178) Add rate control for kafka source

2018-04-26 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455677#comment-16455677 ] buptljy commented on FLINK-9178: [~app-tarush] I think so, and there is another option is using the

[GitHub] flink pull request #5924: [hotfix][README.md] Update building prerequisites

2018-04-26 Thread W4anD0eR96
GitHub user W4anD0eR96 opened a pull request: https://github.com/apache/flink/pull/5924 [hotfix][README.md] Update building prerequisites You can merge this pull request into a Git repository by running: $ git pull https://github.com/W4anD0eR96/flink patch-1 Alternatively

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455598#comment-16455598 ] ASF GitHub Bot commented on FLINK-9138: --- Github user narayaruna commented on the issue:

[GitHub] flink issue #5860: [FLINK-9138][filesystem-connectors] Implement time based ...

2018-04-26 Thread narayaruna
Github user narayaruna commented on the issue: https://github.com/apache/flink/pull/5860 @glaksh100 If you are using BucketingSink with S3, you might be interested in this [PR](https://github.com/apache/flink/pull/4607) as well. ---

[jira] [Commented] (FLINK-6306) Sink for eventually consistent file systems

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455591#comment-16455591 ] ASF GitHub Bot commented on FLINK-6306: --- Github user narayaruna commented on the issue:

[GitHub] flink issue #4607: [FLINK-6306][connectors] Sink for eventually consistent f...

2018-04-26 Thread narayaruna
Github user narayaruna commented on the issue: https://github.com/apache/flink/pull/4607 @aljoscha can we merge this PR. This is very helpful to ingest data to S3 in a more reliable way. BucketingSink writing to S3 errors out making the data ingestion less reliable. ---

[jira] [Closed] (FLINK-6249) Distinct Aggregates for OVER window

2018-04-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6249. Resolution: Duplicate Fix Version/s: 1.6.0 Implemented via FLINK-8689 > Distinct Aggregates

[jira] [Closed] (FLINK-6388) Add support for DISTINCT into Code Generated Aggregations

2018-04-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6388. Resolution: Duplicate Fix Version/s: 1.6.0 Implemented via FLINK-8689 > Add support for

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454892#comment-16454892 ] ASF GitHub Bot commented on FLINK-8689: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6388) Add support for DISTINCT into Code Generated Aggregations

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454891#comment-16454891 ] ASF GitHub Bot commented on FLINK-6388: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3783: [FLINK-6388] Add support for DISTINCT into Code Ge...

2018-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3783 ---

[jira] [Closed] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-8689. Resolution: Implemented Fix Version/s: 1.6.0 Implemented for 1.6.0 with

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/ ---

[jira] [Commented] (FLINK-8533) Support MasterTriggerRestoreHook state reinitialization

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454653#comment-16454653 ] ASF GitHub Bot commented on FLINK-8533: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-8533) Support MasterTriggerRestoreHook state reinitialization

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454651#comment-16454651 ] ASF GitHub Bot commented on FLINK-8533: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-8533) Support MasterTriggerRestoreHook state reinitialization

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454654#comment-16454654 ] ASF GitHub Bot commented on FLINK-8533: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-8533) Support MasterTriggerRestoreHook state reinitialization

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454652#comment-16454652 ] ASF GitHub Bot commented on FLINK-8533: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5427: [FLINK-8533] [checkpointing] Support MasterTrigger...

2018-04-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5427#discussion_r184478068 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/MasterTriggerRestoreHook.java --- @@ -138,4 +158,11 @@ */

[GitHub] flink pull request #5427: [FLINK-8533] [checkpointing] Support MasterTrigger...

2018-04-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5427#discussion_r184477785 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -1009,6 +1013,11 @@ public boolean

[GitHub] flink pull request #5427: [FLINK-8533] [checkpointing] Support MasterTrigger...

2018-04-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5427#discussion_r184481704 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/hooks/MasterHooks.java --- @@ -291,6 +341,34 @@ else if

[GitHub] flink pull request #5427: [FLINK-8533] [checkpointing] Support MasterTrigger...

2018-04-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5427#discussion_r184482881 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1358,6 +1358,10 @@ class JobManager(

[jira] [Comment Edited] (FLINK-9159) Sanity check default timeout values

2018-04-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454535#comment-16454535 ] Fabian Hueske edited comment on FLINK-9159 at 4/26/18 4:56 PM: --- By default

[jira] [Commented] (FLINK-9159) Sanity check default timeout values

2018-04-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454535#comment-16454535 ] Fabian Hueske commented on FLINK-9159: -- By default Tez kills idle containers with a min timeout of 5

[jira] [Commented] (FLINK-9253) Make buffer count per InputGate always #channels*buffersPerChannel + ExclusiveBuffers

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454527#comment-16454527 ] ASF GitHub Bot commented on FLINK-9253: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #5923: [FLINK-9253][network] make the maximum floating bu...

2018-04-26 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5923 [FLINK-9253][network] make the maximum floating buffers count channel-type independent ## What is the purpose of the change The credit-based flow control path assigns exclusive buffers only

[jira] [Commented] (FLINK-8134) Add description to MessageHeaders

2018-04-26 Thread Maxim Belov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454519#comment-16454519 ] Maxim Belov commented on FLINK-8134: [~Zentol], thank you! > Add description to MessageHeaders >

[jira] [Assigned] (FLINK-8134) Add description to MessageHeaders

2018-04-26 Thread Maxim Belov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Belov reassigned FLINK-8134: -- Assignee: Maxim Belov > Add description to MessageHeaders > -

[jira] [Closed] (FLINK-8841) Duplicate MapSerializer and HashMapSerializer.

2018-04-26 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-8841. - Resolution: Fixed Merged on master with 3ac282322a3940da9d69f81b9bc189b6d0c0463f and on

[jira] [Commented] (FLINK-8841) Duplicate MapSerializer and HashMapSerializer.

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454490#comment-16454490 ] ASF GitHub Bot commented on FLINK-8841: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5910: [FLINK-8841] [state] Remove HashMapSerializer and ...

2018-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5910 ---

[GitHub] flink issue #3783: [FLINK-6388] Add support for DISTINCT into Code Generated...

2018-04-26 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3783 Hi @huawei-flink , I'll close this PR later today when merging #. # adds runtime support for distinct aggregation and follows a similar approach as this PR. However, it leverages

[jira] [Commented] (FLINK-6388) Add support for DISTINCT into Code Generated Aggregations

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454465#comment-16454465 ] ASF GitHub Bot commented on FLINK-6388: --- Github user fhueske commented on the issue:

[jira] [Assigned] (FLINK-9232) Add harness test for AggregationCodeGenerator

2018-04-26 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong reassigned FLINK-9232: Assignee: Rong Rong > Add harness test for AggregationCodeGenerator >

[jira] [Commented] (FLINK-8134) Add description to MessageHeaders

2018-04-26 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454460#comment-16454460 ] Chesnay Schepler commented on FLINK-8134: - [~maxbelov] I've given you contributor permissions, you

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454437#comment-16454437 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184442107 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala --- @@ -50,6 +50,155 @@ class

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454434#comment-16454434 ] ASF GitHub Bot commented on FLINK-8689: --- Github user walterddr commented on a diff in the pull

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-26 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184441869 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala --- @@ -47,60 +51,51 @@

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454418#comment-16454418 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184419816 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala --- @@ -47,60 +51,51 @@ class

[jira] [Commented] (FLINK-8780) Add Broadcast State documentation.

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454392#comment-16454392 ] ASF GitHub Bot commented on FLINK-8780: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request #5922: [FLINK-8780] [docs] Add Broadcast State documentat...

2018-04-26 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5922 [FLINK-8780] [docs] Add Broadcast State documentation. R @fhueske You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink broadcast-docs-inv2

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-26 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184429742 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala --- @@ -50,6 +50,155 @@ class

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454388#comment-16454388 ] ASF GitHub Bot commented on FLINK-8689: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454383#comment-16454383 ] ASF GitHub Bot commented on FLINK-8689: --- Github user walterddr commented on a diff in the pull

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-26 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184428065 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala --- @@ -50,6 +50,155 @@ class

[jira] [Commented] (FLINK-8134) Add description to MessageHeaders

2018-04-26 Thread Maxim Belov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454360#comment-16454360 ] Maxim Belov commented on FLINK-8134: [~Zentol], could you please assign it to me? > Add description

[jira] [Assigned] (FLINK-8978) End-to-end test: Job upgrade

2018-04-26 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Zagrebin reassigned FLINK-8978: -- Assignee: Andrey Zagrebin > End-to-end test: Job upgrade >

[jira] [Commented] (FLINK-9185) Potential null dereference in PrioritizedOperatorSubtaskState#resolvePrioritizedAlternatives

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454331#comment-16454331 ] ASF GitHub Bot commented on FLINK-9185: --- Github user tedyu commented on the issue:

[GitHub] flink issue #5894: [FLINK-9185] [runtime] Fix potential null dereference in ...

2018-04-26 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/5894 lgtm Please check test failure. ---

[jira] [Commented] (FLINK-9254) Move NotSoMiniClusterIterations to be an end-to-end test

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454307#comment-16454307 ] ASF GitHub Bot commented on FLINK-9254: --- Github user azagrebin commented on the issue:

[GitHub] flink issue #5921: [FLINK-9254] Move NotSoMiniClusterIterations to be an end...

2018-04-26 Thread azagrebin
Github user azagrebin commented on the issue: https://github.com/apache/flink/pull/5921 cc @StefanRRichter, @aljoscha ---

[jira] [Commented] (FLINK-9254) Move NotSoMiniClusterIterations to be an end-to-end test

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454301#comment-16454301 ] ASF GitHub Bot commented on FLINK-9254: --- GitHub user azagrebin opened a pull request:

[GitHub] flink pull request #5921: [FLINK-9254] Move NotSoMiniClusterIterations to be...

2018-04-26 Thread azagrebin
GitHub user azagrebin opened a pull request: https://github.com/apache/flink/pull/5921 [FLINK-9254] Move NotSoMiniClusterIterations to be an end-to-end test ## What is the purpose of the change This PR moves `NotSoMiniClusterIterations` to nightly e2e tests. ##

[jira] [Commented] (FLINK-9196) YARN: Flink binaries are not deleted from HDFS after cluster shutdown

2018-04-26 Thread yuqi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454295#comment-16454295 ] yuqi commented on FLINK-9196: - As far as i see, The problem may due to the fact that Clifront forget to delete

[jira] [Updated] (FLINK-9196) YARN: Flink binaries are not deleted from HDFS after cluster shutdown

2018-04-26 Thread yuqi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi updated FLINK-9196: Attachment: 0001-xxx.patch > YARN: Flink binaries are not deleted from HDFS after cluster shutdown >

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454275#comment-16454275 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #5894: [FLINK-9185] [runtime] Fix potential null dereference in ...

2018-04-26 Thread StephenJeson
Github user StephenJeson commented on the issue: https://github.com/apache/flink/pull/5894 @tedyu Are you available to review my code? ---

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184405910 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala --- @@ -50,6 +50,155 @@ class

[jira] [Commented] (FLINK-9185) Potential null dereference in PrioritizedOperatorSubtaskState#resolvePrioritizedAlternatives

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454273#comment-16454273 ] ASF GitHub Bot commented on FLINK-9185: --- Github user StephenJeson commented on the issue:

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454272#comment-16454272 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184405329 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala --- @@ -50,6 +50,155 @@ class

[jira] [Commented] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454237#comment-16454237 ] ASF GitHub Bot commented on FLINK-9231: --- GitHub user trionesadam opened a pull request:

[GitHub] flink pull request #5920: [FLINK-9231] [web] Enable SO_REUSEADDR on listen s...

2018-04-26 Thread trionesadam
GitHub user trionesadam opened a pull request: https://github.com/apache/flink/pull/5920 [FLINK-9231] [web] Enable SO_REUSEADDR on listen sockets for WebFront… ## What is the purpose of the change Enable SO_REUSEADDR on listen sockets for WebFrontendBootstrap,This allows

[jira] [Updated] (FLINK-9262) KeyedOneInputStreamOperatorTestHarness throws NPE creating snapshot

2018-04-26 Thread Chris Schneider (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Schneider updated FLINK-9262: --- Description: Although KeyedOneInputStreamOperatorTestHarness and other

[jira] [Created] (FLINK-9262) KeyedOneInputStreamOperatorTestHarness throws NPE creating snapshot

2018-04-26 Thread Chris Schneider (JIRA)
Chris Schneider created FLINK-9262: -- Summary: KeyedOneInputStreamOperatorTestHarness throws NPE creating snapshot Key: FLINK-9262 URL: https://issues.apache.org/jira/browse/FLINK-9262 Project: Flink

[jira] [Commented] (FLINK-7391) Normalize release entries

2018-04-26 Thread Congxian Qiu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454008#comment-16454008 ] Congxian Qiu commented on FLINK-7391: - Hi, [~Zentol], Could you tell me where does the source code of

[jira] [Updated] (FLINK-9261) Regression - Flink CLI and Web UI not working when SSL is enabled

2018-04-26 Thread Edward Rojas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Rojas updated FLINK-9261: Labels: regression (was: ) > Regression - Flink CLI and Web UI not working when SSL is enabled >

[jira] [Created] (FLINK-9261) Regression - Flink CLI and Web UI not working when SSL is enabled

2018-04-26 Thread Edward Rojas (JIRA)
Edward Rojas created FLINK-9261: --- Summary: Regression - Flink CLI and Web UI not working when SSL is enabled Key: FLINK-9261 URL: https://issues.apache.org/jira/browse/FLINK-9261 Project: Flink

[jira] [Commented] (FLINK-8237) BucketingSink throws NPE when Writer.duplicate returns null

2018-04-26 Thread Pavel Shvetsov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453944#comment-16453944 ] Pavel Shvetsov commented on FLINK-8237: --- [~gaborhermann] tell me please how to reproduce the issue?

[jira] [Updated] (FLINK-9196) YARN: Flink binaries are not deleted from HDFS after cluster shutdown

2018-04-26 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-9196: Description: When deploying on YARN in flip6 mode, the Flink binaries are not deleted from HDFS after the

[jira] [Updated] (FLINK-9196) YARN: Flink binaries are not deleted from HDFS after cluster shutdown

2018-04-26 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-9196: Description: When deploying on YARN in flip6 mode, the Flink binaries are not deleted from HDFS after the

[jira] [Commented] (FLINK-9178) Add rate control for kafka source

2018-04-26 Thread Tarush Grover (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453832#comment-16453832 ] Tarush Grover commented on FLINK-9178: -- [~wind_ljy] One small question when we say rate control do we

[GitHub] flink pull request #5919: [hotfix][state.md]modify typo in the state.md

2018-04-26 Thread maqingxiang
GitHub user maqingxiang opened a pull request: https://github.com/apache/flink/pull/5919 [hotfix][state.md]modify typo in the state.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/maqingxiang/flink fix-typo-in-state.md

[GitHub] flink pull request #5918: [hotfix][ListCheckpointed]modify parallelism in th...

2018-04-26 Thread maqingxiang
GitHub user maqingxiang opened a pull request: https://github.com/apache/flink/pull/5918 [hotfix][ListCheckpointed]modify parallelism in the annotation of ListCheckpointed You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-9201) same merge window will be fired twice if watermark already passed the merge window

2018-04-26 Thread yuemeng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453759#comment-16453759 ] yuemeng commented on FLINK-9201: hi [~till.rohrmann] can you check this issue? > same merge window will

[jira] [Comment Edited] (FLINK-9201) same merge window will be fired twice if watermark already passed the merge window

2018-04-26 Thread yuemeng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453759#comment-16453759 ] yuemeng edited comment on FLINK-9201 at 4/26/18 9:40 AM: - hi [~till.rohrmann] can

[jira] [Commented] (FLINK-9201) same merge window will be fired twice if watermark already passed the merge window

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453752#comment-16453752 ] ASF GitHub Bot commented on FLINK-9201: --- GitHub user hzyuemeng1 opened a pull request:

[GitHub] flink pull request #5917: [FLINK-9201] Fixed the same merge window will be f...

2018-04-26 Thread hzyuemeng1
GitHub user hzyuemeng1 opened a pull request: https://github.com/apache/flink/pull/5917 [FLINK-9201] Fixed the same merge window will be fired twice if water… …mark already passed the merge window *Thank you very much for contributing to Apache Flink - we are happy

[jira] [Closed] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-26 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-9259. - Resolution: Invalid Assignee: Kostas Kloudas Hi [~bob365]. As the exception says:

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453732#comment-16453732 ] ASF GitHub Bot commented on FLINK-5544: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3359: [FLINK-5544][streaming] Add InternalTimerService implemen...

2018-04-26 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3359 @shixiaogang are you still interested in contributing or collaborating on this feature? I think we should try to get this into Flink 1.6. What do you think? ---

[jira] [Commented] (FLINK-8841) Duplicate MapSerializer and HashMapSerializer.

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453721#comment-16453721 ] ASF GitHub Bot commented on FLINK-8841: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5910: [FLINK-8841] [state] Remove HashMapSerializer and use Map...

2018-04-26 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5910 LGTM 👍 ---

[jira] [Updated] (FLINK-9201) same merge window will be fired twice if watermark already passed the new merged window

2018-04-26 Thread yuemeng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuemeng updated FLINK-9201: --- Summary: same merge window will be fired twice if watermark already passed the new merged window (was: same

[jira] [Updated] (FLINK-9201) same merge window will be fired twice if watermark already passed the merge window

2018-04-26 Thread yuemeng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuemeng updated FLINK-9201: --- Summary: same merge window will be fired twice if watermark already passed the merge window (was: same merge

[jira] [Comment Edited] (FLINK-9178) Add rate control for kafka source

2018-04-26 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453686#comment-16453686 ] buptljy edited comment on FLINK-9178 at 4/26/18 8:46 AM: - [~app-tarush]  It seems

[jira] [Commented] (FLINK-8841) Duplicate MapSerializer and HashMapSerializer.

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453701#comment-16453701 ] ASF GitHub Bot commented on FLINK-8841: --- Github user kl0u commented on the issue:

[GitHub] flink issue #5910: [FLINK-8841] [state] Remove HashMapSerializer and use Map...

2018-04-26 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5910 Thanks @yuqi1129, @bowenli86 and @StefanRRichter for the reviews. I integrated your comments. If you are done with reviewing, I will merge it as soon as Travis gives the green light. ---

[jira] [Commented] (FLINK-9243) SuccessAfterNetworkBuffersFailureITCase#testSuccessfulProgramAfterFailure is unstable

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453693#comment-16453693 ] ASF GitHub Bot commented on FLINK-9243: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5915: [FLINK-9243][tests] fix flaky SuccessAfterNetworkBuffersF...

2018-04-26 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5915 true, `points.rebalance()` is redundant, thanks for having a look, I created a follow-up fix in #5916 ---

[GitHub] flink pull request #5916: [hotfix][tests] remove redundant rebalance in Succ...

2018-04-26 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5916 [hotfix][tests] remove redundant rebalance in SuccessAfterNetworkBuffersFailureITCase This removes a redundant `rebalance()` operation introduced by #5915. You can merge this pull request into a Git

[jira] [Commented] (FLINK-9178) Add rate control for kafka source

2018-04-26 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453686#comment-16453686 ] buptljy commented on FLINK-9178: [~app-tarush] Of course. Thanks ! > Add rate control for kafka source >

[jira] [Commented] (FLINK-8841) Duplicate MapSerializer and HashMapSerializer.

2018-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453673#comment-16453673 ] ASF GitHub Bot commented on FLINK-8841: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5910: [FLINK-8841] [state] Remove HashMapSerializer and ...

2018-04-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5910#discussion_r184304664 --- Diff: flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java --- @@ -221,6 +226,52 @@ protected ObjectStreamClass

  1   2   >