[jira] [Commented] (FLINK-9141) Calling getSideOutput() and split() on one DataStream causes NPE

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465508#comment-16465508 ] ASF GitHub Bot commented on FLINK-9141: --- Github user zentol commented on the issue:

[GitHub] flink issue #5836: [FLINK-9141][datastream] Fail early when using both split...

2018-05-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5836 merging. ---

[jira] [Commented] (FLINK-8655) Add a default keyspace to CassandraSink

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465505#comment-16465505 ] ASF GitHub Bot commented on FLINK-8655: --- Github user zentol commented on the issue:

[GitHub] flink issue #5538: [FLINK-8655] [DataSink] Added default keyspace to Cassand...

2018-05-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5538 We would have to pass the keyspace via the constructor as the `Configuration` approach doesn't work for streaming. Generally speaking it isn't a problem to set the keyspace when creating the

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465498#comment-16465498 ] ASF GitHub Bot commented on FLINK-8500: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465499#comment-16465499 ] ASF GitHub Bot commented on FLINK-8500: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465500#comment-16465500 ] ASF GitHub Bot commented on FLINK-8500: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465497#comment-16465497 ] ASF GitHub Bot commented on FLINK-8500: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465496#comment-16465496 ] ASF GitHub Bot commented on FLINK-8500: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465501#comment-16465501 ] ASF GitHub Bot commented on FLINK-8500: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465495#comment-16465495 ] ASF GitHub Bot commented on FLINK-8500: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...

2018-05-06 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5958#discussion_r186338002 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/serialization/DeserializationSchema.java --- @@ -42,14 +42,22 @@ @Public public in

[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...

2018-05-06 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5958#discussion_r186337736 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/serialization/ConsumerRecordMetaInfo.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to t

[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...

2018-05-06 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5958#discussion_r186337890 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/serialization/ConsumerRecordMetaInfo.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to t

[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...

2018-05-06 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5958#discussion_r186338049 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/serialization/DeserializationSchema.java --- @@ -42,14 +42,22 @@ @Public public in

[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...

2018-05-06 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5958#discussion_r186337834 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/serialization/ConsumerRecordMetaInfo.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to t

[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...

2018-05-06 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5958#discussion_r186338721 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/serialization/DeserializationSchema.java --- @@ -42,14 +42,22 @@ @Public public in

[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...

2018-05-06 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5958#discussion_r186337301 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka010Fetcher.java --- @@ -78,6

[jira] [Resolved] (FLINK-8064) Extend dependency section to list flink-core

2018-05-06 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-8064. Resolution: Fixed Fix Version/s: 1.5.0 > Extend dependency section to list fl

[jira] [Commented] (FLINK-8064) Extend dependency section to list flink-core

2018-05-06 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465487#comment-16465487 ] Tzu-Li (Gordon) Tai commented on FLINK-8064: Merged (updating the QS documenta

[jira] [Resolved] (FLINK-9169) NPE when restoring from old savepoint and state serializer could not be deserialized

2018-05-06 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-9169. Resolution: Fixed > NPE when restoring from old savepoint and state serializer could

[jira] [Resolved] (FLINK-9287) KafkaProducer011 seems to leak threads when not in exactly-once mode

2018-05-06 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-9287. Resolution: Fixed > KafkaProducer011 seems to leak threads when not in exactly-once

[jira] [Commented] (FLINK-9287) KafkaProducer011 seems to leak threads when not in exactly-once mode

2018-05-06 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465486#comment-16465486 ] Tzu-Li (Gordon) Tai commented on FLINK-9287: Merged. 1.6.0: c8657bf9dee23bc13

[jira] [Commented] (FLINK-9287) KafkaProducer011 seems to leak threads when not in exactly-once mode

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465485#comment-16465485 ] ASF GitHub Bot commented on FLINK-9287: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5950: [FLINK-9169] [state-backend] Allow absence of old ...

2018-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5950 ---

[GitHub] flink pull request #5956: [hotfix][javadocs] Correct the javadoc of Standalo...

2018-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5956 ---

[jira] [Commented] (FLINK-9169) NPE when restoring from old savepoint and state serializer could not be deserialized

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465484#comment-16465484 ] ASF GitHub Bot commented on FLINK-9169: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5918: [hotfix][ListCheckpointed]modify parallelism in th...

2018-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5918 ---

[GitHub] flink pull request #5006: [hotfix][docs][QS] MInor cleanup of QS documentati...

2018-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5006 ---

[GitHub] flink pull request #5952: [FLINK-9287][kafka] Properly clean up resources in...

2018-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5952 ---

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465456#comment-16465456 ] ASF GitHub Bot commented on FLINK-8500: --- GitHub user FredTing opened a pull request:

[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...

2018-05-06 Thread FredTing
GitHub user FredTing opened a pull request: https://github.com/apache/flink/pull/5958 [FLINK-8500] Get the timestamp of the Kafka message from kafka consumer ## What is the purpose of the change This pull request make the Kafka timestamp and timestampType available in the m

[jira] [Commented] (FLINK-9238) There are some questions about BuckeingSink when sinking data to S3.

2018-05-06 Thread liuzhixin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465391#comment-16465391 ] liuzhixin commented on FLINK-9238: -- Thanks for your answer,that's a really annoying probl

[jira] [Created] (FLINK-9303) Unassign partitions from Kafka client if partitions become unavailable

2018-05-06 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-9303: -- Summary: Unassign partitions from Kafka client if partitions become unavailable Key: FLINK-9303 URL: https://issues.apache.org/jira/browse/FLINK-9303 Proj

[GitHub] flink issue #5957: [hotfix][doc] Synchronize Quickstart with the latest SNAP...

2018-05-06 Thread W4anD0eR96
Github user W4anD0eR96 commented on the issue: https://github.com/apache/flink/pull/5957 cc @zentol @tzulitai ---

[GitHub] flink pull request #5957: [hotfix][doc] Synchronize Quickstart with the late...

2018-05-06 Thread W4anD0eR96
GitHub user W4anD0eR96 opened a pull request: https://github.com/apache/flink/pull/5957 [hotfix][doc] Synchronize Quickstart with the latest SNAPSHOT ## What is the purpose of the change Our Quickstart page is a little out of date, this pull request is to keep it synchroniz

[GitHub] flink issue #5006: [hotfix][docs][QS] MInor cleanup of QS documentation

2018-05-06 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5006 +1, LGTM. Will address Greg's last comment and merge this .. ---

[GitHub] flink issue #5956: [hotfix][javadocs] Correct the javadoc of StandaloneCheck...

2018-05-06 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5956 LGTM, thanks @klion26. Merging this .. ---

[jira] [Commented] (FLINK-8999) Ensure the job has an operator with operator state.

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465354#comment-16465354 ] ASF GitHub Bot commented on FLINK-8999: --- Github user tzulitai commented on the issue

[GitHub] flink issue #5890: [FLINK-8999] [e2e] Ensure the job has an operator with op...

2018-05-06 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5890 Hi @zhangminglei, I think the current general purpose DataStream job already subsumes this PR; for example, the sequence source generator in the job already uses operator state. Moreover, `test_resu

[GitHub] flink issue #5918: [hotfix][ListCheckpointed]modify parallelism in the annot...

2018-05-06 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5918 Thanks @maqingxiang! This LGTM, will merge this, thanks. ---

[jira] [Commented] (FLINK-9287) KafkaProducer011 seems to leak threads when not in exactly-once mode

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465348#comment-16465348 ] ASF GitHub Bot commented on FLINK-9287: --- Github user tzulitai commented on the issue

[GitHub] flink issue #5952: [FLINK-9287][kafka] Properly clean up resources in non EX...

2018-05-06 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5952 As discussed offline, both approaches I mentioned wouldn't seem to work. I'll merge as is, let's keep an eye on it to see if the test is flaky. ---

[jira] [Commented] (FLINK-9169) NPE when restoring from old savepoint and state serializer could not be deserialized

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465338#comment-16465338 ] ASF GitHub Bot commented on FLINK-9169: --- Github user tzulitai commented on the issue

[GitHub] flink issue #5950: [FLINK-9169] [state-backend] Allow absence of old seriali...

2018-05-06 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5950 Thanks for the review Stefan! Will merge this now .. ---

[jira] [Commented] (FLINK-8655) Add a default keyspace to CassandraSink

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465299#comment-16465299 ] ASF GitHub Bot commented on FLINK-8655: --- Github user Bekreth commented on the issue:

[GitHub] flink issue #5538: [FLINK-8655] [DataSink] Added default keyspace to Cassand...

2018-05-06 Thread Bekreth
Github user Bekreth commented on the issue: https://github.com/apache/flink/pull/5538 This looks like it'd work out well! When I made this PR, I was aware that the Cassandra connection happened irrespective of the keyspace and I tried to maintain that in order to minimize the change

[jira] [Commented] (FLINK-9235) Add Integration test for Flink-Yarn-Kerberos integration for flip-6

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465243#comment-16465243 ] ASF GitHub Bot commented on FLINK-9235: --- Github user suez1224 commented on a diff in

[GitHub] flink pull request #5901: [FLINK-9235][Security] Add integration tests for Y...

2018-05-06 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5901#discussion_r186298337 --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java --- @@ -85,54 +88,75 @@ public void checkForProhibitedLogContents

[GitHub] flink issue #5538: [FLINK-8655] [DataSink] Added default keyspace to Cassand...

2018-05-06 Thread ctamisier
Github user ctamisier commented on the issue: https://github.com/apache/flink/pull/5538 This is also something I would need and I would like to see with you for an alternative fix. What about using the `Configuration` that is provided in `RichFunction.open(Configuration param

[jira] [Commented] (FLINK-8655) Add a default keyspace to CassandraSink

2018-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465212#comment-16465212 ] ASF GitHub Bot commented on FLINK-8655: --- Github user ctamisier commented on the issu

[GitHub] flink issue #5956: [hotfix][javadocs] Correct the javadoc of StandaloneCheck...

2018-05-06 Thread klion26
Github user klion26 commented on the issue: https://github.com/apache/flink/pull/5956 @uce hi, could you please review this typo fix? ---

[GitHub] flink pull request #5956: [hotfix][javadocs] Correct the javadoc of Standalo...

2018-05-06 Thread klion26
GitHub user klion26 opened a pull request: https://github.com/apache/flink/pull/5956 [hotfix][javadocs] Correct the javadoc of StandaloneCheckpointIDCounter#getLast ## What is the purpose of the change Correct the javadoc of StandaloneCheckpointIDCounter#getLast You