[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478558#comment-16478558 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 Have't received any response from RocksDB yet, but I found this example with using `RocksIterator#stats()`:

[jira] [Commented] (FLINK-9070) Improve performance of RocksDBMapState.clear()

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478522#comment-16478522 ] ASF GitHub Bot commented on FLINK-9070: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #5979: [FLINK-9070][state]improve the performance of RocksDBMapS...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5979 @StephanEwen , I had a micro-benchmark, here is the result ``` -> Batch VS Put < BATCH: end insert - duration:255 PUT: end insert - duration:545

[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...

2018-05-16 Thread medcv
Github user medcv commented on the issue: https://github.com/apache/flink/pull/5996 @tzulitai I would appreciate if you review this. ---

[jira] [Commented] (FLINK-9343) Add Async Example with External Rest API call

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478489#comment-16478489 ] ASF GitHub Bot commented on FLINK-9343: --- Github user medcv commented on the issue:

[jira] [Updated] (FLINK-7814) Add BETWEEN and NOT BETWEEN expression to Table API

2018-05-16 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruidong Li updated FLINK-7814: -- Summary: Add BETWEEN and NOT BETWEEN expression to Table API (was: Add BETWEEN expression to Table API

[jira] [Commented] (FLINK-7814) Add BETWEEN expression to Table API

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478451#comment-16478451 ] ASF GitHub Bot commented on FLINK-7814: --- GitHub user Xpray opened a pull request:

[GitHub] flink pull request #6027: [FLINK-7814][TableAPI && SQL] Add BETWEEN and NOT ...

2018-05-16 Thread Xpray
GitHub user Xpray opened a pull request: https://github.com/apache/flink/pull/6027 [FLINK-7814][TableAPI && SQL] Add BETWEEN and NOT BETWEEN expression to Table API ## What is the purpose of the change Add BETWEEN expression to Table API ## Brief

[jira] [Commented] (FLINK-9182) async checkpoints for timer service

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478440#comment-16478440 ] ASF GitHub Bot commented on FLINK-9182: --- Github user makeyang commented on the issue:

[GitHub] flink issue #6019: [FLINK-9182]async checkpoints for timer service

2018-05-16 Thread makeyang
Github user makeyang commented on the issue: https://github.com/apache/flink/pull/6019 @StefanRRichter & @sihuazhou thanks u guys ---

[GitHub] flink pull request #6019: [FLINK-9182]async checkpoints for timer service

2018-05-16 Thread makeyang
Github user makeyang closed the pull request at: https://github.com/apache/flink/pull/6019 ---

[jira] [Commented] (FLINK-9182) async checkpoints for timer service

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478441#comment-16478441 ] ASF GitHub Bot commented on FLINK-9182: --- Github user makeyang closed the pull request at:

[jira] [Commented] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478438#comment-16478438 ] ASF GitHub Bot commented on FLINK-9384: --- Github user tragicjun commented on the issue:

[GitHub] flink issue #6026: [FLINK-9384]KafkaAvroTableSource failed to work due to ty...

2018-05-16 Thread tragicjun
Github user tragicjun commented on the issue: https://github.com/apache/flink/pull/6026 Thanks @suez1224 for reviewing. I've committed a new patch as per your suggestions. As for the unit test, the issue was exposed in my integration tests which requires a kafka setup, any advice on

[jira] [Commented] (FLINK-9352) In Standalone checkpoint recover mode many jobs with same checkpoint interval cause IO pressure

2018-05-16 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478358#comment-16478358 ] vinoyang commented on FLINK-9352: - and [~till.rohrmann] any idea about this issue? > In Standalone

[jira] [Commented] (FLINK-9276) Improve error message when TaskManager fails

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478356#comment-16478356 ] ASF GitHub Bot commented on FLINK-9276: --- Github user yanghua commented on the issue:

[GitHub] flink issue #5954: [FLINK-9276] Improve error message when TaskManager fails

2018-05-16 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5954 hi @StephanEwen this PR also reviewed by you, yesterday it has a conflicts with master branch, I have fixed, would you please review it again, thanks. ---

[jira] [Commented] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478190#comment-16478190 ] ASF GitHub Bot commented on FLINK-9384: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478189#comment-16478189 ] ASF GitHub Bot commented on FLINK-9384: --- Github user suez1224 commented on a diff in the pull

[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...

2018-05-16 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/6026#discussion_r188786194 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSource.java --- @@ -81,7

[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...

2018-05-16 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/6026#discussion_r188786307 --- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java --- @@ -110,6 +116,8 @@ private void

[jira] [Updated] (FLINK-9381) BlobServer data for a job is not getting cleaned up at JM

2018-05-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9381: - Fix Version/s: 1.5.0 > BlobServer data for a job is not getting cleaned up at JM >

[jira] [Commented] (FLINK-9312) Perform mutual authentication during SSL handshakes

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477891#comment-16477891 ] ASF GitHub Bot commented on FLINK-9312: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5966: [FLINK-9312] [security] Add mutual authentication for RPC...

2018-05-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5966 I would move ahead with this PR as follows: - Separate internal and external SSL config - Activate SSL client auth for akka, netty, and blob server (pure internal communication)

[jira] [Commented] (FLINK-9299) ProcessWindowFunction documentation Java examples have errors

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477879#comment-16477879 ] ASF GitHub Bot commented on FLINK-9299: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...

2018-05-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6001 Looks good, thanks, merging this... ---

[jira] [Commented] (FLINK-8655) Add a default keyspace to CassandraSink

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477865#comment-16477865 ] ASF GitHub Bot commented on FLINK-8655: --- Github user ctamisier commented on a diff in the pull

[jira] [Commented] (FLINK-9070) Improve performance of RocksDBMapState.clear()

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477867#comment-16477867 ] ASF GitHub Bot commented on FLINK-9070: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #5964: [FLINK-8655] [Cassandra Connector] add keyspace in...

2018-05-16 Thread ctamisier
Github user ctamisier commented on a diff in the pull request: https://github.com/apache/flink/pull/5964#discussion_r188727153 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java --- @@ -381,6

[GitHub] flink issue #5979: [FLINK-9070][state]improve the performance of RocksDBMapS...

2018-05-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5979 Could you share some micro-benchmark numbers? When we change something that we know works well to something new, would be good to understand what benefits we are talking about. ---

[jira] [Commented] (FLINK-9292) Remove TypeInfoParser

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477860#comment-16477860 ] ASF GitHub Bot commented on FLINK-9292: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5970: [FLINK-9292] [core] Remove TypeInfoParser (part 2)

2018-05-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5970 Merging this... ---

[jira] [Commented] (FLINK-9295) FlinkKafkaProducer011 sometimes throws ProducerFencedExceptions when in EXACTLY_ONCE mode

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477855#comment-16477855 ] ASF GitHub Bot commented on FLINK-9295: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5977: [FLINK-9295][kafka] Fix transactional.id collision...

2018-05-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5977#discussion_r188725700 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java --- @@ -71,6 +71,17 @@ @PublicEvolving

[jira] [Commented] (FLINK-8655) Add a default keyspace to CassandraSink

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477840#comment-16477840 ] ASF GitHub Bot commented on FLINK-8655: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5964: [FLINK-8655] [Cassandra Connector] add keyspace in...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5964#discussion_r188722661 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java --- @@ -381,6 +393,9

[jira] [Commented] (FLINK-8655) Add a default keyspace to CassandraSink

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477818#comment-16477818 ] ASF GitHub Bot commented on FLINK-8655: --- Github user ctamisier commented on the issue:

[GitHub] flink issue #5964: [FLINK-8655] [Cassandra Connector] add keyspace in cassan...

2018-05-16 Thread ctamisier
Github user ctamisier commented on the issue: https://github.com/apache/flink/pull/5964 I pushed the changes about renaming the method to setDefaultKeyspace() and the message in the exception. The field is still 'keyspace', we dont rename it to 'defaultKeyspace' right ? ---

[jira] [Commented] (FLINK-8655) Add a default keyspace to CassandraSink

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477814#comment-16477814 ] ASF GitHub Bot commented on FLINK-8655: --- Github user ctamisier commented on a diff in the pull

[GitHub] flink pull request #5964: [FLINK-8655] [Cassandra Connector] add keyspace in...

2018-05-16 Thread ctamisier
Github user ctamisier commented on a diff in the pull request: https://github.com/apache/flink/pull/5964#discussion_r188717750 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java --- @@ -381,6

[jira] [Comment Edited] (FLINK-9043) Introduce a friendly way to resume the job from externalized checkpoints automatically

2018-05-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477362#comment-16477362 ] Stephan Ewen edited comment on FLINK-9043 at 5/16/18 5:51 PM: -- Thank you for

[jira] [Comment Edited] (FLINK-9043) Introduce a friendly way to resume the job from externalized checkpoints automatically

2018-05-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477362#comment-16477362 ] Stephan Ewen edited comment on FLINK-9043 at 5/16/18 5:51 PM: -- Thank you for

[jira] [Comment Edited] (FLINK-9043) Introduce a friendly way to resume the job from externalized checkpoints automatically

2018-05-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477362#comment-16477362 ] Stephan Ewen edited comment on FLINK-9043 at 5/16/18 5:50 PM: -- Thank you for

[jira] [Commented] (FLINK-9043) Introduce a friendly way to resume the job from externalized checkpoints automatically

2018-05-16 Thread Aris Koliopoulos (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477783#comment-16477783 ] Aris Koliopoulos commented on FLINK-9043: - To be honest I am not sure how Flink should be

[jira] [Created] (FLINK-9386) Remove netty-router dependency

2018-05-16 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-9386: - Summary: Remove netty-router dependency Key: FLINK-9386 URL: https://issues.apache.org/jira/browse/FLINK-9386 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477682#comment-16477682 ] ASF GitHub Bot commented on FLINK-9384: --- GitHub user tragicjun opened a pull request:

[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...

2018-05-16 Thread tragicjun
GitHub user tragicjun opened a pull request: https://github.com/apache/flink/pull/6026 [FLINK-9384]KafkaAvroTableSource failed to work due to type mismatch *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the

[jira] [Closed] (FLINK-9379) HA end-to-end test failing locally

2018-05-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-9379. - Resolution: Fixed Fixed on master with cddb65abe3a7b82ffb3235800903c016fdc38877 and on 1.5 with 

[jira] [Commented] (FLINK-8659) Add migration tests for Broadcast state.

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477648#comment-16477648 ] ASF GitHub Bot commented on FLINK-8659: --- Github user kl0u commented on the issue:

[GitHub] flink issue #5955: [FLINK-8659] Add migration itcases for broadcast state.

2018-05-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5955 Hi @tzulitai ! Thanks for the review. I integrated most of your comments. The only one I left out is the one about merging the checkpointing and the checking. I am not against that. It is just that the

[jira] [Updated] (FLINK-9385) Operators with two inputs should show "Records Received" in Web UI separately, rather than added together

2018-05-16 Thread Josh Lemer (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Lemer updated FLINK-9385: -- Component/s: Webfrontend Web Client Metrics > Operators with two

[jira] [Created] (FLINK-9385) Operators with two inputs should show "Records Received" in Web UI separately, rather than added together

2018-05-16 Thread Josh Lemer (JIRA)
Josh Lemer created FLINK-9385: - Summary: Operators with two inputs should show "Records Received" in Web UI separately, rather than added together Key: FLINK-9385 URL: https://issues.apache.org/jira/browse/FLINK-9385

[jira] [Commented] (FLINK-9381) BlobServer data for a job is not getting cleaned up at JM

2018-05-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477600#comment-16477600 ] Till Rohrmann commented on FLINK-9381: -- I think we don't properly clean up the job resources after

[jira] [Assigned] (FLINK-9381) BlobServer data for a job is not getting cleaned up at JM

2018-05-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-9381: Assignee: Till Rohrmann > BlobServer data for a job is not getting cleaned up at JM >

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477592#comment-16477592 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 FYI, I found this issue related to problem: https://github.com/facebook/rocksdb/issues/3558 ---

[GitHub] flink issue #5421: [FLINK-8573] [client] Add more information for printing J...

2018-05-16 Thread azagrebin
Github user azagrebin commented on the issue: https://github.com/apache/flink/pull/5421 @zhangminglei what do you think about creation one more `ProgramInvocationException` overloaded constructor with JobId as parameter? It could always append to the message like `MESSAGE +

[jira] [Commented] (FLINK-8573) Print JobID for failed jobs

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477581#comment-16477581 ] ASF GitHub Bot commented on FLINK-8573: --- Github user azagrebin commented on the issue:

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477573#comment-16477573 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 Agreed! ---

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477560#comment-16477560 ] ASF GitHub Bot commented on FLINK-9373: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6020 Maybe we should ask them on their issue tracker what the best practise is? I cannot remember seeing such checks in their code examples. Have a hard time to believe that this can be true,

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477556#comment-16477556 ] ASF GitHub Bot commented on FLINK-9373: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6020 It depends, maybe this is already covered currently because we might always do an iteration attempt that checks right after the seek. But in general, this is not very nice and fragile if

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477554#comment-16477554 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 Oh My God...Is that means we need to wrap the `RocksIterator` to delegate all it API? ---

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477549#comment-16477549 ] ASF GitHub Bot commented on FLINK-9373: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6020 After double checking with the RocksDB docs, I am afraid that we need to introduce more checks because for example the point out that also after methods like `seek` the iterator an become

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477502#comment-16477502 ] ASF GitHub Bot commented on FLINK-9008: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-16 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188645244 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6025: Release 1.4

2018-05-16 Thread zhgao
GitHub user zhgao opened a pull request: https://github.com/apache/flink/pull/6025 Release 1.4 *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way,

[jira] [Updated] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-16 Thread Jun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Zhang updated FLINK-9384: - Flags: Patch > KafkaAvroTableSource failed to work due to type mismatch >

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477479#comment-16477479 ] ASF GitHub Bot commented on FLINK-9008: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-16 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188638639 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[jira] [Updated] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-16 Thread Jun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Zhang updated FLINK-9384: - Attachment: flink-9384.patch > KafkaAvroTableSource failed to work due to type mismatch >

[jira] [Created] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-16 Thread Jun Zhang (JIRA)
Jun Zhang created FLINK-9384: Summary: KafkaAvroTableSource failed to work due to type mismatch Key: FLINK-9384 URL: https://issues.apache.org/jira/browse/FLINK-9384 Project: Flink Issue Type:

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477465#comment-16477465 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 Agree, should be correct first before fast! Could you please have a look at this? I think it's already for a look now~ ---

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477459#comment-16477459 ] ASF GitHub Bot commented on FLINK-9373: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6020 It sounds cheap if they just `&` all the flags from the sub iterators. In the end, we can see if there is a performance drop but better be correct first before fast. ---

[jira] [Commented] (FLINK-9301) NotSoMiniClusterIterations job fails on travis

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477453#comment-16477453 ] ASF GitHub Bot commented on FLINK-9301: --- Github user azagrebin commented on the issue:

[jira] [Commented] (FLINK-9301) NotSoMiniClusterIterations job fails on travis

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477452#comment-16477452 ] ASF GitHub Bot commented on FLINK-9301: --- GitHub user azagrebin opened a pull request:

[GitHub] flink issue #6024: [FLINK-9301] [e2e test] Add back "not co mini cluster" te...

2018-05-16 Thread azagrebin
Github user azagrebin commented on the issue: https://github.com/apache/flink/pull/6024 cc @zentol ---

[GitHub] flink pull request #6024: [FLINK-9301] [e2e test] Add back "not co mini clus...

2018-05-16 Thread azagrebin
GitHub user azagrebin opened a pull request: https://github.com/apache/flink/pull/6024 [FLINK-9301] [e2e test] Add back "not co mini cluster" test with reduced parallelism …ced to 25 parallelism and memory usage logging ## What is the purpose of the change

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 @StefanRRichter I had a look at the implementation of the iterators in RocksDB, I found status just return the flag first `_status` as the result without any complex computation, But for some

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477438#comment-16477438 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[jira] [Commented] (FLINK-8918) Introduce Runtime Filter Join

2018-05-16 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477433#comment-16477433 ] Sihua Zhou commented on FLINK-8918: --- [~fhueske] related to the saturated problem, I want to add some

[jira] [Commented] (FLINK-8918) Introduce Runtime Filter Join

2018-05-16 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477429#comment-16477429 ] Sihua Zhou commented on FLINK-8918: --- Hi [~fhueske], sorry that I'm definitely not asked you to promise

[jira] [Commented] (FLINK-8918) Introduce Runtime Filter Join

2018-05-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477424#comment-16477424 ] Fabian Hueske commented on FLINK-8918: -- It's good to know that you were thinking about the issues I

[jira] [Commented] (FLINK-9383) Extend DistributedCache E2E test to cover directories

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477417#comment-16477417 ] ASF GitHub Bot commented on FLINK-9383: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #6023: [FLINK-9383][runtime] Test directories in Distribu...

2018-05-16 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6023 [FLINK-9383][runtime] Test directories in DistributedCache E2E test ## What is the purpose of the change With this PR the distributed cache end-to-end test * also covers the distributed

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477414#comment-16477414 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 I'm going to check the native implementation and see whether the `status()` is a super cheap option... ---

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477413#comment-16477413 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 I think I am a bit torn here now... ---

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477412#comment-16477412 ] ASF GitHub Bot commented on FLINK-9373: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6020 That is a good question, and I'm not sure...but I think that seems to be... ---

[jira] [Commented] (FLINK-9373) Fix potential data losing for RocksDBBackend

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477409#comment-16477409 ] ASF GitHub Bot commented on FLINK-9373: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #6020: [FLINK-9373][state] Fix potential data losing for RocksDB...

2018-05-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6020 Oh you are right, this is confusing :-) So does this also mean the status flag is cleared when we simple continue iterating and only check in the end? ---

  1   2   3   >