[
https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521828#comment-16521828
]
ASF GitHub Bot commented on FLINK-6846:
---
Github user xueyumusic commented on a diff in the pull
Github user xueyumusic commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197674277
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -349,6 +349,17 @@ case class TimestampAdd(
[
https://issues.apache.org/jira/browse/FLINK-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521801#comment-16521801
]
ASF GitHub Bot commented on FLINK-9514:
---
Github user sihuazhou commented on the issue:
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6186
Maybe let me elaborate the TTL checking condition in detail, overall the
checking condition contains two parts and looks like `(current_ts - update_ts)
- time_shift_offset >= TTL`.
The
[
https://issues.apache.org/jira/browse/FLINK-9653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
vinoyang reassigned FLINK-9653:
---
Assignee: vinoyang
> Add operator name to latency metrics
>
>
[
https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521762#comment-16521762
]
ASF GitHub Bot commented on FLINK-6846:
---
Github user hequn8128 commented on a diff in the pull
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197662959
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -349,6 +349,17 @@ case class TimestampAdd(
[
https://issues.apache.org/jira/browse/FLINK-6557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-6557:
--
Labels: pull-request-available (was: )
> RocksDBKeyedStateBackend broken on Windows
>
[
https://issues.apache.org/jira/browse/FLINK-6557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521748#comment-16521748
]
ASF GitHub Bot commented on FLINK-6557:
---
Github user vschafer closed the pull request at:
Github user vschafer closed the pull request at:
https://github.com/apache/flink/pull/4269
---
Julian Stephen created FLINK-9653:
-
Summary: Add operator name to latency metrics
Key: FLINK-9653
URL: https://issues.apache.org/jira/browse/FLINK-9653
Project: Flink
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/FLINK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521570#comment-16521570
]
Deepak Sharma commented on FLINK-9380:
--
Hi [~till.rohrmann], would you still like me to work on
[
https://issues.apache.org/jira/browse/FLINK-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-9563:
--
Labels: pull-request-available (was: )
> Migrate integration tests for CEP
>
[
https://issues.apache.org/jira/browse/FLINK-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521568#comment-16521568
]
ASF GitHub Bot commented on FLINK-9563:
---
Github user deepaks4077 commented on the issue:
Github user deepaks4077 commented on the issue:
https://github.com/apache/flink/pull/6170
@zentol, do you have some time this week to review this? I can proceed with
the other tests once I know that this is the right way to handle it :)
---
[
https://issues.apache.org/jira/browse/FLINK-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sihua Zhou closed FLINK-9585.
-
Resolution: Fixed
Merged in:
master: 5fa61d8ceac8f865002dc0ef84dc1a3c65753d0b
> Logger in
[
https://issues.apache.org/jira/browse/FLINK-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521532#comment-16521532
]
ASF GitHub Bot commented on FLINK-9585:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6175
---
[
https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521509#comment-16521509
]
ASF GitHub Bot commented on FLINK-6846:
---
Github user xueyumusic commented on a diff in the pull
Github user xueyumusic commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197642129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -328,6 +330,71 @@ case class TemporalOverlaps(
[
https://issues.apache.org/jira/browse/FLINK-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521498#comment-16521498
]
ASF GitHub Bot commented on FLINK-9514:
---
Github user sihuazhou commented on the issue:
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6186
I'm still a bit worried about the time-align problem on recovery(because
I've met serval case that would become disaster on production if we don't do
the time-align on recovery. (One instance: we
[
https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521496#comment-16521496
]
ASF GitHub Bot commented on FLINK-6846:
---
Github user hequn8128 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521495#comment-16521495
]
ASF GitHub Bot commented on FLINK-6846:
---
Github user hequn8128 commented on a diff in the pull
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197640442
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -328,6 +330,71 @@ case class TemporalOverlaps(
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197640444
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -328,6 +330,71 @@ case class TemporalOverlaps(
[
https://issues.apache.org/jira/browse/FLINK-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521486#comment-16521486
]
Chesnay Schepler commented on FLINK-6759:
-
[~aitozi] flink-storm-examples should no longer have a
[
https://issues.apache.org/jira/browse/FLINK-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521480#comment-16521480
]
steven-qin edited comment on FLINK-5463 at 6/24/18 12:28 PM:
-
Hi,
I also
[
https://issues.apache.org/jira/browse/FLINK-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521480#comment-16521480
]
steven-qin edited comment on FLINK-5463 at 6/24/18 12:26 PM:
-
Hi,
I also
[
https://issues.apache.org/jira/browse/FLINK-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521480#comment-16521480
]
steven-qin commented on FLINK-5463:
---
Hi,
I also encountered this issue in flink 1.4.2,but I don't
godfrey johnson created FLINK-9652:
--
Summary: Metrics for upstream and downstream
Key: FLINK-9652
URL: https://issues.apache.org/jira/browse/FLINK-9652
Project: Flink
Issue Type: Task
[
https://issues.apache.org/jira/browse/FLINK-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas reassigned FLINK-9603:
-
Assignee: Kostas Kloudas
> Incorrect indexing of part files, when part suffix is
[
https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521448#comment-16521448
]
ASF GitHub Bot commented on FLINK-6846:
---
Github user xueyumusic commented on the issue:
Github user xueyumusic commented on the issue:
https://github.com/apache/flink/pull/6188
Thanks very much for your reivew and guidance, @walterddr @hequn8128 , I
have made some modification, please have a review when you are free, thanks!
---
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/6205
The travis error this time seems unrelated.
---
[
https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521405#comment-16521405
]
ASF GitHub Bot commented on FLINK-9642:
---
Github user Aitozi commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521400#comment-16521400
]
ASF GitHub Bot commented on FLINK-9185:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-9185:
--
Labels: pull-request-available (was: )
> Potential null dereference in
>
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5894
Thanks for you contribution @StephenJeson ! Looks good to me from my side.
---
[
https://issues.apache.org/jira/browse/FLINK-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521395#comment-16521395
]
ASF GitHub Bot commented on FLINK-9585:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-9585:
--
Labels: pull-request-available (was: )
> Logger in ZooKeeperStateHandleStore is public and
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6175
Looks good from my side.
---
[
https://issues.apache.org/jira/browse/FLINK-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521391#comment-16521391
]
ASF GitHub Bot commented on FLINK-9627:
---
Github user zhangminglei commented on the issue:
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6198
Looks good from my side
---
[
https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521386#comment-16521386
]
ASF GitHub Bot commented on FLINK-9642:
---
Github user Aitozi commented on a diff in the pull
Github user Aitozi commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r197629310
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -346,16 +351,87 @@ private void
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/6205
Hi @zhangminglei , thanks for your review. I only check the
SharedBufferTest locally before, the error in travis means the num of state
access (read and write) is less than before which is the
[
https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521384#comment-16521384
]
ASF GitHub Bot commented on FLINK-9642:
---
Github user Aitozi commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521383#comment-16521383
]
ASF GitHub Bot commented on FLINK-9642:
---
Github user zhangminglei commented on a diff in the pull
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r197629304
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -346,16 +351,87 @@ private void
[
https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521380#comment-16521380
]
ASF GitHub Bot commented on FLINK-9642:
---
Github user Aitozi commented on a diff in the pull
Github user Aitozi commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r197629218
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -75,6 +76,9 @@
private MapState
[
https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521381#comment-16521381
]
ASF GitHub Bot commented on FLINK-9642:
---
Github user Aitozi commented on a diff in the pull
53 matches
Mail list logo
