[jira] [Commented] (FLINK-9221) Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]

2018-07-01 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529020#comment-16529020 ] vinoyang commented on FLINK-9221: - [~joshlemer] I think we should not add this method to

[jira] [Commented] (FLINK-9511) Make StateDescriptor configurable with optional TTL

2018-07-01 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529023#comment-16529023 ] vinoyang commented on FLINK-9511: - Hi [~azagrebin] the defined TtlConfig stored in flink-

[jira] [Commented] (FLINK-9682) Add setDescription to execution environment and display it in the UI

2018-07-01 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529025#comment-16529025 ] vinoyang commented on FLINK-9682: - seems a feasible suggestion, what do you think about t

[GitHub] flink issue #6219: [hotfix] Fixed typo in docs

2018-07-01 Thread elbaulp
Github user elbaulp commented on the issue: https://github.com/apache/flink/pull/6219 @tillrohrmann You're welcome :-) ---

[GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-01 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6233 Hi @snuyanzin , thanks for your PR. The code looks good and the `deepToString()` function returns result correctly. I could not spot any issues with the implementation. To make the PR better, I thi

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529096#comment-16529096 ] ASF GitHub Bot commented on FLINK-9696: --- Github user hequn8128 commented on the iss

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-07-01 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199349619 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object temporalOverla

[jira] [Commented] (FLINK-6846) Add TIMESTAMPADD supported in TableAPI

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529099#comment-16529099 ] ASF GitHub Bot commented on FLINK-6846: --- Github user hequn8128 commented on a diff

[GitHub] flink pull request #6214: [FLINK-9669] Add assignment store interface.

2018-07-01 Thread liurenjie1024
Github user liurenjie1024 closed the pull request at: https://github.com/apache/flink/pull/6214 ---

[GitHub] flink issue #6214: [FLINK-9669] Add assignment store interface.

2018-07-01 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/flink/pull/6214 @tillrohrmann This is from my initial design, and since the design has changed, we can close this now. ---

[jira] [Closed] (FLINK-9669) Introduce task manager assignment store

2018-07-01 Thread Renjie Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Renjie Liu closed FLINK-9669. - Resolution: Invalid > Introduce task manager assignment store > --- >

[jira] [Commented] (FLINK-9669) Introduce task manager assignment store

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529103#comment-16529103 ] ASF GitHub Bot commented on FLINK-9669: --- Github user liurenjie1024 closed the pull

[jira] [Commented] (FLINK-9669) Introduce task manager assignment store

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529102#comment-16529102 ] ASF GitHub Bot commented on FLINK-9669: --- Github user liurenjie1024 commented on the

[jira] [Updated] (FLINK-9695) Add option for Mesos executor to forcefully pull Docker images

2018-07-01 Thread Leonid Ishimnikov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonid Ishimnikov updated FLINK-9695: - Description: It would be useful to have an option to forcefully pull Docker images for ta

[GitHub] flink issue #6206: [FLINK-9654] [core] Changed the check for anonymous class...

2018-07-01 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6206 hi @zsolt-donca I have seen the Travis build error log, the failed reason is not because of your code. This PR looks good, but if you can add a test for `isAnonymousClass` method, that would be bette

[jira] [Commented] (FLINK-9654) Internal error while deserializing custom Scala TypeSerializer instances

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529121#comment-16529121 ] ASF GitHub Bot commented on FLINK-9654: --- Github user yanghua commented on the issue

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-07-01 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199352237 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object temporalOverla

[jira] [Commented] (FLINK-6846) Add TIMESTAMPADD supported in TableAPI

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529122#comment-16529122 ] ASF GitHub Bot commented on FLINK-6846: --- Github user walterddr commented on a diff

[GitHub] flink issue #6194: [FLINK-9633][checkpoint] Use savepoint path's file system...

2018-07-01 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6194 +1, there is a conflicting file~ cc @sihuazhou ---

[jira] [Commented] (FLINK-9633) Flink doesn't use the Savepoint path's filesystem to create the OuptutStream on Task.

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529123#comment-16529123 ] ASF GitHub Bot commented on FLINK-9633: --- Github user yanghua commented on the issue

[GitHub] flink pull request #6234: [FLINK-9431]Introduce time bounded condition to ce...

2018-07-01 Thread Aitozi
GitHub user Aitozi opened a pull request: https://github.com/apache/flink/pull/6234 [FLINK-9431]Introduce time bounded condition to cep ## What is the purpose of the change In cep the event is now driving the transformation of the NFA, I think the time factor should also be

[jira] [Updated] (FLINK-9431) Introduce TimeEnd State to flink cep

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9431: -- Labels: pull-request-available (was: ) > Introduce TimeEnd State to flink cep > --

[jira] [Commented] (FLINK-9431) Introduce TimeEnd State to flink cep

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529124#comment-16529124 ] ASF GitHub Bot commented on FLINK-9431: --- GitHub user Aitozi opened a pull request:

[GitHub] flink issue #6194: [FLINK-9633][checkpoint] Use savepoint path's file system...

2018-07-01 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6194 @yanghua Thanks for the review, I rebased the PR. ---

[jira] [Commented] (FLINK-9633) Flink doesn't use the Savepoint path's filesystem to create the OuptutStream on Task.

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529134#comment-16529134 ] ASF GitHub Bot commented on FLINK-9633: --- Github user sihuazhou commented on the iss

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6132 ---

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529253#comment-16529253 ] ASF GitHub Bot commented on FLINK-9456: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-07-01 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-9456. Resolution: Fixed Fixed via 1.6.0: 89cfeaa882f9e68df2bd215563622b48c29a9ec9 50c0ea8c9fe17278d45aba4

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529264#comment-16529264 ] ASF GitHub Bot commented on FLINK-9696: --- Github user snuyanzin commented on a diff

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-01 Thread snuyanzin
Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199364581 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108 @@ +/* + * License

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529265#comment-16529265 ] ASF GitHub Bot commented on FLINK-9696: --- Github user snuyanzin commented on a diff

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-01 Thread snuyanzin
Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199364538 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108 @@ +/* + * License

[GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-01 Thread snuyanzin
Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6233 Hello @hequn8128! Thank you for your review and comments. About PR template - I did changes based on proposed #5811. Please let me know if it is acceptable or not. About `rowToString` agree.

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529266#comment-16529266 ] ASF GitHub Bot commented on FLINK-9696: --- Github user snuyanzin commented on the iss

[jira] [Commented] (FLINK-9431) Introduce TimeEnd State to flink cep

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529276#comment-16529276 ] ASF GitHub Bot commented on FLINK-9431: --- Github user yanghua commented on a diff in

[GitHub] flink pull request #6234: [FLINK-9431]Introduce time bounded condition to ce...

2018-07-01 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6234#discussion_r199365531 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -224,23 +226,26 @@ private boolean isFinalState(ComputationState s

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

2018-07-01 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199365966 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala --- @@ -,6 +,53 @@ class ScalarFun

[jira] [Updated] (FLINK-9688) ATAN2 Sql Function support

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9688: -- Labels: pull-request-available (was: ) > ATAN2 Sql Function support >

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529278#comment-16529278 ] ASF GitHub Bot commented on FLINK-9688: --- Github user yanghua commented on a diff in

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

2018-07-01 Thread snuyanzin
Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199366673 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala --- @@ -,6 +,53 @@ class ScalarF

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529282#comment-16529282 ] ASF GitHub Bot commented on FLINK-9688: --- Github user snuyanzin commented on a diff

[GitHub] flink pull request #6192: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

2018-07-01 Thread Clarkkkkk
Github user Clark closed the pull request at: https://github.com/apache/flink/pull/6192 ---

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529321#comment-16529321 ] ASF GitHub Bot commented on FLINK-9567: --- Github user Clark closed the pull requ

[jira] [Closed] (FLINK-9670) Introduce slot manager factory

2018-07-01 Thread Renjie Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Renjie Liu closed FLINK-9670. - Resolution: Invalid > Introduce slot manager factory > -- > >

[GitHub] flink issue #5995: [FLINK-9337] Implemented AvroDeserializationSchema

2018-07-01 Thread cricket007
Github user cricket007 commented on the issue: https://github.com/apache/flink/pull/5995 What about implementing a `KeyedDeserializationSchema` for Avro? ---

[jira] [Commented] (FLINK-9337) Implement AvroDeserializationSchema

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529329#comment-16529329 ] ASF GitHub Bot commented on FLINK-9337: --- Github user cricket007 commented on the is

[jira] [Created] (FLINK-9698) "case class must be static and globally accessible" is too constrained

2018-07-01 Thread Jeff Zhang (JIRA)
Jeff Zhang created FLINK-9698: - Summary: "case class must be static and globally accessible" is too constrained Key: FLINK-9698 URL: https://issues.apache.org/jira/browse/FLINK-9698 Project: Flink

[jira] [Commented] (FLINK-9698) "case class must be static and globally accessible" is too constrained

2018-07-01 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529406#comment-16529406 ] Jeff Zhang commented on FLINK-9698: --- Could anyone let me know why flink require case cl

[jira] [Updated] (FLINK-9609) Add bucket ready mechanism for BucketingSink when checkpoint complete

2018-07-01 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9609: Description: Currently, BucketingSink only support {{notifyCheckpointComplete}}. However, users wa

[GitHub] flink pull request #6235: [FLINK-9377] [core] Remove serializers from checkp...

2018-07-01 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/6235 [FLINK-9377] [core] Remove serializers from checkpointed state meta infos ## What is the purpose of the change This PR is the first step towards a smoother state evolution experience. I

[jira] [Updated] (FLINK-9377) Remove writing serializers as part of the checkpoint meta information

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9377: -- Labels: pull-request-available (was: ) > Remove writing serializers as part of the checkpoint

[jira] [Commented] (FLINK-9377) Remove writing serializers as part of the checkpoint meta information

2018-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529428#comment-16529428 ] ASF GitHub Bot commented on FLINK-9377: --- GitHub user tzulitai opened a pull request