[jira] [Commented] (FLINK-9511) Implement TTL config

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535606#comment-16535606 ] ASF GitHub Bot commented on FLINK-9511: --- Github user yanghua commented on the issue

[GitHub] flink issue #6277: [FLINK-9511] Implement TTL config

2018-07-06 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6277 cc @azagrebin finished this, please review, the CI failed reason comes from yarn-test. ---

[jira] [Updated] (FLINK-9772) Documentation of Hadoop API outdated

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9772: -- Labels: pull-request-available (was: ) > Documentation of Hadoop API outdated > --

[GitHub] flink pull request #6278: [FLINK-9772] Documentation of Hadoop API outdated

2018-07-06 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6278 [FLINK-9772] Documentation of Hadoop API outdated ## What is the purpose of the change *This pull request updated some outdated documentation of Hadoop compatibility* ## Brief chan

[jira] [Commented] (FLINK-9772) Documentation of Hadoop API outdated

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535605#comment-16535605 ] ASF GitHub Bot commented on FLINK-9772: --- GitHub user yanghua opened a pull request:

[jira] [Updated] (FLINK-9511) Implement TTL config

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9511: -- Labels: pull-request-available (was: ) > Implement TTL config > > >

[jira] [Commented] (FLINK-9511) Implement TTL config

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535584#comment-16535584 ] ASF GitHub Bot commented on FLINK-9511: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #6277: [FLINK-9511] Implement TTL config

2018-07-06 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6277 [FLINK-9511] Implement TTL config ## What is the purpose of the change *This pull request refactors TTL config and create a builder to build it.* ## Brief change log

[jira] [Updated] (FLINK-9294) Improve type inference for UDFs with composite parameter or result type

2018-07-06 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-9294: - Description: Most of the UDF function signatures that includes composite types such as *{{MAP}}*, *{{ARR

[jira] [Updated] (FLINK-9294) Improve type inference for UDFs with composite parameter or result type

2018-07-06 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-9294: - Description: Most of the UDF function signatures that includes composite types such as *{{MAP}}*, *{{ARR

[jira] [Updated] (FLINK-9294) Improve type inference for UDFs with composite parameter or result type

2018-07-06 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-9294: - Description: Most of the UDF function signatures that includes composite types such as *{{MAP}}*, *{{ARR

[jira] [Updated] (FLINK-9294) Improve type inference for UDFs with composite parameter or result type

2018-07-06 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-9294: - Description: Most of the UDF function signatures that includes composite types such as *{{MAP}}*, *{{ARR

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535551#comment-16535551 ] ASF GitHub Bot commented on FLINK-9687: --- Github user Aitozi commented on the issue:

[jira] [Commented] (FLINK-9642) Reduce the count to deal with state during a CEP process

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535553#comment-16535553 ] ASF GitHub Bot commented on FLINK-9642: --- Github user Aitozi commented on the issue:

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

2018-07-06 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6205 Could you take a look at this PR @dawidwys ? ---

[GitHub] flink issue #6224: [FLINK-9687]Delay the state fetch only when the triggerRe...

2018-07-06 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6224 ping @aljoscha , could you help review it, I'd like to hear your opinion on this PR too. thx ---

[GitHub] flink issue #6168: [FLINK-9588][CEP]Reused context with same computation sta...

2018-07-06 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6168 Hi @dawidwys , since this commit has been merged in, is this pr need to be closed by me? ---

[jira] [Commented] (FLINK-9588) Reuse the same conditionContext with in a same computationState

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535548#comment-16535548 ] ASF GitHub Bot commented on FLINK-9588: --- Github user Aitozi commented on the issue:

[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...

2018-07-06 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6247 @nekrassov, @zentol, I'll revert it, just fix static references. I didn't pay attention to the problem of concurrency at first. ---

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535507#comment-16535507 ] ASF GitHub Bot commented on FLINK-9730: --- Github user lamber-ken commented on the is

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535504#comment-16535504 ] ASF GitHub Bot commented on FLINK-9730: --- Github user lamber-ken commented on the is

[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...

2018-07-06 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6247 @nekrassov, yan can open a separate JIRA. here's address [FLINK-JIRA](https://issues.apache.org/jira/projects/FLINK) ---

[jira] [Assigned] (FLINK-9772) Documentation of Hadoop API outdated

2018-07-06 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9772: --- Assignee: vinoyang > Documentation of Hadoop API outdated > > >

[jira] [Assigned] (FLINK-9774) Allow to pass a string-based cluster identifier to command line

2018-07-06 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9774: --- Assignee: vinoyang > Allow to pass a string-based cluster identifier to command line > -

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535240#comment-16535240 ] ASF GitHub Bot commented on FLINK-9730: --- Github user nekrassov commented on the iss

[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...

2018-07-06 Thread nekrassov
Github user nekrassov commented on the issue: https://github.com/apache/flink/pull/6247 lamber-ken, please let me know if you will open a separate JIRA and PR to make `random, executorService` non-static, remove `synchronized`, and remove `counter`. Or I can do that. ---

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535229#comment-16535229 ] ASF GitHub Bot commented on FLINK-9730: --- Github user zentol commented on the issue:

[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...

2018-07-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6247 for the AsyncIOExample, please revert the change to the `counter` field, and open a separate JIRA and PR. This issue is specifically about fixing static references. ---

[jira] [Commented] (FLINK-9776) Interrupt TaskThread only while in User/Operator code

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535210#comment-16535210 ] ASF GitHub Bot commented on FLINK-9776: --- Github user StefanRRichter commented on a

[GitHub] flink pull request #6275: [FLINK-9776] [runtime] Stop sending periodic inter...

2018-07-06 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6275#discussion_r200737014 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1563,7 +1573,7 @@ public void run() {

[jira] [Assigned] (FLINK-9691) Modify run loop in Kinesis ShardConsumer to not sleep for a fixed fetchIntervalMillis

2018-07-06 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Grier reassigned FLINK-9691: -- Assignee: Jamie Grier > Modify run loop in Kinesis ShardConsumer to not sleep for a fixed > f

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200708088 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -858,13 +859,18 @@ class Descripto

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535096#comment-16535096 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535091#comment-16535091 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200707458 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -110,16 +111,44 @@ abstract class BatchTa

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535088#comment-16535088 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200706878 --- Diff: flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowFormatFactoryTest.java --- @@ -0,0 +1,147 @@ +/* + * Licensed

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535085#comment-16535085 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200706630 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactoryService.scala --- @@ -0,0 +1,245 @@ +/* + * Li

[GitHub] flink issue #6276: [FLINK-9486] Introduce TimerState in keyed state backend

2018-07-06 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6276 CC @tillrohrmann ---

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535083#comment-16535083 ] ASF GitHub Bot commented on FLINK-9486: --- Github user StefanRRichter commented on th

[jira] [Updated] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9486: -- Labels: pull-request-available (was: ) > Introduce TimerState in keyed state backend > ---

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535082#comment-16535082 ] ASF GitHub Bot commented on FLINK-9486: --- GitHub user StefanRRichter opened a pull r

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-06 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/6276 [FLINK-9486] Introduce TimerState in keyed state backend ## What is the purpose of the change This PR integrates `InternalTimerQueue` with keyed state backends (Heap and RocksDB), so

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535070#comment-16535070 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200702383 --- Diff: flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowFormatFactoryTest.java --- @@ -0,0 +1,91 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535036#comment-16535036 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200696183 --- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowFormatFactory.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535026#comment-16535026 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200694738 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactoryTestBase.java --- @@

[jira] [Commented] (FLINK-9643) Flink allowing TLS 1.1 in spite of configuring TLS 1.2

2018-07-06 Thread Viktor Vlasov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535017#comment-16535017 ] Viktor Vlasov commented on FLINK-9643: -- Ok, now I figured out that even if the confi

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535004#comment-16535004 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200690291 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactoryTestBase.java --- @@

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534988#comment-16534988 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200687537 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka011JsonTableSourceFactory.java --- @@ -

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534981#comment-16534981 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200686436 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactory.java --- @@ -124,110

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534973#comment-16534973 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200685042 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactory.java --- @@ -124,110

[jira] [Commented] (FLINK-9643) Flink allowing TLS 1.1 in spite of configuring TLS 1.2

2018-07-06 Thread Viktor Vlasov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534970#comment-16534970 ] Viktor Vlasov commented on FLINK-9643: -- I think that my assumption about _The protoc

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534964#comment-16534964 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200684172 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactory.java --- @@ -124,110

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534954#comment-16534954 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200682089 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010JsonTableSource.java --- @@ -32,7 +3

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534942#comment-16534942 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200679446 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010AvroTableSource.java --- @@ -46,7 +5

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534938#comment-16534938 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200678922 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010JsonTableSource.java --- @@ -32,7 +3

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200677056 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010TableSource.java --- @@ -18,48 +18,9

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534932#comment-16534932 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-06 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200653352 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactoryTestBase.java --- @

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534878#comment-16534878 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534880#comment-16534880 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534872#comment-16534872 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534874#comment-16534874 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534895#comment-16534895 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534883#comment-16534883 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534885#comment-16534885 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534899#comment-16534899 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534887#comment-16534887 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534890#comment-16534890 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534892#comment-16534892 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534897#comment-16534897 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534876#comment-16534876 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534888#comment-16534888 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534886#comment-16534886 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534882#comment-16534882 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534870#comment-16534870 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534898#comment-16534898 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534871#comment-16534871 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534889#comment-16534889 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534867#comment-16534867 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534879#comment-16534879 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534893#comment-16534893 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534891#comment-16534891 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534896#comment-16534896 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534894#comment-16534894 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534875#comment-16534875 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534884#comment-16534884 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534869#comment-16534869 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

  1   2   3   >