[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536531#comment-16536531 ] ASF GitHub Bot commented on FLINK-9407: --- Github user wgtmac commented on a diff in the pull

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536530#comment-16536530 ] ASF GitHub Bot commented on FLINK-9407: --- Github user wgtmac commented on a diff in the pull

[jira] [Updated] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9407: -- Labels: pull-request-available (was: ) > Support orc rolling sink writer >

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread wgtmac
Github user wgtmac commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200879243 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread wgtmac
Github user wgtmac commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200879624 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread wgtmac
Github user wgtmac commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200878724 --- Diff: flink-connectors/flink-orc/pom.xml --- @@ -54,6 +54,14 @@ under the License. true +

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536529#comment-16536529 ] ASF GitHub Bot commented on FLINK-9407: --- Github user wgtmac commented on a diff in the pull

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536532#comment-16536532 ] ASF GitHub Bot commented on FLINK-9407: --- Github user wgtmac commented on a diff in the pull

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread wgtmac
Github user wgtmac commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200879775 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-07-08 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536525#comment-16536525 ] Zhenqiu Huang commented on FLINK-7243: -- [~nssalian]  We already have a working version on

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536522#comment-16536522 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 closed the pull request at:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536523#comment-16536523 ] ASF GitHub Bot commented on FLINK-8866: --- GitHub user suez1224 reopened a pull request:

[GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...

2018-07-08 Thread suez1224
GitHub user suez1224 reopened a pull request: https://github.com/apache/flink/pull/6201 [FLINK-8866][Table API & SQL] Add support for unified table sink instantiation **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change

[GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...

2018-07-08 Thread suez1224
Github user suez1224 closed the pull request at: https://github.com/apache/flink/pull/6201 ---

[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536483#comment-16536483 ] ASF GitHub Bot commented on FLINK-9666: --- Github user lamber-ken commented on the issue:

[GitHub] flink issue #6230: [FLINK-9666] short-circuit logic should be used in boolea...

2018-07-08 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6230 @tillrohrmann, @zentol, cc. ---

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-07-08 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536479#comment-16536479 ] Neelesh Srinivas Salian commented on FLINK-7243: What is the status of this [~godfreyhe]

[jira] [Comment Edited] (FLINK-6976) Add STR_TO_DATE supported in TableAPI

2018-07-08 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536478#comment-16536478 ] Neelesh Srinivas Salian edited comment on FLINK-6976 at 7/9/18 1:40 AM:

[jira] [Comment Edited] (FLINK-6976) Add STR_TO_DATE supported in TableAPI

2018-07-08 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536478#comment-16536478 ] Neelesh Srinivas Salian edited comment on FLINK-6976 at 7/9/18 1:40 AM:

[jira] [Commented] (FLINK-6976) Add STR_TO_DATE supported in TableAPI

2018-07-08 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536478#comment-16536478 ] Neelesh Srinivas Salian commented on FLINK-6976: [~sunjincheng121], could I work on this

[jira] [Commented] (FLINK-9777) YARN: JM and TM Memory must be specified with Units

2018-07-08 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536477#comment-16536477 ] vinoyang commented on FLINK-9777: - [~gjy] I fixed issue FLINK-6469, I will take this ticket. > YARN: JM

[jira] [Assigned] (FLINK-9777) YARN: JM and TM Memory must be specified with Units

2018-07-08 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9777: --- Assignee: vinoyang > YARN: JM and TM Memory must be specified with Units >

[jira] [Commented] (FLINK-9588) Reuse the same conditionContext with in a same computationState

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536455#comment-16536455 ] ASF GitHub Bot commented on FLINK-9588: --- Github user Aitozi closed the pull request at:

[GitHub] flink pull request #6168: [FLINK-9588][CEP]Reused context with same computat...

2018-07-08 Thread Aitozi
Github user Aitozi closed the pull request at: https://github.com/apache/flink/pull/6168 ---

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536289#comment-16536289 ] ASF GitHub Bot commented on FLINK-9750: --- Github user xndai commented on the issue:

[GitHub] flink issue #6281: [FLINK-9750] Add new StreamingFileSink with ResumableWrit...

2018-07-08 Thread xndai
Github user xndai commented on the issue: https://github.com/apache/flink/pull/6281 hi @kl0u , where can I find overall document/design of the bucketing sink rework (FLINK-9749)? I am a committer of Apache Orc and are interested in helping Flink-Orc integration. ---

[jira] [Updated] (FLINK-9777) YARN: JM and TM Memory must be specified with Units

2018-07-08 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-9777: Description: FLINK-6469 breaks backwards compatibility because the JobManager and TaskManager memory must

[jira] [Updated] (FLINK-9777) YARN: JM and TM Memory must be specified with Units

2018-07-08 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-9777: Description: FLINK-6469 breaks backwards compatibility because the JobManager and TaskManager memory

[jira] [Updated] (FLINK-9777) YARN: JM and TM Memory must be specified with Units

2018-07-08 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-9777: Environment: commit 9f736d1927c62d220a82931c4f5ffa4955910f27 > YARN: JM and TM Memory must be specified

[jira] [Created] (FLINK-9777) YARN: JM and TM Memory must be specified with Units

2018-07-08 Thread Gary Yao (JIRA)
Gary Yao created FLINK-9777: --- Summary: YARN: JM and TM Memory must be specified with Units Key: FLINK-9777 URL: https://issues.apache.org/jira/browse/FLINK-9777 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-9588) Reuse the same conditionContext with in a same computationState

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536132#comment-16536132 ] ASF GitHub Bot commented on FLINK-9588: --- Github user dawidwys commented on the issue:

[GitHub] flink issue #6168: [FLINK-9588][CEP]Reused context with same computation sta...

2018-07-08 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6168 Hi @Aitozi, yes please close this PR, as I made a spelling mistake while merging and that's why it wasn't closed automatically. Thanks! ---

[jira] [Updated] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9407: Description: Currently, we only support {{StringWriter}}, {{SequenceFileWriter}} and

[jira] [Updated] (FLINK-6847) Add TIMESTAMPDIFF supported in TableAPI

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-6847: -- Labels: pull-request-available starter (was: starter) > Add TIMESTAMPDIFF supported in

[jira] [Commented] (FLINK-9411) Support parquet rolling sink writer

2018-07-08 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536070#comment-16536070 ] zhangminglei commented on FLINK-9411: - [~triones] Are you still working on this ? > Support parquet

[jira] [Commented] (FLINK-6847) Add TIMESTAMPDIFF supported in TableAPI

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536071#comment-16536071 ] ASF GitHub Bot commented on FLINK-6847: --- GitHub user xueyumusic opened a pull request:

[GitHub] flink pull request #6282: [FLINK-6847][FLINK-6813][Table Api & Sql] Timestam...

2018-07-08 Thread xueyumusic
GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6282 [FLINK-6847][FLINK-6813][Table Api & Sql] TimestampDiff table api and sql support ## What is the purpose of the change This PR propose to add TimestampDiff sql and table Api. Sql

[jira] [Updated] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9407: Labels: (was: patch-available pull-request-available) > Support orc rolling sink writer >

[jira] [Updated] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9407: Description: Currently, we only support {{StringWriter}}, {{SequenceFileWriter}} and

[jira] [Updated] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9407: Description: Currently, we only support {{StringWriter}}, {{SequenceFileWriter}} and

[jira] [Updated] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9407: Description: Currently, we only support {{StringWriter}}, {{SequenceFileWriter}} and

[jira] [Commented] (FLINK-5232) Add a Thread default uncaught exception handler on the JobManager

2018-07-08 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536059#comment-16536059 ] vinoyang commented on FLINK-5232: - [~till.rohrmann] this issues past a long time,  any opinion? > Add a

[jira] [Assigned] (FLINK-5231) JobManager should exit on "OutOfMemoryError"

2018-07-08 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-5231: --- Assignee: vinoyang > JobManager should exit on "OutOfMemoryError" >

[jira] [Commented] (FLINK-9377) Remove writing serializers as part of the checkpoint meta information

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536052#comment-16536052 ] ASF GitHub Bot commented on FLINK-9377: --- Github user yanghua commented on the issue:

[GitHub] flink issue #6273: [FLINK-9377] [core] Implement restore serializer factory ...

2018-07-08 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6273 conflicts, please update the PR~ ---

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536051#comment-16536051 ] ASF GitHub Bot commented on FLINK-9750: --- Github user yanghua commented on a diff in the pull

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-08 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r200835177 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/serialization/Writer.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-9733) Make location for job graph files configurable

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536050#comment-16536050 ] ASF GitHub Bot commented on FLINK-9733: --- Github user yanghua commented on the issue:

[GitHub] flink issue #6280: [FLINK-9733] Make location for job graph files configurab...

2018-07-08 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6280 @zentol thanks for your suggestion, I have done some refactor and removed the config item from `RestOptions ` ---

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536025#comment-16536025 ] ASF GitHub Bot commented on FLINK-9407: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200833563 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200831458 --- Diff: flink-connectors/flink-orc/src/test/java/org/apache/flink/orc/OrcFileWriterTest.java --- @@ -0,0 +1,40 @@ +/** + * Licensed to the

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536007#comment-16536007 ] ASF GitHub Bot commented on FLINK-9407: --- Github user zhangminglei commented on a diff in the pull

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536005#comment-16536005 ] ASF GitHub Bot commented on FLINK-9407: --- Github user xndai commented on a diff in the pull request:

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200831360 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536004#comment-16536004 ] ASF GitHub Bot commented on FLINK-9407: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200830833 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535997#comment-16535997 ] ASF GitHub Bot commented on FLINK-9407: --- Github user xndai commented on a diff in the pull request:

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535999#comment-16535999 ] ASF GitHub Bot commented on FLINK-9407: --- Github user xndai commented on a diff in the pull request:

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535998#comment-16535998 ] ASF GitHub Bot commented on FLINK-9407: --- Github user xndai commented on a diff in the pull request:

[jira] [Commented] (FLINK-9407) Support orc rolling sink writer

2018-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535996#comment-16535996 ] ASF GitHub Bot commented on FLINK-9407: --- Github user xndai commented on a diff in the pull request:

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200830078 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200830111 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200830013 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcFileWriter.java --- @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache

[GitHub] flink pull request #6075: [FLINK-9407] [hdfs connector] Support orc rolling ...

2018-07-08 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/flink/pull/6075#discussion_r200830153 --- Diff: flink-connectors/flink-orc/src/test/java/org/apache/flink/orc/OrcFileWriterTest.java --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache