[GitHub] twalthr commented on a change in pull request #6359: [FLINK-6895][table]Add STR_TO_DATE supported in SQL

2018-08-19 Thread GitBox
twalthr commented on a change in pull request #6359: [FLINK-6895][table]Add STR_TO_DATE supported in SQL URL: https://github.com/apache/flink/pull/6359#discussion_r211093924 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/StrToDateCallG

[jira] [Commented] (FLINK-6895) Add STR_TO_DATE supported in SQL

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585045#comment-16585045 ] ASF GitHub Bot commented on FLINK-6895: --- twalthr commented on a change in pull requ

[jira] [Commented] (FLINK-6895) Add STR_TO_DATE supported in SQL

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585044#comment-16585044 ] ASF GitHub Bot commented on FLINK-6895: --- twalthr commented on a change in pull requ

[GitHub] TisonKun commented on issue #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-19 Thread GitBox
TisonKun commented on issue #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#issuecomment-414108811 @fhueske I think this PR meets its purpose. LGTM! This

[jira] [Commented] (FLINK-10153) Add tutorial section to documentation

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585053#comment-16585053 ] ASF GitHub Bot commented on FLINK-10153: TisonKun commented on issue #6565: [FLI

[jira] [Commented] (FLINK-10156) Drop the Table.writeToSink() method

2018-08-19 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585075#comment-16585075 ] Hequn Cheng commented on FLINK-10156: - Ok, make sense. +1 on deprecating the method.

[GitHub] yanghua opened a new pull request #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors

2018-08-19 Thread GitBox
yanghua opened a new pull request #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors URL: https://github.com/apache/flink/pull/6577 ## What is the purpose of the change *This pull request add Apache Kafka 1.0/1.1 connectors* ## Brief change log - *Add Apache

[jira] [Updated] (FLINK-7964) Add Apache Kafka 1.0/1.1 connectors

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-7964: -- Labels: pull-request-available (was: ) > Add Apache Kafka 1.0/1.1 connectors > ---

[jira] [Commented] (FLINK-7964) Add Apache Kafka 1.0/1.1 connectors

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585098#comment-16585098 ] ASF GitHub Bot commented on FLINK-7964: --- yanghua opened a new pull request #6577: [

[GitHub] klion26 commented on issue #6558: [FLINK-9116] Introduce getAll and removeAll for MapState

2018-08-19 Thread GitBox
klion26 commented on issue #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558#issuecomment-414117596 Hi, @StefanRRichter If I use a field to store the user map in Heap backend, I will override the `AbstractHeapState#clear` to upda

[jira] [Commented] (FLINK-9116) Introduce getAll and removeAll for MapState

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585108#comment-16585108 ] ASF GitHub Bot commented on FLINK-9116: --- klion26 commented on issue #6558: [FLINK-9

[jira] [Commented] (FLINK-10168) support filtering files by modified/created time in StreamExecutionEnvironment.readFile()

2018-08-19 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585121#comment-16585121 ] buptljy commented on FLINK-10168: - [~phoenixjiangnan] You're right. The second solution

[jira] [Created] (FLINK-10170) Support map types in descriptor-based Table API

2018-08-19 Thread Jun Zhang (JIRA)
Jun Zhang created FLINK-10170: - Summary: Support map types in descriptor-based Table API Key: FLINK-10170 URL: https://issues.apache.org/jira/browse/FLINK-10170 Project: Flink Issue Type: Improve

[jira] [Updated] (FLINK-10170) Support map types in descriptor-based Table API

2018-08-19 Thread Jun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Zhang updated FLINK-10170: -- Attachment: flink-10170 > Support map types in descriptor-based Table API > --

[jira] [Updated] (FLINK-10170) Support map types in descriptor-based Table API

2018-08-19 Thread Jun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Zhang updated FLINK-10170: -- Description: Since 1.6 the recommended way of creating source/sink table is using connector/format/sc

[jira] [Updated] (FLINK-10170) Support string representation for map types in descriptor-based Table API

2018-08-19 Thread Jun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Zhang updated FLINK-10170: -- Summary: Support string representation for map types in descriptor-based Table API (was: Support stri

[jira] [Updated] (FLINK-10170) Support string representation for map types

2018-08-19 Thread Jun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Zhang updated FLINK-10170: -- Summary: Support string representation for map types (was: Support map types in descriptor-based Tabl

[jira] [Commented] (FLINK-9642) Reduce the count to deal with state during a CEP process

2018-08-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585165#comment-16585165 ] Chesnay Schepler commented on FLINK-9642: - [~dawidwys] Can you give this issue a

[GitHub] tragicjun opened a new pull request #6578: [FLINK-10170 [table] Support string representation for map types in d…

2018-08-19 Thread GitBox
tragicjun opened a new pull request #6578: [FLINK-10170 [table] Support string representation for map types in d… URL: https://github.com/apache/flink/pull/6578 ## What is the purpose of the change Since 1.6 the recommended way of creating source/sink table is using connector/format

[jira] [Updated] (FLINK-10170) Support string representation for map types in descriptor-based Table API

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10170: --- Labels: pull-request-available (was: ) > Support string representation for map types in des

[jira] [Commented] (FLINK-10170) Support string representation for map types in descriptor-based Table API

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585166#comment-16585166 ] ASF GitHub Bot commented on FLINK-10170: tragicjun opened a new pull request #65

[GitHub] tragicjun removed a comment on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-19 Thread GitBox
tragicjun removed a comment on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#issuecomment-411685212 @twalthr @suez1224 could you please review?

[GitHub] tragicjun removed a comment on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-19 Thread GitBox
tragicjun removed a comment on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#issuecomment-412394575 CC @zentol @fhueske This is an

[GitHub] tragicjun commented on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-19 Thread GitBox
tragicjun commented on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#issuecomment-414133588 @walterddr @twalthr @fhueske could you please take a look, I thought it was a nice-to-have add-on in the

[jira] [Updated] (FLINK-9642) Add caching layer to SharedBuffer

2018-08-19 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-9642: Summary: Add caching layer to SharedBuffer (was: Reduce the count to deal with state durin

[jira] [Created] (FLINK-10171) Allow for assemblePartPath override in the BucketingSink

2018-08-19 Thread Lakshmi Rao (JIRA)
Lakshmi Rao created FLINK-10171: --- Summary: Allow for assemblePartPath override in the BucketingSink Key: FLINK-10171 URL: https://issues.apache.org/jira/browse/FLINK-10171 Project: Flink Issue

[jira] [Commented] (FLINK-10170) Support string representation for map types in descriptor-based Table API

2018-08-19 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585204#comment-16585204 ] buptljy commented on FLINK-10170: - I think this is duplicated by FLINK-10120, can you he

[jira] [Commented] (FLINK-10170) Support string representation for map types in descriptor-based Table API

2018-08-19 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585210#comment-16585210 ] buptljy commented on FLINK-10170: - I think this duplicates FLINK-10120, can you help imp

[jira] [Issue Comment Deleted] (FLINK-10170) Support string representation for map types in descriptor-based Table API

2018-08-19 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] buptljy updated FLINK-10170: Comment: was deleted (was: I think this is duplicated by FLINK-10120, can you help implement the same thi

[GitHub] buptljy commented on issue #6578: [FLINK-10170] [table] Support string representation for map types in descriptor-based Table API

2018-08-19 Thread GitBox
buptljy commented on issue #6578: [FLINK-10170] [table] Support string representation for map types in descriptor-based Table API URL: https://github.com/apache/flink/pull/6578#issuecomment-414141226 @tragicjun +1, this is good, but can you implement the same thing on other types like arra

[jira] [Commented] (FLINK-10170) Support string representation for map types in descriptor-based Table API

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585211#comment-16585211 ] ASF GitHub Bot commented on FLINK-10170: buptljy commented on issue #6578: [FLIN

[GitHub] Guibo-Pan commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL

2018-08-19 Thread GitBox
Guibo-Pan commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6576#issuecomment-414144275 @yanghua thanks for your suggestion, I've made an update. ---

[jira] [Commented] (FLINK-10145) Add replace supported in TableAPI and SQL

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585227#comment-16585227 ] ASF GitHub Bot commented on FLINK-10145: Guibo-Pan commented on issue #6576: [FL

[GitHub] StephanEwen commented on issue #5982: [FLINK-9325][checkpoint]generate the meta file for checkpoint only when the writing is truly successful

2018-08-19 Thread GitBox
StephanEwen commented on issue #5982: [FLINK-9325][checkpoint]generate the meta file for checkpoint only when the writing is truly successful URL: https://github.com/apache/flink/pull/5982#issuecomment-414149487 Apologies for the delay. The interface of the `AtomicCreatingFsDataOutpu

[jira] [Commented] (FLINK-9325) generate the _meta file for checkpoint only when the writing is truly successful

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585251#comment-16585251 ] ASF GitHub Bot commented on FLINK-9325: --- StephanEwen commented on issue #5982: [FLI

[jira] [Created] (FLINK-10172) Inconsistentcy in ExpressionParser and ExpressionDsl for order by asc/desc

2018-08-19 Thread Rong Rong (JIRA)
Rong Rong created FLINK-10172: - Summary: Inconsistentcy in ExpressionParser and ExpressionDsl for order by asc/desc Key: FLINK-10172 URL: https://issues.apache.org/jira/browse/FLINK-10172 Project: Flink

[GitHub] hequn8128 commented on issue #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-19 Thread GitBox
hequn8128 commented on issue #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#issuecomment-414172119 +1 to merge. I could not spot any issues with the pr. Also could not find any broken links. --

[jira] [Commented] (FLINK-10153) Add tutorial section to documentation

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585324#comment-16585324 ] ASF GitHub Bot commented on FLINK-10153: hequn8128 commented on issue #6565: [FL

[GitHub] HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format

2018-08-19 Thread GitBox
HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r211128582 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetInputF

[GitHub] HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format

2018-08-19 Thread GitBox
HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r211129763 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetInputF

[GitHub] HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format

2018-08-19 Thread GitBox
HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r211130119 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/Parquet

[GitHub] HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format

2018-08-19 Thread GitBox
HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r211131207 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/Parquet

[GitHub] HuangZhenQiu commented on issue #6483: [Flink-7243][flink-formats] Add parquet input format

2018-08-19 Thread GitBox
HuangZhenQiu commented on issue #6483: [Flink-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-414184561 @walterddr @suez1224 Fixed Rong's comments. Please continue with the review process at your most convenient time. -

[GitHub] HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format

2018-08-19 Thread GitBox
HuangZhenQiu commented on a change in pull request #6483: [Flink-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r211131715 ## File path: flink-formats/flink-parquet/pom.xml ## @@ -73,6 +73,11 @@ under the License.

[jira] [Assigned] (FLINK-9716) Support scans from table version function

2018-08-19 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruidong Li reassigned FLINK-9716: - Assignee: Ruidong Li > Support scans from table version function > -

[jira] [Commented] (FLINK-9716) Support scans from table version function

2018-08-19 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585380#comment-16585380 ] Ruidong Li commented on FLINK-9716: --- https://issues.apache.org/jira/browse/FLINK-8868 d

[jira] [Comment Edited] (FLINK-9716) Support scans from table version function

2018-08-19 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585380#comment-16585380 ] Ruidong Li edited comment on FLINK-9716 at 8/20/18 3:25 AM: h

[GitHub] yanghua commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors

2018-08-19 Thread GitBox
yanghua commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors URL: https://github.com/apache/flink/pull/6577#issuecomment-414209554 cc @tillrohrmann and @aljoscha This is an automated message from the Ap

[jira] [Commented] (FLINK-7964) Add Apache Kafka 1.0/1.1 connectors

2018-08-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585471#comment-16585471 ] ASF GitHub Bot commented on FLINK-7964: --- yanghua commented on issue #6577: [FLINK-7

[jira] [Created] (FLINK-10173) Elasticsearch 6 connector does not package Elasticsearch

2018-08-19 Thread Timo Walther (JIRA)
Timo Walther created FLINK-10173: Summary: Elasticsearch 6 connector does not package Elasticsearch Key: FLINK-10173 URL: https://issues.apache.org/jira/browse/FLINK-10173 Project: Flink Issu

[jira] [Updated] (FLINK-10173) Elasticsearch 6 connector does not package Elasticsearch

2018-08-19 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-10173: - Affects Version/s: 1.6.0 > Elasticsearch 6 connector does not package Elasticsearch > --