[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631414#comment-16631414 ] ASF GitHub Bot commented on FLINK-10057: lzqdename commented on issue #6491: [FL

[GitHub] lzqdename commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-27 Thread GitBox
lzqdename commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-425334328 > @lzqdename From my side this pull request goes the right direction and now it is ready to be merged. > > However, I am not a comm

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631412#comment-16631412 ] ASF GitHub Bot commented on FLINK-10057: TisonKun edited a comment on issue #649

[GitHub] TisonKun edited a comment on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-27 Thread GitBox
TisonKun edited a comment on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-425333772 @lzqdename From my side this pull request goes the right direction and now it is ready to be merged. However, I am not a comm

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631410#comment-16631410 ] ASF GitHub Bot commented on FLINK-10057: TisonKun commented on issue #6491: [FLI

[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-27 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-425333772 @lzqdename From my side this pull request goes the right direction and now it is ready to be merged. However, I am not a committer wh

[GitHub] Guibo-Pan commented on issue #6773: Add reverse function in Table API and SQL

2018-09-27 Thread GitBox
Guibo-Pan commented on issue #6773: Add reverse function in Table API and SQL URL: https://github.com/apache/flink/pull/6773#issuecomment-425318708 cc @xccui @yanghua This is an automated message from the Apache Git Service.

[jira] [Commented] (FLINK-10340) Add Cosh math function supported in Table API and SQL

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631324#comment-16631324 ] ASF GitHub Bot commented on FLINK-10340: xccui commented on a change in pull req

[GitHub] xccui commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL

2018-09-27 Thread GitBox
xccui commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6700#discussion_r221136490 ## File path: docs/dev/table/functions.md ## @@ -1274,6 +1274,17 @@ ATAN2(nume

[jira] [Commented] (FLINK-10340) Add Cosh math function supported in Table API and SQL

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631322#comment-16631322 ] ASF GitHub Bot commented on FLINK-10340: xccui commented on a change in pull req

[GitHub] xccui commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL

2018-09-27 Thread GitBox
xccui commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6700#discussion_r221136490 ## File path: docs/dev/table/functions.md ## @@ -1274,6 +1274,17 @@ ATAN2(nume

[GitHub] Guibo-Pan opened a new pull request #6773: Add reverse function in Table API and SQL

2018-09-27 Thread GitBox
Guibo-Pan opened a new pull request #6773: Add reverse function in Table API and SQL URL: https://github.com/apache/flink/pull/6773 ## What is the purpose of the change *This pull request add replace function in TableAPI and SQL* ## Brief change log - *Add reverse fun

[jira] [Created] (FLINK-10456) Remove org.apache.flink.api.common.time.Deadline

2018-09-27 Thread tison (JIRA)
tison created FLINK-10456: - Summary: Remove org.apache.flink.api.common.time.Deadline Key: FLINK-10456 URL: https://issues.apache.org/jira/browse/FLINK-10456 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-10420) Create and drop view in sql client should check the view created based on the configuration.

2018-09-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631287#comment-16631287 ] vinoyang commented on FLINK-10420: -- hi [~twalthr] I think the *CREATE OR REPLACE VIEW*

[jira] [Updated] (FLINK-10240) Pluggable scheduling strategy for batch jobs

2018-09-27 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-10240: Affects Version/s: 1.7.0 > Pluggable scheduling strategy for batch jobs >

[jira] [Comment Edited] (FLINK-4399) Add support for oversized messages

2018-09-27 Thread Leanken.Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631275#comment-16631275 ] Leanken.Lin edited comment on FLINK-4399 at 9/28/18 2:26 AM: -

[jira] [Commented] (FLINK-10398) Add Tanh math function supported in Table API and SQL

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631278#comment-16631278 ] ASF GitHub Bot commented on FLINK-10398: yanghua commented on issue #6736: [FLIN

[GitHub] yanghua commented on issue #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL

2018-09-27 Thread GitBox
yanghua commented on issue #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6736#issuecomment-425300319 @pnowojski I also changed this PR based on your suggestion for the `cosh`

[jira] [Comment Edited] (FLINK-4399) Add support for oversized messages

2018-09-27 Thread Leanken.Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631275#comment-16631275 ] Leanken.Lin edited comment on FLINK-4399 at 9/28/18 2:21 AM: -

[jira] [Commented] (FLINK-4399) Add support for oversized messages

2018-09-27 Thread Leanken.Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631275#comment-16631275 ] Leanken.Lin commented on FLINK-4399: Hi. [~till.rohrmann] > Add support for oversize

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631252#comment-16631252 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on issue #6759: [FL

[GitHub] Clarkkkkk commented on issue #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-09-27 Thread GitBox
Clark commented on issue #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#issuecomment-425296165 cc @TisonKun @yanghua This is an automated m

[jira] [Commented] (FLINK-10168) support filtering files by modified/created time in StreamExecutionEnvironment.readFile()

2018-09-27 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631165#comment-16631165 ] Bowen Li commented on FLINK-10168: -- [~wind_ljy] are you planning to start working on th

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631143#comment-16631143 ] ASF GitHub Bot commented on FLINK-10289: isunjin commented on issue #6739: [FLIN

[GitHub] isunjin commented on issue #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread GitBox
isunjin commented on issue #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#issuecomment-425266762 @StephanEwen , i have changed the implementation with java annotation, could yo

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631036#comment-16631036 ] ASF GitHub Bot commented on FLINK-10289: yingdachen commented on a change in pul

[GitHub] yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread GitBox
yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#discussion_r221074188 ## File path: flink-runtime/src/main/java/org/apa

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631031#comment-16631031 ] ASF GitHub Bot commented on FLINK-10289: yingdachen commented on a change in pul

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631032#comment-16631032 ] ASF GitHub Bot commented on FLINK-10289: yingdachen commented on a change in pul

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631033#comment-16631033 ] ASF GitHub Bot commented on FLINK-10289: yingdachen commented on a change in pul

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631030#comment-16631030 ] ASF GitHub Bot commented on FLINK-10289: yingdachen commented on a change in pul

[GitHub] yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread GitBox
yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#discussion_r221073399 ## File path: flink-runtime/src/main/java/org/apa

[GitHub] yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread GitBox
yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#discussion_r221073448 ## File path: flink-runtime/src/main/java/org/apa

[GitHub] yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread GitBox
yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#discussion_r221073415 ## File path: flink-runtime/src/main/java/org/apa

[GitHub] yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread GitBox
yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#discussion_r221073384 ## File path: flink-runtime/src/main/java/org/apa

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631029#comment-16631029 ] ASF GitHub Bot commented on FLINK-10289: yingdachen commented on a change in pul

[GitHub] yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-09-27 Thread GitBox
yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#discussion_r221073431 ## File path: flink-runtime/src/main/java/org/apa

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630888#comment-16630888 ] ASF GitHub Bot commented on FLINK-10205: xndai commented on a change in pull req

[GitHub] xndai commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…

2018-09-27 Thread GitBox
xndai commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6684#discussion_r221036186 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630841#comment-16630841 ] ASF GitHub Bot commented on FLINK-10205: isunjin commented on a change in pull r

[GitHub] isunjin commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…

2018-09-27 Thread GitBox
isunjin commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6684#discussion_r221024426 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Executi

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630825#comment-16630825 ] ASF GitHub Bot commented on FLINK-10057: lzqdename commented on issue #6491: [FL

[GitHub] lzqdename commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-27 Thread GitBox
lzqdename commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-425186485 @TisonKun @StefanRRichter will this PR be merged into master edition? Thi

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630816#comment-16630816 ] ASF GitHub Bot commented on FLINK-10205: isunjin commented on a change in pull r

[GitHub] isunjin commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…

2018-09-27 Thread GitBox
isunjin commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6684#discussion_r221019265 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Executi

[jira] [Commented] (FLINK-9377) Remove writing serializers as part of the checkpoint meta information

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630790#comment-16630790 ] ASF GitHub Bot commented on FLINK-9377: --- StephanEwen commented on issue #6711: [FLI

[GitHub] StephanEwen commented on issue #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-09-27 Thread GitBox
StephanEwen commented on issue #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#issuecomment-425180397 @dawidwys and me had a long joint review / discussion session. A lot in this PR goes in a very good direction.

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630761#comment-16630761 ] ASF GitHub Bot commented on FLINK-10205: xndai commented on a change in pull req

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630760#comment-16630760 ] ASF GitHub Bot commented on FLINK-10205: xndai commented on a change in pull req

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630759#comment-16630759 ] ASF GitHub Bot commented on FLINK-10205: xndai commented on a change in pull req

[GitHub] xndai commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…

2018-09-27 Thread GitBox
xndai commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6684#discussion_r221007252 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.

[GitHub] xndai commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…

2018-09-27 Thread GitBox
xndai commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6684#discussion_r221002876 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution

[GitHub] xndai commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…

2018-09-27 Thread GitBox
xndai commented on a change in pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6684#discussion_r221001196 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630712#comment-16630712 ] ASF GitHub Bot commented on FLINK-10397: tillrohrmann commented on issue #6752:

[GitHub] tillrohrmann commented on issue #6752: [FLINK-10397] Remove CoreOptions#MODE

2018-09-27 Thread GitBox
tillrohrmann commented on issue #6752: [FLINK-10397] Remove CoreOptions#MODE URL: https://github.com/apache/flink/pull/6752#issuecomment-425159955 I agree with @TisonKun. Removing the `EXECUTION_MODE_OPTION` and `isNewMode` can be done in another subtask of FLINK-10392. ---

[jira] [Commented] (FLINK-10399) Refractor ParameterTool#fromArgs

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630706#comment-16630706 ] ASF GitHub Bot commented on FLINK-10399: TisonKun commented on issue #6737: [FLI

[GitHub] TisonKun commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs

2018-09-27 Thread GitBox
TisonKun commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs URL: https://github.com/apache/flink/pull/6737#issuecomment-425159102 ping @StephanEwen what is the following step? I am confused that it stalls. --

[jira] [Commented] (FLINK-10419) ClassNotFoundException while deserializing user exceptions from checkpointing

2018-09-27 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630660#comment-16630660 ] Nico Kruber commented on FLINK-10419: - The initial error on the task managers leadin

[jira] [Updated] (FLINK-10419) ClassNotFoundException while deserializing user exceptions from checkpointing

2018-09-27 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-10419: Description: It seems that somewhere in the operator's failure handling, we hand a user-code exce

[jira] [Created] (FLINK-10455) Potential Kafka producer leak in case of failures

2018-09-27 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-10455: --- Summary: Potential Kafka producer leak in case of failures Key: FLINK-10455 URL: https://issues.apache.org/jira/browse/FLINK-10455 Project: Flink Issue Type: B

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630646#comment-16630646 ] ASF GitHub Bot commented on FLINK-10397: tillrohrmann commented on a change in p

[GitHub] tillrohrmann commented on a change in pull request #6752: [FLINK-10397] Remove CoreOptions#MODE

2018-09-27 Thread GitBox
tillrohrmann commented on a change in pull request #6752: [FLINK-10397] Remove CoreOptions#MODE URL: https://github.com/apache/flink/pull/6752#discussion_r220978579 ## File path: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendTestBase.java ## @@ -19,43

[jira] [Commented] (FLINK-10384) Add Sinh math function supported in Table API and SQL

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630623#comment-16630623 ] ASF GitHub Bot commented on FLINK-10384: yanghua edited a comment on issue #6730

[jira] [Commented] (FLINK-10384) Add Sinh math function supported in Table API and SQL

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630622#comment-16630622 ] ASF GitHub Bot commented on FLINK-10384: yanghua commented on issue #6730: [FLIN

[GitHub] yanghua edited a comment on issue #6730: [FLINK-10384][table] Add Sinh math function supported in Table API and SQL

2018-09-27 Thread GitBox
yanghua edited a comment on issue #6730: [FLINK-10384][table] Add Sinh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6730#issuecomment-425139027 @pnowojski I have refactored this PR's documentation. --

[GitHub] yanghua commented on issue #6730: [FLINK-10384][table] Add Sinh math function supported in Table API and SQL

2018-09-27 Thread GitBox
yanghua commented on issue #6730: [FLINK-10384][table] Add Sinh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6730#issuecomment-425139027 @pnowojski also refactored this PR's documentation. ---

[jira] [Commented] (FLINK-9455) Make SlotManager aware of multi slot TaskManagers

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630616#comment-16630616 ] ASF GitHub Bot commented on FLINK-9455: --- tillrohrmann commented on issue #6734: [FL

[GitHub] tillrohrmann commented on issue #6734: [FLINK-9455][RM] Add support for multi task slot TaskExecutors

2018-09-27 Thread GitBox
tillrohrmann commented on issue #6734: [FLINK-9455][RM] Add support for multi task slot TaskExecutors URL: https://github.com/apache/flink/pull/6734#issuecomment-425136715 Thanks for the review @azagrebin, @GJL and @shuai-xu. Merging this PR once Travis gives green light.

[jira] [Commented] (FLINK-10415) RestClient does not react to lost connection

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630601#comment-16630601 ] ASF GitHub Bot commented on FLINK-10415: tillrohrmann commented on issue #6763:

[GitHub] tillrohrmann commented on issue #6763: [FLINK-10415] Fail response future if connection closes in RestClient

2018-09-27 Thread GitBox
tillrohrmann commented on issue #6763: [FLINK-10415] Fail response future if connection closes in RestClient URL: https://github.com/apache/flink/pull/6763#issuecomment-425132571 Yes, I will increase the idleness timeout to 5 minutes. Merging this PR then. -

[jira] [Commented] (FLINK-10402) Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630600#comment-16630600 ] ASF GitHub Bot commented on FLINK-10402: StefanRRichter commented on a change in

[GitHub] StefanRRichter commented on a change in pull request #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread GitBox
StefanRRichter commented on a change in pull request #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base URL: https://github.com/apache/flink/pull/6750#discussion_r220965813 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/entr

[jira] [Commented] (FLINK-10402) Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630595#comment-16630595 ] ASF GitHub Bot commented on FLINK-10402: tillrohrmann commented on issue #6750:

[GitHub] tillrohrmann commented on issue #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread GitBox
tillrohrmann commented on issue #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base URL: https://github.com/apache/flink/pull/6750#issuecomment-425131771 Thanks for the review @StefanRRichter.

[jira] [Commented] (FLINK-10402) Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630592#comment-16630592 ] ASF GitHub Bot commented on FLINK-10402: tillrohrmann commented on a change in p

[GitHub] tillrohrmann commented on a change in pull request #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread GitBox
tillrohrmann commented on a change in pull request #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base URL: https://github.com/apache/flink/pull/6750#discussion_r220964730 ## File path: flink-tests/src/test/java/org/apache/flink/test/recovery/Ab

[jira] [Commented] (FLINK-10410) Search for broken links on travis

2018-09-27 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630591#comment-16630591 ] Piotr Nowojski commented on FLINK-10410: Ok, thanks [~Zentol] :) > Search for b

[jira] [Commented] (FLINK-10402) Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630590#comment-16630590 ] ASF GitHub Bot commented on FLINK-10402: tillrohrmann commented on a change in p

[jira] [Commented] (FLINK-9712) Support enrichment joins in Flink SQL/Table API

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630589#comment-16630589 ] ASF GitHub Bot commented on FLINK-9712: --- pnowojski commented on issue #6741: [FLINK

[GitHub] tillrohrmann commented on a change in pull request #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread GitBox
tillrohrmann commented on a change in pull request #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base URL: https://github.com/apache/flink/pull/6750#discussion_r220964322 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/entryp

[GitHub] pnowojski commented on issue #6741: [FLINK-9712][table, docs] Document processing time Temporal Table Joins

2018-09-27 Thread GitBox
pnowojski commented on issue #6741: [FLINK-9712][table,docs] Document processing time Temporal Table Joins URL: https://github.com/apache/flink/pull/6741#issuecomment-425130543 I have almost all of the comments (or wrote reply if not). Can you check the revised PR? ---

[jira] [Commented] (FLINK-10402) Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630583#comment-16630583 ] ASF GitHub Bot commented on FLINK-10402: tillrohrmann commented on a change in p

[GitHub] tillrohrmann commented on a change in pull request #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base

2018-09-27 Thread GitBox
tillrohrmann commented on a change in pull request #6750: [FLINK-10402] Port AbstractTaskManagerProcessFailureRecoveryTest to new code base URL: https://github.com/apache/flink/pull/6750#discussion_r220961425 ## File path: flink-tests/src/test/resources/log4j-test.properties ##

[jira] [Commented] (FLINK-9712) Support enrichment joins in Flink SQL/Table API

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630578#comment-16630578 ] ASF GitHub Bot commented on FLINK-9712: --- pnowojski commented on a change in pull re

[jira] [Commented] (FLINK-9712) Support enrichment joins in Flink SQL/Table API

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630573#comment-16630573 ] ASF GitHub Bot commented on FLINK-9712: --- pnowojski commented on a change in pull re

[GitHub] pnowojski commented on a change in pull request #6741: [FLINK-9712][table, docs] Document processing time Temporal Table Joins

2018-09-27 Thread GitBox
pnowojski commented on a change in pull request #6741: [FLINK-9712][table,docs] Document processing time Temporal Table Joins URL: https://github.com/apache/flink/pull/6741#discussion_r220960721 ## File path: docs/dev/table/streaming/temporal_tables.md ## @@ -0,0 +1,263 @@

[GitHub] pnowojski commented on a change in pull request #6741: [FLINK-9712][table, docs] Document processing time Temporal Table Joins

2018-09-27 Thread GitBox
pnowojski commented on a change in pull request #6741: [FLINK-9712][table,docs] Document processing time Temporal Table Joins URL: https://github.com/apache/flink/pull/6741#discussion_r220960460 ## File path: docs/dev/table/streaming/temporal_tables.md ## @@ -0,0 +1,263 @@

[jira] [Commented] (FLINK-10410) Search for broken links on travis

2018-09-27 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630566#comment-16630566 ] Chesnay Schepler commented on FLINK-10410: -- You can also fork the branch {{cron

[jira] [Commented] (FLINK-6873) Limit the number of open writers in file system connector

2018-09-27 Thread Oscar Westra van Holthe - Kind (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630562#comment-16630562 ] Oscar Westra van Holthe - Kind commented on FLINK-6873: --- What may a

[jira] [Commented] (FLINK-9712) Support enrichment joins in Flink SQL/Table API

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630560#comment-16630560 ] ASF GitHub Bot commented on FLINK-9712: --- pnowojski commented on a change in pull re

[GitHub] pnowojski commented on a change in pull request #6741: [FLINK-9712][table, docs] Document processing time Temporal Table Joins

2018-09-27 Thread GitBox
pnowojski commented on a change in pull request #6741: [FLINK-9712][table,docs] Document processing time Temporal Table Joins URL: https://github.com/apache/flink/pull/6741#discussion_r220957402 ## File path: docs/dev/table/streaming/temporal_tables.md ## @@ -0,0 +1,263 @@

[jira] [Commented] (FLINK-9712) Support enrichment joins in Flink SQL/Table API

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630554#comment-16630554 ] ASF GitHub Bot commented on FLINK-9712: --- pnowojski commented on a change in pull re

[GitHub] pnowojski commented on a change in pull request #6741: [FLINK-9712][table, docs] Document processing time Temporal Table Joins

2018-09-27 Thread GitBox
pnowojski commented on a change in pull request #6741: [FLINK-9712][table,docs] Document processing time Temporal Table Joins URL: https://github.com/apache/flink/pull/6741#discussion_r220956370 ## File path: docs/dev/table/streaming/temporal_tables.md ## @@ -0,0 +1,263 @@

[jira] [Commented] (FLINK-10415) RestClient does not react to lost connection

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630530#comment-16630530 ] ASF GitHub Bot commented on FLINK-10415: zentol commented on issue #6763: [FLINK

[GitHub] zentol commented on issue #6763: [FLINK-10415] Fail response future if connection closes in RestClient

2018-09-27 Thread GitBox
zentol commented on issue #6763: [FLINK-10415] Fail response future if connection closes in RestClient URL: https://github.com/apache/flink/pull/6763#issuecomment-425115999 urgh, well that's unfortunate. We may want to increase the idle timeout to a larger value though (maybe 5 minutes?),

[jira] [Commented] (FLINK-10401) Port ProcessFailureCancelingITCase to new code base

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630510#comment-16630510 ] ASF GitHub Bot commented on FLINK-10401: tillrohrmann commented on issue #6749:

[GitHub] tillrohrmann commented on issue #6749: [FLINK-10401] Port ProcessFailureCancelingITCase to new code base

2018-09-27 Thread GitBox
tillrohrmann commented on issue #6749: [FLINK-10401] Port ProcessFailureCancelingITCase to new code base URL: https://github.com/apache/flink/pull/6749#issuecomment-425111422 Thanks for the review @StefanRRichter. Addressing your comment and then merging this PR. -

[jira] [Commented] (FLINK-9712) Support enrichment joins in Flink SQL/Table API

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630506#comment-16630506 ] ASF GitHub Bot commented on FLINK-9712: --- pnowojski commented on a change in pull re

[jira] [Commented] (FLINK-10401) Port ProcessFailureCancelingITCase to new code base

2018-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630505#comment-16630505 ] ASF GitHub Bot commented on FLINK-10401: tillrohrmann commented on a change in p

[GitHub] tillrohrmann commented on a change in pull request #6749: [FLINK-10401] Port ProcessFailureCancelingITCase to new code base

2018-09-27 Thread GitBox
tillrohrmann commented on a change in pull request #6749: [FLINK-10401] Port ProcessFailureCancelingITCase to new code base URL: https://github.com/apache/flink/pull/6749#discussion_r220942743 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterComp

  1   2   3   4   >