[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639198#comment-16639198 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6759:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639189#comment-16639189 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6759:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639197#comment-16639197 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6759:

[GitHub] Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-04 Thread GitBox
Clark commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#discussion_r222880990 ## File path:

[GitHub] Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-04 Thread GitBox
Clark commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#discussion_r222880965 ## File path:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639193#comment-16639193 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6759:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639190#comment-16639190 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6759:

[GitHub] Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-04 Thread GitBox
Clark commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#discussion_r222880749 ## File path:

[GitHub] Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-04 Thread GitBox
Clark commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#discussion_r222880719 ## File path:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639192#comment-16639192 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6759:

[GitHub] Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-04 Thread GitBox
Clark commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#discussion_r222880652 ## File path:

[GitHub] Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-04 Thread GitBox
Clark commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#discussion_r222880596 ## File path:

[jira] [Commented] (FLINK-10487) fix invalid Flink SQL example

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639182#comment-16639182 ] ASF GitHub Bot commented on FLINK-10487: hequn8128 commented on issue #6790: [FLINK-10487]

[GitHub] hequn8128 commented on issue #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API

2018-10-04 Thread GitBox
hequn8128 commented on issue #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API URL: https://github.com/apache/flink/pull/6790#issuecomment-427227713 @bowenli86 thanks for the update. LSGTM.

[jira] [Commented] (FLINK-10316) Kinesalite bug fix (FLINK-9402) doesn't fully fix the problem.

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639056#comment-16639056 ] ASF GitHub Bot commented on FLINK-10316: diego-carvallo-tx commented on a change in pull request

[GitHub] diego-carvallo-tx commented on a change in pull request #6789: [FLINK-10316][kinesis] bug was preventing FlinkKinesisProducer to connect to Kinesalite

2018-10-04 Thread GitBox
diego-carvallo-tx commented on a change in pull request #6789: [FLINK-10316][kinesis] bug was preventing FlinkKinesisProducer to connect to Kinesalite URL: https://github.com/apache/flink/pull/6789#discussion_r222859878 ## File path:

[jira] [Commented] (FLINK-9544) Downgrade kinesis protocol from CBOR to JSON not possible as required by kinesalite

2018-10-04 Thread Diego Carvallo (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639026#comment-16639026 ] Diego Carvallo commented on FLINK-9544: --- I am using the Scala sdk version 1.6.0 and this is NOT

[jira] [Commented] (FLINK-10487) fix invalid Flink SQL example

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639016#comment-16639016 ] ASF GitHub Bot commented on FLINK-10487: bowenli86 commented on issue #6790: [FLINK-10487]

[GitHub] bowenli86 commented on issue #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API

2018-10-04 Thread GitBox
bowenli86 commented on issue #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API URL: https://github.com/apache/flink/pull/6790#issuecomment-427198159 @hequn8128 @fhueske Thanks for your review. I've updated code accordingly

[jira] [Updated] (FLINK-10494) Rename 'JobManager' to 'JobMaster' for some classes in JobMaster folder

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10494: --- Labels: pull-request-available (was: ) > Rename 'JobManager' to 'JobMaster' for some

[jira] [Commented] (FLINK-9932) If task executor offer slot to job master timeout the first time, the slot will leak

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638954#comment-16638954 ] ASF GitHub Bot commented on FLINK-9932: --- isunjin commented on a change in pull request #6780:

[jira] [Commented] (FLINK-10494) Rename 'JobManager' to 'JobMaster' for some classes in JobMaster folder

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638969#comment-16638969 ] ASF GitHub Bot commented on FLINK-10494: isunjin opened a new pull request #6794: [FLINK-10494]

[GitHub] isunjin opened a new pull request #6794: [FLINK-10494] [Job Manager] Rename 'JobManager' to 'JobMaster' for some classes in JobMaster folder

2018-10-04 Thread GitBox
isunjin opened a new pull request #6794: [FLINK-10494] [Job Manager] Rename 'JobManager' to 'JobMaster' for some classes in JobMaster folder URL: https://github.com/apache/flink/pull/6794 ## What is the purpose of the change * this pull request is a code renaming, no logic

[jira] [Commented] (FLINK-9932) If task executor offer slot to job master timeout the first time, the slot will leak

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638946#comment-16638946 ] ASF GitHub Bot commented on FLINK-9932: --- isunjin commented on a change in pull request #6780:

[GitHub] isunjin commented on a change in pull request #6780: [FLINK-9932] [runtime] fix slot leak when task executor offer slot to job master timeout

2018-10-04 Thread GitBox
isunjin commented on a change in pull request #6780: [FLINK-9932] [runtime] fix slot leak when task executor offer slot to job master timeout URL: https://github.com/apache/flink/pull/6780#discussion_r222842321 ## File path:

[GitHub] isunjin commented on a change in pull request #6780: [FLINK-9932] [runtime] fix slot leak when task executor offer slot to job master timeout

2018-10-04 Thread GitBox
isunjin commented on a change in pull request #6780: [FLINK-9932] [runtime] fix slot leak when task executor offer slot to job master timeout URL: https://github.com/apache/flink/pull/6780#discussion_r222842321 ## File path:

[jira] [Commented] (FLINK-10392) Remove legacy mode

2018-10-04 Thread JIN SUN (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638905#comment-16638905 ] JIN SUN commented on FLINK-10392: - Sounds good, i will try my best. :) > Remove legacy mode >

[jira] [Updated] (FLINK-10494) Rename 'JobManager' to 'JobMaster' for some classes in JobMaster folder

2018-10-04 Thread JIN SUN (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JIN SUN updated FLINK-10494: Summary: Rename 'JobManager' to 'JobMaster' for some classes in JobMaster folder (was: Rename

[jira] [Created] (FLINK-10494) Rename 'JobManager' to J'obMaster' for some classes in JobMaster folder

2018-10-04 Thread JIN SUN (JIRA)
JIN SUN created FLINK-10494: --- Summary: Rename 'JobManager' to J'obMaster' for some classes in JobMaster folder Key: FLINK-10494 URL: https://issues.apache.org/jira/browse/FLINK-10494 Project: Flink

[jira] [Commented] (FLINK-10493) Macro generated CaseClassSerializer considered harmful

2018-10-04 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638834#comment-16638834 ] Elias Levy commented on FLINK-10493: This issue was noted [~tzulitai] back in June 2017 

[jira] [Closed] (FLINK-10459) Flink cluster does not work properly in kubernetes

2018-10-04 Thread Georgii Gobozov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georgii Gobozov closed FLINK-10459. --- > Flink cluster does not work properly in kubernetes >

[jira] [Commented] (FLINK-10459) Flink cluster does not work properly in kubernetes

2018-10-04 Thread Georgii Gobozov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638825#comment-16638825 ] Georgii Gobozov commented on FLINK-10459: - [~till.rohrmann] thanks, it works now, closing issue.

[jira] [Resolved] (FLINK-10459) Flink cluster does not work properly in kubernetes

2018-10-04 Thread Georgii Gobozov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georgii Gobozov resolved FLINK-10459. - Resolution: Fixed > Flink cluster does not work properly in kubernetes >

[jira] [Created] (FLINK-10493) Macro generated CaseClassSerializer considered harmful

2018-10-04 Thread Elias Levy (JIRA)
Elias Levy created FLINK-10493: -- Summary: Macro generated CaseClassSerializer considered harmful Key: FLINK-10493 URL: https://issues.apache.org/jira/browse/FLINK-10493 Project: Flink Issue

[jira] [Closed] (FLINK-10483) Can't restore from a savepoint even with Allow Non Restored State enabled

2018-10-04 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elias Levy closed FLINK-10483. -- Resolution: Invalid > Can't restore from a savepoint even with Allow Non Restored State enabled >

[jira] [Commented] (FLINK-9083) Add async backpressure support to Cassandra Connector

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638763#comment-16638763 ] ASF GitHub Bot commented on FLINK-9083: --- jparkie commented on issue #6782: [FLINK-9083][Cassandra

[GitHub] jparkie commented on issue #6782: [FLINK-9083][Cassandra Connector] Add async backpressure support to Cassandra Connector

2018-10-04 Thread GitBox
jparkie commented on issue #6782: [FLINK-9083][Cassandra Connector] Add async backpressure support to Cassandra Connector URL: https://github.com/apache/flink/pull/6782#issuecomment-427147368 I think post 3.0.4 the driver doesn’t block on executeAsync() when the internal queues are full.

[jira] [Comment Edited] (FLINK-10484) New latency tracking metrics format causes metrics cardinality explosion

2018-10-04 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638756#comment-16638756 ] Jamie Grier edited comment on FLINK-10484 at 10/4/18 7:46 PM: -- Cool.  We

[jira] [Commented] (FLINK-10484) New latency tracking metrics format causes metrics cardinality explosion

2018-10-04 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638756#comment-16638756 ] Jamie Grier commented on FLINK-10484: - Cool.  We should definitely backport [FLINK-10242] as well

[jira] [Commented] (FLINK-10475) Standalone HA - Leader election is not triggered on loss of leader (ZK 3.5.3-beta only)

2018-10-04 Thread Thomas Wozniakowski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638747#comment-16638747 ] Thomas Wozniakowski commented on FLINK-10475: - Sure - I can update the docs. I'll say that

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638702#comment-16638702 ] ASF GitHub Bot commented on FLINK-10289: isunjin commented on issue #6739: [FLINK-10289]

[GitHub] isunjin commented on issue #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-10-04 Thread GitBox
isunjin commented on issue #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#issuecomment-427133050 @StefanRRichter Thanks for review and you make a very good point, but

[jira] [Commented] (FLINK-9083) Add async backpressure support to Cassandra Connector

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638668#comment-16638668 ] ASF GitHub Bot commented on FLINK-9083: --- bmeriaux commented on issue #6782: [FLINK-9083][Cassandra

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638685#comment-16638685 ] ASF GitHub Bot commented on FLINK-10205: isunjin commented on issue #6684: [FLINK-10205]

[GitHub] isunjin commented on issue #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…

2018-10-04 Thread GitBox
isunjin commented on issue #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6684#issuecomment-427127694 @StefanRRichter thanks for comments - for the inconsistent issue,

[GitHub] bmeriaux commented on issue #6782: [FLINK-9083][Cassandra Connector] Add async backpressure support to Cassandra Connector

2018-10-04 Thread GitBox
bmeriaux commented on issue #6782: [FLINK-9083][Cassandra Connector] Add async backpressure support to Cassandra Connector URL: https://github.com/apache/flink/pull/6782#issuecomment-427124744 Nice work ! i ask my self if it should be push down to the driver or not ?

[jira] [Commented] (FLINK-8424) [Cassandra Connector] Update Cassandra version to last one

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638644#comment-16638644 ] ASF GitHub Bot commented on FLINK-8424: --- bmeriaux commented on issue #6715: [FLINK-8424] update

[GitHub] bmeriaux commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest

2018-10-04 Thread GitBox
bmeriaux commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest URL: https://github.com/apache/flink/pull/6715#issuecomment-427121123 Hi, do you have any idea when this will be merged ? 1.6.2 ? or 1.7.0 ?

[jira] [Commented] (FLINK-10392) Remove legacy mode

2018-10-04 Thread tison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638600#comment-16638600 ] tison commented on FLINK-10392: --- [~isunjin] Previously I made a similar proposal but now let's say that

[GitHub] markcho opened a new pull request #6793: [hotfix] [docs] Update cluster setup docs to reflect the new syntax of jobmanager.sh script.

2018-10-04 Thread GitBox
markcho opened a new pull request #6793: [hotfix] [docs] Update cluster setup docs to reflect the new syntax of jobmanager.sh script. URL: https://github.com/apache/flink/pull/6793 [docs] Update cluster setup docs to reflect the new syntax of jobmanager.sh script. jobmanager.sh

[jira] [Commented] (FLINK-10392) Remove legacy mode

2018-10-04 Thread JIN SUN (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638539#comment-16638539 ] JIN SUN commented on FLINK-10392: - +1, can we also do the refactor by move the code to a folder "legacy"

[jira] [Commented] (FLINK-10289) Classify Exceptions to different category for apply different failover strategy

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638496#comment-16638496 ] ASF GitHub Bot commented on FLINK-10289: StefanRRichter commented on issue #6739: [FLINK-10289]

[GitHub] StefanRRichter commented on issue #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

2018-10-04 Thread GitBox
StefanRRichter commented on issue #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy URL: https://github.com/apache/flink/pull/6739#issuecomment-427087088 @isunjin I also like the general idea, but not so much the current

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638449#comment-16638449 ] ASF GitHub Bot commented on FLINK-10205: StefanRRichter commented on issue #6684:

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638448#comment-16638448 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on a change in pull request #6729:

[GitHub] TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-04 Thread GitBox
TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r222733909 ## File path:

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638391#comment-16638391 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on a change in pull request #6729:

[GitHub] TisonKun edited a comment on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-04 Thread GitBox
TisonKun edited a comment on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427071700 All "Why are we removing these assertions?" is as you say, we do not send those state updates via

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638426#comment-16638426 ] ASF GitHub Bot commented on FLINK-10386: TisonKun edited a comment on issue #6729: [FLINK-10386]

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638424#comment-16638424 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on issue #6729: [FLINK-10386]

[GitHub] TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-04 Thread GitBox
TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427071700 All "Why are we removing these assertions?" is as you say, we do not send those state updates via

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638401#comment-16638401 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on issue #6729: [FLINK-10386]

[GitHub] TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-04 Thread GitBox
TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427068734 @tillrohrmann currently our production codes never deal with the message send by `notifyObservers`, because

[GitHub] TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-04 Thread GitBox
TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r222721494 ## File path:

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638389#comment-16638389 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on a change in pull request #6729:

[GitHub] TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-04 Thread GitBox
TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r222721303 ## File path:

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638386#comment-16638386 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on a change in pull request #6729:

[GitHub] TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-04 Thread GitBox
TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r222720265 ## File path:

[jira] [Commented] (FLINK-10469) FileChannel may not write the whole buffer in a single call to FileChannel.write(Buffer buffer)

2018-10-04 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638378#comment-16638378 ] Yun Gao commented on FLINK-10469: - I commented on the pull request, but it seems that the comment fails

[jira] [Commented] (FLINK-10316) Kinesalite bug fix (FLINK-9402) doesn't fully fix the problem.

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638284#comment-16638284 ] ASF GitHub Bot commented on FLINK-10316: tweise commented on a change in pull request #6789:

[GitHub] tweise commented on a change in pull request #6789: [FLINK-10316][kinesis] bug was preventing FlinkKinesisProducer to connect to Kinesalite

2018-10-04 Thread GitBox
tweise commented on a change in pull request #6789: [FLINK-10316][kinesis] bug was preventing FlinkKinesisProducer to connect to Kinesalite URL: https://github.com/apache/flink/pull/6789#discussion_r222691000 ## File path:

[jira] [Commented] (FLINK-10008) Improve the LOG function in Table to support bases less than 1

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638273#comment-16638273 ] ASF GitHub Bot commented on FLINK-10008: Xpray commented on issue #6465: [FLINK-10008] [table]

[GitHub] Xpray commented on issue #6465: [FLINK-10008] [table] Improve the LOG function in Table to support bases less than 1

2018-10-04 Thread GitBox
Xpray commented on issue #6465: [FLINK-10008] [table] Improve the LOG function in Table to support bases less than 1 URL: https://github.com/apache/flink/pull/6465#issuecomment-427033176 It's strange that I rebase the master and modified the sql.md, but it always shows a conflict.

[jira] [Commented] (FLINK-9997) Improve Expression Reduce

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638251#comment-16638251 ] ASF GitHub Bot commented on FLINK-9997: --- Xpray commented on a change in pull request #6455:

[jira] [Commented] (FLINK-9997) Improve Expression Reduce

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638253#comment-16638253 ] ASF GitHub Bot commented on FLINK-9997: --- Xpray commented on a change in pull request #6455:

[GitHub] Xpray commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce

2018-10-04 Thread GitBox
Xpray commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce URL: https://github.com/apache/flink/pull/6455#discussion_r222677511 ## File path:

[GitHub] Xpray commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce

2018-10-04 Thread GitBox
Xpray commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce URL: https://github.com/apache/flink/pull/6455#discussion_r222677293 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala

[jira] [Commented] (FLINK-9997) Improve Expression Reduce

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638249#comment-16638249 ] ASF GitHub Bot commented on FLINK-9997: --- Xpray commented on a change in pull request #6455:

[GitHub] Xpray commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce

2018-10-04 Thread GitBox
Xpray commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce URL: https://github.com/apache/flink/pull/6455#discussion_r222677089 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala

[jira] [Created] (FLINK-10491) Deadlock during spilling data in SpillableSubpartition

2018-10-04 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-10491: -- Summary: Deadlock during spilling data in SpillableSubpartition Key: FLINK-10491 URL: https://issues.apache.org/jira/browse/FLINK-10491 Project: Flink

[jira] [Created] (FLINK-10492) Document generic support for configuring AwsKinesisClient in the Kinesis Consumer

2018-10-04 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-10492: --- Summary: Document generic support for configuring AwsKinesisClient in the Kinesis Consumer Key: FLINK-10492 URL: https://issues.apache.org/jira/browse/FLINK-10492

[jira] [Updated] (FLINK-10491) Deadlock during spilling data in SpillableSubpartition

2018-10-04 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-10491: --- Priority: Critical (was: Major) > Deadlock during spilling data in SpillableSubpartition

[jira] [Commented] (FLINK-10309) Cancel flink job occurs java.net.ConnectException

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638144#comment-16638144 ] ASF GitHub Bot commented on FLINK-10309: GJL commented on issue #6785: [FLINK-10309][rest]

[jira] [Resolved] (FLINK-10354) Savepoints should be counted as retained checkpoints

2018-10-04 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-10354. -- Resolution: Fixed Fix Version/s: 1.5.5 1.6.2 Fixed in

[jira] [Assigned] (FLINK-8880) Validate configurations for SQL Client

2018-10-04 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong reassigned FLINK-8880: Assignee: (was: Rong Rong) > Validate configurations for SQL Client >

[jira] [Commented] (FLINK-8880) Validate configurations for SQL Client

2018-10-04 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638159#comment-16638159 ] Rong Rong commented on FLINK-8880: -- [~twalthr] yes aboslutely. please go ahead. > Validate

[GitHub] GJL commented on issue #6785: [FLINK-10309][rest] Before shutting down cluster, wait for asynchronous operations

2018-10-04 Thread GitBox
GJL commented on issue #6785: [FLINK-10309][rest] Before shutting down cluster, wait for asynchronous operations URL: https://github.com/apache/flink/pull/6785#issuecomment-426998950 There are some test failures that I have to look into.

[jira] [Commented] (FLINK-10469) FileChannel may not write the whole buffer in a single call to FileChannel.write(Buffer buffer)

2018-10-04 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638121#comment-16638121 ] Yun Gao commented on FLINK-10469: - [~NicoK] [~pnowojski] Sorry for responding later. I found the problem

[jira] [Updated] (FLINK-10474) Don't translate IN to JOIN with VALUES for streaming queries

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10474: --- Labels: pull-request-available (was: ) > Don't translate IN to JOIN with VALUES for

[jira] [Commented] (FLINK-10474) Don't translate IN to JOIN with VALUES for streaming queries

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638101#comment-16638101 ] ASF GitHub Bot commented on FLINK-10474: hequn8128 opened a new pull request #6792:

[GitHub] hequn8128 opened a new pull request #6792: [FLINK-10474][table] Don't translate IN/NOT_IN to JOIN with VALUES

2018-10-04 Thread GitBox
hequn8128 opened a new pull request #6792: [FLINK-10474][table] Don't translate IN/NOT_IN to JOIN with VALUES URL: https://github.com/apache/flink/pull/6792 ## What is the purpose of the change IN clauses are translated to JOIN with VALUES if the number of elements in the IN

[jira] [Updated] (FLINK-9422) Dedicated DISTINCT operator for streaming tables with time attributes

2018-10-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-9422: - Summary: Dedicated DISTINCT operator for streaming tables with time attributes (was: Dedicated

[jira] [Commented] (FLINK-10354) Savepoints should be counted as retained checkpoints

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638099#comment-16638099 ] ASF GitHub Bot commented on FLINK-10354: dawidwys closed pull request #6704: [FLINK-10354]

[jira] [Closed] (FLINK-10488) Add DISTINCT operator for streaming tables that leverages time attributes

2018-10-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-10488. - Resolution: Duplicate Duplicate of FLINK-9422 > Add DISTINCT operator for streaming tables

[GitHub] dawidwys closed pull request #6704: [FLINK-10354] Revert "[FLINK-6328] [chkPts] Don't add savepoints to CompletedCheckpointStore"

2018-10-04 Thread GitBox
dawidwys closed pull request #6704: [FLINK-10354] Revert "[FLINK-6328] [chkPts] Don't add savepoints to CompletedCheckpointStore" URL: https://github.com/apache/flink/pull/6704 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[jira] [Commented] (FLINK-10470) Add method to check if pattern can produce empty matches

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638073#comment-16638073 ] ASF GitHub Bot commented on FLINK-10470: pnowojski commented on a change in pull request #6781:

[jira] [Commented] (FLINK-10488) Add DISTINCT operator for streaming tables that leverages time attributes

2018-10-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638097#comment-16638097 ] Fabian Hueske commented on FLINK-10488: --- Yes, thanks for noticing! > Add DISTINCT operator for

[jira] [Updated] (FLINK-8594) Add a dedicated DISTINCT operator to always produce append sreams

2018-10-04 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-8594: --- Summary: Add a dedicated DISTINCT operator to always produce append sreams (was: Make

[jira] [Commented] (FLINK-10488) Add DISTINCT operator for streaming tables that leverages time attributes

2018-10-04 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638085#comment-16638085 ] Hequn Cheng commented on FLINK-10488: - Is this a duplicate of

[jira] [Commented] (FLINK-10470) Add method to check if pattern can produce empty matches

2018-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638074#comment-16638074 ] ASF GitHub Bot commented on FLINK-10470: pnowojski commented on a change in pull request #6781:

  1   2   >