[GitHub] tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223265779 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/SerializationP

[GitHub] tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223265866 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerial

[jira] [Commented] (FLINK-9377) Remove writing serializers as part of the checkpoint meta information

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641458#comment-16641458 ] ASF GitHub Bot commented on FLINK-9377: --- tzulitai commented on a change in pull req

[jira] [Commented] (FLINK-9377) Remove writing serializers as part of the checkpoint meta information

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641459#comment-16641459 ] ASF GitHub Bot commented on FLINK-9377: --- tzulitai commented on a change in pull req

[GitHub] zentol closed pull request #6798: [docs] Fixed typo, please instead of pelase

2018-10-08 Thread GitBox
zentol closed pull request #6798: [docs] Fixed typo, please instead of pelase URL: https://github.com/apache/flink/pull/6798 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[jira] [Commented] (FLINK-10487) fix invalid Flink SQL example

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641467#comment-16641467 ] ASF GitHub Bot commented on FLINK-10487: fhueske commented on issue #6790: [FLIN

[GitHub] fhueske commented on issue #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API

2018-10-08 Thread GitBox
fhueske commented on issue #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API URL: https://github.com/apache/flink/pull/6790#issuecomment-427743674 merging This is an automate

[jira] [Created] (FLINK-10509) Drop flink-storm

2018-10-08 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-10509: Summary: Drop flink-storm Key: FLINK-10509 URL: https://issues.apache.org/jira/browse/FLINK-10509 Project: Flink Issue Type: Improvement Co

[GitHub] tzulitai commented on issue #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
tzulitai commented on issue #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#issuecomment-427744344 Thanks a lot for the detailed reviews and discussions, @dawidwys and @StephanEwen. @dawidwys and I went th

[jira] [Commented] (FLINK-9377) Remove writing serializers as part of the checkpoint meta information

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641469#comment-16641469 ] ASF GitHub Bot commented on FLINK-9377: --- tzulitai commented on issue #6711: [FLINK-

[GitHub] fhueske commented on a change in pull request #6710: [FLINK-10134] UTF-16 support for TextInputFormat bug fixed

2018-10-08 Thread GitBox
fhueske commented on a change in pull request #6710: [FLINK-10134] UTF-16 support for TextInputFormat bug fixed URL: https://github.com/apache/flink/pull/6710#discussion_r223268822 ## File path: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java #

[jira] [Commented] (FLINK-10134) UTF-16 support for TextInputFormat

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641470#comment-16641470 ] ASF GitHub Bot commented on FLINK-10134: fhueske commented on a change in pull r

[GitHub] tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223269252 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerial

[jira] [Commented] (FLINK-9377) Remove writing serializers as part of the checkpoint meta information

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641472#comment-16641472 ] ASF GitHub Bot commented on FLINK-9377: --- tzulitai commented on a change in pull req

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427747927 I took a look at the different sizes of a serialized `AbstractID` with and without the transi

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641480#comment-16641480 ] ASF GitHub Bot commented on FLINK-10412: tillrohrmann commented on issue #6755:

[jira] [Commented] (FLINK-10491) Deadlock during spilling data in SpillableSubpartition

2018-10-08 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641481#comment-16641481 ] zhijiang commented on FLINK-10491: -- I think we can set the {{BufferPoolOwner}} in the c

[GitHub] zhangxinyu1 commented on issue #6770: [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs more friendly.

2018-10-08 Thread GitBox
zhangxinyu1 commented on issue #6770: [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs more friendly. URL: https://github.com/apache/flink/pull/6770#issuecomment-427748392 @tillrohrmann Thanks, I'll resolve conflicts if it has until you review this PR. -

[jira] [Commented] (FLINK-10002) WebUI shows logs unfriendly, especially when the amount of logs is large

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641483#comment-16641483 ] ASF GitHub Bot commented on FLINK-10002: zhangxinyu1 commented on issue #6770:

[jira] [Commented] (FLINK-10453) Move hadoop 2.4 travis profile into cron job

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641484#comment-16641484 ] ASF GitHub Bot commented on FLINK-10453: zentol closed pull request #6772: [FLIN

[GitHub] zentol closed pull request #6772: [FLINK-10453][travis] Move hdp 2.4 tests to cron jobs

2018-10-08 Thread GitBox
zentol closed pull request #6772: [FLINK-10453][travis] Move hdp 2.4 tests to cron jobs URL: https://github.com/apache/flink/pull/6772 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427751092 @tillrohrmann I have tried to do it the way you said it, but because the fully qualified names of

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641490#comment-16641490 ] ASF GitHub Bot commented on FLINK-10412: yanghua commented on issue #6755: [FLIN

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641491#comment-16641491 ] ASF GitHub Bot commented on FLINK-10412: tillrohrmann commented on issue #6755:

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427751527 Why are the fully qualified names different @yanghua? I actually just tried to do the same an

[jira] [Created] (FLINK-10510) Bump asm version to 6

2018-10-08 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-10510: Summary: Bump asm version to 6 Key: FLINK-10510 URL: https://issues.apache.org/jira/browse/FLINK-10510 Project: Flink Issue Type: Sub-task

[GitHub] tillrohrmann edited a comment on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann edited a comment on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427752299 This is the commit: https://github.com/tillrohrmann/flink/commit/5179eac7d19b342e161cb

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427752299 This is the branch: https://github.com/tillrohrmann/flink/commit/5179eac7d19b342e161cb188f78e

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641493#comment-16641493 ] ASF GitHub Bot commented on FLINK-10412: tillrohrmann commented on issue #6755:

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641494#comment-16641494 ] ASF GitHub Bot commented on FLINK-10412: tillrohrmann edited a comment on issue

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427752657 Since @StephanEwen initially rejected this PR I would still like to hear his opinion before m

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641496#comment-16641496 ] ASF GitHub Bot commented on FLINK-10412: tillrohrmann commented on issue #6755:

[GitHub] yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427753059 > If existing savepoints have an AbstractID serialized in it, will the deserialization fail if

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641498#comment-16641498 ] ASF GitHub Bot commented on FLINK-10412: yanghua commented on issue #6755: [FLIN

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427753255 I created the resource files with the serialized `AbstractID` before applying your changes. T

[GitHub] tillrohrmann edited a comment on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann edited a comment on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427753255 I created the resource files with the serialized `AbstractID` before applying your cha

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641501#comment-16641501 ] ASF GitHub Bot commented on FLINK-10412: tillrohrmann edited a comment on issue

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641500#comment-16641500 ] ASF GitHub Bot commented on FLINK-10412: tillrohrmann commented on issue #6755:

[GitHub] yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427753765 Oh, @tillrohrmann I understood. --

[jira] [Commented] (FLINK-10412) toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641507#comment-16641507 ] ASF GitHub Bot commented on FLINK-10412: yanghua commented on issue #6755: [FLIN

[GitHub] tillrohrmann commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427755128 Thanks for the clarification @TisonKun. I'll give it another pass with your comments in mind. ---

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641512#comment-16641512 ] ASF GitHub Bot commented on FLINK-10386: tillrohrmann commented on issue #6729:

[GitHub] tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r223285835 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runt

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641522#comment-16641522 ] ASF GitHub Bot commented on FLINK-10386: tillrohrmann commented on a change in p

[GitHub] GJL commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427761358 Hi, I am taking a look again. This is an automated mess

[GitHub] TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427761218 @tillrohrmann thanks for your review! This is

[GitHub] GJL closed pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL closed pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] leanken opened a new pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken opened a new pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775 ## What is the purpose of the change See. [FLINK-5542](https://issues.apache.org/jira/browse/FLINK-5542) use YarnCluste

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641539#comment-16641539 ] ASF GitHub Bot commented on FLINK-5542: --- GJL commented on issue #6775: [FLINK-5542]

[GitHub] GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427761358 Hi, I am taking a looking. This is an automated

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641540#comment-16641540 ] ASF GitHub Bot commented on FLINK-5542: --- GJL closed pull request #6775: [FLINK-5542

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641537#comment-16641537 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on issue #6729: [FLI

[GitHub] GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427761358 Hi, I am taking a look. This is an automated mes

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641544#comment-16641544 ] ASF GitHub Bot commented on FLINK-5542: --- GJL edited a comment on issue #6775: [FLIN

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641541#comment-16641541 ] ASF GitHub Bot commented on FLINK-5542: --- leanken opened a new pull request #6775: [

[GitHub] GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427761358 Hi, I am taking a look now. This is an automated

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641543#comment-16641543 ] ASF GitHub Bot commented on FLINK-5542: --- GJL edited a comment on issue #6775: [FLIN

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641545#comment-16641545 ] ASF GitHub Bot commented on FLINK-5542: --- GJL edited a comment on issue #6775: [FLIN

[GitHub] tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r223286665 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runt

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641557#comment-16641557 ] ASF GitHub Bot commented on FLINK-10386: tillrohrmann commented on a change in p

[jira] [Assigned] (FLINK-10156) Drop the Table.writeToSink() method

2018-10-08 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-10156: - Assignee: Fabian Hueske > Drop the Table.writeToSink() method > ---

[jira] [Updated] (FLINK-8033) Build Flink with JDK 9

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-8033: -- Labels: pull-request-available (was: ) > Build Flink with JDK 9 > -- > >

[jira] [Commented] (FLINK-8033) Build Flink with JDK 9

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641561#comment-16641561 ] ASF GitHub Bot commented on FLINK-8033: --- zentol opened a new pull request #48: [FLI

[GitHub] TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427768967 @tillrohrmann sounds good. As you suggest, we can replace `notifyFinalState` with `updateTaskExecutionState` s

[GitHub] rinkako opened a new pull request #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section

2018-10-08 Thread GitBox
rinkako opened a new pull request #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section URL: https://github.com/apache/flink/pull/6802 `DELETE` request to **`/jobs/:jobid/cancel`** always return {"errors": ["Not found."]}, since the correct API should be `GET` request to `/

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641570#comment-16641570 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on issue #6729: [FLI

[GitHub] TisonKun commented on issue #6778: [FLINK-10426] [tests] Port TaskTest to new code base

2018-10-08 Thread GitBox
TisonKun commented on issue #6778: [FLINK-10426] [tests] Port TaskTest to new code base URL: https://github.com/apache/flink/pull/6778#issuecomment-427769213 This pull request need a rebase on #6729 and thus now WIP. This is

[jira] [Updated] (FLINK-10426) Port TaskTest to new code base

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10426: --- Labels: pull-request-available (was: ) > Port TaskTest to new code base > -

[jira] [Commented] (FLINK-10426) Port TaskTest to new code base

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641573#comment-16641573 ] ASF GitHub Bot commented on FLINK-10426: TisonKun commented on issue #6778: [FLI

[jira] [Closed] (FLINK-10453) Move hadoop 2.4 travis profile into cron job

2018-10-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-10453. Resolution: Fixed master: 12a9591a46c220f4707d89797a2bf177f538ba89 > Move hadoop 2.4 trav

[jira] [Created] (FLINK-10511) Code duplication of creating RPC service in ClusterEntrypoint and AkkaRpcServiceUtils

2018-10-08 Thread Shimin Yang (JIRA)
Shimin Yang created FLINK-10511: --- Summary: Code duplication of creating RPC service in ClusterEntrypoint and AkkaRpcServiceUtils Key: FLINK-10511 URL: https://issues.apache.org/jira/browse/FLINK-10511 P

[jira] [Commented] (FLINK-10508) Port JobManagerITCase to new code base

2018-10-08 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641583#comment-16641583 ] TisonKun commented on FLINK-10508: -- This test is corresponding not to {{JobMasterITCase

[GitHub] GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223300816 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.jav

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641585#comment-16641585 ] ASF GitHub Bot commented on FLINK-5542: --- GJL commented on a change in pull request

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641584#comment-16641584 ] ASF GitHub Bot commented on FLINK-5542: --- GJL commented on a change in pull request

[GitHub] GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223301904 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.jav

[GitHub] GJL commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs

2018-10-08 Thread GitBox
GJL commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs URL: https://github.com/apache/flink/pull/6737#issuecomment-427774173 Taking a look now. This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-10399) Refractor ParameterTool#fromArgs

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641589#comment-16641589 ] ASF GitHub Bot commented on FLINK-10399: GJL commented on issue #6737: [FLINK-10

[GitHub] yanghua commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file

2018-10-08 Thread GitBox
yanghua commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file URL: https://github.com/apache/flink/pull/6542#issuecomment-427774371 @StephanEwen @tillrohrmann and @zentol ,Any opinions about this PR?

[GitHub] leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223303030 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641590#comment-16641590 ] ASF GitHub Bot commented on FLINK-5542: --- leanken commented on a change in pull requ

[jira] [Commented] (FLINK-6437) Move history server configuration to a separate file

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641591#comment-16641591 ] ASF GitHub Bot commented on FLINK-6437: --- yanghua commented on issue #6542: [FLINK-6

[jira] [Updated] (FLINK-10399) Refactor ParameterTool#fromArgs

2018-10-08 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-10399: - Summary: Refactor ParameterTool#fromArgs (was: Refractor ParameterTool#fromArgs) > Refactor ParameterT

[jira] [Commented] (FLINK-8581) Improve performance for low latency network

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641606#comment-16641606 ] ASF GitHub Bot commented on FLINK-8581: --- zhijiangW commented on a change in pull re

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641607#comment-16641607 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on issue #6759: [FL

[GitHub] Clarkkkkk commented on issue #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-08 Thread GitBox
Clark commented on issue #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#issuecomment-427780030 Thanks for your review @tillrohrmann . I have replace the RPC service with actor system and get rid of the add

[GitHub] zhijiangW commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
zhijiangW commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r223309406 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/net

[GitHub] leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223309660 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor

[GitHub] zentol closed pull request #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section

2018-10-08 Thread GitBox
zentol closed pull request #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section URL: https://github.com/apache/flink/pull/6802 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223309773 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor

[GitHub] zentol commented on issue #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section

2018-10-08 Thread GitBox
zentol commented on issue #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section URL: https://github.com/apache/flink/pull/6802#issuecomment-427780402 -1 for a few reasons: * That part of the documentation is for legacy mode => legacy mode indeed requires a DELETE to

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641609#comment-16641609 ] ASF GitHub Bot commented on FLINK-5542: --- leanken commented on a change in pull requ

[GitHub] leanken commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427780528 @GJL resolved yours comments. This is an automated

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641612#comment-16641612 ] ASF GitHub Bot commented on FLINK-5542: --- leanken commented on issue #6775: [FLINK-5

[jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641610#comment-16641610 ] ASF GitHub Bot commented on FLINK-5542: --- leanken commented on a change in pull requ

[jira] [Created] (FLINK-10512) Remove legacy REST API docs

2018-10-08 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-10512: Summary: Remove legacy REST API docs Key: FLINK-10512 URL: https://issues.apache.org/jira/browse/FLINK-10512 Project: Flink Issue Type: Sub-task

[GitHub] tillrohrmann commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427780989 Alright @TisonKun. I'll do the removal of `notifyFinalState` as a follow up. -

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641614#comment-16641614 ] ASF GitHub Bot commented on FLINK-10386: tillrohrmann commented on issue #6729:

[GitHub] zentol opened a new pull request #6803: [FLINK-10512][rest][docs] Remove legacy docs

2018-10-08 Thread GitBox
zentol opened a new pull request #6803: [FLINK-10512][rest][docs] Remove legacy docs URL: https://github.com/apache/flink/pull/6803 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC

[jira] [Updated] (FLINK-10512) Remove legacy REST API docs

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10512: --- Labels: pull-request-available (was: ) > Remove legacy REST API docs >

  1   2   3   4   >